Commit Graph

7128 Commits

Author SHA1 Message Date
Keerti Parthasarathy e62b89c56d Add a byte store that can be shared for use with Cider.
Change-Id: I492aebb476aa7e681eb4d7d5bff995d12917c9b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150684
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-06-11 02:42:25 +00:00
Konstantin Shcheglov 3902021740 Check inferred types using their string presentation.
R=brianwilkerson@google.com

Change-Id: Ie634ba1be72db6384cf5c9a8a91fd9b908518a30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-10 23:55:23 +00:00
Konstantin Shcheglov f3fba2eeb5 Fix _PackageMapUriResolverTest on Windows.
Change-Id: Id53c541bf681ccd2f035bc64e733f976bef98af6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-10 17:39:47 +00:00
Konstantin Shcheglov 965ef001f6 When evaluating constants, use the TypeSystem of the library.
Change-Id: Ief2207cafef6e6b28169ab0c46239d1dea665fac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150700
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-10 16:27:47 +00:00
Konstantin Shcheglov c6ca3180df Support null shorting for FunctionExpressionInvocation.
Change-Id: I470c85574662d70517aa880e5c094d54226efa11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150668
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-10 16:25:57 +00:00
Konstantin Shcheglov 3137a91d3c Enable type inference for local variables with initializers of type Never.
Bug: https://github.com/dart-lang/sdk/issues/42205
Change-Id: I7b032734b18fdb86e48270118b4dd91184594e12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150474
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-06-09 17:27:35 +00:00
Konstantin Shcheglov fd60cbc21f Issue 42190. Fix PackageMapUriResolver and path with non-ASCII characters.
Bug: https://github.com/dart-lang/sdk/issues/42190
Change-Id: I4a5fea9f808a08d547b7b6e97ba8b93ee9dd16e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-09 16:32:16 +00:00
Konstantin Shcheglov 2f5a376ec6 Fixes for Null Safety and constants - potential const types, 'as' expression.
Bug: https://github.com/dart-lang/sdk/issues/42205
Change-Id: I6936225bddd47eff027330682200d7946620c7b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150472
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-09 15:50:01 +00:00
Sam Rawlins 1b0d293059 Analyzer: check for conflicting members on classes, mixins w/o inheritance clauses
_checkMixinInheritance and _checkClassInheritance check various errors
with the literal structure of inheritance nodes on class and mixin
declarations. But members can conflict with the implicit super-class,
Object.

Fixes https://github.com/dart-lang/sdk/issues/35036

Change-Id: If1bb47a439e9f09e4b1b1c55e24322d6d76c904d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150476
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2020-06-09 14:39:25 +00:00
Sam Rawlins 1497af771b Analyzer: Report when enum value names conflict with Object instance members
Fixes https://github.com/dart-lang/sdk/issues/23353

Change-Id: I74ed41863e0811a15d7c078a7fb71e63f0fe34a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150269
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2020-06-09 04:09:21 +00:00
Konstantin Shcheglov 5fbf7952d2 Don't apply extensions to Never.
https://github.com/dart-lang/language/pull/1003

Change-Id: Ie9526e8e362865754e84b5d9cda307dc7b07aaee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-08 18:20:53 +00:00
Konstantin Shcheglov e3c3d4df32 Issue 42178. Fix for crash when 'Class?.method()' resolution.
Bug: https://github.com/dart-lang/sdk/issues/42178
Change-Id: I86312a35aed7342492bff9aae22121a05e7906ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150184
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-06-08 18:05:04 +00:00
Sam Rawlins 66e2b22d14 Analyzer: report conflicting extension type variables
Fixes https://github.com/dart-lang/sdk/issues/42216

Report when an extension declares a type parameter with the same name as the
extension.

Report when an extension declares a member with the same basename as the name
of any of the extension's type parameters.

Move tests into diagnostics/.

Move tests for RECURSIVE_INTERFANCE_INHERITANCE.

Change-Id: If19041571008b9b14122d9ff458d1d30ea0ff034
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150270
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2020-06-08 05:44:12 +00:00
Konstantin Shcheglov 87c5e3612b Issue 42201. Use fresh type parameters in extension inference.
Bug: https://github.com/dart-lang/sdk/issues/42201
Change-Id: I6dd8071821fa03c5c20541b65a7c143d4a739730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150271
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-07 17:43:22 +00:00
Konstantin Shcheglov a12fd560b7 Implement allowedExperimentsJson for EmbedderSdk.
https://github.com/flutter/engine/pull/18830

Change-Id: Iab1a3dd319da12d192a042b75a8ff6affc4d11cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150169
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-04 23:29:12 +00:00
Jens Johansen cbbbc09b3e [parser] Better recovery of typedefs with bad name
Note that this leaves differences in errors issued between
"typedef void void();" and "typedef void = void Function();" though.

Fixes #42158

Change-Id: I0785f99234c87bdeadbb2865e089b1389851333e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149599
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2020-06-04 14:21:11 +00:00
Sam Rawlins 8020a0f286 Analyzer: move built_in_identifier_* tests
Change-Id: I9802a055d40ac20f928e4b6e68fd0aecd0f9bc74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149665
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-06-02 16:52:12 +00:00
Sam Rawlins 598c65165b Analyzer: Mark used extension operators as such
Fixes https://github.com/dart-lang/sdk/issues/42122

Change-Id: I3cc57715471a6369c60d21e2a691e8cc0d90f809
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149663
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-06-02 16:37:22 +00:00
Paul Berry 930cae0f13 Revert "Remove DartSdk.useSummary."
This reverts commit a2c3ecabce.

Reason for revert: Breaking change to de facto API

Original change's description:
> Remove DartSdk.useSummary.
> 
> R=​brianwilkerson@google.com
> 
> Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I9998bedb74ea940371f18ac7dce42b2f5dcc3b98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149687
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-06-02 15:20:32 +00:00
Konstantin Shcheglov fe52ae462c Instantiate Never as Null* in legacy libraries.
Change-Id: Ibe7302a539e7debd0cab468119a4dba0a4517163
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-01 19:44:58 +00:00
Konstantin Shcheglov 197bc061b9 Issue 38799. Test that function expressions can infer Never as return type.
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38799
Change-Id: I1093749cb31a00a1b450c23ec4631595bce4bd00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149605
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-01 18:38:07 +00:00
Konstantin Shcheglov 058e25875c Issue 42093. Add async test.
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/42093
Change-Id: I96b5c1597d7d16b269b6f6c7d3fd67bd960ff589
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-01 18:28:38 +00:00
Konstantin Shcheglov a25f8e54ac Extensions are always enabled, merge corresponding tests.
Change-Id: I2a2603ea506baaf95ce26da656cee965faf094c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149608
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-01 16:47:36 +00:00
Konstantin Shcheglov 24c50fb8b2 Issue 35710. Test switch exhaustiveness, improve for null.
Bug: https://github.com/dart-lang/sdk/issues/35710
Change-Id: I6f17db1a9b2c01ec4b97538e224146fd3cec9002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149606
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-31 18:58:53 +00:00
Konstantin Shcheglov 20e6f150e5 Fix crash when inferring types with FunctionExpressionInvocation and out of order dependencies.
This fixes language/lazy/static_test

R=brianwilkerson@google.com

Change-Id: I52c25903de8096af58b4fac9654eace7ee358aba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-31 01:56:22 +00:00
Konstantin Shcheglov a2c3ecabce Remove DartSdk.useSummary.
R=brianwilkerson@google.com

Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-30 19:07:32 +00:00
Konstantin Shcheglov 439e99483f Remove DartSdk.getLinkedBundle().
R=brianwilkerson@google.com

Change-Id: I2335ad03856b73e6d864d939a90839ef85dcab78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149487
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-30 03:16:51 +00:00
Konstantin Shcheglov 89782c96d9 Implement changes to return type verification.
https://github.com/dart-lang/sdk/issues/41803
https://dart-review.googlesource.com/c/sdk/+/149163
https://github.com/dart-lang/language/pull/989

Change-Id: I13caf53a3e96c7b266dd3b3bf511002addcf83b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149373
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-29 23:09:37 +00:00
Konstantin Shcheglov a2e85dcda9 Rename HintCode.DEAD_CODE visitor to LegacyDeadCodeVerifier, report other dead code.
Finishing https://dart-review.googlesource.com/c/sdk/+/149240

R=brianwilkerson@google.com

Change-Id: I801f9140587d16969d639889fa14efde3b09dd4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149388
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-29 17:40:46 +00:00
Konstantin Shcheglov a538c7fcc7 Non-nullify context type for FunctionExpression inference.
Bug: https://github.com/dart-lang/sdk/issues/42007
Change-Id: Id75956759c66aa6090ba52e07deb120ce44fd8d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 20:22:20 +00:00
Konstantin Shcheglov 860d3c0697 Report UNUSED_LABEL when null safety, fix for crash.
Bug: https://github.com/dart-lang/sdk/issues/42077
Change-Id: I85325ae1f2d25f680182d07ef50ddb56633b89f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 19:36:30 +00:00
Parker Lougheed 6489a0c68d Fix error when modifying import on Windows
If there is an exception when checking if a resource exists, it is similar to it not existing. Open to feedback here though, perhaps the issue should be handled more specifically to Windows path requirements.

Bug: https://github.com/dart-lang/sdk/issues/37403
Change-Id: Ic5d4ed0cb22619897c3ccaf46feaadd297b55472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-05-27 05:50:13 +00:00
Konstantin Shcheglov 279024d823 Deprecate InstanceCreationExpression.staticElement
Change-Id: I3c2de8ce22944963418d543b887720db15badd0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148981
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-26 22:56:42 +00:00
Konstantin Shcheglov fc1a782168 Remove support for '--package-root'.
Bug: https://github.com/dart-lang/sdk/issues/41197
Change-Id: Ia10946b4db2204cc11e78a1d114578ba79904e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149045
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-26 21:33:32 +00:00
Konstantin Shcheglov 571f564eda Rewrite TypeName to ConstructorName in one place, consolidate error reporting.
Change-Id: I5ea1369d65c5eb47e920f68806d28f34931d372e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-26 21:32:22 +00:00
Parker Lougheed 66e2339142 [pkg/analyzer] Address prefer_final_fields lint
Change-Id: I737502b4bbef575ef6d9e0a16c12f43365a5e093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-05-26 19:00:56 +00:00
Parker Lougheed 2e89bcfc7d Fix prefer_conditional_assignment lint suggestions
This is a step towards moving towards the 1.9.0 version of pedantic which includes this lint.

Change-Id: I59a8d8d7a2c377a007cc08fdf7eef8c60203466d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148986
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-05-26 17:46:08 +00:00
Konstantin Shcheglov 32ab4205e3 Extract resolution of 'new Class.constructor<typeArguments>()'.
Change-Id: Ib2ffb7bc0b5411a087949f797d153eed1710f9e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-25 21:07:49 +00:00
Konstantin Shcheglov c0b4f14360 Use NNBD aware subtype matching rules for inference.
Change-Id: I12133e6e9195817af96d93ce8f39b635d187751a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-24 19:06:38 +00:00
Konstantin Shcheglov 659bd15f2f Test isEnumConstant.
R=brianwilkerson@google.com

Change-Id: Ie0515c5dea283fbf54fe4e9b0d9708bb89e207b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-24 18:01:18 +00:00
Konstantin Shcheglov d24a834181 Subtype constraint generation.
Implements part of https://github.com/dart-lang/language/pull/957

Change-Id: Ia9174c6be6710ae43619f7b5c07d8feb190ca6a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148225
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-21 00:38:24 +00:00
Konstantin Shcheglov c93537c50f Use FindNode and FindElement in search tests.
Change-Id: I29d7ad856e050b09337817df02610aebb6f40303
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148790
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-21 00:29:10 +00:00
Konstantin Shcheglov dbc41af864 Extract ElementNameComponents and use in indexing, tests, and search.
Change-Id: Ib84f5d593bffc8a4e7587d1bded22459bf234e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148785
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 22:46:54 +00:00
Konstantin Shcheglov 819e82ee1d Fix subtype 'T <: Object' when T has implicit Object? bound.
We were not reporting a compile-time error by a wrong reason.
https://github.com/dart-lang/sdk/issues/40089

Change-Id: Ic0caf01a49e5dc4badefb5a534a7dbaac2108213
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 21:45:24 +00:00
Konstantin Shcheglov 2231b8c580 Use AllowedExperiments in analyzer.
Bug: https://github.com/dart-lang/sdk/issues/41741
Change-Id: Iba0face7198f4ecc17c86d2fcb0630912db7ba60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148648
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 20:42:31 +00:00
Konstantin Shcheglov 1821f0ec32 Issue 41997. Fix for indexing, searching, renaming members of unnamed extensions.
Bug: https://github.com/dart-lang/sdk/issues/41997
Change-Id: I963a9ceae03a0d1ed3d04936c4042980a08fa56f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-20 18:12:30 +00:00
Konstantin Shcheglov daa8d68a29 Handle the case when source cannot be found for uri
Change-Id: Ia34d6162f59fa83ae9ed8f6e841088e5b779065a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148236
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
2020-05-19 22:35:11 +00:00
Konstantin Shcheglov 3ebcc10acd Issue 41938. Report INSTANCE_MEMBER_ACCESS_FROM_STATIC for extension members.
Bug: https://github.com/dart-lang/sdk/issues/41938
Change-Id: I95364cb460eacf8076de9a12f4975eb7b1963916
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-18 19:36:17 +00:00
Konstantin Shcheglov a849f66762 Extract INSTANCE_MEMBER_ACCESS_FROM_STATIC tests.
R=brianwilkerson@google.com

Change-Id: I84be2de6602e910912984eba11b700ea2bc4a831
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-05-18 18:00:17 +00:00
Konstantin Shcheglov 08bad91aa3 Fix for crash 'C?.foo'.
Change-Id: I9e03b056c9df6c476de7fa29f412c1704d6c3185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148183
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-05-18 02:43:47 +00:00