dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

8489 Commits

Author SHA1 Message Date
Mike Fairhurst 402c3101a7 Remove unused imports 
Change-Id: Ieceb2f150a8f579231bda40c92215e61adc69f7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114922
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-08-29 06:32:05 +00:00
Konstantin Shcheglov b565c8c20f Don't serialize not serializable constant variable initializers. 
R=brianwilkerson@google.com

Change-Id: If5287b11293391d8620b9843880b95f725efc5fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-28 22:28:56 +00:00
Dan Rubel e9a44ba6a8 fix extension instance field error 
This changes EXTENSION_DECLARES_INSTANCE_FIELD to be a parser error
and moves it into the parser so that it is generated for all of CFE.

See https://github.com/dart-lang/sdk/issues/37945

Change-Id: Ib49d49a20d670e0dd7d9a4cd870237d2cf87dd00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114882
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-28 21:26:31 +00:00
Dan Rubel 15a7b57d8e split endFields into endClass/Mixin/ExtensionFields events 
Change-Id: I538d21a595f957ef6080bf3bfe6f0b7299b4bc8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-28 21:26:31 +00:00
Brian Wilkerson 7eecb77b0f Minor updates to the diagnostic docs 
Attempt to fix the link to the glossary and consistently place 'keyword'
after the name of the keyword in text.

Change-Id: Ib5f75568bdea0a875d1829ab52cbe93894e7f595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114742
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
 2019-08-28 17:29:01 +00:00
Konstantin Shcheglov cb934a0402 Build types for function type type parameter bounds. 
R=brianwilkerson@google.com

Change-Id: Ied38fda4d1671a9e706bffe8bcf16d953c8c973e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-28 15:57:23 +00:00
Konstantin Shcheglov 0c06fbd88f Read default values fully. 
R=brianwilkerson@google.com

Change-Id: I336fa6a9d92687ebcb67eb672dabab64f75fcb43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-28 15:15:23 +00:00
danrubel 7b37cddbe8 rename ClassKind to DeclarationKind 
... and add DeclarationKind.TopLevel

Change-Id: I631c0173a056e856845f02d4415c11336a796e3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114629
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-28 00:57:42 +00:00
danrubel 52e732b786 fix constructor in extension error 
This changes EXTENSION_DECLARES_CONSTRUCTOR to be a parser error
and moves it into the parser so that it is generated for all of CFE.

See https://github.com/dart-lang/sdk/issues/37945

Change-Id: Iecaf277c63d7791a4b7ac9e6583b5018821d2c18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114626
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-28 00:57:42 +00:00
Konstantin Shcheglov 3604f75cd4 Gracefully degrade if annotation uses (non-serializable) FunctionExpression. 
R=brianwilkerson@google.com

Change-Id: Id0e18d14252a4140f085e1c609e59ef9ae40fb5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114624
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-27 20:47:57 +00:00
danrubel aeb5e732fd split endClass/Mixin/ExtensionFactoryMethod event 
This separates an existing parser event into 3 separate events
based upon the enclosing declaration so that listeners
can process them differently in future CLs.

Also address comment in https://dart-review.googlesource.com/c/sdk/+/114564

Change-Id: I07b259d02bd16257edf47eb76cbdd0d022f808dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-27 17:54:52 +00:00
Konstantin Shcheglov 35f8a8bf00 Gracefully degrade when FunctionTypeAlias uses FieldFormalParameter. 
R=brianwilkerson@google.com

Change-Id: Ie2989000148b24f5c380043bbd7c034908f2846d
Bug: https://github.com/dart-lang/sdk/issues/37733
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-27 17:46:48 +00:00
Parker Lougheed d61daa79d3 Add more specific warnings to analyzer for @required on parameters 
Deprecates the old HintCode and adds three new ones which clarify to
the user the problem with using @required on different types
of parameters.

Bug: https://github.com/dart-lang/sdk/issues/36966
Change-Id: I2245663537e88aeb15bcf14eb5913e54be98829d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102900
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-27 14:54:45 +00:00
Dan Rubel f17d0563fa split class/mixin/extension member parsing 
This change makes the parser more aware of what type of member
is being parsed so that proper error messages can be reported
for extension method members in future CLs.

Change-Id: I30002ad1a636b988e59b89d64ba4b0a8ae77c847
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114564
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-27 14:52:45 +00:00
Konstantin Shcheglov c6cd0c4890 Rename SourceLibraryBuilder to LibraryBuilder and move it up. 
R=brianwilkerson@google.com

Change-Id: Ie327cd0d03b7f6259c78c32736f1e353a0ccc08d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-27 00:43:12 +00:00
Konstantin Shcheglov b6897ea094 Stop using resolutionMap in analyzer and analysis_server. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ie8f75e330e9efee67ded892929a3d78b7de1c586
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-26 23:18:54 +00:00
Konstantin Shcheglov a7666c4fac Identifiers with ExtensionElement don't have types. 
R=brianwilkerson@google.com

Change-Id: I9134982c56006467314e335d1ca1c8f3982ac4dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114557
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-26 21:54:58 +00:00
Konstantin Shcheglov e18ebb610b Set relevance tags for constructors. 
R=brianwilkerson@google.com

Bug: https://github.com/JetBrains/intellij-plugins/pull/665#issuecomment-523843326
Change-Id: I347822b84311ed2b94171231597aeceebd900015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-26 20:36:01 +00:00
Paul Berry b8cb25c96f Flow analysis: shift responsibility for handling final fall-through to FlowAnalysis. 
Dart allows the last switch case to "fall through" the end of the
switch statement.  To account for this, we previously required the
caller of FlowAnalysis to calling `handleBreak` at the end of the last
switch case.  (In the analyzer implementation we actually only did
this if the last case was a `default` case, but in practice there was
no observable difference).

This CL shifts the responsibility to FlowAnalysis to handle this
scenario; the caller only needs to call `handleBreak` if there is an
actual break statement present.

Change-Id: Ia0d7abb21d78205f1050873e28b30cddc5fbe344
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114547
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-26 19:39:00 +00:00
Brian Wilkerson 9b46abc4ad Restore removed error codes to unbreak angular 
Change-Id: I18403d3dcf9cf2a9966458836561574367c82602
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114542
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-08-26 18:49:30 +00:00
Konstantin Shcheglov 969c01f02c Remove unused methods from DeclarationResolver. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib4b587088d10f348bf8de221d74b3f1e923e1bc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114543
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-26 17:15:34 +00:00
Paul Berry 2011b6fa6b Flow analysis: refactor and unit test switch statement logic. 
Responsibility for deciding whether to cancel promotions has been
moved to FlowAnalysis (previously the caller decided).  This should
reduce the risk of the analyzer and front end behaviors diverging.

Also removed an unnecessary argument from
FlowAnalysis.switchStatement_end.

Change-Id: Ib015e4e360e62da7bb267057e4626acaa94e9e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114541
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-26 16:11:25 +00:00
Paul Berry 30e4092d27 Flow analysis: handle empty for-loop conditions directly in FlowAnalysis. 
Previously the client was required to create a synthetic `true`
literal.  The client may still do that (it's equivalent), but it's no
longer necessary.

Change-Id: Iffa12769b542678dab6cd4b5583d7058b41aebd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114342
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-23 16:19:49 +00:00
Paul Berry 2e4c89aa73 Flow analysis: fix handling of for(;;) loops. 
Change-Id: I2bf43c35b80b72fc5a3c3cbe4c8043162809fd1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114341
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-08-23 16:19:49 +00:00
Paul Berry 05f411dbf4 Sort declarations in flow_analysis_visitor.dart. 
No change other than re-ordering.

Change-Id: I2c32a8f51db924deb020e69a0823c3cd9503f245
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-08-23 16:19:49 +00:00
Brian Wilkerson 9a854c111a Resolve uses of super within extensions to dynamic to prevent an exception and remove follow-on diagnostics 
Change-Id: I8d6350dd254061abd12fc212a46e3c556638f8a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114185
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-23 14:47:09 +00:00
Konstantin Shcheglov fb90729cf7 Fix isMoreSpecific() for extensions to check that extensions declared in the platform. 
Change MockSdk to allow additional libraries.

Fix the tests.

R=brianwilkerson@google.com

Change-Id: I58b0145ed476408522a90c18c8b0fc1d91e0cefb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-22 22:03:33 +00:00
Brian Wilkerson fe9814195b Produce diagnostics when a reference to a static member of an extension cannot be resolved 
Change-Id: Iea412d9a9e3e96eebc53f6fdc827c284f1df8e4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114180
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-22 21:41:22 +00:00
Konstantin Shcheglov e7f82cdb7c Support for FunctionTypedFormalParameter in GenericFunctionType. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/37733
Change-Id: If335fcabd354a4a33c6177ae149aebcb31b4a0b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114120
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-22 21:19:00 +00:00
Brian Wilkerson 5935b916e3 Rename several error codes and improve some messages 
Change-Id: I6e629719dee14c2af7c1358145fb25b21f5d5157
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-22 20:08:53 +00:00
Konstantin Shcheglov a65615964a Log computed unit elements. 
R=brianwilkerson@google.com

Change-Id: I9a7df5d25fb21b1a63f253657fb728623885d7b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114055
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-22 15:59:53 +00:00
Aske Simon Christensen 95c9f732de Expire spread and control-flow collection flags. 
Change-Id: I59fe3ad2bdd90681e6d40dc39f04a0e53125e707
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113989
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-08-22 10:52:51 +00:00
Paul Berry 51cd16ecf0 Flow analysis: support for and for-in elements in collections. 
Change-Id: Ia73c68c2b8a57c62ce2b4984184cf8a712b554af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113944
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-08-21 21:57:54 +00:00
Brian Wilkerson 47d2794a71 Implement methods that were missing from ExtensionElementForLink 
Change-Id: Ib4031eb1dbca5f583136b0b0c83bfff40abe8d90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113952
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-21 21:55:24 +00:00
Konstantin Shcheglov a17959b5a0 Log the context in which analysis work is done. 
R=brianwilkerson@google.com

Change-Id: Idb8c1296917053e802442ac87e8aa9e2fae0dee7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-21 21:33:24 +00:00
Paul Berry 4bf5a72ca0 Flow analysis: support functions whose bodies are expressions. 
Change-Id: I01a66fb2c897e0cabbdfb4b7423cab53291b3adf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113947
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-21 20:41:13 +00:00
Konstantin Shcheglov 3729b961bb Use SearchedFiles when searching subtypes for 'analysis.implemented'. 
R=brianwilkerson@google.com

Change-Id: I7bba90bd550602588553382fe61c8c41539483ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113951
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-21 18:44:13 +00:00
Konstantin Shcheglov 9aa48c2e91 Build local elements in initializers of typed constants. 
R=brianwilkerson@google.com

Change-Id: I7e7c75841b50ca91132278244cb71a6f7aa3649c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113963
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-21 17:07:22 +00:00
Sam Rawlins 7bc9515ac2 Fix CompilationUnitMember doc comment. Fixes #27170 
Change-Id: I2aee1bb92e05fb780910ee319ff4e29b5a16de35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-08-21 16:44:11 +00:00
Brian Wilkerson ef39492fd6 Fix support for annotations on extensions 
Change-Id: I635727da4a7480f6d271ede571163bd790b3a952
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113925
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-21 16:25:01 +00:00
Konstantin Shcheglov 64efe44e5e Formal parameters of FunctionTypeAlias should be created in @function reference. 
R=brianwilkerson@google.com

Change-Id: I9f0a4f385d714644b07313752ba0d4643673fc0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113961
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-21 16:15:31 +00:00
Paul Berry 468800f9d7 Refine the type of FunctionTypeAlias.declaredElement. 
A FunctionTypeAlias is known to declare a FunctionTypeAliasElement.
This was already reflected in the type of
FunctionTypeAliasImpl.declaredElement, it just wasn't reflected in the
public API.

Change-Id: Ia1a01f91e8fccee261fceddfc8797c3be36f7ea1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113942
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-21 15:01:59 +00:00
Konstantin Shcheglov f50a566476 Enclose local variables in default values of optional formal parameters. 
R=brianwilkerson@google.com

Change-Id: I693759f24cab6a63d5a1ecbdb131324b29fc8d34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113927
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-08-21 00:41:24 +00:00
pq ee38a308da thread feature set into linter debug util 
Change-Id: I50e7145105bdee7227a4d5437fc154272a43ccb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-08-20 23:09:13 +00:00
Brian Wilkerson a5007cde35 Clean up an obsolete TODO comment 
Change-Id: I5626c2d03d46517ee12333dd76d6d08cc8a36a5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113921
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-08-20 21:59:02 +00:00
pq f842b03de5 linter visit hooks for extensions 
Change-Id: Ibd8060ae17579126cb7a417acc2fc45cb7fe17bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-08-20 20:49:50 +00:00
Sam Rawlins 72923471c4 strict-inference failures for untyped parameters: 
* Untyped function parameters are a strict-inference failure.
* Add tests for strict-inference failures on fields.

This finalizes the "untyped / uninferred variables" cases.

strict-inference spec: https://github.com/dart-lang/language/blob/master/resources/type-system/strict-inference.md

Bug: https://github.com/dart-lang/sdk/issues/33749
Change-Id: I1d01ad15418be1891c95588132a44d478c5905a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:06:48 +00:00
Dan Rubel bfc7f8c4b5 Fix crash parsing invalid constructor initializer 
Fix https://github.com/dart-lang/sdk/issues/37414

Change-Id: I6ea202050e2278da50c92b26acd91bdc429d5341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-20 20:04:19 +00:00
Dan Rubel e2777454cc Fix dartfmt bug 
... by changing ANNOTATION_WITH_TYPE_ARGUMENTS to be a syntax error

Fix https://github.com/dart-lang/dart_style/issues/836

Change-Id: I2ac1b1105b817b6728ecc3d73875581a9cf65861
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Brian Wilkerson 56b3dede78 Implement some missed methods for summary2 support 
Change-Id: I18cbec26512c4d660b6dbc3ea1e5325ff032a8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113753
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 00:31:52 +00:00