30ea777c65
fix parsing of "?.." cascade operator
...
Fix https://github.com/dart-lang/sdk/issues/37859
Change-Id: Ie29f4fd000199f0099137308603335e36af6ae26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116089
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-10 20:36:04 +00:00
7ffb9de00f
Update the version in the extension methods version hint
...
Change-Id: I465413e0d1252573112bff2e518fc933308e093b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-10 19:48:17 +00:00
c11ca7d439
Check for CompileTimeErrorCode.CONST_WITH_TYPE_PARAMETERS in LinterContext.canBeConst().
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/linter/issues/1712
Change-Id: I8e6ec22999baf2af95f05af13fdaf596cba7676a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-10 17:57:11 +00:00
fa099eb717
Look for both getter and setter in the hierarchy before looking for extension.
...
Change-Id: I7080f5ffb307b9deb9bba453e1d1c1aa253b7cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-10 16:39:09 +00:00
331271d405
Set id(s) for GenericFunctionType(s) in constructor initializers and default values.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/38282
Change-Id: I05d5b5c003fa51cc5061ed2dd6883809b6f82cae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116490
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-10 16:26:39 +00:00
7413879026
[analyzer] Add getter isNullAware to SpreadElement
...
Change-Id: I89d644da2277b4527f32e176f9355cf16734dc64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116380
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-10 03:20:19 +00:00
0851b9ae4c
Consider both getter and setter when deciding whether an extension reference is ambiguous.
...
Change-Id: I8acbabda7f748e7415bd38a957e96f906afd7f6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116250
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-09 19:13:06 +00:00
6f38a73618
Remove most of the task model.
...
I run presubmit, and it does not look to me that any failin tests
are caused by this CL.
https://test.corp.google.com/ui#id=OCL:267824456:BASE:267824473:1567923135217:2380181a
R=brianwilkerson@google.com
Change-Id: I838f2174460e0d06c85bbb83de9037113c0b6393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116252
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-09 18:26:50 +00:00
fbd21a0d1f
Guard against null in exportedDeclarations.
...
I was not able to find the root reason of the problem :-(
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/38261
Change-Id: Ib9a78366548688eab231fc941b29f608bdb6b15e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-09 18:24:16 +00:00
41bf7443d4
update parser to report static constructor
...
Change-Id: I95b07f5e85600a05c59b3107922ae663f242b0dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116246
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-09 05:26:16 +00:00
fb73cb19e6
update parser to report MixinDeclaresConstructor error
...
Change-Id: I4750ff522046cbcc6bab561d189f578a8e8fd8d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-09 05:26:16 +00:00
355df2a354
split AstBuilder endClassConstructor out of endClassMethod event
...
This CL moves the logic determining whether a declaration is a method
or constructor into the parser and splits the AstBuilder endClassMethod
event handler into simplified endClassConstructor and endClassMethod event handlers
Change-Id: I2d2124a2456f70d5511163cead25f6c586ea9c71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-09 05:26:16 +00:00
b6f6240013
fix extension factory declaration in AST
...
Constructor declarations within extensions are invalid and the parser
reports an error. This modifies AstBuilder to add the declaration
as a method declaration in order to get navigation, search, etc.
Fix https://github.com/dart-lang/sdk/issues/38202
Change-Id: I6071a8d5a742d6598f18a831688ddc97e411f76f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-09 05:26:16 +00:00
23d28932f0
Remove asserts in TypeProviderImpl.
...
R=brianwilkerson@google.com
Change-Id: I4a82fc390d202ba316af4f36932349993952df98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116183
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-07 15:10:38 +00:00
7f8398e484
Changes to MockSdk to make it usable in linter.
...
The goal is to switch linter to analyzer's MockSdk.
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I3bf735ddf82efaaa24ccc07fa8fe7e752dc6d19f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-07 14:53:28 +00:00
116cfbaa2d
Issue 38198. Fix for isMoreSpecific() extension.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/38198
Change-Id: I734d2353b9064a1a0e007495a1df546873e15c8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-07 14:53:20 +00:00
2c219ddb07
Replace AnalysisContextFactory with TestAnalysisContext.
...
R=brianwilkerson@google.com
Change-Id: I45ac78530061478e4835bd78355ab9f089f80879
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116047
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-06 22:47:36 +00:00
ffd50c0dc5
Report EXTENSION_AS_EXPRESSION, set type fo dynamic.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/38203
Change-Id: Iee270b7b3fecbeaba202c304f21ef703a8567674
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116055
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-06 22:14:34 +00:00
4e4047a52f
fix extension abstract method error
...
This changes EXTENSION_DECLARES_ABSTRACT_MEMBER to be a parse error
and moves it into the parser so that it is generated for all of CFE.
Fix https://github.com/dart-lang/sdk/issues/37945
Change-Id: Iba2876eb2db83e96ec49adc49a7b6a0e7aff200b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116002
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-06 19:50:17 +00:00
0d63ce1d0c
Clean up MockSdkElements.
...
R=brianwilkerson@google.com
Change-Id: I378bc57d08119d4a82315f1e181b934e3d7e17e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116045
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-06 19:14:39 +00:00
6ae9709bcb
Create TestTypeProvider as TypeProviderImpl on MockSdkElements.
...
R=brianwilkerson@google.com
Change-Id: I540cf25a37447a0e83db1bbbed4dbd5128d490a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-06 17:36:08 +00:00
17c06c342e
Unify to single TypeProviderImpl.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I93b0f9956cd9a138cdaa94a95a9d3eea4c0a6b62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115776
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-06 16:01:00 +00:00
836039e9b6
Add MockSdkElements for creating dart:core and dart:async mocks.
...
Switch AnalysisContextFactory to using it.
TestTypeProvider will also use it, via TypeProviderImpl from another CL.
https://dart-review.googlesource.com/c/sdk/+/115776
R=brianwilkerson@google.com
Change-Id: Ib6a26c84e08d024b64146c0631ece35d8a4d32cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-06 14:25:59 +00:00
2246f0a8a3
Compute constant dependencies for constructor elements in canBeConst().
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I92871e880e669aca5447f6fe7d7a8249421e7c44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115613
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-06 03:29:28 +00:00
35f45f0ee4
Do null-aware shorting for IndexExpression.
...
R=brianwilkerson@google.com
Change-Id: I72e6aabb4fd2f79201ee1146e6ea83aa54ceb7a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115763
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-05 23:52:39 +00:00
592914fb8b
Don't report HintCode.CAN_BE_NULL_AFTER_NULL_AWARE when NNBD.
...
With NNBD we do shorting, so `foo?.bar.baz` is OK, `baz` will never be
requested from `null`, unless `foo.bar` is nullable, in which case
it is UNCHECKED_USE_OF_NULLABLE_VALUE.
R=brianwilkerson@google.com
Change-Id: Ic9bbd0f6116dfca53b8dd9cf05b557919c025d2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-05 20:26:12 +00:00
ff8b43750a
Move reporting INVALID_ASSIGNMENT for compound assignments into StaticTypeAnalyzer.
...
R=brianwilkerson@google.com
Change-Id: Ia5355023ff5873c7d10eb60b85c5fd8a41dea417
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-05 18:29:35 +00:00
68ba13e4e8
With NNBD null-shorting is performed.
...
So, the type of `a?.b.c` is nullable, but the type of `c` is not.
Everything after `a?` is just not executed if `a` is null.
R=brianwilkerson@google.com
Change-Id: I705051080b8cc2bb5014355688561b0f3dccc0d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-05 16:44:13 +00:00
6eed35b60d
Analyze null-aware index expression reads.
...
R=brianwilkerson@google.com
Change-Id: Idcd787434eae070e87adf267a016bda2a4e5703e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-05 00:58:46 +00:00
57314a7e2f
Add fixes to create getters in extensions
...
Change-Id: I9a78cdeac0fddfc23f919956723a884456c4e429
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-09-04 21:13:45 +00:00
43a7408129
Turn on summary2.
...
Change-Id: I075531073614f58d14f87016e1896698c9ad2aea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-04 16:59:23 +00:00
6bcf67a6a2
Move isLate to VariableElement.
...
R=brianwilkerson@google.com
Change-Id: I9228dc48a42d7daa08d96b8cd52949a817bcbeff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115272
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-03 21:31:54 +00:00
67ac9cf52c
Don't report ASSIGNMENT_TO_FINAL or ASSIGNMENT_TO_FINAL_LOCAL for late variables.
...
R=brianwilkerson@google.com
Change-Id: I72feef1b1e78ab787fa538d7ff87e20c04a644fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115269
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-03 19:38:16 +00:00
d92ffcb771
Change where we decide that unnamed extensions are private
...
Change-Id: If9a979d58418f9405c362acc746ec37e51562cc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115264
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-03 16:44:18 +00:00
233b4a71ca
Deprecate some unnecessarily duplicated error codes
...
Originally the spec made a distinction between when some of these
conditions were errors and when they were warnings. That distinction has
been removed, so this just cleans up our code to reflect that fact.
Change-Id: I3a6fdae2896eb93c6b9cacfea790cd9b553feec5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115261
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-03 16:01:25 +00:00
9f57cf71d7
Add a blacklist to spelling tests; spell-check all packages and sdk with blacklist
...
Change-Id: I5bf3d5784d2ba48568a2699bb09ae39a85be17c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115214
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-09-03 12:39:24 +00:00
fc3fb37b6e
Fix for 'static late' fields.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/37858
Change-Id: I0065653c876932dd3aba01d485479fc64788ed8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115076
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-30 22:45:08 +00:00
a900a65ab7
Add AnalysisOptions.isLintEnabled(name)
...
R=brianwilkerson@google.com , pquitslund@google.com
Bug: https://github.com/dart-lang/sdk/issues/38081
Change-Id: Ie00dca15d5869556373eb24e9d21e40f83feb316
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115071
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-30 22:11:43 +00:00
b6ad76845e
Extensions imported via a prefix are not in scope
...
Change-Id: Ie3d03d0cc9d2650fdf9a737bae090235af7ef866
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-30 20:34:02 +00:00
a94a3c60d7
Format the code snippets in docs
...
Change-Id: Ieabed8b05df79b4872090e82cdc6ceb941979e71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115060
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2019-08-30 16:38:14 +00:00
11a40915c1
Enable sending URIs with documented diagnostics
...
Change-Id: Ie89f451f1dc4a026d3d6e6693ff2dd525cb099fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-30 15:48:24 +00:00
a873bc5db3
fix extension constructor error
...
This moves another usage of EXTENSION_DECLARES_CONSTRUCTOR into the parser
so that it can be shared by all of CFE.
Change-Id: I3b1502eaf83fdbcc663f4a18d638230e3c5ea925
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-08-30 00:33:43 +00:00
6061906a77
split endMethod into 6 separate events
...
This updates the parser to detect constructors vs methods
in classes vs mixins vs extensions. Rather than generating a single
endMethod event and require listeners to determine the type of
declaration, the parser now generates different events for
different types of declarations so that listeners can process
each of these different types separately.
In addition, this lays the groundwork for fixing extension declaration
error messages and moving error generation that is duplicated
in the various listeners into the parser.
Change-Id: Ia86a4bf3e6f1442ca4926c754b66e7d6e86fb47d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-30 00:33:43 +00:00
c5d108a623
Build new elements for GenericFunctionType in DeclarationResolver.
...
Change-Id: I555c6dacebbc3187aa94bf3ce4ff8b662ca3054c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114963
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-29 20:24:05 +00:00
a78e0c4af0
generate errors for extensions named w/ built-in ids
...
Fixes: https://github.com/dart-lang/sdk/issues/38095
Change-Id: I7e328668898e46ad2e37e0e57046b2ec1cc8ccc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114755
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-29 20:11:15 +00:00
7835190cc9
Revert: Read default values fully.
...
This reverts https://dart-review.googlesource.com/c/sdk/+/114780 ,
because it causes other stack overflow while reading elements.
R=brianwilkerson@google.com
Change-Id: Id9e398bba984f364d4a1a8fcb76f71d7f39379af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-29 17:12:04 +00:00
c7f3300448
Flow analysis: begin tracking where variables are written to in closures.
...
Not yet used. This will be needed in order to implement the
"writeCaptured" behaviors in the flow analysis spec.
Change-Id: I873f10089a7b93ec5b40d979ddf3a6754e30b181
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114960
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-08-29 17:01:24 +00:00
45b85e12d2
[VM] - Remove rules to build vm_legacy_platform
...
Change-Id: If79375d73e24f99017cbeafd3357e03001925162
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114924
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2019-08-29 15:57:54 +00:00
cd5bcd7ddc
Fix for FieldFormalParameter with type parameters.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/38057
Change-Id: I7a24adbc4af9c2e1bc244f0ebca1a651f2c487d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114929
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-29 14:42:54 +00:00
6fa5b31fcc
Report an error when extensions declare a static final field that is not initialized
...
Change-Id: I85e15ae0965ac905751b9877691cf20e9f615021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114927
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-29 13:17:50 +00:00
danrubel