Konstantin Shcheglov
b0d079a96b
Set context type for extension override receiver.
...
Change-Id: I9c32f67af8e934ac78c580c97174547278618bfe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-09 16:35:14 +00:00
Brian Wilkerson
0c727420c3
Stop reporting undefined method when there are ambiguous extension methods
...
If this approach looks reasonable, then I'll use it to also stop reporting
undefined getters and setters in the same way.
Change-Id: Ia46204558fef06d092c5465774846841802de1f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112484
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-09 14:58:22 +00:00
Mike Fairhurst
e627d8b852
[nnbd_migration] use postdominators to do hard edge detection in most cases
...
Change-Id: I6af934b4a4795a0cfd74519985b24ae171485880
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111941
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-08-09 07:12:00 +00:00
Konstantin Shcheglov
4d30d9cffc
Make TypeSystem.resolveToBound() do what it promised in the documentation.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/110757
Reverted: https://dart-review.googlesource.com/c/sdk/+/112274
Change-Id: I85fbd7782730b9f44d972a1c807b191e068beff5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112303
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-08 18:32:49 +00:00
Konstantin Shcheglov
559f7cd182
Fix selecting URI for import/export configuration with '== true'.
...
R=brianwilkerson@google.com
Change-Id: Ie18d5f76041342c6a42fd7b1f8a3be55a6e8adee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-08 18:24:44 +00:00
Brian Wilkerson
7bde33139d
Add support for extensions to unused import detection
...
Change-Id: I211c769765293a35f371bd2b403b38ac5dcb3b14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112280
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2019-08-08 12:40:40 +00:00
Konstantin Shcheglov
08517e10f9
Revert "Make TypeSystem.resolveToBound() do what it promised in the documentation."
...
This reverts commit 7d54324657 .
Reason for revert: forgot to update CHANGELOG
Original change's description:
> Make TypeSystem.resolveToBound() do what it promised in the documentation.
>
> OTOH, we don't have TypeSystem.instantiateToBounds(), so I'm not 100%
> sure whether the doc is inaccurate, or instantiateToBounds() should be
> added. Or even if DartType.resolveToBound() should be used, not the
> version from TypeSystem.
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Change-Id: Ied333161d68af40314f4b8e2c3cee3b350d05f7c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110757
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Reviewed-by: Paul Berry <paulberry@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
Change-Id: I9019fdf8bf1eb78632dc396f99e7a1108e4bc38f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112274
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-08 01:51:38 +00:00
Konstantin Shcheglov
7b63de3c06
Fixes for importing URIs that have 'part of' directives.
...
Change-Id: If5495106e44b55059558537ceafee43549235152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-07 23:46:02 +00:00
pq
59c63139d0
set thisType for functions and void types
...
Change-Id: I7886d02b982bd0303074cb4c2370a9bc72258d58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-07 22:57:14 +00:00
Konstantin Shcheglov
7d54324657
Make TypeSystem.resolveToBound() do what it promised in the documentation.
...
OTOH, we don't have TypeSystem.instantiateToBounds(), so I'm not 100%
sure whether the doc is inaccurate, or instantiateToBounds() should be
added. Or even if DartType.resolveToBound() should be used, not the
version from TypeSystem.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ied333161d68af40314f4b8e2c3cee3b350d05f7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110757
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-07 22:41:15 +00:00
Konstantin Shcheglov
31bb4df3ed
Move ExtensionOverride errors into resolveOverride().
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Ia9dae5b461210c6fae40e9cf2d5282aa4fea3b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112262
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-07 20:28:05 +00:00
Paul Berry
bff5732c10
Flow analysis: unify API for handling == null and != null.
...
This reduces code duplication in the client.
Change-Id: I278fb4d3c7fc7b913498d4a69f4f361f6227da32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112146
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-08-07 19:21:24 +00:00
Konstantin Shcheglov
27783bd46b
Combine inference and choosing the most specific extension.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Idb69695611f777727c127aeb629e5b62e8112648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112220
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-07 17:29:44 +00:00
Paul Berry
0ce7cc53fe
Expose flow analysis operations so they can be reused by NNBD migration
...
Change-Id: Ifa101b91cfc93f19a492ecceb8bebbfeccd1a7db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112164
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-08-07 15:15:00 +00:00
Paul Berry
595f5c9b3e
Migration: add support to EdgeBuilder for assignment of complex generic types.
...
Change-Id: Ia1a754c0174b71dfeb420309324307b391e3eb4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-06 22:03:37 +00:00
Brian Wilkerson
b095be9531
Resolve methods when the type of this is defined by a type parameter bounds
...
Change-Id: I857c35ea23fcccb3f7932cd266e9abcfd193b86d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112100
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2019-08-06 20:51:57 +00:00
Konstantin Shcheglov
98b1e28591
Include isSynchronous/isGenerator into API signature.
...
They are flags on FunctionBody, but exposed from the element model.
R=brianwilkerson@google.com
Change-Id: I30e5032598535bce8106e685f26d084e305e8d34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-06 17:49:49 +00:00
Konstantin Shcheglov
1235643cfc
Support for Combinator offset / end.
...
R=brianwilkerson@google.com
Change-Id: I7a0c9a3a78a9e45e2a3214c076d773703259aaca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111994
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-06 17:33:59 +00:00
pq
47ee568c52
extension type awareness in matching
...
Fixes: language_2/extension_methods/static_extension_getter_setter_test
Change-Id: I71b4b3ac63a3d22f4b1856a912b123661d5e23d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112031
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-06 16:44:33 +00:00
Konstantin Shcheglov
e10c138475
Infer extension types without extension override.
...
R=brianwilkerson@google.com
Change-Id: I66dbcee754995563acb09d4643df1800ea1064d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111990
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-06 00:29:37 +00:00
Paul Berry
2cac8637d6
Flow analysis: separate nullability and reachability tests.
...
Change-Id: I875493ff504f094ade2818f29539525fdd75a808
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-08-05 22:12:26 +00:00
Brian Wilkerson
d0775434be
Resolve extension methods within other extensions
...
Change-Id: I15283f84e5e8c7e39301d7358f4de1ee7f5eb857
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112021
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-05 21:58:26 +00:00
Paul Berry
612825900e
Only create FlowAnalysisResult data structure when running internal tests.
...
The data structure isn't optimized (recording data into it takes
O(n^2) time, where n is the number of unreachable nodes in the file),
and we don't need it for normal execution anyhow.
Following the model used by CFE and dart2js, the analysis driver has a
new flag `retainDataForTesting` to control whether the test data is
gathered, so that under normal execution there is no overhead. The
testing data is stored in a new class `TestingData`; we can expand
this class in the future if we need to record other intermediate
analysis results for testing.
Change-Id: I7e79d31b9f3c9c45121dceb49094be802e4d286f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-08-05 21:12:43 +00:00
Konstantin Shcheglov
034131f10a
Add MapSubstitution interface, and use it in Member hierarchy.
...
R=brianwilkerson@google.com
Change-Id: If5a9c07c2fb1582fb31ba414f0f329c59eb1af16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111924
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-05 18:30:50 +00:00
Brian Wilkerson
77a957da1d
Report the use of an extension override without an instance member access
...
Change-Id: Ibd960aedd1739e4b446371349f0f4d4d6d5f6c61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-08-05 18:11:28 +00:00
Konstantin Shcheglov
28a4717476
Don't overwrite synthetic field setter with duplicate setter.
...
R=brianwilkerson@google.com
Change-Id: I006b6e845b5359d02f0f60b48bf89544b2ed80c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111966
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-05 18:02:41 +00:00
Johnni Winther
6eb9f54683
[cfe] Add ClassKind to Listener.begin/endClassOrMixinBody
...
This allows for special-casing extension declarations bodies. This
is needed because the on-clause hold the type of the parameter holding
the `this` value inside an instance method in an extension declaration.
Change-Id: I7af9bf0a9842f7e6f42dddb54fb487c69a8fa519
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111729
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-08-05 17:15:37 +00:00
Konstantin Shcheglov
ae2a06171c
Fix for enclosingElement for default parameter element initializer function.
...
This fixes another error found by Mike's fuzzer.
R=brianwilkerson@google.com
Change-Id: Id16a280949d14ce7589d47a88faf9a038c588e04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-05 16:45:17 +00:00
Konstantin Shcheglov
919b5cd2d5
Fix for duplicate top-level declarations.
...
This fixes one of the errors which Mike found with fuzz tester.
R=brianwilkerson@google.com
Change-Id: I987f47746c8721d9a39de0c186cf4c3776f66611
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111960
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-05 14:29:55 +00:00
Paul Berry
db1988acd0
Add voidType to TypeProvider
...
Change-Id: Ibacf7e741c959584159798061ffd04ebefd9ebab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111881
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-08-05 14:21:50 +00:00
Konstantin Shcheglov
df606cc566
Infer types of static fields in extensions, summary2.
...
This fixes:
co19_2/LanguageFeatures/Extension-methods/syntax_member_declarations_t01
R=brianwilkerson@google.com
Change-Id: Ic1fba8721414028d04a18c28eeff5c09db6c07c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-03 15:18:11 +00:00
Konstantin Shcheglov
bf020a99d4
Sanitize recursive GenericTypeAlias in summary2.
...
This fixes:
co19_2/LanguageFeatures/regression/33599_34700_t02
co19_2/LanguageFeatures/regression/33599_34700_t04
R=brianwilkerson@google.com
Change-Id: Ia01274fbce6a8a3e23a538bb81fd69cd1f6c1947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111922
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-03 15:10:16 +00:00
Konstantin Shcheglov
be581f69db
Move search.getDeclarations to available declarations.
...
So, we keep this feature working when switch to summary2.
IntelliJ does not use it though.
Change-Id: I11f71443dc7354de8a593442de470fa91aa228e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111870
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-03 15:10:06 +00:00
Konstantin Shcheglov
cf0af59b33
Fix summary2 for TypeAnnotation as extended type.
...
This fixes crash in:
language_2/extension_methods/static_extension_silly_types_test/01
language_2/extension_methods/static_extension_silly_types_test/none
R=brianwilkerson@google.com
Change-Id: I349e0cb7b2d071b879b61d992de681e39bdc4aa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-03 15:02:14 +00:00
Konstantin Shcheglov
e72b70fbc6
Extract RequiredParametersVerifier, but use directly in ErrorVerifier.
...
With AnalysisDriver, and computing constant values on demand, we
can check for required parameters directly, without pending constants
and errors.
We also don't have to do additional recursive pass over AST, so will
probably run a little faster.
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I623f47851bf0094ac59d60a24f3015a3154432c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-03 15:02:03 +00:00
Brian Wilkerson
19ab86cbf6
Report the use of covariant in optional parameters
...
Change-Id: I66cbe9b7b1c95e02ade4038786d6494af2f34a44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111869
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-03 14:17:11 +00:00
Konstantin Shcheglov
4bebfebdbc
Initial support for extension methods inference.
...
Only the case with ExtensionOverride is supported for now.
Still fixes some co19 tests.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I6c7c98f4839a1fc40504d93107648d952a4176d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111866
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-02 23:24:41 +00:00
Brian Wilkerson
57b9ce7fb7
Report when super is used in instance members of extensions
...
Change-Id: I58370268e018d97c78667c900678e419af07e7ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111863
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-08-02 21:31:49 +00:00
Konstantin Shcheglov
3a2576eca9
Use ExecutableMember.from2() in ParameterMember.getAncestor().
...
R=brianwilkerson@google.com
Change-Id: Ieb2a7ae700080ff2871e5a3d02e3c27ea7ee37ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111864
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-02 20:37:44 +00:00
Konstantin Shcheglov
9bb446aae1
Record if MethodDeclaration has NativeFunctionBody, so it external.
...
This fixes the issue with failing DDC tests like this:
co19_2/LayoutTests/fast/media/matchmedium-query-api_t01
R=brianwilkerson@google.com , paulberry@google.com
TypeError: html.window.styleMedia[$matchMedium] is not a function
Change-Id: Ic7a80c53122cdc3e0bcce835b5717413e342ce74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111862
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-02 19:43:39 +00:00
Konstantin Shcheglov
0e24437b81
Replace InterfaceType with Substitution in Member(s).
...
I ran it in google3:
https://test.corp.google.com/ui#id=OCL:261214112:BASE:261244079:1564722983792:f6286cfb
Change-Id: I820d2dbbaefe495c20b0d8fe3f7c54f1766d5689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-02 19:34:18 +00:00
Brian Wilkerson
622ec5099f
Support tearoffs through extension overrides
...
Also add tests for other forms of tearoffs
Change-Id: I43ee36ffcc9e69af6b2785153c6d95f5de814371
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111668
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-08-01 21:35:53 +00:00
Konstantin Shcheglov
42e978ca54
Fix Windows bot.
...
Change-Id: I4a92643e2007818555c96cd782c7ef9b6b17c42d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111670
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-01 21:31:32 +00:00
Brian Wilkerson
7826b4faf1
Partially support extensions of function types
...
This causes some of the language_2 tests to stop crashing, but doesn't
fully implement support for extensions of function types.
Change-Id: Ie1fad540f3ed0b5ed46aec7162f9fe3f15244db0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111661
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-08-01 19:28:06 +00:00
Konstantin Shcheglov
a05ef7c0cc
Store inferred type arguments for tear-off(s).
...
This change passes pre-submit run over google3.
https://test.corp.google.com/ui#id=OCL:260993915:BASE:261043007:1564632838252:e80ace42
Change-Id: Ibef739f241fdb60a574da971961b1abe6abde9c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111402
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-01 18:25:39 +00:00
Konstantin Shcheglov
677f434a6b
Fix computeUnlinkedApiSignature() to change signature when body changed from/to empty.
...
R=brianwilkerson@google.com
Change-Id: Ib103017308bbd3bc1eecd992cb924ff0d02a9e32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-01 16:26:43 +00:00
Brian Wilkerson
bbc97f5f79
Improve some diagnostic messages
...
Change-Id: I4784d995d701004dee23f6295a1687fc626a7785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111603
Reviewed-by: Kathy Walrath <kathyw@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-01 14:50:49 +00:00
Konstantin Shcheglov
6123dbdae5
Support for extensions in available declarations.
...
R=brianwilkerson@google.com
Change-Id: Id173e18fb7e7167cae6677318cc6fca68889c8ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-01 02:26:22 +00:00
Konstantin Shcheglov
c4e423db48
Deprecate isSupertypeOf, flattenFutures, isAssignableTo of DartType.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I3028d79580602d5e4d64ca9f013b28173ad63787
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110756
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-07-31 22:47:41 +00:00
Konstantin Shcheglov
6a4d805df4
Implement 'Import Library' quick fix using DeclarationsTracker.
...
This reverts commit 143e5ef556 .
Change-Id: I3c575ff690fd8c8d93a90e50a451a6ec993c4164
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111305
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-31 22:14:21 +00:00