8cf4c15bf0
Update the context location label for general type alias support
...
By the way, I didn't actually regenerate the table, I just hand edited
it. We don't have any way to ensure that the checked in table matches
what would be generated because we can't have the code used to generate
the table available on the build systems (or every developer's machine).
Change-Id: I4b645f3a276f23bab469e5daf2325cc8f2d0bce4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181441
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-01-27 22:38:07 +00:00
77353dc380
[Analyzer] Allow files inside .dart_tool to be analyzed when modified
...
These files were already analyzed at startup but not when modified. This meant code generated by flutter_gen would not update unless the analysis server was restarted/the project was reanalyzed.
Fixes https://github.com/Dart-Code/Dart-Code/issues/3074 .
Change-Id: If0c88c1e5ab7e796046e7e776a42c3d904944405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179776
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-27 20:37:25 +00:00
00edf6fd13
Mark newly published docs as being published
...
Change-Id: I5663eaf6a6df94d279f15ca42364e96054c04987
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180800
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-27 20:19:17 +00:00
3a5294c7e6
Fixes and tests for completion in non-function type aliases.
...
Change-Id: I69cf74380fc1c251e0f44334fdff17f327cafeaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-27 19:27:35 +00:00
6e1a0b08c7
Update to null safe package:html
...
Change-Id: I667efbe0f895628130bc695e96a7f95a991c2e9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181040
Commit-Queue: Nate Bosch <nbosch@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2021-01-27 18:41:10 +00:00
b23be6b8ee
Update the completion metrics measurement tool
...
Change-Id: I8e67d138e60e0e226cef87e9efd35088526dec72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-26 23:54:15 +00:00
83a72e18f3
Switch completion tests to WithNonFunctionTypeAliasesMixin, updates and tests for suggesting non-function type aliases.
...
Change-Id: I0066d479b23b46e0aaaae43aebdc1bbc58336ad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181282
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-26 23:04:05 +00:00
79c35e872d
Update messages for checking the name of a type alias.
...
R=brianwilkerson@google.com
Change-Id: I6a523d3b5f8db07f1f1e1e779c1e9aacf885b173
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-26 23:03:55 +00:00
e9fe25003b
Issue 43166. Don't ignore changes to files excluded from reporting diagnostics.
...
Bug: https://github.com/dart-lang/sdk/issues/43166
Change-Id: I9d9f8cf77129ecd811f13876aa6e284f633f023a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-26 22:23:55 +00:00
d8961dc2c9
Test that rename refactoring works for non-function type aliases.
...
Change-Id: I801be01b73f0e27245ec8958b0a18e521615c8e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-26 22:11:45 +00:00
64a8d2a8b8
Fix for indexing constructor references in documentation comments.
...
Bug: https://github.com/Dart-Code/Dart-Code/issues/2816
Change-Id: I4515b6887f5d8bd93fc6ba59812c5a9ec14f0d3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-26 20:15:44 +00:00
d373094cbb
Test that search of/in non-function type alias works.
...
Change-Id: I4d750da4a706d837d626349ad4225f80d35c3f78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181140
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-26 16:08:39 +00:00
4a5ac9df57
Support for non-function type aliases in convertElement() and test navigation.
...
Change-Id: Ic2dcf6ad3faaf6712fdcbbe5197f332b6ba42e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-26 06:40:00 +00:00
3a9dc0ae9f
Highlight Function/typedef as BUILT_IN, non-function TypeAliasElement as TYPE_ALIAS.
...
Change-Id: Icd2375338c3b37c34b8438453d58af43e8d0dfd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180640
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-25 23:02:17 +00:00
f438d72387
report sdk root in status
...
Change-Id: I9c9d09a2812566d88835b3dbc6808a515089cd4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-25 19:53:53 +00:00
527034b059
remove (redundant) exists check
...
the check is expensive and because of the async nature of the filesystem doesn't do away with a need for try-catch.
Change-Id: Ief5020066f21789c83a331f767a65ccdb2769a77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-25 19:32:13 +00:00
40b9650b67
Add ElementKind.TYPE_ALIAS and HighlightRegionType.TYPE_ALIAS to the protocol.
...
Change-Id: Ia4991d4f657f4bfa5e244d9c3b126e89571b9e7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180660
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-25 18:42:03 +00:00
3001499c78
data driven sdk api fix support
...
Change-Id: I5b05044b505fa5936d8148515c61172e443dc129
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180721
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-24 15:41:48 +00:00
a00530b46f
Remove unused support for requesting token details
...
Change-Id: I9cc160d84e06b4b7be67e53962fe38c1430e74b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180762
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-24 05:11:48 +00:00
0f0c2b5e66
Fold tests with experiments into AnalysisNotificationHighlightsTest.
...
R=brianwilkerson@google.com
Change-Id: Idfc8e2413eda6f2d755a24f6cad8800244bf3aa0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180621
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-22 19:32:54 +00:00
995b91675a
Enable the use of config files when testing data-driven fixes
...
Change-Id: I8e21111840275a3db65adadc465482e998fb8cbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180385
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-21 19:47:03 +00:00
e45665fc5f
Add support for parsing a config file for a data-driven fix test
...
The contents of the file are not yet being applied, so the only thing
that can be tested at this point is the parser.
Change-Id: If8579e8b7383937f47e4960c3ecd3dfe283c40bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-21 17:58:31 +00:00
b94adb2bc2
[Analyzer] Add folding regions for comment blocks
...
Change-Id: Iafe70e977065dc68230503349b8ba3abe9b4c0c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179777
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-20 16:23:45 +00:00
34f9c07457
fix edits that can be applied to other libraries
...
See: https://github.com/dart-lang/sdk/issues/44534
Change-Id: I24101c493faed2da7e1ce4ff01a8c652d6c5f901
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180087
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-20 00:25:14 +00:00
3621c6a02f
Add a flag to the bulk fix protocol to support testing
...
I think it makes more sense for the server to read the config file than
for `dart fix` to read it and then pass the data to server as part of
the protocol, which it would effectively need to be parsed a second time.
But I don't want config files to be used outside of test mode, so I
added the flag to the protocol. Let me know if you can think of a better
approach.
Change-Id: I1c53bc995272451247e84914f2cd6b75a837ee1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180082
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-19 23:16:14 +00:00
d901213061
[Analyzer] suggest type names in field declarations where fields may have been parsed as field names
...
Change-Id: Ie31cc3bae86538ea5580627851a7b7d95571a5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179771
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-19 22:26:14 +00:00
15cd98f511
[Analyzer] Add a custom semantic tokens modifier to named parameter labels
...
Change-Id: I5b5e4030a17bd894872884960d11eaa748c12e5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179769
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-19 15:51:22 +00:00
e8d4569e37
Fix for ConflictingEditException in RemoveUnusedLocalVariable.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I5614e83b5b7dca720b5de09a5ee7fd457a13b2e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-18 07:08:49 +00:00
053b948963
Enhance the comment on BulkFixProcessor
...
Change-Id: Icdd38ad7ea37142829f3b3688ff31e335431525c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179681
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-16 17:43:33 +00:00
44cb6a17e9
bulk fix for avoid_relative_lib_imports
...
Change-Id: I5c1d19d81f0293ef7ae2d3e67a67f9eb5f405d7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179585
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-16 03:24:42 +00:00
5ae02ab4c3
Fix merge conflict findNodeAtString vs. FindNode.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I7953b2b6e2f2201297c6ae91e36d69297a23ff15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2021-01-15 18:48:57 +00:00
1711659823
Replace findNodeAtOffset() and findNodeAtString() with FindNode.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I7058e347d504e7017e6229e520669d45602decd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179369
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-15 17:15:42 +00:00
58e7e7eb26
Prepare for breaking change in package:http
...
The `url` argument is changing from `Object`, accepting either `String`
or `Uri` at runtime, to `Uri` for better static help.
https://github.com/dart-lang/http/pull/507
- Switch to using `Uri` for requests. Where sensible push this type into
the signature of the surrounding method.
- Make some updated method private where they were unnecessarily public
which makes it harder to have confidence when looking for usages.
Rename a method with an unnecessary `get` name.
Change-Id: Ibf075741d6b9d292349b15f1dc84004981729aca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179368
Auto-Submit: Nate Bosch <nbosch@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2021-01-15 16:35:01 +00:00
37369b310e
Refactor and add tests for creating an ElementMatcher for a node
...
The code that was moved contains some additional fixes. I'm happy to
break this up into two CLs if you'd prefer.
Change-Id: I4e2407d28b238ff75934fcf92a411d5fe0b94585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179364
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-15 14:57:08 +00:00
56903e6cfb
Replace findElementInUnit(), findLocalFunction(), and findLocalVariable() with FindElement.
...
Change-Id: I508b63fee81dc087489055448debb495a06eff6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179361
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-14 23:15:25 +00:00
cfe510ade8
Test for search of non-function type alias.
...
Change-Id: Iab2fc3980563a321eec3cf4e843d487b7b2b399d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179320
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 21:52:13 +00:00
68025f0170
Use findNode and findElement more in DAS tests.
...
Change-Id: I949f1613d6d427ef3bddb9b4ab40b7feb012985b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 20:50:03 +00:00
48503619f8
Replace AbstractSingleUnitTest.findElement with FindElement.
...
R=brianwilkerson@google.com
Change-Id: Id0a3bc6e6d33c969432337e0a7cb198ff4d6a5c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 17:05:43 +00:00
353b35cc4e
Suggest only either getter or setter, but not both.
...
Otherwise we get two conflicting edits.
R=brianwilkerson@google.com
Change-Id: I57f69099f715ad3cfd342d65a6a80e2c34d812a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-01-14 01:17:55 +00:00
f757851fa6
add test for over-eager add_late fix
...
Change-Id: I9cf7d6eda6b9ed50b87225e4a2558d2ca29b011b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-14 01:05:30 +00:00
4a7dd03932
bulk fix for avoid_private_typedef_functions
...
Change-Id: I9775a542b58948488710156652ff8960ccbbc45b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178932
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 23:38:27 +00:00
f0f4f58728
[analyzer] Use generated names for extracted methods
...
Change-Id: I2aeaac092bc2222d6116c2e7172e73406bfa2260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 18:51:38 +00:00
65af2a0941
[analyzer] Add ExtractLocalVariable to LSP server
...
Change-Id: I997b9914d0c451e69a914c75da0f313430ba3722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178987
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 18:48:52 +00:00
a154a0dbdf
[analyzer] Add new contexts to declarations tracker after rebuilding due to watcher failure
...
Fixes https://github.com/dart-lang/sdk/issues/44650 .
Change-Id: Ifb59268b550e69b909c15e592cf925f40ba5f7cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 18:06:28 +00:00
d5ab427d16
analysis_server: Add a Convert to Null-aware Spread quick fix
...
Change-Id: I04dfb48e0257d8e14de81b927699b7eb063ea578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178924
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-13 17:24:48 +00:00
1d35109cc1
bulk fix for prefer_is_not_operator
...
Change-Id: Ib9888b034ff4e7376d295fb15adb738451a50085
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-12 18:24:23 +00:00
2866e46476
UseIsNotEmpty name fix
...
Change-Id: I01b358f9f80698bfa760bb6cac6e2f00a98dccd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2021-01-12 16:15:21 +00:00
b25f6959a9
Do not ignore the class of the target when deciding whether a transform applies to a diagnostic site
...
Change-Id: I5b3f77557ebc86c6942a57bc082d9224ebcd2401
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2021-01-12 00:51:10 +00:00
726d18b5f9
Add a test case for convert-to-on-type
...
Change-Id: If2dd4197dcd79ea311bec4d9aec6ed9da278aec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178721
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-11 22:56:50 +00:00
c818059287
[Analyzer] Report EXTRA_POSITIONAL_ARGUMENTS and EXTRA_POSITIONAL_ARGUMENTS_COULD_BE_NAMED against first unmatched argument
...
Fixes #44598 .
Change-Id: I6bccf4f5448de024f27d0ed1ba51c730e22b6fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178020
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-01-11 18:46:26 +00:00
Brian Wilkerson