dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6105 Commits

Author SHA1 Message Date
Parker Lougheed f9c3c09a9e Create a quick fix and bulk fix for unnecessary_string_interpolations 
Change-Id: I8cdf98ef8e23ac6a0e5fd10d4c0605a1b0d38a85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178340
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-10 16:24:25 +00:00
pq b29d36c559 bulk fix for use_function_type_syntax_for_parameters 
Change-Id: I3a28cea584cc98dd0dcc9b750887485a7950b7ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178264
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-09 20:45:24 +00:00
Sam Rawlins 897235204e Split use_of_nullable_value into separate codes with more friendly 
messages.

* UNCHECKED_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_METHOD_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_OPERATOR_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_PROPERTY_ACCESS_OF_NULLABLE_VALUE
* UNCHECKED_USE_OF_NULLABLE_VALUE_AS_CONDITION
* UNCHECKED_USE_OF_NULLABLE_VALUE_AS_ITERATOR
* UNCHECKED_USE_OF_NULLABLE_VALUE_IN_SPREAD
* UNCHECKED_USE_OF_NULLABLE_VALUE_IN_YIELD_EACH

Additionally, improve the ADD_NULL_CHECK quick fix by supporting
expressions which need to be null-checked in a for-each, a yield-each,
and a spread.

Bug: https://github.com/dart-lang/sdk/issues/44603
Change-Id: Ie493a2dc1c05b64a16fd17c77d3468e8d562c497
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178080
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-08 21:07:02 +00:00
pq daac91856b bulk fix for always_require_non_null_named_parameters 
Change-Id: Ib91171f2f892b3a7db5e674b9b7dc884cba28d5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-01-08 15:22:42 +00:00
Brian Wilkerson 5c174c8d8c Remove unused data from AssistKind 
Change-Id: I71c21e4d8138fa7f92d1a3e5a919b9fff3b2098f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177980
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-07 23:16:48 +00:00
pq 63795a73e6 bulk fix for unnecessary_null_in_if_null_operators 
Change-Id: I13b9ad4ad9ecaefd41eb211ac0a0aa0ee70557a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178040
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-07 20:24:38 +00:00
Devon Carew ad3c3644a4 Add an initial version of a 'dart language-server' command. 
Change-Id: Iffb8dedf7419a421e5282e09b4584e768c47e53f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176485
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-06 18:14:51 +00:00
Danny Tuppeny e5ed69d04d [Analyzer] Add support for LSP semanticTokens/range 
Change-Id: Iebd0a5bfca29b51fe6bb309f71c1ee476d4ed9f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177702
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-06 17:50:11 +00:00
Danny Tuppeny ee2899ed17 [Analyzer] Update DartUnitHighlightsComputer to allow generating LSP semantic tokens directly 
This allows additional types/modifiers that cannot be mapped from highlights region (for example where the existing `keyword` region type needs to be mapped into both `keyword` and `keyword.control` to support different colours as the original textmate grammar did.

Change-Id: Ie71b165fa6e4d902c068854cbbba4039ddefe185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177605
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-06 17:50:11 +00:00
Danny Tuppeny 28523a5e31 [Analyzer] Fix race condition in LSP semantic tokens + re-enable 
Change-Id: I52c4eb18dd09e3334f21bbf5fac9ce4e716ea234
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-06 17:50:11 +00:00
Konstantin Shcheglov abe144c30f Fix AvailableSuggestionSetsTest on Windows. 
R=brianwilkerson@google.com

Change-Id: Ief007dd6ca0431cc69181603e19f88717910e9ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-06 03:49:50 +00:00
Konstantin Shcheglov 17b43ca846 Issue 44353. Fix adding duplicate relavance tags for available declarations in parts. 
Bug: https://github.com/dart-lang/sdk/issues/44353
Bug: https://github.com/flutter/flutter-intellij/issues/5108
Change-Id: I6a5f04a7f44d12466799c10bac720189bd4b0612
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-05 22:43:38 +00:00
Brian Wilkerson 95c680e640 Enhance add_null_check to cover more cases 
Change-Id: I9817a300bc4600b72396fb1cd35463e6fa2f3953
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-01-03 17:39:57 +00:00
Konstantin Shcheglov 24e0fa09ce Fix RemoveUnnecessaryParenthesesTest for Windows. 
Using absolute offsets does not work well, on Windows lines endings
are `\r\n` vs. just `\n` on Mac.

R=brianwilkerson@google.com

Change-Id: Ia64e532687bcb7b197cff3ffb4514391fcc1d84e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-03 06:52:46 +00:00
Konstantin Shcheglov d407e16cff Fix for LintNames.unnecessary_parenthesis 
Change-Id: Ia31ed2b35cc93a6eab030a39705597f006fc3da4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177400
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-02 19:22:36 +00:00
Konstantin Shcheglov ea775a6a0f Migrate SearchEngineImplTest to AnalysisContextCollection. 
Change-Id: Ide259d4baf2a309a08ae74019ecb95d54d97f365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-02 19:21:16 +00:00
Brian Wilkerson 2318119845 Support make_variable_nullable fix when variables are initialized to null 
Change-Id: I816aa5fd173816aba8c2cd0be242ca8465f2c33b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-02 16:05:36 +00:00
Sam Rawlins 78956cb8d4 analysis_server: Remove unnecessary imports 
https://github.com/dart-lang/sdk/issues/44569

Change-Id: I0b5d237f532ab99c112247e9f24392ef317575dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177222
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-12-30 04:39:25 +00:00
pq 03adde5555 quick fix for invalid null-aware ops after a short-circuit 
Fixes: https://github.com/dart-lang/sdk/issues/41511

Change-Id: I4ebfb6aa896a4e8aaf1f6ed210bc86d811a81702
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-12-23 18:11:11 +00:00
pq 35f9425b6d add fix to make assigned final field late 
Fixes: https://github.com/dart-lang/sdk/issues/44440

Change-Id: Iafdd448c5cae0c72e24b39e7e65a91c1810a0c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-12-22 23:58:41 +00:00
Danny Tuppeny 0d878d1d97 [Analyzer] Ensure semantic tokens are sorted correctly before handling overlaps 
Change-Id: I10a236d7c911867c654939d25c02208fa465ea3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176524
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-22 18:15:41 +00:00
pq eaa0f5d19a quickfix to remove deprecated lints from options files 
Change-Id: I0440450257416570feb68e71e78f1f7f4e042287
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176700
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-12-21 19:25:59 +00:00
Danny Tuppeny 3ee3dac08e [Analyzer] Disable LSP semantic tokens 
There's a race condition in semantic tokens that's causing errors that I've yet to track down or reproduce in a test (though can relatively easily reproduce manually).

Change-Id: Icf65ec52e0307ed71f10c74ded120076e4fcd90c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176525
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-18 20:29:15 +00:00
Michal Terepeta ba0a7c5df7 Disable watching for files generated by Bazel 
Apparently this is causing some performance issues, so we might
want to disable this until we can benchmark and optimize it.

Bug: 44484
Change-Id: I8a661b128cbc8fdd425e4d3516a7ac132e511a99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176521
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2020-12-18 08:26:55 +00:00
Danny Tuppeny 5f28cb13f8 [Analyzer] Use "variable" LSP semantic token for field declaration/references 
Change-Id: I4daef717459cc2d91c642b024f564368576f5512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-17 16:59:33 +00:00
Devon Carew 543364df65 Fix the user text for a quick fix. 
Change-Id: Ie78c78b8c128e10ad6085a36f751e4f0b0656438
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-12-16 19:08:02 +00:00
Danny Tuppeny eb409d97bc [Analyzer] Fix an issue where LSP semantic tokens may be missing for some "import" keywords 
Change-Id: Idf5a60b1d41e12d07549865ad6d6bd26ef0ac6e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176446
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-16 18:23:07 +00:00
Brian Wilkerson 3ecab274a4 Expressions that cannot be evaluated should not throw an exception 
This also adds a test case for another bug, which I'll attempt to fix
after this has landed.

Change-Id: I00f6bc707767777525a89ba8ea9fdf8a6f41a0ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176480
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-16 18:11:12 +00:00
Danny Tuppeny 222f3dcd11 [Analyzer] Prevent two sets of parens being inserted for setState() when LSP's completeFunctionCalls is enabled 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3006.

Change-Id: Idc1ac2b41208a13a887e0c0ece98a255114fc634
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-15 19:21:31 +00:00
Konstantin Shcheglov c860af98d8 Remove ClassElementImpl.collectAllSupertypes() 
We have API for this now.

Change-Id: I89c68cae5e4205f7ac1200041cb72f5b6842305e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-15 07:13:30 +00:00
Brian Wilkerson edb381a527 Fix path completion on under Windows 
Change-Id: Ic33e65fd5174cf19e27b41196161f9c7fd06ff3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176066
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-15 00:34:09 +00:00
Konstantin Shcheglov 9717c775e4 Deprecate FunctionTypeAliasElement.function 
Change-Id: Id629afa92c6681ba796aed75b24c4251fd86810f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176140
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-14 22:26:29 +00:00
Danny Tuppeny 26cee4e0db [Analyzer] Produce string highlight tokens for literal string parts of interpolated strings 
Change-Id: Idadfc90ba34d4a533964b34799585d7254b16830
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176121
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-14 20:37:29 +00:00
Danny Tuppeny cb2ede57b7 [Analyzer] Add LSP support for textDocument/semanticTokens/full 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2202 + many more.

Change-Id: Ia2e8ec2415836a77618821144699971e97b4fc5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175722
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-14 20:37:29 +00:00
Danny Tuppeny 069a2f83d9 [Analyzer] Add support to LSP server for updating imports on file renames 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2761.

Change-Id: I9e4779760a02bc91850c45aa0d0bf261ef922222
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175485
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-14 17:06:03 +00:00
Danny Tuppeny 5d2905e8cb [Analyzer] Add a setting to enable sending TODOs as LSP diagnostics 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3010.

Change-Id: Id504f46a0c0ff6dc6eb4005e3779714081df8fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176085
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-14 17:05:24 +00:00
Danny Tuppeny f6c6ea5373 [Analyzer] Update to final published version of v3.16.0 of LSP spec 
Change-Id: I290b462352fc72b58b2f8f5f8b85464257017b7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176080
Auto-Submit: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-14 16:03:59 +00:00
Brian Wilkerson 9dad1876d3 Suggest hidden files and folders when completing in YAML files 
Change-Id: Icea426117c1d8c3bd014511396cebd301586baaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-13 23:56:47 +00:00
Konstantin Shcheglov 999321ede2 Extract TestInstrumentationService into a library, more tests. 
R=brianwilkerson@google.com

Change-Id: I563304d4d278fa0755387122a7078b8f020c2d0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175862
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-11 19:49:29 +00:00
Konstantin Shcheglov b16c212776 Fix ConvertQuotes and ConvertToMutilineString when unterminated string. 
I finally understood how to reproduce it :-)

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Id75fa54057f7db49e8d3f8f3b6f2f25785ed4977
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175822
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-11 02:36:08 +00:00
Konstantin Shcheglov d54acb59ae Fix RemoveComparison for empty block in IfStatement, some refactoring. 
A couple of new tests.

Change-Id: Iab8a6df102c8dcaa8faafec715f1556424e3b571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-11 00:45:28 +00:00
Sam Rawlins 69cb9f7a67 Analyzer: Remove legacy parser (replaced by Fasta). 
* Replace most of the implementation of Parser with the implementation
  found in _Parser2, which uses Fasta.
* Rework Parser constructor to do exactly what the previous factory
  constructor + _Parser2 constructor did.
* Remove _Parser2 and ParserAdapter.
* Remove `useFasta` argument in several places.
* Delete tests in parser_test.dart which only used the legacy parser.
* Move ParserProxy from parser_fasta_test.dart to parser_test.dart
* Remove ~240 cases of dead code like `if (useFasta)` and `useFasta ?`
  in tests.

Change-Id: Iea29a10ff83103293902336490fbc9cd46cd20ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175560
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-10 23:47:48 +00:00
Brian Wilkerson 5d99e7cdfe Support using data-driven fixes when using deprecated APIs from the same package as the use 
Change-Id: I0f12505bf2a772cdb9b187c170bbfa44b2ff85cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175743
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-10 18:18:52 +00:00
Danny Tuppeny c9f6e51315 [Analyzer] Update to include final LSP v3.16 changes 
Change-Id: Icb35324308485e3a40abfcee8550ba10538a935e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-10 18:10:47 +00:00
pq 690ae7a7ba add null check quickfix for index expressions 
Fixes: https://github.com/dart-lang/sdk/issues/44441

Change-Id: I7cca517fa2864e6b09dd9d7971447420e59e221e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-12-10 15:44:47 +00:00
Danny Tuppeny 4525525a9d [Analyzer] Handle parsing v3.16 LSP Spec 
Change-Id: I6afd5c32673ba580cdf6691bdfa521766f65c3b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158392
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-09 20:29:30 +00:00
Michal Terepeta 97093b2594 Watch Bazel generated files for changes 
This introduces a way to see what paths have been searched for by
the `BazelWorkspace` and adds a polling-based watcher to detect
when files generated by Bazel appear (or have changed). This allows
us to re-analyze things automatically instead of, e.g., restarting
the server.

Change-Id: I60eae29b0e4fcc3a91d8d2275c6898e45548ea03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168649
Commit-Queue: Michal Terepeta <michalt@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-12-09 09:39:19 +00:00
Danny Tuppeny 0fa6674ea9 [Analyzer] Include required-named params in defaultArgumentListString and LSP complete-function-calls 
Change-Id: I8b4c09305df6e868e7447c538be4a3b540aa7e57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174802
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-08 20:47:04 +00:00
Konstantin Shcheglov 993bd8a380 Fix NPE in AddAsync when implicit return type. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Id684a3c5d93aa353b0ad5a89407378bd3c9522e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175328
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 17:43:04 +00:00
Konstantin Shcheglov b3bcf36a8e Fix for crash in EncapsulateField when in extension. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ie8b06ad2eea1c4976ca119a39c086cd15faab013
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175330
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 17:25:40 +00:00