dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6105 Commits

Author SHA1 Message Date
Danny Tuppeny f03ec46eff [analyzer] Detect completion inside comments at the end of file 
Fixes https://github.com/dart-lang/sdk/issues/33183.
Fixes https://github.com/Dart-Code/Dart-Code/issues/3170.

Change-Id: Ia8c76ace89e424f5cca08120282e886e7567ee2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-02 16:25:04 +00:00
Danny Tuppeny f77eba360e [analyzer] Generate completion text more suited to replacements for LSP 
Change-Id: Id8c20ea7e1c32759673c32c9f4b363345bc23116
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188290
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-02 16:14:12 +00:00
Danny Tuppeny ff61ff7d33 [analyzer] Call toJson() on items in Lists when generating LSP json 
Change-Id: I9f5876dc577499ae609079eaecae6a3eb47535d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188288
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-02 15:24:38 +00:00
Brian Wilkerson 4643444205 Add map/reduce functionality to the completion metrics tool 
Change-Id: I69d206fa7d817b022eedac01a13355a14a09a650
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-26 20:45:17 +00:00
Konstantin Shcheglov bf4a65cb62 Cache resolved files in FileResolver. 
Change-Id: I3df19bb31e962ff6666e3c677d696315f8e8d8e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187720
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 23:46:24 +00:00
Konstantin Shcheglov c33616c713 Remove isContainedInDotFolder(), switch to isAnalyzed(). 
Change-Id: I037947c253afe8d676bc2bf44e4b0eeaadc56e19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 23:19:14 +00:00
Konstantin Shcheglov 0e9f75c14c Fix for NPE in ReplaceIfElseWithConditional. 
Saw it in crashes and was able to reproduce.

Change-Id: I6cb79b51319730636f1a0200ea0ba71e2ece015a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 21:10:27 +00:00
Konstantin Shcheglov f4bf9288cf Rename newAnalysisOptionsYamlFile() and newDotPackagesFile() 
Change-Id: I1d11d5c8a7e7fc4f965cd797471dc84a5572fe9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 20:12:46 +00:00
Konstantin Shcheglov 34bec2f1a5 Deprecate AnalysisDriver.contextRoot 
Change-Id: I2dfb7f2f751e3c3ba7cdc11c94b9dfa5ddd35670
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 19:35:11 +00:00
Danny Tuppeny 85aecd53f4 [analyzer] Seed overlay modification stamp with DateTime.now().millisecondsSinceEpoch 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3160.

Change-Id: If57d37796dc36c06ec4bbd986719cecbbc1a98a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-25 18:02:36 +00:00
pq ecaabe591b prefer constants for fix kind priorities 
Change-Id: I665bd9bab8e2ea54a3b1bf295135f4024f1b2440
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-02-25 17:33:36 +00:00
Danny Tuppeny 526e191a57 [analyzer] Return isQualified=true for the name of a constructor 
Fixes https://github.com/dart-lang/sdk/issues/45105.

Change-Id: Ic7878bd14e6b9b9ee522b5b7d91f25137ab6f31f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-25 17:00:41 +00:00
Konstantin Shcheglov b3f5c31465 Analyze AndroidManifest.xml files in ContextRoot.analyzedFiles() 
Change-Id: I30ceb3c714ffaa498b4f348ed5d3fdc62915feb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 16:52:36 +00:00
Konstantin Shcheglov a629b48fdc Remove file name constants from AnalysisEngine. 
Change-Id: I3457973212e704a0fedee20db17956c017ec91ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 05:52:56 +00:00
Konstantin Shcheglov 2c3d4c9d88 Use InstrumentationService instance where available. 
Change-Id: I615faf1e74fdd5134a35f0d562c289d8f2d21a1c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 05:52:35 +00:00
pq 94f6b6ec94 migrate multi-fixes to unique fix kinds 
Change-Id: If28b89ebeab3be8120cb9189d7c54eb1393beb6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186741
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-25 00:24:35 +00:00
Brian Wilkerson 71cd2eab85 Add support to the relevance table generator to generate multiple tables for comparison purposes 
Change-Id: Iba8dc640540b1689d619a928cc7075c4b17555ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-24 21:36:34 +00:00
Konstantin Shcheglov 722fb9fbc6 Use file_paths.isAndroidManifestXml() instead of 'manifest.xml' 
I am a bit surprised that there are no failing tests before or after.

Change-Id: Ie2f94ba6437f95a95c74ec301f2bcbad4ebd9b49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187100
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-24 21:13:14 +00:00
Konstantin Shcheglov c9332fb487 Renames for check/analyze non-Dart files. 
Change-Id: I31d9b19429f73e4c9c40f95cf5e7a55ac4a5a09a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-24 21:10:06 +00:00
Konstantin Shcheglov fd81b73e67 Replace AnalysisEngine.isDartFileName() with file_paths.isDart() 
Change-Id: Icf5d524945ffdb7087b96555968804946b4e5af4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-24 21:03:24 +00:00
Konstantin Shcheglov 7b68624218 Remove unused analyzedFilesGlobs in AbstractAnalysisServer. 
Change-Id: I46f0b7c1b426d3c530d568df3cb04c0ad194d186
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186802
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-24 04:14:37 +00:00
Konstantin Shcheglov c3a41ab771 Remove ContextManagerImpl.createSourceInContext() 
Change-Id: I58bfa95d0cbddb96f79043b854f398602420268d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186801
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-02-24 04:11:07 +00:00
Konstantin Shcheglov 5036e3ad2c Ensure that _getSdkPath() returns absolute normalized path. 
Change-Id: I92dc53e6248e36c2025cd848057eb732b0ae69be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186744
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-24 00:47:37 +00:00
Brian Wilkerson 2c982b0c1f Enhance the command-line relevance table generator tool to support a map-reduce style of table generation 
Change-Id: Ie0e26094b4cd6acaf864556d04d3de0415683cdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186501
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-23 17:46:21 +00:00
Danny Tuppeny c4edcc4cfa [analyzer] Support separate insert/replace ranges for completions 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2998.

Change-Id: I8e989932c16dc97f704c79c06374c8d1d1881f7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-23 17:43:11 +00:00
Konstantin Shcheglov 917d61b92e Add only dart files to drivers. 
Change-Id: I345d3481a9107b6eec1e7e8845e8181f9d12a1ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186500
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-23 04:24:59 +00:00
Konstantin Shcheglov 8194c530e8 Handle ChangeType.REMOVE for any file, flush it. 
Change-Id: Idb61bcb96ad5b6d29d46063fe46a9ae7413679a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-22 22:05:20 +00:00
Sam Rawlins 9a673e4ae7 analysis_server: Remove unused dart: import 
A bug in the analyzer is causing it to not report this unused import currently.
This PR is part of a cleanup to allow fixing the bug.

Bug: https://github.com/dart-lang/sdk/issues/45028
Change-Id: I2306306e1e51d141c6ba8aa29b7b655fac7b36fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186384
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-02-22 22:05:00 +00:00
Konstantin Shcheglov f1094d5c3a Use newPubspecYamlFile() to create pubspec.yaml files 
Change-Id: I181a3f3f14810019731201bf43e27befa7bc5481
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-22 21:32:00 +00:00
Konstantin Shcheglov 64757ef097 AbstractAnalysisServer.notificationManager is always provided. 
Change-Id: Ic99fac81c734ec5d743e77b717e11753b6890b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186382
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-22 20:50:29 +00:00
Konstantin Shcheglov 3f54b435e1 For for NPE in isInAnalysisRoot when the collection is not create yet. 
Change-Id: Iee6142397e490fba84b7c56b976a2c75f4fb1648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-22 20:35:34 +00:00
Konstantin Shcheglov 41dd9e5bea Replace ContextManagerCallbacks.removeContext() with afterContextsDestroyed() 
Change-Id: Ibd3dead3e2f117d29f336cd289b1483bcbe0e092
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186380
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-22 20:28:40 +00:00
Danny Tuppeny 8f9cdb3b2f [analyzer] Remove LSP fix-all-in-file functionality 
To be replaced by new functionality that works with LSP + original protocol.

Change-Id: I59627e2c4e99b0a6aa0eb850168c870e5390e03b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-22 19:53:39 +00:00
Brian Wilkerson 191e95fa3e Fix the replace_conditional_with_if_else assist in null safe libraries (issue 45030) 
Bug: 45030
Change-Id: I2a0946a490a1e69cab7d1bbac6c9efdabd8926c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-22 18:20:59 +00:00
Konstantin Shcheglov a68d60090e Add util/file_paths.dart and use in ContextManagerImpl 
Change-Id: Ibbf8ec0b0809fa17e073df6b61065f7e6278c7d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186022
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-02-20 20:33:36 +00:00
Parker Lougheed 5ef1dcdcab [Analysis Server] Update font inclusions for API doc 
Some of the weights we used were missing causing blurry text. I've also switched from Source Code Pro to Roboto Mono to be consistent with other Dart websites.

While not related I also updated the semver link to https.

Change-Id: Ifc4a10a05d795134caade2081045517426c21fc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-20 16:48:56 +00:00
Konstantin Shcheglov 8d0a5dd6fa Fix AnalysisDomainTest on Windows. 
TBR

Change-Id: I4920ef5bfcb60d652b286c04c58b4c30de13a2a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186041
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-20 01:24:25 +00:00
Konstantin Shcheglov c2195fcc14 Rewrite to use AnalysisContextCollection in analysis_server. 
Change-Id: Iee6b392711790d17c25a3c18fa1e9bdfe8b8cc4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-19 23:01:25 +00:00
Konstantin Shcheglov e4643d5809 Deprecate ElementVisitor.visitFunctionTypeAliasElement() 
Change-Id: Ib5d364b77af7974d757626a0719604fa7ec1fec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-19 22:21:15 +00:00
Keerti Parthasarathy dcf6b12270 Add CiderAssistComputer to compute assists for Cider. 
Change-Id: I6087ccabda0c0749d0027b40ecad5050a2eb0431
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185492
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-02-19 15:08:34 +00:00
Konstantin Shcheglov 2e40e359e2 getElementDeclaration() can return null. 
Change-Id: I2c8331d22191587991cd1782525d84f5044a79b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-19 08:21:37 +00:00
Konstantin Shcheglov 9bfd416c45 Add ContextRoot.workspace, deprecated AnalysisContext.workspace, support included excludes in ContextLocatorImpl 
Change-Id: Iecd324ad45b926ca6b0626f8bea4f479409154e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185499
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-19 02:15:40 +00:00
Konstantin Shcheglov 9a30392588 Require Workspace for ContextBuilder.getAnalysisOption() and createSourceFactory() 
Ideally we want to create Workspace only once, and pass it around.
I was not able to do this yet, because DAS ContextManager kind of
dynamically updates contexts and drivers. I expect to avoid this issue
by switching DAS soon to AnalysisContextCollection.

I will follow with a bigger CL that keeps Workspace in ContextRoot.

Change-Id: I3050ba65400e0e5aa73e6d5f8beae821db10a6ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185498
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-19 00:54:30 +00:00
Brian Wilkerson bfe3a31cd4 Add a failing test for issue 45030 
Change-Id: I59e9db21ef97286c137e635b1c8bdbd2991b98a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185493
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-18 23:29:50 +00:00
Danny Tuppeny a6c14e8848 [analyzer] Insert imports after annotation of first import directive in file 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3104.

Change-Id: Ic91727c11cda1436662a52b737094ea87927047c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-16 21:32:50 +00:00
pq 4302f058dd disable legacy fix-all fix creation 
Tests to be re-enabled when we wire-up `FixInFileProcessor`.  (Or maybe we want a different approach to testing fix all fixes entirely?  TBD.)

See: https://github.com/dart-lang/sdk/issues/45026

Change-Id: I66f83d06801a71143dcc770cc38d9e2f86782264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185180
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-16 20:50:20 +00:00
Danny Tuppeny c8c49c7cc8 [analyzer] Handle creating new files from code actions 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3141.

Change-Id: I44d7f20962512988ff1d54c7b38b6a144f973a58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-16 18:54:39 +00:00
Brian Wilkerson 77da201b19 Add a fix for unnecessary_nullable_for_final_variable_declarations 
Change-Id: Ibd6570c05f3a289fba72c42f3fc30e88649a9004
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185000
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-15 16:26:39 +00:00
Brian Wilkerson e6b5d2c7c0 Add the fix data file to analyzableFilePatterns 
Devon noticed the other day that this was missing. I was curious so I
commented out all of the non-Dart file patterns and ran the tests. There
were no failures. There were failures when I also commented out the
file pattern for Dart files, so that much is being used. My guess is
that it would be better to remove the seemingly unused patterns, but
then I have to ask whether we shouldn't just remove this field and
replace uses by a check that the name ends in '.dart'. Let me know what
you think.

Change-Id: Icda44a6fa532989f86cdb52acb3bd0f7a5b28e20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-13 00:40:29 +00:00
Keerti Parthasarathy 5a97dc8fc2 Add lineinfo to CiderErrorFixes 
Change-Id: Ic2b82c27a98794a456a43a129ccfc9bd1fc0c07a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184841
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2021-02-13 00:04:11 +00:00