dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6105 Commits

Author SHA1 Message Date
Paul Berry 244b4247e9 Migration: better description text for edges. 
Change-Id: I58651c927a741721283c3c4c951673a86aa7a1b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140883
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-25 19:38:34 +00:00
Brian Wilkerson 9e4eb054a4 Add new relevance scores for NamedConstructorContributor 
Change-Id: I6e5fd10edf74b44afb766acd675dffd5ef0cb25f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140906
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-25 17:47:42 +00:00
Brian Wilkerson 2323087237 Fix the comment for the LabelContributor 
Change-Id: I8ac9f343608b04b7fe1ec59a9d151dd6dd81e926
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140902
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-25 16:39:12 +00:00
Sam Rawlins 1aab8bccd0 Add a dev mode to Migrator preview site compiler 
Change-Id: I355ca9f89371e497370664ed8733a581c5958ae5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140763
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-25 14:49:32 +00:00
Lasse R.H. Nielsen 8760283247 New implementation of runZoned. 
A combination of `runZoned` and `runZonedGuarded` where only the latter allows an `onError` parameter,
and only that has a nullable return type.

Retains the `onError` parameter on `runZoned` for now because it's too breaking to remove it until packages have been migrated off of it.
It will be removed in a follow-up CL.

Change-Id: If0e86c8d14e13fa089c66f4af975aeacb2616cf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137302
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-03-25 00:24:33 +00:00
Brian Wilkerson ef56e3a3fc Update relevance of labels 
Change-Id: Id862fa2da7969a9dcdb1854f6ffe38a4c122a024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140778
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-24 22:46:07 +00:00
Brian Wilkerson 7e0190a6d7 Add new relevance values for field formal parameter suggestions 
Also updated a comment that I missed from the last CL.

Change-Id: Ibfcce19998532c672b9990308cd7b03fd42d14cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140772
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-24 20:46:27 +00:00
Jaime Wren 81894b958f Fix another case of the form described in https://github.com/dart-lang/sdk/issues/41039, this fixes the FunctionDeclaration case. 
Bug: https://github.com/dart-lang/sdk/issues/41039
Change-Id: I03df7f8d92b1e7754410dc88e1c09ad83476960e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140769
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-24 19:11:15 +00:00
Brian Wilkerson 2d0fed35bb Update the ArgListContributor to have new relevance scores 
This also includes a new metric computation showing how often function
typed parameters have closures as arguments.

Change-Id: I8999cc3935bcc7514ebba90a8a4d246b2f236c42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140702
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-03-24 17:00:55 +00:00
Mike Fairhurst 799560bff7 [nnbd_migration] Remove language version comments during migrate 
Bug: 41095
Change-Id: I3262d6da485d78fee1e2dfe4ac22692c5e4b6daf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140369
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-24 16:44:05 +00:00
Sam Rawlins 5a1a83275c Migrator: Scroll the Edit Details panel into view when refreshing the contents 
Change-Id: I577d165189c0a790774f2ac7c44fe9c70367bfbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140370
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-24 14:12:49 +00:00
Devon Carew 1e45051341 [analyzer] initial implementation of SDK, file based configuration of the analysis server 
Change-Id: Iff3808fb073b062fa566993e7f05e2669a5fde7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140003
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-24 14:07:59 +00:00
Erik Ernst e3af7e724f Update usage of int/String fromEnvironment 
Breaking change 40678 requires the constructors int.fromEnvironment and
String.fromEnvironment to get new default values for the named
parameter `defaultValue`. This CL changes usages of these constructors
such that they do not depend on the default value, such that it
becomes a non-breaking change for code in the SDK repo to perform the
change in sdk and in sdk_nnbd.

Change-Id: I82af0e1f92d6cd3618b65c0c50d754ae8c39eb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140284
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-03-24 11:19:14 +00:00
Konstantin Shcheglov 6b7d7aa2c1 Type Function should be excluded from extended / implemented / mixed types. 
Change-Id: If225400a976657f042856bfdaf95b285f98cebb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-23 20:35:37 +00:00
Jaime Wren 6219daa274 Preventatively check for null from the return of AstNode.findPrevious(..). This was the only instance of a missing null check in analyzer, analyzer_plugin, analysis_server and analyzer_cli. 
Context: https://dart-review.googlesource.com/c/sdk/+/140245 (cases in code completion)
Bug: https://github.com/dart-lang/sdk/issues/38681
Change-Id: I951811034976041c425e74a52f33d27f13781015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140253
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
 2020-03-23 18:08:16 +00:00
Jaime Wren 6f76f194b1 Fix the common case of https://github.com/dart-lang/sdk/issues/41039, around MethodDeclarations 
Code completion will now include void, dynamic and other class declaration keywords in the return type location, in the following snippet: '@override void someMethod(...) {}'

This is relatively common, this happens 103 times in the collection package.

Bug: https://github.com/dart-lang/sdk/issues/41039
Change-Id: I28129f2d735d2ff7d0a0e65194b7963c74b01c51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-23 18:03:44 +00:00
Jaime Wren dd95365f76 Optimization for the MeanReciprocalRankComputer.  This change doesn't have the object hold onto the list of ranks for the entire duration of a run, but has a running sum instead (similar to ArithmeticMeanComputer). 
This would have been an over-optimization originally, but at this point, we have 10 of these computer objects in completion_metrics.dart, and we are running this algorithm with up to 1.2 million ranks.

(Assuming that an int takes 4 bytes which I believe is true...) On a recent run of Brians, 29.4 MB of data was the running total of all the ranks.  With this change, the same data will be stored with 10 doubles and 10 ints.

Change-Id: If97ca18e78782c02a3ca0a3ed9d6a9725f5a05ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-21 19:50:36 +00:00
Sam Rawlins 0fdc2816c0 Migrator: Improve scrolling behavior for elements near top or bottom 
Change-Id: I24f951d6e16b8175e15af1bff32ed0d7d58a39b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140367
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-20 23:17:15 +00:00
Sam Rawlins b6ef199bc0 Migrator: fix test to assert on information region when not making a parameter nullable 
Change-Id: I1df34c06ec0f6ffac29fcef873ab7a83e7636044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140249
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-20 18:30:28 +00:00
Jaime Wren 6238c6c0f9 Add missing null checks for return values from AstNode.findPrevious(..) 
The documentation on [findPrevious] reads: "Return the token before [target] or `null` if it cannot be found."

Bug: https://github.com/dart-lang/sdk/issues/38681
Change-Id: I3f9d0418e7ea4efa5190da895a3932bf91f160d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140245
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-03-20 17:52:12 +00:00
pq a3499f0849 quickfix for prefer_const_constructors_in_immutables 
Fixes: https://github.com/dart-lang/sdk/issues/41097

Change-Id: I2ff001437ff4a4174bc7ba10b9f6ea5fab89317e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-03-20 17:04:29 +00:00
Jens Johansen 71e05a8d37 [analyzer] Make setters work in 'Add explicit 'show' combinator' 
Fixes #41069

Change-Id: I12586b761b92b25be592bb61b4df11a0f1ebbfe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-20 08:19:40 +00:00
Devon Carew 3f8366363b [nnbd migration] move the docs for the NNBD migration tool 
Change-Id: I932da23be10839b5bde6034f120763c54f63889f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140102
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-03-19 23:12:24 +00:00
Brian Wilkerson a5c2d2aa71 Add new relevance support to the OverrideContributor 
I couldn't think of any useful features to use when ranking overrides. I
briefly considered `deprecated`, but even deprecated members might need
to be overridden until all implementation of the member can be deleted.

Change-Id: I994d4177b1111ebdf44a223f975422779c5a8ae8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140005
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 22:48:39 +00:00
Brian Wilkerson 63738baa4b Add relevance support to InheritedReferenceContributor 
Change-Id: Ib5d518034a766de369da3b5bad1bc0ce1cb8cda4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140145
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 20:56:58 +00:00
Brian Wilkerson ce67d6ae27 Consolidate relevance tests into a single directory 
Change-Id: Iee3a3553b17d2e8b3b6f479159e6fe560e44192f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140120
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 20:51:38 +00:00
Sam Rawlins a225178919 Trim not useful bottoms off of the non/nullability stack traces 
Change-Id: I2f7bfab13fd3d70c5cbdbb10ce14a8a91f8c7a60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140000
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-19 18:13:33 +00:00
Brian Wilkerson dcdde433b6 Use the deprecated feature for static members 
Change-Id: I718a30d9c392ebae2fe611b402c13cdb60a90825
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140080
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 16:09:59 +00:00
Brian Wilkerson 2a2855c781 Perform new relevance computations for extension members 
Sorry for the size of the change.

This started out looking like a fairly simple task of repeating the work
done for type mambers, but it was too similar so I ended up doing some
refactoring in order to share the code.

Along the way I realized that we didn't yet have a feature for demoting
deprecated members, so I added it.

Then I discovered some more places where the old and new logic were
getting intertwined, so I straightened that out as well.

Change-Id: Ic24babd30bbbeeae9709a8019642e497a2ebb65d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139949
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 13:34:19 +00:00
Paul Berry 75a720f2fb Migration: in preview tool, links in edit details should not clear edit details 
Change-Id: I30336e93b9d3d579d1ef8c91d3a21d68b0e4aeb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139946
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-18 21:40:02 +00:00
Paul Berry 3b0b0eb6dd Migration: reorder data in "Edit Details" box 
This CL moves the "edit rationale" section down to the bottom, and
marks it as "experimental", since it doesn't seem to give as useful
information as the traces.

Change-Id: I5c45c31d9cfcee89bf03b1ef8803f4a59ac180e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139945
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-18 21:24:32 +00:00
Paul Berry 40976c6000 Migration: remove "Nullability trace for" text from preview tool. 
It was redundant with the text in the trace description.

Change-Id: I7970cede15fe620440e3a05adb987ea451ac9f16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139943
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-18 21:18:22 +00:00
Paul Berry 096bf5769d Migration: add "why not nullable" traces to preview tool. 
Change-Id: If945d32f33124e5e85429bd76c1db14167c0024e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139960
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-18 21:18:22 +00:00
Paul Berry 41b67a9b52 Migration: add grayed-out spaces to indicate types not being made nullable. 
Change-Id: I4fa076693c25cf9466d33332030df3983043ffd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139940
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-18 21:18:22 +00:00
Brian Wilkerson 49c3fd32da Measure how often context type information is available 
Change-Id: I4dc3fea554ec16665e7ca5e4cfb1e577403a8ec9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139861
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 23:28:55 +00:00
Brian Wilkerson f617f92c15 Capture the syntactic metrics removed from relevance-metrics 
Change-Id: I89f7112ad31f41b0b6bc406156f4371fa373d62c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139842
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:35:55 +00:00
Brian Wilkerson 23abbd30b8 Set a default relevance for cases where none of the features apply 
Change-Id: I7fd837349965ce7710fd99daacd691b30bf25100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139841
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:27:30 +00:00
Brian Wilkerson 169b88654d Split out metrics computations for static members 
Also did a little cleanup and sorted the file.

Change-Id: I7bb288345abf851dd88d6f7cf28e4d49ade75ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139829
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:23:27 +00:00
Brian Wilkerson 486467c02d Bulk sort of a subset of the files in analysis_server 
Change-Id: Id811d37ad565c6f3c0ed508ae2b42e22469cbd3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:13:14 +00:00
Brian Wilkerson 8c07071afb Use context type in the static member contributor 
I couldn't think of any other features related to static members. Please
let me know if you can think of any.

I need to modify the metrics utility to be able to differentiate between
static and instance member references in order to measure the impact of
this approach. I'll look into doing that today. I suspect that we'll
eventually need it to split out results in many more ways as well.

Also updated some comments in an attempt to make it easier in the future
to determine which contributor to look at for bug fixes or enhancements.

Change-Id: Ieef62c6189bbfbd35283abdf35b8cbdd17746ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139820
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 17:27:46 +00:00
Paul Berry d9ce4d57aa Migration: create data structures for the navigation tree view. 
Change-Id: I482b07d3ae2025cf3a9375a02ddaa509beabc2de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139780
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-17 17:19:41 +00:00
Paul Berry 87cc6c76ca Sort declarations in navigation_tree_renderer.dart 
Change-Id: I3689bc8e6079252cead246bfd0a8402b8f60da1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 17:19:41 +00:00
Paul Berry 2ce64e4a7e Migration: create data structures for file details. 
Change-Id: Ibb909795431b33f826e52c39cd7108cc3ec7f204
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139684
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-17 00:07:41 +00:00
Jaime Wren 4590cd86c1 Add some missing tests for the new class ArithmeticMeanComputer in pkg/analysis_server/tool/completion_metrics/completion_metrics.dart 
Change-Id: Icff02abe7912e7d9b36a63181aa0a2f84b78aab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139742
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 22:11:41 +00:00
Jaime Wren 810d85d4cf Measure and report the average number of milliseconds it takes per code completions. 
Tests to come for the new class.

Change-Id: I387ec41966e8db674c0be26124a9dcb8abeeb30a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-16 19:58:20 +00:00
pq 0e0d4fb76b linter 0.1.113 
Change-Id: I75cc9478171de15df24bc5addfa0aca4dcf7e97a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139660
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 19:48:00 +00:00
Brian Wilkerson 90e32fe161 Disable other sorting when using the new relevance computation 
This actually makes the scores slightly worse, but I think it's important
that we understand the quality of the scores without other sorting. The
scores are still better than with the old computation.

Change-Id: I514aa35029b600b9ab87bf531064f1e89b02774a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139682
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 18:36:03 +00:00
Janice Collins 34fee361b6 Add sanity checks for NNBD state in migration. 
Also adds some ability for the migration tool to abort itself on
a few known-fatal errors and armor-plates dartdev tests against
CWD problems.

Bug: https://github.com/dart-lang/sdk/issues/40329
Change-Id: I1cfa2c9dcc7815eed075ecb38c63a74c75889002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139282
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2020-03-16 18:27:58 +00:00
Mike Fairhurst 1ec961a7f9 [nnbd_migration] Reload changed paths on rerun to remove hack. 
Fixes https://github.com/dart-lang/sdk/issues/41025

Change-Id: I40fc3aa3438bdcecd595768d8b34dbe864b2a5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139407
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 18:14:48 +00:00
Konstantin Shcheglov 3237380259 Fix for creating a field when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I90b8031a805ba0cb51e7ccb8c2477d4f0d0ac8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 15:52:08 +00:00