dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6105 Commits

Author SHA1 Message Date
Brian Wilkerson 4e9ffc5a0d Remove the experimental flag from closing labels 
I think it's safe to remove the experimental status at this point.

Change-Id: I3a992e7134633d1e9de0bba0f1a3d2ff357fd8b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142884
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-09 16:51:19 +00:00
Jaime Wren 489d7b1695 Follow up on https://dart-review.googlesource.com/c/sdk/+/142705 to fix the assertion in the new completions in FieldDeclarations 
Change-Id: Id50663401c5dff67cb69fd30aece229f5c1f6617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142883
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-08 19:47:24 +00:00
Brian Wilkerson c9888ad58a Update code_metrics to support running it over a corpus 
Change-Id: I52eaf18914dd1ac1743f3c1830fdc27f607de9f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142881
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-08 16:22:33 +00:00
Jaime Wren eddc9271ab Suggest type names before names in FieldDeclarations, even when they are documented with dartdoc 
Similar to https://dart-review.googlesource.com/c/sdk/+/142545

Change-Id: I217a17324bcfd9efb7e9bd1a53332fd06d1dc024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142705
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-07 20:53:46 +00:00
Jaime Wren 3f36b1fed1 Modify the completion_metrics.dart file to print the delta between the generated completions with and without useNewRelevance set 
Change-Id: Ic50cc0df6eee02d7aad44ed12766234268899601
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142723
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-07 19:45:56 +00:00
Paul Berry 03c15848d6 Migration: distinguish inserted casts based on whether they are downcasts. 
Inserted casts that aren't downcasts are much less likely to be safe
than inserted downcasts.

Change-Id: I21e0ef54b1c4d58c54724a510b25828fc3018142
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142552
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-04-07 18:35:56 +00:00
Paul Berry 8c982a1373 Migration: categorize changes shown in the preview tool. 
We now sort changes into the following categories (in order):
- Dead code removals
- Casts added
- Null checks added
- Required keywords added
- Types made nullable
- Casts now unnecessary
- Language version comments removed

The reasoning is that this corresponds roughly to how important it is
for a human to inspect each kind of change to make sure it is safe
(dead code removals, for example, are highly likely to indicate an
incorrect migration, where as dropping of unnecessary casts is benign
and almost certainly correct).

Change-Id: I49e3adac3ac98de1a9298f9caadb76c73a9c67d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142542
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-04-07 18:35:56 +00:00
Jaime Wren faab097e01 Suggest type names before names in TopLevelVariableDeclarations, even when they are documented with dartdoc. 
The test test_TopLevelVariableDeclaration_type_after_comment3, fails without the change to optype.dart, the other tests were added simply to have more coverage.

Change-Id: I11512f1a97e72796b6e0656b7555206640e2a8f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142545
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 18:07:16 +00:00
Jaime Wren f0f3199daa Improve the completion of return types on FunctionTypedFormalParameters in FormalParameterLists 
Change-Id: I7c7446f5077844daadf935f5ec0af5b12da739fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142600
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-07 17:51:16 +00:00
Jaime Wren ff6be8d822 Update the completion_metrics.dart algorithm to have 2 overlay options 
1- remove the token to complete, and then attempt the completion
2- remove the token and the rest of the file, and then attempt the completion

The default remains that there is no overlay, the file remains the same and the completion attempt is made at the starting character of the token.

Change-Id: I45f840fef295f2da12f2278445f85152b6c17262
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142521
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-06 20:10:34 +00:00
Mike Fairhurst 7e68842b8e [nnbd_migration] Add sanity checks before writing to disk. 
Change-Id: I09e8f1bebd12747c06538f7cc5976a8601e8cbee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142210
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-06 18:26:14 +00:00
Mike Fairhurst 5d9eb40f20 [nnbd_migration] Change edit links to buttons. 
Change-Id: I7ac1b19021849c93a23aa6ffc739c318b7770664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142214
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-04-06 18:12:34 +00:00
Jaime Wren cedb19f386 Some additional prints in the completion_metrics.dart algorithm 
Change-Id: Ic2f8c266a6c10a128fa06b9ea915e47131428b93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142447
Commit-Queue: Jaime Wren <jwren@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-05 17:50:50 +00:00
Jaime Wren 987ad1d967 Iterating on additional corner cases in the completion metrics algorithm 
Change-Id: Ia497c258f639b808fb3c583870ea19c219ef3c53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-05 17:09:50 +00:00
pq 1e4a56ee72 remove type params for list param args 
Fixes: https://github.com/dart-lang/sdk/issues/41303

Change-Id: I733cef8d7ed94cab931a5e13c1a0a0f7d9f36c66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142420
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-04 02:35:37 +00:00
Jaime Wren 270c9ee459 Bug fix in the completion_metrics.dart visitor by fixing the element kind in the instance creation expressions 
Change-Id: I4b2a07ad4a0975aad8892b65dbad9320db0c809f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142322
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-03 16:44:06 +00:00
Paul Berry 3edfab164f Migration: remove redundancy from NullabilityFixKind enum. 
The values discardCondition, discardElse, discardIf, discardThen, and
removeNullAwareness are all variants of dead code removal and there's
no reason to distinguish them.

Change-Id: Id55035486e07f52e6ef7b5a2485dcb0cadb153e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142060
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-04-03 16:18:51 +00:00
Jaime Wren 8eab8bfc0c Bug fix in inherited_reference_contributor.dart, completions inside of ConstructorDeclarations should include inherited members. 
Change-Id: I9f91087e98c8925b5b733b4b4a0a852f53073b82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142208
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-04-02 22:16:59 +00:00
Brian Wilkerson 1de74f0739 Remove an unnecessary type annotation to satisfy a lint 
Change-Id: I6ca927c2c97235e464b039a3aabad046b79ed5c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142082
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-02 16:15:45 +00:00
Brian Wilkerson 0eadef9d95 Report more development time metrics 
Change-Id: Ibee7131783d847aa95c19c4ef647ccbac5a8611a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142180
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-02 16:09:04 +00:00
Brian Wilkerson b85c68a73c Collect and print information about the worst completion results 
Change-Id: I38e1d2a587f80ed4ee0da75f875b94aff922fe3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142064
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-04-01 21:45:48 +00:00
Konstantin Shcheglov 191be51124 Extract GenericInferrer and type schema. 
Change-Id: Ic306342609911e3e232dbf95f30b60cff94c34be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 20:54:48 +00:00
Jaime Wren a14d41958e Modify the completion_metrics.dart file to ignore named arguments in dynamic or unknown method calls. 
This is a follow up on https://dart-review.googlesource.com/c/sdk/+/140775

Change-Id: Id84271f1bc8559f516c2c4e09c2b66dc10462f3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141915
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-01 18:26:32 +00:00
Paul Berry 278a2db4df Add a --preview-port flag to dart migrate. 
Change-Id: I526a2e40198960e0e3fb3509ed8a84979f520b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141765
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-04-01 12:10:04 +00:00
Paul Berry b7130b0bf7 Migration: improve preview tool display when ! is added due to an explicit hint. 
Change-Id: Ie9b2a6cabaf02c46da2e8b8ac1bffa0e699acc64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141741
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-31 22:04:46 +00:00
Konstantin Shcheglov ca6b0fd0df Fix for crash in WrapInText when the parameter is not InterfaceType. 
There was a crash in the logs.

_TypeError: type 'GenericFunctionTypeElementImpl' is not a subtype of type 'ClassElement'
at WrapInText.compute	(wrap_in_text.dart:26 )
at FixProcessor._addFromProducers.compute	(fix_internal.dart:4506 )
at FixProcessor._addFromProducers	(fix_internal.dart:4520 )
at FixProcessor.compute	(fix_internal.dart:762 )
at DartFixContributor.computeFixes	(fix_internal.dart:82 )


R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I187b3348a212391cc6c64ab2c412653bd2319334
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141820
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-31 15:56:40 +00:00
Konstantin Shcheglov fb4b59e043 Deprecate isProxy / isOrInheritsProxy in ClassElement. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ied4011961d4dece33d527888d274893985d85f93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141767
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 23:27:39 +00:00
Jaime Wren 11d6bc6055 Comment out the currently incomplete available suggestions work to ensure that the output is accurate for non-available suggestions users 
Change-Id: I094392cb81edf5c0c7b11702ba42e5d2c80a1453
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141760
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 22:08:19 +00:00
Mike Fairhurst 0943e6136d [nnbd_migration] Save line number of details to preserve on reload. 
When clicking on a region, store its offset & line in the URL via
`pushState`, so that on reload (after rerun migration or after apply
edit, or just in general) the context isn't lost.

Note that offset is not enough. Basically, every navigable element gets
a class `o$offset`, and if the page is loaded with some offset such
that no element with class `o$offset` exists, it falls back to line
number. And if there were edits mode before the region since reload,
there will only be an element `o$offset` if you are lucky.

Change-Id: Ic5fd83aceb4e8731348e70c039fec2ca2a6ab9e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141465
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-30 21:41:59 +00:00
Brian Wilkerson 93313eb244 Enable omit_loval_variable_types in analysis_server_client 
Change-Id: I21271bfc6b2b7949fcafc5f91f23f8364697bcfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:59:07 +00:00
Brian Wilkerson 8969b1839c Enable omit_local_variable_types in analysis_server 
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:58:44 +00:00
Konstantin Shcheglov 3a0bf3ad36 Fix for creating a setter when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I3c364f01c9cb31166e24f2b28d6a4640fa7d8c93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-28 21:00:23 +00:00
Brian Wilkerson a564026dc7 Remove the need for a --corpus flag from completion_metrics 
Change-Id: Id395b3f4d58a072c435d97920a573379439d8580
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141471
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:50:53 +00:00
Brian Wilkerson 2b4f12f3c5 Remove the need for a --corpus flag from relevance_metrics 
Change-Id: I7dacc57728258a9cbbe481950d618bbe73bfa22f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141470
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:50:44 +00:00
Brian Wilkerson 7e724e70b0 Sort non-generated files in analyis_server and add a test to ensure they stay that way 
Change-Id: I6c7a38cefa69f46737bd50eefe2fbb88c127017b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:12:03 +00:00
Brian Wilkerson 232052da06 New relevance values for UriContributor 
Change-Id: I32a3151cb78a333ef7e23e89f2688acb4c74edb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141480
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-27 22:51:34 +00:00
Brian Wilkerson c3fc96ad62 New relevance values for KeywordContributor 
Change-Id: I851e9fa12bc674b6714089fa2b23443c2e2140d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141463
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-03-27 22:37:59 +00:00
Brian Wilkerson 8a126788fc New relevance values for VariableNameContributor 
Change-Id: Id2670c4ec0860ce246a44dfe2abd8b6dbf987a35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141462
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-27 22:37:51 +00:00
Mike Fairhurst 104bdcd4cc [nnbd_migration] Add confirm dialog to "apply migration" button 
Change-Id: I377caf627725c6f38eeca34001e61ab23323a700
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141029
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2020-03-27 19:50:57 +00:00
Brian Wilkerson 127d84aa56 Update relevance computations in LocalReferenceContributor 
Change-Id: I19baafc28488304d781757c2a2648ec3d3781d15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141361
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-27 18:33:29 +00:00
Brian Wilkerson db91583b38 Update relevance values for LocalLibraryContributor and ImportedReferenceContributor 
Change-Id: I204bd8a95d9697f166e8e0a97d36098fc35c1dc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141206
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-27 18:30:08 +00:00
Mike Fairhurst 62c4b1fb2e [nnbd_migration] Add a "rerun from sources" button. 
Change-Id: I09f1c76cb41549b81218783ec69d190271508ba0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141028
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-27 16:50:12 +00:00
Brian Wilkerson 7d66feb5ff Compute new relevance in LocalConstructorContributor 
Change-Id: Ife24a24829fae36b1caef5ab0a55e4c210a063a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141201
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-26 21:50:29 +00:00
Janice Collins da1d9eb1bd Add a way for analysis_server to open communication via a IsolateChannel. 
The idea is to pass a SendPort as an optional parameter to
ServerStarter.start(), and if present, key server behavior around
behaving well as an isolate.

Bug: https://github.com/dart-lang/sdk/issues/41056
Change-Id: Ifc6ac2fefcf6aae8bce712e470524d1c06fa2ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140373
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-26 21:37:59 +00:00
Sam Rawlins fe6f3eaf9f Migrator: Add an auth token for the preview site 
Fixes #41134

Change-Id: I6d436805d3dfb64cc4d7ddde2b307132fbd1365d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140621
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-26 20:01:56 +00:00
Mike Fairhurst 3095a082cd [analyzer] Add an API to get a language comment token off a unit. 
Change-Id: I377fdc44d5e514d6d9a601b3947c3908e5a4497a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 03:47:57 +00:00
Brian Wilkerson d194838578 Add new relevance scores to LibraryElementSuggestionBuilder, which covers both LibraryMemberContributor and CombinatorContributor 
This should have tests, but I (or someone else) need to do some data
mining to figure out the correct relevance values and hence the correct
ordering to test for.

Change-Id: I7782d7b7e13ff38a785c445cd0d6fc82a388a6aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141000
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-25 22:49:26 +00:00
Brian Wilkerson df5e6c8e5f Compute new relevances in LibraryPrefixConstributor 
Once again, test suggestions are welcome.

Change-Id: I470825a0ef51f555977bdc86192cc38bd718519a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140943
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-25 21:01:16 +00:00
Mike Fairhurst 5f20fe7d83 Revert "Trim not useful bottoms off of the non/nullability stack traces" 
This reverts commit a225178919.

Reason for revert: This seems to remove useful info from the stack trace. Will revert, then hopefully land an improved version.

Original change's description:
> Trim not useful bottoms off of the non/nullability stack traces
> 
> Change-Id: I2f7bfab13fd3d70c5cbdbb10ce14a8a91f8c7a60
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140000
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,mfairhurst@google.com,srawlins@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I9a2fb07e387d57394242b694e27456333f2cf2b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140908
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-25 20:57:36 +00:00
Brian Wilkerson 3abbcd0da9 Attempt to fix windows bot failure 
Change-Id: I6288838fe5dea2cb7b8e0d79ee90d09c91496769
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140901
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-25 20:39:56 +00:00