65a944f78f
Add CiderCompletionComputer.compute2(), tests.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: Ie6acad3873f78060cde85a350ebd48b854ea1314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144345
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-21 23:46:04 +00:00
511baaae48
migrator: Switch help link to the shortened URL
...
Fixes #41488
Change-Id: I272e9dbe32311454767a99d309a694e8d0fc9730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144300
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-21 18:39:34 +00:00
925e3fe782
Migration: detect weak-only code in conditional expressions.
...
This change adds the ability to detect when one branch of a
conditional expression is weak-only due to nullability. For example,
in the following code:
int f(int/*!*/ i) => i == null ? g(null) : i;
int g(int j) => ...;
the call to `g` can only happen in weak checking mode. The migrator
also now understands that j only needs to be nullable if i is
nullable.
Fixes #41555 .
Partially addresses #41551 .
Bug: https://github.com/dart-lang/sdk/issues/41555
Change-Id: I02c9c3072f0104db0f1a5b432fb1f2f8f06d5282
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144120
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-04-20 19:09:32 +00:00
4932348ff3
Expose fix/assist IDs in LSP code actions
...
Change-Id: Ic75fd362f9feada81834a7d36419c27cf316f18d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143814
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-04-20 14:57:26 +00:00
1c12bde2a9
Add a fix to remove invalid question marks
...
Change-Id: I24caf62176e3426dddcae17204a1435f0f7946d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144080
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-20 02:42:25 +00:00
19008faa12
Pass DartDoc directive info to completion manager under LSP (issue 41564)
...
Bug: 41564
Change-Id: Ief7b302161b04e21952e4e77e16315bfbbd1e794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-18 20:09:08 +00:00
232826b6e6
[nnbd_migration] fix #41391 , crash applying migration.
...
This is caused by changes to non-dart code, which does not get a
UnitInfo.
Fixes https://github.com/dart-lang/sdk/issues/41391
Fixed: 41392
Change-Id: I5054c672c0ca87027d66f1304385ea29d3e17d10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144001
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-04-17 22:54:04 +00:00
40661e3bc6
Create the class SuggestionBuilder and pass it to contributors
...
Change-Id: Ia36906d614ced8d8b783a03f86385ebc903375c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143965
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-17 20:48:04 +00:00
3de4d76b4a
[nnbd_migration] Use offsets instead of column numbers in traces
...
Change-Id: I37f44c1a4713106e15b346739354b73592d208d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143721
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-04-17 19:07:44 +00:00
780bea595e
Add CiderCompletionComputer.
...
It encapsulates resolution logic, creating completion request and
manager, caching and reusing suggestions from imported libraries.
In the spirit of keeping the Cider part thin.
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I95f13a98d776eb418b40ea2fae421654eef7602d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-17 18:47:36 +00:00
d52dc104d4
Migration: instead of removing weak-only code, warn about it.
...
Previously we considered such code "dead", but it's not really dead
until Dart 3.0. Removing it changes weak mode semantics, and we don't
want to do that automatically.
Fixes #41231
Change-Id: I6a88f016b4f3fcba160dcb738558867219715cbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143941
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-17 17:27:59 +00:00
d35f9a8aba
Measure identifier length as a possible feature
...
See the email I sent as background.
Change-Id: Ib4f558a2dfdf585236e99d695bdfcaff045c95c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143940
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-17 16:47:58 +00:00
0eaf749dfd
Fix some hints in analysis_server (TBR)
...
Change-Id: Ia43fa5ad0b12b24f434483da67ce168fb39a69fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143886
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-17 15:11:58 +00:00
4747672929
Migration: fix preview output when accepting a /*late*/ hint.
...
Change-Id: I383be37cc86d3c83f5b2b332ae14ce35516f858d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143563
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-17 00:17:15 +00:00
a72e0e3412
Migration: don't double count edits when accepting hints
...
Technically, accepting a hint requires two edits, one to remove the
`/*` and one to remove the `*/`. But we only want it to show up as
one edit in the "Proposed Edits" pane.
Fixes #38471
Change-Id: Ica7880a2ffab98715a1c9f3bbe723363fd481086
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143484
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-17 00:17:15 +00:00
fdc13e3f43
Migration: remove hints when performing migration.
...
Previously, if we migrated a code snippet like this:
void f(int/*?*/ i) {
/*late*/ int j = i/*!*/;
}
the migration result would leave the hints and add the hinted text,
resulting in:
void f(int?/*?*/ i) {
/*late*/ late int j = i!/*!*/;
}
We now simply remove the `/*` and `*/` surrounding each hint (with
whitespace corrections as needed), to produce:
void f(int? i) {
late int j = i!;
}
Change-Id: Ic4e1216cb4693d73d71c9ab1a37d5cc15b8ef334
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143460
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-04-17 00:17:15 +00:00
8c5bad716b
Add some fixes to dartfix
...
Fixes https://github.com/dart-lang/sdk/issues/41536
The already implemented lint fixes prefer_const_constructors,
prefer_const_constructors_in_immutables and prefer_const_declarations
have been added to the list of all fixes so that they can be used from
the tool dartfix.
Change-Id: I5a3a1a0a849498a5bf759f40dc51606c4f605a32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-16 18:09:05 +00:00
4f2e21b351
migrator: Update pubspec.yaml, not analysis_options.yaml
...
Fixes #38347
Change-Id: I201a02ad467401e8277631947dcdf3a19f74ddb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143440
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-16 17:35:34 +00:00
715361eef2
Change format of IDs for fixes and attach them to generated changes
...
Having IDs to the change allows them to be key-bound in VS Code (see https://github.com/Dart-Code/Dart-Code/issues/2169 ).
Changing for format is to make them better match the existing IDs for assists (these will need to be pre-loaded into VS Code to allow users to see them to aid keybinding).
Change-Id: Iedcfaaf9a29d5e8575f1b8394e3db0ff19360872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143588
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-16 17:35:24 +00:00
84beb4d31b
Implement the element kind feature
...
In addition to implementing the feature, this CL updates one of the
contributors to use the new feature as a way of testing it. I haven't
looked to see whether it impacts the metrics, but I wouldn't expect much
change anyway because of the small number of completions that are likely
to be effected by this change.
It might be interesting to start thinking about ways to measure the
impact of individual features.
Change-Id: Idd0040a774e5fd9a6e3f6c29d0aa7fd762676fbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143622
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
2020-04-16 14:33:24 +00:00
0e7df4b062
Remove unneeded <Widget> type params from "wrap with..." assists
...
Fixes: https://github.com/dart-lang/sdk/issues/41517
Change-Id: I18a560a82863c576cab8694eb940f16a9ebedfee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-04-15 19:44:57 +00:00
92db79412e
Add a generator and generated code for the element kind relevance table
...
Change-Id: I8b25a6e7c992eb572305d0ae8392baee03e479ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143483
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-15 19:15:22 +00:00
f7f0e2b51b
Add a fuzzy matcher for filtering completion suggestions
...
Change-Id: If3e9f87ad6a98be8f2a1f4c5c51679a48a206cf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143400
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-15 18:47:42 +00:00
69526e6512
Depecate many AnalysisOptions fields.
...
Change-Id: Ibe219527d9abdad38bb99390d3023e7ee6bb8420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143251
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-15 18:36:52 +00:00
6617e3e207
[nnbd_migration] New style for when migration needs rerun
...
Change-Id: I429ab3f0df58228d0bcfe594d6f614ac2b120728
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143401
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-04-15 17:51:13 +00:00
2feaa2ad81
analyzer: Add SecurityLintCode and a new getter on ErrorCode, isIgnorable
...
`isIgnorable` is the new way to determine whether a report from the
analyzer can be ignored. Codes with an ERROR severity are not ignorable,
and the new SecurityLintCode is not ignorable.
Change-Id: Ied72f1b61808eda088b947b8836e0cf1dfdd9850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143331
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-15 01:51:59 +00:00
1d3105e0b3
Migration: prioritize changes differently if they're due to hints.
...
Change-Id: I4dfdd0287e488dfac21923c71741d2218a2c070c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143334
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 23:33:46 +00:00
46b49d23ec
Migration: track multiple fix reasons for expressions with complex types.
...
Change-Id: I1a1f78377ed64504e5315b5096914219dc625e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143188
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 23:33:46 +00:00
46a89f7671
[nnbd_migration] allow edits to be done incrementally.
...
Mutate datastructures to match disk contents. Leverages offset mapper,
by rebasing the migration mapping onto the disk changes which occur in
sequence.
Add an integration test for preview site tests that confirms multiple
changes workflow works, including regions and navigation, including
using the changed edit offsets.
One thing that is not updated is traces. It seems that trace entries are
misusing "offset" by storing column values. Without that, adjusting
trace entries is not trivial. I have not looked into how difficult it
would be to correct this. Traces still *work*, they just may point to an
incorrect column. This is not easy to notice, but worth fixing in the
next CLs.
Another potential consistency improvement would be to use the offset
mapper to handle regions so that they do not need to be updated this
way. This would be more consistent with how other things like navigation
did not require updates once the offset mapper was done correctly.
Another quirk is that this API for performing edits does not *necessarily*
lend itself to reruns. For this CL, I decided to check when the edit is
"insertion only" and therefore easy to do incrementally. However, the API
allows for things like mass deletions that might be trickier to handle in
general. In this case, it will still do a rerun.
Change-Id: Ib88bb32592f54502d69b58ccab71ffb0b5f8040e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143325
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 22:42:46 +00:00
05c867873a
[nnbd_migration] Reset dartfix change listener on rerun.
...
Without this, rerunning causes the change list to grow, including all
prior changes. When users hit the apply migration button, the result is
corrupt.
Change-Id: I3b57b24be25e897ac6c976254d04a78dbb3a5a7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143324
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 22:42:46 +00:00
da2f4a6363
[nnbd_migration] Add CSS class tracking when the user needs to rerun
...
Currently not hooked up to any special styling, but will hide the "apply
migration" button.
Also currently not set to true by any workeflows, but that will of
course change in follow-up CLs.
Change-Id: Ie0ef64361dac40b19bf08497c1c4f92a80b0891d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143323
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 22:42:46 +00:00
2c86d0b78a
[nnbd_migration] Clean up edit URLs in preview site tests
...
Change-Id: Ia2b97085a1433532a5af0f66ed54a023715f8fd9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143305
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 21:05:25 +00:00
3ae6f3231e
[nnbd_migration] Rename originalContent to diskContent, it can change.
...
Remove assertion as well that disk content is only set once. In the new
workflow it can be set many times.
Change-Id: I86039fee1d144a8a03cd82dc5c9e0f45bb130141
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143304
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 21:05:25 +00:00
b7262388a3
[nnbd_migration] Add optional offset mapper to navigation assertion
...
Change-Id: I2895e4da2af5419744a20b6e38c630ca21bf602c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143321
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 21:05:25 +00:00
9f0c5cbcad
[nnbd_migration] Move region & navigation target asserts into test base
...
Change-Id: Ifa19451fd3985d7068ebaf18fedd7bc2304f6cc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143320
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 21:05:25 +00:00
23b636ae29
[nnbd_migration] Add three new offset mappers: insert, sequence, rebase
...
Change-Id: I5c11a98acf54735c21e7bf399ef099f371ebdb39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143281
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 21:05:25 +00:00
fad05e89dc
Require exact type matches for equality in LSP classes
...
Change-Id: Ia3f502a315e2c6fbc62eb6fbe3785dad86c782cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142992
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-14 15:47:01 +00:00
2fbe4d9194
Resolve type aliases when generating LSP equals methods
...
Change-Id: Iccecfa8dc8d77cb0d4358db1f7fa54607ffaa428
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142991
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-14 15:47:01 +00:00
7fe16ba812
sort_directives quick fix
...
Fixes: https://github.com/dart-lang/sdk/issues/41464
Change-Id: I9c5804ef8ec872b8420feba3d9a0f0da5fb757d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143303
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-14 00:45:18 +00:00
b68334052a
Support macro expansion of Dartdoc in code completion
...
Change-Id: Idbde9584da82606949cce79849088c6432d0602a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-13 21:37:09 +00:00
e1822e9626
Migrator: Add new fix kinds: replaceVar, addType
...
Fixes #41410
Change-Id: I127d309e84423c24eb2563063af433187b9bf057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143222
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-13 20:11:32 +00:00
115fb42a01
Fix warnings in nnbd_migration.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I56fd93eec4a300ed869c0208e2b1544d18fa183b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-13 17:35:56 +00:00
2aecf30d2b
Add some missed children to code metrics
...
Change-Id: Ibfed9bfc32b291427247bd4750e57f0eaae62e4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143253
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-13 16:08:53 +00:00
c9710e5059
analyzer: Do not report on a bad type of return expression if function has illegal return type
...
Fixes #38188 and fixes #41439
Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-04-13 03:42:35 +00:00
3a8cfa3547
Migration: don't generate traces for casts that don't involve nullability.
...
Change-Id: I9dca37cb5542d27485b28a012d32eb0e05f45044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143016
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-10 23:32:03 +00:00
65f9127e14
Add word breaks in details panel; fixes #41404
...
Change-Id: Ic79ac26318b51fa73d5f7f7a645e474d5310daaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143103
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-10 19:21:34 +00:00
eb4b9b5241
[nnbd_migration] Fix windows file paths in edit links, pt 2
...
Change-Id: Ie9bc22d2a5d48b7e7d9355ac77b1cbe4397bf532
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143121
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-10 19:03:59 +00:00
254d115a80
Fix analyzer windows bot
...
Change-Id: Ic95b3121461765622fd577409faa8163d7740c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142660
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
2020-04-09 17:33:09 +00:00
0923668147
Migration: remove preview section "edit rationale"
...
Also remove the code to generate it, and associated tests. This
feature is no longer useful now that we have the "stacktrace" view,
and there's a considerable amount of complex logic backing it that's
interfering with other work I'm trying to do.
Fixes #41387
Change-Id: I552ffbfea8573e5d640ec98a3a196bd0eb36cdb9
Bug: https://github.com/dart-lang/sdk/issues/41387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142886
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-09 17:30:09 +00:00
b11da4d65e
Get go-to-definition working with plugins for LSP
...
Change-Id: I49c469a15a651718ed21850e6c1a8fac798392c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142378
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-09 17:01:19 +00:00
Konstantin Shcheglov