d49a98b866
Simplify FeatureComputer and improve for location before named arguments and with spaces.
...
Change-Id: Ie2b383078ab79ecc6ac9634f9f38534f0c22c707
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152989
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-30 23:17:37 +00:00
db61737086
Simplify CompletionPerformance.
...
R=brianwilkerson@google.com
Change-Id: Iff0cf3b8b684f72d8a32b3fe4b9493295c11d59b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152985
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-30 22:45:27 +00:00
99cc566afc
Clean up ArgumentList tests for FeatureComputer.
...
R=brianwilkerson@google.com
Change-Id: I50c880ba5e60b8a5ba4b80f0fe0da7097eb2cb9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152733
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-30 21:26:22 +00:00
c4503f0074
Use OperationPerformance to track performance in CompletionPerformance.
...
R=brianwilkerson@google.com
Change-Id: I50158512020be87b3c51363ed2e503c3df3cfaae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-30 17:44:54 +00:00
3fe9867ae2
Add a fix for prefer_final_in_for_each (issue 42510)
...
Change-Id: Iebac9c2854eaf40dd7c177d5357172dfcafa6806
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152618
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-29 19:20:23 +00:00
12f1d68ee3
Move OperationPerformance out of Cider to use it wider.
...
Change-Id: I9e1669c650b23d02e645ef3b19bfd9e15c7f54ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152735
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2020-06-29 18:42:44 +00:00
e8e366714c
Rename "Sort Directives" as "Organize Imports" in the quick-fix
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/2552 .
Change-Id: I5591b3fa7b0e2c03e104b16f878689cf2e8caa4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151514
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
2020-06-29 16:38:13 +00:00
13aae92ae9
Fix for crash when computing the context type and unresolved named argument.
...
StateError: Bad state: No element
at Iterable.first (dart:core)
at _ContextTypeVisitor.visitArgumentList (feature_computer.dart:400)
R=brianwilkerson@google.com
Change-Id: I578a17d5f0451785a0ed9ff5953705f91676c4ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152731
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-28 17:49:02 +00:00
79e54facb8
Add a new category in completion_metrics.dart when gathering and printing the data: type references.
...
Change-Id: I6a30195a21e4c2b6886e48d5360f11bd2d200467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-06-27 00:36:08 +00:00
616ed353a2
Rename / deprecate FileResolver methods.
...
R=keertip@google.com
Change-Id: I684465db327f5f448a95f57a18cf65e172c09b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152603
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-25 20:59:32 +00:00
8ed0541439
Fix typo causing a test not to be run
...
Change-Id: I6455621fd59603adf980dddcedb2ee4f1d455664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152430
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-06-25 17:59:32 +00:00
87d431e8de
Improve flutter wrap assists when caret is at the offset of an argument list
...
Bug: https://github.com/Dart-Code/Dart-Code/issues/2492
Change-Id: I296f9396b3eedcbd1a63f272ed34c65f9d95d83b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-06-25 17:17:12 +00:00
d619edf7ae
Avoid using a visitor to find the identifier of a completion target
...
Change-Id: I94a3515912b373cd201a7d110382d126420bc67e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-06-25 17:02:02 +00:00
52d16dfbba
Resolve only relevant portion of the file for Cider completion.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: Icf23a79f25baf309f88b737ac061a10a655d2f7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152407
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-25 01:02:41 +00:00
2ec47ad273
Use ElementKind.ENUM for enums.
...
There was a crash internally, caused by the fact that when we have
duplicate name for class and enum, during linking we put them into
different Reference bucket - @class and @enum, and also inside
the class, the reference to its name is the class.
But when we resolve, we check equality of elements using not
references, but locations. So, we need to make sure that their
kinds are also different, so go into different bucket, and so
not equal.
When they are InterfaceType and equal, we would try to match
type arguments against the wrong number of type parameters and crash.
Change-Id: Iee3f8691adac65d4b0395ceec7fc7250f96afa88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-25 00:20:31 +00:00
ff83b0fec9
Add support for navigating from the URI in import and export configurations to the referenced file
...
Change-Id: Ic6234d9a24dcb52228067b20d69277e47ff89a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-24 22:46:33 +00:00
d0e78f8a77
Fix the edit groups created by create_missing_overrides (issue 42468)
...
Change-Id: I53e5f44af3583549f277f1d7acbe1f725f7a6ef5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-24 22:39:18 +00:00
ccd2af6402
This new tool resolves and evaluates field declarations where the type isn't specified, but is known when the code is resolved, i.e. cases of var i = 1;.
...
These cases are collected sorted and printed back out to help us improve the context type algorithm, that is we may choose to in completion locations 'var i = ^', to assume that the user will be entering an int type.
Change-Id: Ia3e4663b2cf1614935ff49a4ab10299db0dc909d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151783
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-23 20:59:03 +00:00
7f824bb02d
Check for null in VariableDeclaration context type.
...
R=brianwilkerson@google.com
Change-Id: Iabf7b76812cdd9480a71b3a396c9895b33e3c998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-23 19:16:23 +00:00
b95538cff1
Generate tables of keyword relevance
...
Change-Id: Ic0f07561bd4b4cd81a3b511bac31b0f7b4906319
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151881
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-23 18:57:03 +00:00
2d73cb53a1
Filter LSP completion requests when offset is mid-symbol
...
Change-Id: I28bf5ddda1d7d6f1177a602d9f2dd3091f35966d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-06-23 11:38:20 +00:00
f0c87e9f21
Clean up no-publish comments in pubspecs
...
Change-Id: I6cc1ab404de75cd02183b862842198c85b6d9256
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152005
Reviewed-by: Alexander Thomas <athom@google.com >
2020-06-23 10:34:09 +00:00
ab73158758
Fix the windows bot and update MockSdk
...
Fixing the test that's causing the Windows bot to fail required updating
the MockSdk, which cause a lot of other changes. I would have done this
in two separate CLs if I'd known how big this was going to get, but I'm
hoping it isn't too big.
Change-Id: Idee56bab5e73a78ab7857e81177090493aa08b40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151874
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-22 14:34:25 +00:00
32d403b472
Add a fix to insert the keyword late
...
Change-Id: I40612fd2710a1189137d8ba676c1b66b4943d677
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151037
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-06-21 17:33:10 +00:00
52dd48651b
Convert the remaining quick assists to use CorrectionProducer
...
Change-Id: I0accafaf3f076d99bb265d2e6d8815cf2720a7a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151871
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-06-21 15:43:42 +00:00
8fd04408f0
Add CiderCompletionComputer.warmUp()
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I4fce7250d7f7b85ea47bf119ddfd6ef25fb28efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151888
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-19 22:59:17 +00:00
9fcac032b6
Convert more quick assists to be correction producers
...
Change-Id: I6cc0343cc9af390923a7d4a66a95e1c15aeb47f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151887
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-19 22:23:47 +00:00
e12a515be0
Use the new analysis we now have with implied types to included types at locations such as 'var i = ^' for purposes of code completion.
...
Change-Id: Ie78a51a5c3c65818bec66496e51716f9406899c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151807
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-19 20:38:28 +00:00
67173ade40
Record performance for analysis operations.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: Ib85680d37f36c9a34f61b8d215a68ed2bd71f8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-19 20:15:35 +00:00
69843a8f04
Record performance with CiderOperationPerformance hierarchy.
...
This does not include breakdown for resolution yet.
I wonder if this more general information could replace specialized
CiderCompletionPerformance fields 'resolution', 'suggestions', etc.
WDYT?
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I4685dc2a8de8028ce84cc2640943f45c8cf047e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151811
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2020-06-19 17:33:03 +00:00
71ddad82e4
Disable UriContributor for Cider.
...
There are two reasons to disable it.
1. This contributor talks to the file system, and for Cider this
operation is too slow.
2. It just does not work. We need `SourceFactory` for it, and the
way we get it is not compatible with the Cider's `AnalysisSession`
mock.
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I652c4f438dbab2a9fa220878ff09d47c14434cd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151806
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-18 23:29:03 +00:00
ae6a489dfb
New 'non-type member completions' relevance tests in the analysis server.
...
This test includes: a failing type parameter test, as well as a common completion bug with Flutter widget construction, this test shows that the new relavance logic does the right thing.
When we add additional categories in completion metrics to split apart this group of completions, this test may be split as well, this name seemed appropriate for the time being.
Change-Id: I67638a121528be5e9a20bebc022a576282db1867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151631
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-06-18 00:03:31 +00:00
60bb0d3a41
Separate current and to restrict FeatureSet(s) in scanner.
...
Bug: https://buganizer.corp.google.com/issues/159207726
Change-Id: I41b4c79590dccd05d8b0fa42d296f00a3c3ee229
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151620
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-17 23:32:31 +00:00
5944ff823f
Context type improvement for code completion, fill in missing functionality and add tests for FieldDeclarations, VariableDeclarations, VariableDeclarationList, and TopLevelVariableDeclarations.
...
Change-Id: I7267712f68990b5f55ab64bca2345409e41738b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-06-17 20:42:41 +00:00
7f8ec737db
Add a note to docs about enumerations being extended
...
Change-Id: Ia5d6017018b812777b35641c2ee5a4bca9aa9501
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151527
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-06-17 19:32:50 +00:00
7951b21c91
Add folding regions for do/while loop blocks
...
Change-Id: I92c5c9392ca6e19e8ca0378beb23100fe0ccd1db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-17 19:32:50 +00:00
f0e1f32c87
Add support for folding if/else/elseif blocks
...
Change-Id: I3cbf1f282ee59c577c6ba912e957f838e827fd3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-17 19:32:50 +00:00
f36151e2d2
Add ChangeTo/CreateClass fixes for implements/mixin of missing identifiers
...
Change-Id: Iac0c512e87aaf5ba183d155e7bffe2a74936d7a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151509
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-17 15:44:36 +00:00
094d98a812
Use the context type for available declarations
...
Change-Id: I698becd01145dde94505608f99171789a7f39c62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151428
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-17 15:43:36 +00:00
b2f755ac07
Add a note about passing client-id/client-version to LSP doc
...
Change-Id: Ic82e5915e512c78c99b963bbaa74aaed42374726
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151506
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-06-17 15:06:54 +00:00
728df5d9ab
Fix placement of "final" for late fields with types
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/2553 .
Change-Id: Ief79c8d5e095c17afc39d83eb231604bcf224ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151511
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-06-17 14:56:04 +00:00
aa3f7dc4e9
[analysis_server] Fix crash reporting bug, casting exception to a string
...
Brian noticed this running unit tests. Who knows how many bug reports we
have missed from this -- we can only hope it is very few.
```
type '_TypeError' is not a subtype of type 'String'
package:analysis_server/src/server/error_notifier.dart 26:7 ErrorNotifier.logException
package:analysis_server/src/analysis_server.dart 266:54 AnalysisServer.handleRequest.<fn>
dart:async/zone.dart 1222:13 _rootRunBinary
dart:async/zone.dart 1107:19 _CustomZone.runBinary
dart:async/zone.dart 1601:18 runZonedGuarded.<fn>
dart:async/zone.dart 751:19 _ZoneDelegate.handleUncaughtError
...
```
Change-Id: Ib83dc99a88a1566ead5d59a9f71afc80416eb341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151464
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-06-17 07:11:30 +00:00
d279cb47b5
Enforce sorting in analyzer/.
...
Change-Id: If7e76e442e64cd4991b80c3993e3da10bb3a19ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-17 05:04:30 +00:00
651464c909
Implement the rest of the ArgumentList ASTNode logic in the context type visitor in feature_computer.dart, tests added in feature_computer_test.dart
...
Change-Id: I35afea21912a785af427afb317cbff532c29d717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151364
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-16 20:51:21 +00:00
c7d9fa996b
Clean up some unnecessary code in completion manager
...
Change-Id: Ifdbe46f12b82a521aa079db87fd8c1aba9dd165b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151424
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-16 20:41:01 +00:00
6d4e7d6830
Fix an exception thrown when a method cannot be resolved because the target type is dynamic
...
Change-Id: I0479305057a2f763f68aa61c860ab9785d2ca1b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151420
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-16 17:38:30 +00:00
25f2f7796a
Send LSP outlines for all open files
...
Change-Id: Icd785376c54965c53bd4ea0cf89ede74a4287981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151390
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-06-16 16:21:50 +00:00
6021f0aec2
Follow up on https://dart-review.googlesource.com/c/sdk/+/151343 , assertOrder() now accepts the order with current.relevance > previous.relevance instead of current.relevance >= previous.relevance, additional tests use assertOrder([]).
...
Change-Id: I7f7c27d2e3205cc4b556e0fbb1b238a743d281ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151323
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-06-16 06:55:21 +00:00
0d3e77d28e
Start converting assists to CorrectionProducer
...
Change-Id: Ie2d12ce8c15a75e8db71434d790c32a76a06b13e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151324
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-06-16 00:11:28 +00:00
047f1721a1
Remove the DartCompletionManagerTest and replace it with CompletionRelevanceTest, making all of the completion relevance tests consistent.
...
Change-Id: I24d042b420a3c1d6f38b063913cb702c34858076
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151343
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-06-15 22:37:04 +00:00
Konstantin Shcheglov