dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6105 Commits

Author SHA1 Message Date
pq af8767e9c8 bulk fix for prefer_is_empty 
Change-Id: I5c4cdb5b87ccbab8e257a45c33fe78d2d41923e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 17:17:19 +00:00
pq bd65d441f5 bulk fix for prefer_conditional_assignment 
Change-Id: I45e979bc00da0d8a5a8a257ce0fbd484137c143d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 02:01:13 +00:00
Brian Wilkerson 0a19e8dbfe Add test requested in earlier CL 
Change-Id: I112004e06150ed913d64b77f272a4ae85c6ef61a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156926
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-03 23:53:23 +00:00
pq 43c68d782d bulk fix for prefer_adjacent_string_concatenation 
Change-Id: I873d3531307a9685dc0950aa2fc2119af5abdd0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 22:40:07 +00:00
pq 2bf777ea6e bulk fix for omit_local_variable_types 
Change-Id: I1cc6eb6c7423ded3c5694728271cec52341ff98a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 20:59:31 +00:00
pq 987c9e347c bulk fix for null_closures 
Change-Id: I20e57da5b95868551216b9b0a095e82116c3585e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 19:14:22 +00:00
Brian Wilkerson ac79402072 remove-duplicate-case should not remove statements if there are cases that fall through to them 
Change-Id: I2094335d06e62eeb184f78b14e6028fdb5341dba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156849
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-03 18:50:21 +00:00
pq d427ab510d bulk fix for no_duplicate_case_values 
Change-Id: I4925113c44d5042062ccaabea680a07eedf7bfdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 18:11:51 +00:00
Brian Wilkerson 4121cf3cb4 Add a quick fix to add a null check operator 
Change-Id: Ie85ab236015057c2cb0255cc1548605e5b01e908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156783
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-01 01:17:11 +00:00
Konstantin Shcheglov 28c20c0861 Fix for crash in ReplaceCascadeWithDot, simplify it. 
R=brianwilkerson@google.com

Change-Id: I3243203e42856b6a4e65603aafb708473bdfe3fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-01 00:32:01 +00:00
pq 5553dcbea7 bulk fix for hash_and_equals 
Change-Id: Ifbca2871bbf90f8c1ea3e3ae6dd6ef9e8b5b00c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 22:28:20 +00:00
Brian Wilkerson dc908e076b Do not suggest an explicit cast when the only difference is the nullability of the type 
Change-Id: Ibb20fd5d3ced4ca13bb604bbe42eced16903de9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156723
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-07-31 19:00:20 +00:00
Brian Wilkerson 4776ac1f89 Fix a couple of recently introduced hints 
Change-Id: I68b653ea44e548a2789f7e720d6abfddb7cfb08c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156721
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-31 17:33:58 +00:00
Konstantin Shcheglov dfb3720cda Changes to analysis_server/ to be compatible with the breaking changes to analyzer/. 
Change-Id: I606072798633601d78f38c0035b579d93875ef3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-31 17:04:58 +00:00
pq 4894e34f1f bulk fix for empty_statements 
Change-Id: I92c2dd5333d9b505a2c37b5936199895ab928fad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 16:27:10 +00:00
pq b10f22c7f5 bulk fix for empty_constructor_bodies 
Change-Id: Iffd3b80e6316372986374dc6b66cae24bd287dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 14:30:00 +00:00
pq 2dca5ad318 bulk fix for empty_catches 
Change-Id: Ia1cc3aefd79968bba0ff43f7ac9016e68ee2195a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156600
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-31 01:29:45 +00:00
pq 2b51d59e69 bulk fix for use_curly_braces 
Change-Id: Ia1a9fdde3d283cab94455aa4277d26e2d09998cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 00:02:24 +00:00
pq f640e58e45 bulk fix for await_only_futures 
Change-Id: Ic643ef1fd0e8374ecce7fffff34fc9b6f7e8550c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-30 21:26:04 +00:00
Konstantin Shcheglov 0a06e86e57 Test that prefix based filtering in Cider does not use following identifier. 
Change-Id: Ieb37a1adce3ab2fb7bdc49fcb1d263b3940fd1e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-30 17:34:18 +00:00
Danny Tuppeny 6762f2294c Tweak parser to handle LSP 3.16 spec 
Change-Id: I53ef27f4b9dc9c4f6a8ff54e116dd3d2a9faf65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156506
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-30 15:49:28 +00:00
Danny Tuppeny 38fa4aea17 Don't use whole identifier as completion targetPrefix if it's after the cursor 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2672
Change-Id: I45ccc00990495ddd9fa8881d673a45bf6c4f82d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-30 13:58:28 +00:00
Konstantin Shcheglov 219107cca0 Report INVALID_ASSIGNMENT on the cascade target. 
https://dart-review.googlesource.com/c/sdk/+/155380 has tests that
show that it is otherwise hard to specify where the offending
expression is.

Change-Id: I8cdbc3d974148d644b75889a8afd921a2a2716cd
Bug: https://github.com/dart-lang/sdk/issues/42865
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156067
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-29 23:04:49 +00:00
Konstantin Shcheglov e60a0315dd Fix for crash in RemoveEmptyConstructorBody. 
R=brianwilkerson@google.com

Change-Id: I0fe17e9fe96028c5286f509c3bf9ec16248f4841
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-29 22:01:59 +00:00
pq e12a536edb bulk fix for avoid_types_on_closure_parameters 
Change-Id: Id080559bc2a18fd8ce4c8eb59412c4461d8dac39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-29 19:45:25 +00:00
Brian Wilkerson 15fb170ffb Enable the new code completion relevance feature 
The new feature will be enabled by default but the option still exists
so that users can disable it if they want/need to.

Change-Id: I9e001b00b5dfe132a6b7bcfdcacd3143fb24f65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156121
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2020-07-29 17:14:44 +00:00
pq e2f0cbc4d6 bulk fix for avoid_return_types_on_setters 
Change-Id: I29465e1a33be384948015682725b3e8f8db99bb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-29 16:03:16 +00:00
pq 1324146fb4 bulk fix for avoid_redundant_argument_values 
Change-Id: Id7dacf56d72acecfbd0f862585e68d93f2c22d55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-29 15:11:13 +00:00
pq 89504b4e84 bulk fix for avoid_empty_else 
Change-Id: I5ec1f4c1223aba42e972b78a3c31cc7c2f71c23e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-29 00:43:31 +00:00
pq 1a28fb28c8 bulk fix for avoid_annotating_with_dynamic 
Change-Id: I29815825e65f51f3db8ec2320412f9926abd0a92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-28 22:10:55 +00:00
Konstantin Shcheglov 78bcab9428 Fix for NPE when REMOVE_UNUSED_PARAMETER in invalid code. 
R=brianwilkerson@google.com

Change-Id: Ida985d86e062d6c62efa2ae8a394f75a239644e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156068
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-28 21:24:06 +00:00
pq 03e4737f31 bulk fix for prefer_contains 
Change-Id: Ifb45c1d9dbb19ca7ac6ba20ce9da1b7712827d76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-28 18:24:26 +00:00
pq fbe33e8123 avoid_init_to_null bulk fix 
Change-Id: I2c40b1028382d1818dc13a3f80e94184738016c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156069
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-28 16:03:48 +00:00
Brian Wilkerson 68472f2767 Fix add_missing_required_argument to handle named constructors 
Change-Id: I00b5c22c36881f2643867da1fafb5ff2cf59c931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156061
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-07-27 22:27:51 +00:00
Konstantin Shcheglov 8de8a1c226 Move codes from StaticTypeWarningCode into CompileTimeErrorCode. 
They are all errors now.

Change-Id: If48d38e38e845fd5b5a950dd5514bf1cbbce03d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-27 16:44:15 +00:00
Konstantin Shcheglov ba92b78acd Move errors from StaticWarningCode to CompileTimeErrorCode. 
Bug: https://github.com/dart-lang/sdk/issues/42821
Change-Id: I153c48d7a2e4a02026928e6203aacf8f2dc029ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155849
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-26 04:19:25 +00:00
Brian Wilkerson 9e1b6030d2 Fix a type cast exception in the create-constructor fix (issue 42830) 
Change-Id: I47b11000c2c4ec96856a58d43f9b7b6493cc7908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155825
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-07-24 23:36:23 +00:00
pq 8d8dbfcea2 Add @override bulk-fix 
Change-Id: I45da6351fc705ca2d7d6e20b5ef43a6ca9173289
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155828
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-24 21:54:41 +00:00
pq 8c1829e110 bulk fix protocol wiring 
Change-Id: If9827b8765eb17c728113aaf23a26df5c8a05738
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155726
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-24 16:56:34 +00:00
Danny Tuppeny afee49e7c1 Add a default clientID when running in LSP mode 
Change-Id: Ice200282cb84e512562628fd534177ebbd1c13de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152801
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-24 15:07:44 +00:00
Konstantin Shcheglov c2d28d1569 Rename Null Safety tests. 
R=brianwilkerson@google.com

Change-Id: I9276244cab52cb5c0f2687052f2a3df9a9fd48b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-24 00:26:08 +00:00
Konstantin Shcheglov 4d3ec06277 Add more data and performance operations for Cider. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: If2ad5135a8de977f92300e6c2480891ab02c6458
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155721
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-24 00:25:56 +00:00
Konstantin Shcheglov cc519b9a03 Test that during partial resolution for Cider we don't resolve some nodes. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I7212016394b7e2027b47ba8dec47b94961dccb5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155546
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-07-23 16:21:00 +00:00
Konstantin Shcheglov 58b6f40c73 Issue 42797. Understand in legacy libraries that a function returning Never (in Null Safety library) never returns. (reland) 
Initial: https://dart-review.googlesource.com/c/sdk/+/155500
Reverted: https://dart-review.googlesource.com/c/sdk/+/155540

Bug: https://github.com/dart-lang/sdk/issues/42797

Change-Id: I5f0f1df594ac678718f347ee80b1764f971e42e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-23 00:01:12 +00:00
Konstantin Shcheglov dfe1d9b682 Disable OverrideContributor for Cider. 
We see that it is slow, about 600ms, at least in some cases.

R=brianwilkerson@google.com, keertip@google.com

Change-Id: I5c1170a84c06aa9c28000c03fbc138d2909e7f2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155504
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-22 22:23:19 +00:00
pq aea99b2f5c scope debug property assist to Diagnosticables 
Fixes: https://github.com/dart-lang/sdk/issues/42783

Change-Id: Ied9b0fa04e0f99b4d5b4604c72696b5cfaec737d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-22 22:18:24 +00:00
Konstantin Shcheglov 6f8ce20c99 Move asInstanceOf(ClassElement) to DartType. 
This follows to the change to the specification.
https://github.com/dart-lang/language/pull/1106

R=brianwilkerson@google.com

Change-Id: I6575f201161c454de98e9bcbec74b9974d91d062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155242
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-22 01:22:05 +00:00
Brian Wilkerson 79a2aca554 Generalize data-driven changes to support references to named parameters 
Change-Id: I75162225f88c2a50b4f5e0ca6601c685be6436b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-07-21 23:31:55 +00:00
Konstantin Shcheglov 284ba97259 Call getFileContext() once for Cider completion. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: If6332ad5a7a3153e7bc67376294df9bbb2468ce7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-07-21 17:07:02 +00:00
Brian Wilkerson 052f100a95 Fix newly reported hints in analysis_server 
Change-Id: Ie39a0f1f67019282c9d2bb4548ac553fa7061a65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155131
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-21 17:01:42 +00:00