dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6105 Commits

Author SHA1 Message Date
Danny Tuppeny 0aed132f4d Don't send analysis errors for ignored files 
Bug: https://github.com/dart-lang/sdk/issues/36064
Change-Id: Ic12aa70d7ca287c4a8db7915c10dde5da2e2137c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155130
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-21 15:44:28 +00:00
Brian Wilkerson ac3e85a69d Fix a type in a class name 
Change-Id: I59bcdb777a5cad69bcbe32919453c1bfa4a52caa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-21 13:49:27 +00:00
Brian Wilkerson 511ee086c0 Move more implemenation into subclasses of Change and breakout validate and apply phases 
Change-Id: I6ef5a3afd7cf9902e400c707f3ad5d858b7e9bc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155067
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-21 13:49:19 +00:00
Konstantin Shcheglov 86ec742832 Switch to new Scope(s). 
No much changes to resolution itself, only to the way how we create
scopes. But we still use `lookupIdentifier` that is basically the old
approach to resolution.

This also moves the fix of https://github.com/dart-lang/sdk/issues/42620
to TypeNameResolver.

I will continue improving in following CLs.

Change-Id: I89bae5afe0a7978aba9fe9bf7c8bf08fb59b1440
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-21 01:37:34 +00:00
Brian Wilkerson 3adf588153 Hovers stop claiming that classes contain themselves (issue 40056) 
Change-Id: I27b3f63e7795c287f43fd88b730c8792c9a8f768
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-20 20:36:41 +00:00
Brian Wilkerson 802647fa26 Add a processor that can apply multiple fixes across multiple files 
Change-Id: I2df6a473cd83d978e678ebabb88d5bfbcea3653f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-20 17:59:41 +00:00
Brian Wilkerson bfc4a22869 Add initial support for data-driven fixes 
Change-Id: I7d63438dde4c0904bf6e04ac9feb00aac72a6066
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154981
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-20 16:23:27 +00:00
Danny Tuppeny 0de2455c02 Fix modifications stamps for modified files 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2286#issuecomment-658597532
Change-Id: Ibb49a3b244ca40da5018fd705adffdbe6e0ce880
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-20 14:46:07 +00:00
Danny Tuppeny 2e6dd67859 Prevent NPE when trying to compute AddDiagnosticPropertyReference assist inside a mixin 
Bug: https://github.com/dart-lang/sdk/issues/42749
Change-Id: I2772f0c0f4f21409730713c1ed8a871725080a2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-20 14:15:34 +00:00
Brian Wilkerson e2f14603db Add a new replace-cascade-with-dot fix 
Change-Id: I1e3416e8d92c4c63f26e5627c68ed587ab260cc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154921
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-07-20 05:16:53 +00:00
Konstantin Shcheglov ea7a92845c Fix NPE for CREATE_FUNCTION when IndexExpression argument. 
Change-Id: I539908a5033aa0f84adcce5ae0be4ea6713ff75c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-19 15:40:19 +00:00
Brian Wilkerson 7032b2b1d7 Fix an npe in assign-to-local-variable assist (issue 42747) 
Change-Id: Ib9c4a683a15b83d2d8e8fe00565d6457cea36c1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154845
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-07-17 21:58:23 +00:00
Brian Wilkerson 174759cfbd Add a way to get all of the lint codes used by a rule 
Several of the lint rules have been producing diagnostics with more than
one lint code, but the code that deserializes diagnostics has only been
able to use one of the codes. That potentially leads to errors, though I
suspect the bug has been invisible because we serialize and deserialize
the messages. Nevertheless, it seems like we ought to do this correctly
and that it will eventually lead to a visible bug.

Change-Id: I41faaa45df63cb3c74042661e1c89e3fde3d72d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154843
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-17 18:39:37 +00:00
Brian Wilkerson e0cfdc0d62 Deprecate the class DartChangeBuilder and update all references to it in the analyzer packages 
Change-Id: I6c2692ed5ece57d28f70482877933564d443cfa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154753
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-17 00:11:14 +00:00
pq 4aa16acb30 bulk fixes impl 
A basic implementation.  Next up a dedicated `BulkFixesProcessor`.

Change-Id: I6d11888b8df66cd58a5a59d2e2ddb53e51d08872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-15 21:59:50 +00:00
Danny Tuppeny 8a4f583571 Support Deprecated + Unnecessary diagnostic tags for LSP 
Change-Id: I3915c2658e090caae40d126f6faff38620518950
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154468
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-15 18:13:24 +00:00
Danny Tuppeny cf89c2e2cb Add support for LSP CompletionItemTags 
Change-Id: I40b30e8e442913d20bccd53d4b96c2b60fb81190
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154467
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-15 17:12:14 +00:00
Konstantin Shcheglov b6773035ba Fix for Cider completion in libraries with parts. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I834d27cad96092d32d7c1bacb71fc4584ba3503d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-14 23:58:03 +00:00
Danny Tuppeny e7f861023c Add dart.lineLength setting to the LSP docs 
Change-Id: Ic517979497a0755683a8b5f2335ee75d103b5220
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154327
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-14 18:13:30 +00:00
Konstantin Shcheglov c3655ed435 Remove FolderBasedDartSdk.defaultSdkDirectory() and getSdkProperty(). 
It is up to the higher level clients to decide how to find SDK.

It is not API, and is not referenced internally, so we can land it
without going through breaking changes.

Change-Id: Id428519fa9bb3c38368f095c0f358e07f65c45b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-14 18:09:30 +00:00
Brian Wilkerson 9bb4fb680e Update the wrap-in-padding fix to not add the keyword const when in a constant context 
Change-Id: Icc9a8ed08b1294757df336d0d7169ac8b75c95c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154287
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-07-14 16:34:49 +00:00
Konstantin Shcheglov 69d11907ec Support for data attachments to OperationPerformance. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I674f2eaa271d9c2bbf9a82831bfeaff1ca765264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154286
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-13 22:34:19 +00:00
Danny Tuppeny ba459f96cf Allow dart.lineLength to control formatting for LSP 
Noted at https://github.com/Dart-Code/Dart-Code/issues/2286#issuecomment-655762024.

Change-Id: If45bede84a0a4414a16d1809a1aa0f81d18cebfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154008
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-13 17:09:59 +00:00
Brian Wilkerson da9697feb9 Fix the update-sdk-constraints fix 
The bug was reported on https://github.com/Dart-Code/Dart-Code/issues/2629.

The fix is not ideal, but the best I know how to do quickly. I think
that a better fix would be to not have a `DartChangeBuilder` and to have
`ChangeBuilder` be able to build file builders for both Dart and non-Dart
files. The reason I haven't done that yet is that I want to spend some
time thinking about the best API for that change.

Change-Id: Idbc55e347f724cd1102b6032c2f7239cd9ee7fc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-13 16:18:19 +00:00
Mike Fairhurst 0506475654 [analysis_server] Remove added space. 
Change-Id: I7a5c8fdfc318359904b9c4befe07ff0be186b446
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154125
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-11 04:17:32 +00:00
Brian Wilkerson 082a6e03bd Use element kind to boost the relevance of available declarations 
This doesn't significantly improve the overall scores, but it does cause
the element kind to be used for available declarations, which means that
constructors are suggested before classes.

Change-Id: I75e7bb13bd867b9209a43c4d737c5079c42eb25a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154080
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-10 20:08:36 +00:00
Mike Fairhurst dfd71a7e3d [analysis_server] Report plugin startup failures to instrumentation 
And don't report an issue stopping a plugin that crashed.

Change-Id: Ic079748e578a0a5331165bd60a3ed0e6cf44e3b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153944
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-07-10 20:04:26 +00:00
Konstantin Shcheglov 707c6404f9 Use not deprecated analysis_options_provider library ins analysis server. 
R=brianwilkerson@google.com

Change-Id: I009c28e6e91bec4c4d75fb9452b3794635269b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-10 19:13:46 +00:00
Konstantin Shcheglov 90ce990409 Simplify Flutter support to a single instance. 
Change-Id: I90813c4e01694510971c4ce9cf96a4a3380a2923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153952
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-10 17:21:24 +00:00
Konstantin Shcheglov adb317e5b0 Use InterfaceType.asInstanceOf() in AddDiagnosticPropertyReference. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ic40accfcdb645dc0260965efaec1701d3e5548ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153950
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-10 15:17:32 +00:00
pq 3d5df93fb1 bulk fix protocol 
Change-Id: Id8505d5ad6f0f3d1c5289ab12d4932c6174f72e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-10 14:20:07 +00:00
Jaime Wren 9a4e2b1514 Add an additional completion metric into completion_metrics.dart: 'use old vs new relevance rank comparison' 
Change-Id: I21eb1447dd6c833870158717031a01d7e8f253c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153485
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-09 17:19:02 +00:00
Danny Tuppeny c4a2efd6e7 Switch all generated LSP classes to use named constructor arguments 
Change-Id: I111b58fa5d04314247d5f92650491cdeef6bd4a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-09 17:18:07 +00:00
Danny Tuppeny 6db0396c83 Regenerate code from v3.15 LSP spec 
Commit v3.15 of LSP spec + regen generated code

Change-Id: Ic0823063791900f347e1ff1f2242a6e4e6ed8ca6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153778
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-09 17:18:07 +00:00
Danny Tuppeny d86fa966a9 Tweaks to be able to parse v3.15 spec 
Change-Id: Ifdb8696246b6893b743754dab5344d5939550a10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153776
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-09 17:18:07 +00:00
Konstantin Shcheglov aff22600de Use CaughtExceptionWithFiles instead of LibraryCycleLinkException. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Iae70c6453930fca8ef8e2828cf7e3932cc742263
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153706
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-09 00:34:57 +00:00
Konstantin Shcheglov 9dea0a8d97 Add InterfaceType.asInstanceOf(ClassElement) to API. 
R=brianwilkerson@google.com

Change-Id: I91c61aea37bb4ccfb300083e1b017b8e71ef6d6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-09 00:34:38 +00:00
pq 7498facd2a fix async fix processor name 
Change-Id: Ie6e0a0e3e42ce07f4a5a8334a4f4240c8c0fa64d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153624
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-08 22:03:46 +00:00
Jaime Wren 431b57cbbb Add an additional category into completion_metrics.dart: parameter references 
Change-Id: Ifed40f0eb0472894be92a41f105a6dfb36bcbb36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153367
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-07-06 22:39:39 +00:00
Jaime Wren 1a60f94fd0 Add two failing tests in the local_reference_contributor_test.dart, after some for(var foo ...) ^, the completion is in the implicit statement which is in the scope of the foo declaration. 
I imagine that similar tests could/ should be written for other such ASTs.

Change-Id: Iea059af339e5dec34a937ed2c28fe55fdb072fc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-07-06 17:06:10 +00:00
Danny Tuppeny 34ad5a5908 Don't reuse LSP error code that triggers shutdown for refactor errors 
Bug: https://github.com/dart-lang/sdk/issues/42573
Change-Id: I615563ed636cf48b4fe84e7588f49bb7137a4f53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-06 14:35:43 +00:00
Konstantin Shcheglov 326f7b4a8f Remove DartSdk.useSummary. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/149495
Reverted: https://dart-review.googlesource.com/c/sdk/+/149687
Change-Id: Ibd3f1af1aef83adc35f77cfbda66e07c5ae99922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-03 15:56:41 +00:00
Konstantin Shcheglov 9cfdc02e58 Stop depending on exports from generated/resolver.dart 
We cannot remove them completely just yet, there are users in google3.
But this CL will allow experimenting internally to track these users
and update them similarly.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Ic588b2873f9d5202783c8991f58e86bab28bd47e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-03 15:55:41 +00:00
Konstantin Shcheglov 4301899ed5 Track more Cider operation performance. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I95f2a36434556256dd5d55395cfc1bfca056763b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153068
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-02 23:33:59 +00:00
Jaime Wren 8afe9875a6 Some incremental changes in the new relevance algorithm to improve the completion quality 
Change-Id: I8a0a9e35c16bc497f54cd082241fa0b6d2cba7f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-07-02 04:17:09 +00:00
Konstantin Shcheglov 45201d6b12 Move checkAborted() from CompletionRanking to DartCompletionManager. 
I don't understand why it falls into the runZonedGuarded() error handler instead of being caught by `on AbortCompletion`.
It seems somehow related to the fact that we throw AbortCompletion inside an async function, but before any `await`.
IIRC we now execute this portion immediately, and actually return a Future instance only when we reach the first `await`.
Maybe this somehow affects the try/catch.

R=brianwilkerson@google.com

Change-Id: I192b5d410d9372205473b6032ef43c7c9880f9ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152906
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-01 21:51:54 +00:00
Jaime Wren fffa2bd30c Small change from https://dart-review.googlesource.com/c/sdk/+/153020 that Gerrit did not successfully patch before landing the PR 
Change-Id: Iac0907d353d7c39c84bbe5c9364c7888e481b694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152904
Auto-Submit: Jaime Wren <jwren@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-01 19:34:24 +00:00
Jaime Wren b08ade3748 completion_metrics.dart change- add an additional group, local references, when printing out the output 
Change-Id: I38601eb748d0247413725b62718bcabdb1e3e6fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-07-01 18:36:14 +00:00
Brian Wilkerson 5d064d2748 Add and use a feature based on the distance to a local variable declaration 
Change-Id: Id89e2e9bb417fa62095d4e81f9721a8d3c0893ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152901
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-01 18:19:44 +00:00
Eric Dallo 6d3928554c Add lsp-dart to lsp_spec README 
https://emacs-lsp.github.io/lsp-dart

Closes https://github.com/dart-lang/sdk/pull/42514
https://github.com/dart-lang/sdk/pull/42514

GitOrigin-RevId: cfa8edf358669c3ec2324a726a848fbc548bb6a3
Change-Id: Icaa90cdbb462b51fae6c186fe7626ca6168b9599
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152820
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2020-07-01 13:15:22 +00:00