dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4182 Commits

Author SHA1 Message Date
Konstantin Shcheglov ae1bee3859 Make AssistContributor asynchronous. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1461343002 .
 2015-11-20 12:18:26 -08:00
Brian Wilkerson 6b45d6544c Fix test failures on the bots 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1467623002 .
 2015-11-20 11:48:35 -08:00
Brian Wilkerson 1367d2d47d Clean-up the registration of plugins 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1460123002 .
 2015-11-20 08:14:14 -08:00
Konstantin Shcheglov 2b59830f49 Convert into block documentation comment assist. 
I found out that I don't like the /// style.
So, I'm going to convert the Angular2 analysis plugins to the block style.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1466623002 .
 2015-11-20 08:11:28 -08:00
Konstantin Shcheglov a689bf4180 Report error for ignored priority file. Ignore subscription for ignored files. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1462693002 .
 2015-11-18 17:31:58 -08:00
pq 3a1a3ee094 Embedded options discovery (#24943). 
Merges analysis options extracted from `_embedder.yaml` files (potentially) with local overrides.

Background: https://github.com/dart-lang/sdk/issues/24943

For test coverage of merging, see: `analyzer/test/src/util/yaml_test.dart`.

BUG=24943
R=brianwilkerson@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1445363002 .
 2015-11-18 16:41:27 -08:00
Konstantin Shcheglov abe8d87e0e Implement AnalysisServer.getContainingContext() using ContextManager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1455163005 .
 2015-11-18 14:10:35 -08:00
Brian Wilkerson bc0f99c95a Generalize API, fix bug, format/sort 
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1461763002 .
 2015-11-18 14:07:44 -08:00
Brian Wilkerson 905cb67e99 Add support for running git in tests 
Review URL: https://codereview.chromium.org/1453213002 .
 2015-11-18 09:37:14 -08:00
Konstantin Shcheglov 4ed3afeb5e Fix for mapping SDK files to 'dart:' URIs. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24873

Review URL: https://codereview.chromium.org/1457643002 .
 2015-11-17 17:20:15 -08:00
Brian Wilkerson 8c3722e92a Add server utilities for the stress test 
R=keertip@google.com

Review URL: https://codereview.chromium.org/1454813002 .
 2015-11-17 13:18:04 -08:00
danrubel 6a5ac59b9c process sorter analysis request(s) 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1449333002 .
 2015-11-17 10:38:41 -08:00
danrubel eee07a4815 update completion sorter to new API 
first step updating to the new completion API

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1447503002 .
 2015-11-16 23:01:43 -08:00
Konstantin Shcheglov de6925a23e Add ApplyChangesStatus to AnalysisContext.applyChanges() and use it in DAS. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1448173002 .
 2015-11-16 19:42:15 -08:00
John McCutchan bb4d547a5d Add _embedder.yaml support to analyzer and analysis_server 
- If a package has an '_embedder.yaml'  file with an 'embedder_libs' key two things happen:
  1) We do not use the DartUriResolver to resolve dart: libraries.
  2) We use the EmbedderUriResolver to resolve all dart: libraries

- If multiple packages have an '_embedder.yaml' file we merge them.
  - This might not be the final behaviour that we want but I'm not sure how to surface errors to the end user.

- The '_embedder.yaml' file has a top level key 'embedder_libs' which is a map from dart: library uri to source path. Other keys are ignored by the EmbedderUriResolver.

- Unit tests for analyzer
- Integration test for analysis_server.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1437893003 .
 2015-11-16 15:30:17 -08:00
pq 6d9cb5e48a Move diagnostics to diagnostics domain (#24931). 
Still flagged `experimental` so no docs created.

See: https://github.com/dart-lang/sdk/issues/24931

BUG=24931
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1453433002 .
 2015-11-16 14:10:10 -08:00
Konstantin Shcheglov 610401a8d5 Fix for the watcher leak. 
We need not just to cancel the subscription, but also to remove it from the map.

It's not so bad now for the MDL project, but any similar project will use a lot
of memory even after closign the project. This may be the reason of one of
the issues opened against DAS.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/24613

Review URL: https://codereview.chromium.org/1447603004 .
 2015-11-13 18:23:58 -08:00
Konstantin Shcheglov 31b1288f06 Fix for test - don't depend on the order of errors. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1434063002 .
 2015-11-11 14:03:54 -08:00
Konstantin Shcheglov 02fe5bcd5a Exclude 'doc' folders. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1439723002 .
 2015-11-11 13:10:35 -08:00
Konstantin Shcheglov a19b2985dc Fix for the case when a class appears twice in a type hierarchy. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1406403009 .
 2015-11-06 11:14:30 -08:00
pq 82e83bb34d Experimental getDiagnostics request (#24480). 
* Adds `getDiagnostics` request with *very* provisional diagnostics payload (primary goal here is to plumb this fully through and iterate).
* Updates codegenerator to skip doc generation for experimental APIs.

Additional context here: https://github.com/dart-lang/sdk/issues/24480.

BUG=24480
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1416093007 .
 2015-11-05 15:05:21 -08:00
Konstantin Shcheglov f49612ba51 Covering expression offsets/lengths integration. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1411973006 .
 2015-11-03 10:45:17 -08:00
Konstantin Shcheglov 069ba985de Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths. 
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1407333006 .
 2015-11-03 10:19:41 -08:00
Konstantin Shcheglov 128250a9ea Compute covering offsets/lengths. 
Drop support for binary expressions fragments.

Reduce number of reported problems, provide best guess results instead.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1431673003 .
 2015-11-02 18:22:12 -08:00
Konstantin Shcheglov 765c7fd0f1 Mark HintCode.CAN_BE_NULL_AFTER_NULL_AWARE as fixable. 
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/1428903002 .
 2015-10-30 08:02:29 -07:00
Konstantin Shcheglov 03eed1c3c9 Fix for duplicate priority sources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1408163008 .
 2015-10-29 17:46:00 -07:00
Konstantin Shcheglov 851dc4ea97 Quick Fix for CAN_BE_NULL_AFTER_NULL_AWARE. 
Also fix for false positive :-(

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1423993005 .
 2015-10-29 13:47:17 -07:00
Konstantin Shcheglov 7b75a53fef Fix for regions reported with multiple targets. 
We should merge them into single NavigationRegion(s) with multiple targets.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1403373018 .
 2015-10-28 16:38:12 -07:00
pq ff08fe58b6 Stop unwanted sharing between filter closures. 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1414863004 .
 2015-10-28 13:02:28 -07:00
pq 2f9c4af993 Error Suppression FTW. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1420363005 .
 2015-10-28 09:59:05 -07:00
pq c4ccdb462a LineInfo line-end detection fixes. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1413783005 .
 2015-10-27 09:39:30 -07:00
pq 808f32d61d Fix to give LineInfo to options error spans. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1417363007 .
 2015-10-26 21:09:48 -07:00
pq 52fb3b3bab Introducing a lint server plugin. 
Avoids introducing an unwanted dependency on the options plugin to server (efects discovered: https://codereview.chromium.org/1411313005/). Also soon to be future home for fixes and completions.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1410553005 .
 2015-10-26 12:11:38 -07:00
Konstantin Shcheglov cbea0dedf9 Issue 24714. Check other libraries that define unresolved class. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24714

Review URL: https://codereview.chromium.org/1413973007 .
 2015-10-26 11:32:59 -07:00
pq 68dc36a3e7 OptionsValidator plugin extension and linter service. 
* Adds a new extension point to allow for contributing OptionsValidators.
* Adds a new linter 'service' to server that contributes a lint-aware validator.

You'll notice that the warning code I added is NOT in `errors.dart`.  I did that in anticipation of plugin-specifc warnings living elsewhere.  If that's not the right angle, happy to un-do!

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1418333002 .
 2015-10-26 08:50:55 -07:00
Konstantin Shcheglov 289bd0a056 [Atom] Issue 424. Fix for 'getNavigation' and index expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424

Review URL: https://codereview.chromium.org/1402353009 .
 2015-10-25 11:29:54 -07:00
Konstantin Shcheglov 041e61a0f6 Ensure that RESOLVED_UNITx ready once for every library. 
...instead of ensuring this separately for complete closures of every library.

This improves initial analysis performance from about 44 seconds to 39.
This also makes WorkOrder.moveNext less expensive - to about 5.6% during initial analysis.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1412273004 .
 2015-10-23 13:25:56 -07:00
danrubel 5bd191ee12 fix import uri completion exception - fixes #24709 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1418123004 .
 2015-10-23 14:55:20 -04:00
pq afa746230f Lint option change propagation test. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1417963004 .
 2015-10-21 15:22:13 -07:00
Konstantin Shcheglov f18a0209fb Fix for 'Assign to Local Variable' in closures. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1415253002 .
 2015-10-21 13:20:22 -07:00
pq 6c85fe785a Analysis Options error notifications. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1411013003 .
 2015-10-21 09:59:19 -07:00
pq bf0ba96027 Analysis Options processing task and manager. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1413973003 .
 2015-10-20 15:38:55 -07:00
Konstantin Shcheglov c7907e7800 Support for searching files by import/export/part URIs and library identifiers. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1417483006 .
 2015-10-20 08:52:02 -07:00
Konstantin Shcheglov 5f71b2e7cd Check that AnalysisContext is not null. 
I guess this happens when a "resolved" CompilationUnit is not actially resolved.
I don't know why we get such units, but I saw this situation twice in IDEA.
So, probably we need to fix at least throwing NPE here.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1418513002 .
 2015-10-19 13:27:50 -07:00
Konstantin Shcheglov 5e9ea82aa4 Issue 24612. Skip excluded folder during contexts creation. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24612

Review URL: https://codereview.chromium.org/1411393003 .
 2015-10-19 13:17:11 -07:00
Konstantin Shcheglov ea947094ae Fix for suggesting methods as a *name* of a local variable declaration. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1417603002 .
 2015-10-19 12:29:22 -07:00
Konstantin Shcheglov efc1d4b224 Ignore contexts in folders named 'packages' or starting with dot. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24614

Review URL: https://codereview.chromium.org/1415713002 .
 2015-10-19 11:59:11 -07:00
danrubel 948b21a8cf (TBR) update test to run with new task model 
Review URL: https://codereview.chromium.org/1413963002 .
 2015-10-19 12:04:51 -04:00
Konstantin Shcheglov 3b198ed6ae Disable completion of formal parameter names as *types*. 
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org/1414653002 .
 2015-10-18 13:28:12 -07:00
Konstantin Shcheglov af4fbdd952 Index library/part file references from import/export/part containing files. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1407863004 .
 2015-10-18 10:24:53 -07:00