6d5efd3175
remove unused DartCompletionCache
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1536683003 .
2015-12-17 10:58:49 -05:00
0c6fb170dc
Do not suggest loop variable when completing expression in ForEachStatement
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1534793002 .
2015-12-17 10:57:51 -05:00
0de484bb8b
convert ImportedReferenceContributor to new API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1526303003 .
2015-12-16 21:17:27 -05:00
3bf298760f
extract InheritedReferenceContributor from imported reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1533613004 .
2015-12-16 16:20:53 -05:00
f13460e235
rename InheritedContributor to OverrideContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1523163004 .
2015-12-16 12:15:34 -05:00
70cd905c4d
Issue 25253. Improve collecting names that may conflict with the extracted local variable.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25253
Review URL: https://codereview.chromium.org/1528013004 .
2015-12-15 12:26:11 -08:00
62f8832770
cleanup LocalLibraryContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1527613008 .
2015-12-15 13:03:41 -05:00
f71ae984a9
Issue 25252. Stop collecting covering expressions at void invocations.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25252
Review URL: https://codereview.chromium.org/1528023002 .
2015-12-15 09:55:48 -08:00
56fe38f0ab
Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer)
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1527793003 .
2015-12-14 19:31:46 -08:00
6464160147
move LocalDeclarationVisitor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1529653003 .
2015-12-14 20:36:57 -05:00
5ff1ebe935
extract LocalLibraryContributor from imported reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1525753003 .
2015-12-14 20:31:50 -05:00
8a99902b94
suppress all dart contributor suggestions in comments
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1522003003 .
2015-12-14 18:50:18 -05:00
b44ed3e91e
Issue 25251. Fix for extracting string literal part with zero length.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25251
Review URL: https://codereview.chromium.org/1522193002 .
2015-12-14 12:56:59 -08:00
5c3fcf81c0
fix CombinatorContributor to only suggest public members
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1525713002 .
2015-12-14 14:21:01 -05:00
d8494d2f50
move LocalReferenceContributor to new API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1528633002 .
2015-12-14 13:57:51 -05:00
6824bd9b32
Fix for enum signatures.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1529593002 .
2015-12-14 10:53:08 -08:00
38a4193b5f
Issue 25244. Disable invalid overrides.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25244
Review URL: https://codereview.chromium.org/1519413002 .
2015-12-13 15:50:12 -08:00
2f0f398c73
Fix lints: unnecessary_brace_in_string_interp
...
Also fixes two cases of empty_constructor_bodies.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1521883002 .
2015-12-13 13:05:00 -08:00
86472f32ce
Move public API for elements into a public location
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1519283003 .
2015-12-13 10:48:56 -08:00
aca32e681a
Updates to the stress test
...
R=skybrian@google.com
Review URL: https://codereview.chromium.org/1514693013 .
2015-12-12 07:28:45 -08:00
7db8d0267d
extract LocalConstructorContributor from local reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1521753002 .
2015-12-12 10:01:22 -05:00
3a5a2d17ee
extract LabelContributor from local reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1514263004 .
2015-12-11 17:46:41 -05:00
168556a3e4
Tweaks for hover.
...
1. Include full signature of classes - extends, with and implements clauses.
2. Provide statis type only for variables - for all other elements the static type is always the same as in the signature.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1513943005 .
2015-12-11 14:25:46 -08:00
7ad6c0f1f9
extract LibraryPrefixContributor from imported reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1517693004 .
2015-12-10 22:42:53 -05:00
59c3ed6ded
simplify contributors by resolving declarations in scope
...
once rather than requiring each contributor to do so.
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1520613003 .
2015-12-10 17:41:03 -05:00
62656833d4
Wraps up the server-side of the 'Allow a user to configure which hints are "fatal"' ask ( #24452 ).
...
* migrates error filtering from a predicate to a process that can customize severities.
* moves filtering/processing from the `dart` task into the `getErrors` request and the errors notification.
See: https://github.com/dart-lang/sdk/issues/24452
(Pending a thumbs-up, support for CLI to follow.)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1517723002 .
2015-12-10 13:35:11 -08:00
f93d4fde97
Issue 25219. Fix for RangeError during converting empty lines in /// comments.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25219
Review URL: https://codereview.chromium.org/1518723002 .
2015-12-10 10:08:07 -08:00
37d52a5d1c
do not suggest completions for cascade on library prefix - fixes #25215
...
add CompletionRequest dotTarget
add CompletionTarget offset and isCascade
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1516883002 .
2015-12-10 11:57:26 -05:00
e48f962af1
Validate that root paths are absolute and normalized.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25203
Review URL: https://codereview.chromium.org/1511833004 .
2015-12-09 15:05:22 -08:00
29a44c7b4c
remove argument list suggestions - fixes #25197
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1514613003 .
2015-12-09 16:06:53 -05:00
d54fb071a9
do not suggest import uri reaching out of lib
...
related to https://github.com/dart-lang/sdk/issues/22358
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1509373005 .
2015-12-09 14:38:49 -05:00
824a012d8f
do not suggest static methods from superclass - fixes #24258
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1509723004 .
2015-12-09 14:37:03 -05:00
830a37afae
suggest after import prefix in part files - fixes #25023
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1514603002 .
2015-12-09 14:35:30 -05:00
1f5973e24e
Explicitly specify that FilePath is not just absolute, but also a normalized path.
...
It was implied, and every client I know of uses absolute and normalized paths.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1506323002 .
2015-12-09 11:30:54 -08:00
2fdcb1bd74
Promote diagnostic.getDiagnostics() ( #25061 ).
...
* removes rolling average support
* removes "experimental" tag
* bumps API version
Fixes #25061 .
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1509033003 .
2015-12-09 09:29:26 -08:00
e9a77de7dd
suggest yield and yeild* - fixes #24346
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1511553005 .
2015-12-09 12:03:12 -05:00
e03c395a8c
extract TypeMemberContributor from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1504223005 .
2015-12-09 07:38:20 -05:00
b05ae45575
Extract Local refactoring: provide a linked edit group for the name.
...
This will support in-place rename after extract in IDEA.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1502183007 .
2015-12-08 15:27:05 -08:00
dcacf6145b
extract LibraryMemberContributor from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1507303002 .
2015-12-08 15:10:32 -05:00
c66a5d3fb5
suggest async* and sync* - fixes 24554
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1509193003 .
2015-12-08 15:07:35 -05:00
72cf3cbe91
Remove unnecessary 'noSuchMethod' declarations.
...
Also format these file.
I don't like how the new formatter changed the code :-(
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1507813004 .
2015-12-08 11:39:37 -08:00
4c28eb6f67
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-08 10:16:29 -08:00
1e4cea355f
Embedded option processing fixes ( #25115 ).
...
* Updates error filter and linter configuration to play nice with embedded options.
* Fixes embedded lint config (#25115 ).
* Improves support for (and tests of) options file deletions.
* Pulls in linter with untyped options support (needed for processing merged options).
Unblocks: https://github.com/flutter/flutter/issues/624 .
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1503353002 .
2015-12-07 16:18:47 -08:00
088b50f8a9
extract StaticMemberContributor from PrefixedElementContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1505703003 .
2015-12-07 17:15:14 -05:00
20909182b0
add suggestion for partial named parameter - fixes #24758
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1504233002 .
2015-12-07 17:13:06 -05:00
aed5431106
Issue 24988. Parse source for sorting.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24988
Review URL: https://codereview.chromium.org/1507083002 .
2015-12-07 14:01:24 -08:00
ea3ba0e31f
Remove deprecated code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1502213002 .
2015-12-07 10:24:36 -08:00
89168a1956
add completions in assert stmt - fixes #24888
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1509523002 .
2015-12-07 12:51:02 -05:00
55a8740ba1
extract named constructor suggestions from prefixed element contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1507633002 .
2015-12-07 11:58:39 -05:00
de3a1b22c8
Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27
2015-12-07 07:04:07 -08:00
Dan Rubel