Commit Graph

4182 Commits

Author SHA1 Message Date
Paul Berry f9aebddc67 Ignore added files in hidden directories.
In commit 6ddc37a5cc, the ContextManager
was modified to disable analysis of files in hidden directories,
provided those files existed prior to the creation of the context.
This CL extends the fix to apply also to files that are added after
context creation.

Fixes #24212.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1372173004 .
2015-09-28 14:10:32 -07:00
Konstantin Shcheglov 5bc38481a7 Report a fatal error on attempt to rename an element declared in SDK.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1377623002 .
2015-09-28 14:00:13 -07:00
danrubel 6cd9e0da71 Do not suggest static fields in constructor initializer - fixes #24256
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1365403002 .
2015-09-26 11:59:15 +02:00
Konstantin Shcheglov 6bab7d9cbc Use Element.nameLength where possible.
...or don't use it when there is a better alternative.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372673003 .
2015-09-25 15:03:46 -07:00
Konstantin Shcheglov 6c029f9cb1 Issue 24440. Fix for renaming libraries using 'part of' directives.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24440

Review URL: https://codereview.chromium.org//1364853007 .
2015-09-25 14:24:05 -07:00
Konstantin Shcheglov 4f8649f1b3 Issue 24442. Fix for renaming library names with spaces.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24442

Review URL: https://codereview.chromium.org//1370793003 .
2015-09-25 13:55:13 -07:00
Konstantin Shcheglov 83f94a2114 Add navigation region for 'library' directives.
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1373593002 .
2015-09-25 12:35:51 -07:00
Konstantin Shcheglov df827a06ae The 'analysis.implemented' notification implementation.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1368793003 .
2015-09-25 12:33:02 -07:00
Konstantin Shcheglov da29a447c4 New analysis.implemented notification specification.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372623004 .
2015-09-25 09:57:29 -07:00
Keerti Parthasarathy 6f775acc7b add performance tests
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1366923003 .
2015-09-25 08:35:42 -07:00
Konstantin Shcheglov 805f6ec3ba Record HAS_ANCESTOR relations into index.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1371463002 .
2015-09-24 16:21:09 -07:00
pq d869088ea3 Error handling for bad .analysis_options files.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1364813003 .
2015-09-23 13:27:19 -07:00
Konstantin Shcheglov 6899986bfe Use TypeSystem in the 'Extract Method' refactoring.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1364803003 .
2015-09-23 10:28:50 -07:00
Konstantin Shcheglov 5fd8b38737 Tweak navigation for 'part of' directives.
This makes it consistent with import/export/part directives, where only URIs are navigation sources.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1365663002 .
2015-09-23 10:14:49 -07:00
Konstantin Shcheglov 4aa6466ccb Use IndexContributor(s) in LocalIndex.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359113002 .
2015-09-23 08:17:33 -07:00
Konstantin Shcheglov 531f1d1e5b Extract Dart specific node management into DartUnitIndexObjectManager.
We want to be able to index not just CompilationUnitElement(s), but also
for example results of Angular resolution, which while are based on resolved
CompilationUnit(s), are not ready together with it, so should live in separate
split index nodes.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359023002 .
2015-09-22 12:26:41 -07:00
Konstantin Shcheglov f67bc2f546 Replace NameElement with IndexableName.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1347943006 .
2015-09-21 12:02:34 -07:00
danrubel d6051a53a0 refactor ContributionSorter to use new API
move CompletionTarget to public API
modify DartCompletionRequest to return completion target

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1347283005 .
2015-09-18 16:03:22 -04:00
Brian Wilkerson 42593f4094 (TBD) Disable broken test
Review URL: https://codereview.chromium.org//1358493002 .
2015-09-18 09:17:01 -07:00
Brian Wilkerson f4b1879180 Add a completion for inherited methods
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1338173002 .
2015-09-18 08:59:56 -07:00
danrubel b96b1cfc5d Add defaultCompletionSorter allowing sorting to be overridden - fixes #24339
I will convert CompletionSorter to use the new completion API in a subsequent CL.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1353913002 .
2015-09-17 14:59:48 -04:00
Konstantin Shcheglov 75600fc162 Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1345943006 .
2015-09-17 10:37:04 -07:00
Konstantin Shcheglov a01281370b Fix for dynamic instance field reference highlighting.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1349223002 .
2015-09-17 09:25:22 -07:00
Konstantin Shcheglov d71bda7c05 Highlight library identifiers as LIBRARY_NAME.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1352843002 .
2015-09-17 09:24:14 -07:00
Brian Wilkerson b233ab26ad Remove unused setter from ServerStarter and un-deprecate a used setter
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1341343002 .
2015-09-15 09:38:56 -07:00
Konstantin Shcheglov cf88943a10 Issue 24338. Don't propose creating a local class for prefixed identifiers.
Importing with prefix would take more time than I'd like to spend now.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1336323003 .
2015-09-14 08:17:18 -07:00
Konstantin Shcheglov e4b7c93961 Merge occurrences.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1338153002 .
2015-09-14 08:10:02 -07:00
Konstantin Shcheglov ef2fc0d778 Add OCCURRENCES_CONTRIBUTOR_EXTENSION_POINT_ID.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1337143002 .
2015-09-11 13:59:28 -07:00
Konstantin Shcheglov d13a9ec666 Rename NavigationHolder to NavigationCollector.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1307663007 .
2015-09-09 13:27:24 -07:00
Konstantin Shcheglov cfc52cfbbf Make NavigationOperation a MergeableOperation.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1327173002 .
2015-09-09 11:01:01 -07:00
Konstantin Shcheglov 0e6eec7968 Make navigation notification operation Source based, without Dart knowledge.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1307143004 .
2015-09-09 10:02:12 -07:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
2015-09-09 08:19:18 -07:00
Paul Berry b39928e01d Ignore non-existent analysis roots.
Fixes #24242.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//1316753003 .
2015-09-08 05:36:30 -07:00
Konstantin Shcheglov f0cbf430e0 Issue 24298. Fix for 'async' function body conversion.
R=paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/24298

Review URL: https://codereview.chromium.org//1324323004 .
2015-09-04 21:39:28 -07:00
Konstantin Shcheglov dfd09f3f66 Extension point for AnalysisResultListener(s).
The plan is that plugins will listen for computed results. For example the Angular
plugin will listen for DART_TEMPLATES and once it sees one, it will schedule
sending the navigation notification, because now the other extension - NavigationContributor
can produce its navigation regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303343008 .
2015-09-04 09:56:27 -07:00
Konstantin Shcheglov 13d5a4744d Support for 'superOnly' in 'search.getTypeHierarchy'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1322323005 .
2015-09-03 14:29:48 -07:00
Konstantin Shcheglov 58f5005cb1 Add the optional 'superOnly' request parameter for 'search.getTypeHierarchy'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1325543006 .
2015-09-03 13:03:01 -07:00
Konstantin Shcheglov e090ff872e Issue 24277. Use node's offset as the source range start for the first unit node in Outline.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24277

Review URL: https://codereview.chromium.org//1325143003 .
2015-09-02 17:55:15 -07:00
danrubel 07184f6cdd rename ImportUriContributor to UriContributor
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1329463002 .
2015-09-01 11:11:36 -04:00
danrubel 773c3cf9d1 improve import uri completions - fixes #24000
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1325583002 .
2015-08-31 15:21:34 -04:00
Dan Rubel c0fe214c47 show all available import completion suggestions - fixes #23955
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1317023002 .
2015-08-26 17:37:01 -04:00
Dan Rubel bd95b13b90 improve keyword suggestions - fixes #24016
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1303233008 .
2015-08-26 17:34:57 -04:00
Dan Rubel f61faa2fbd exclude instance suggestions in static context - fixes #22932
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1319753002 .
2015-08-26 14:00:03 -04:00
Brian Wilkerson 271bc1f776 Convert completion API to be future based
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1318543002 .
2015-08-25 11:01:13 -07:00
Brian Wilkerson 4bd6b4b048 Fix display of parameter lists in servers Element structure (issue 24194)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1313113002 .
2015-08-25 09:23:26 -07:00
Konstantin Shcheglov aea1e572a1 Sort top-level constants before other top-level variables.
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1306083003 .
2015-08-21 12:19:48 -07:00
Paul Berry 03a156c891 Plumb "enableSuperMixins" option through analysis server (implements DEP 34).
Partially addresses #23772.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1301533003 .
2015-08-20 09:47:26 -07:00
Paul Berry 8f2ed2c68d Fix most implementations of UriResolver.restoreAbsolute.
Although it wasn't previously clear in the documentation,
implementations of UriResolver.restoreAbsolute() should only depend on
Source.fullName.  To do otherwise breaks some assumptions made by
analysis server.  This CL fixes all implementations except
SdkExtUriResolver (which has been deferred to issue #24090).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1296653003 .
2015-08-18 11:32:15 -07:00
Konstantin Shcheglov 7e99b8696e Support for analysis.setPriorityFiles for files in SDK.
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/215

Review URL: https://codereview.chromium.org//1289643003 .
2015-08-17 10:48:38 -07:00
Dan Rubel 0aaa3bd0a4 reformat and 2 new tests for #23501
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1290743003 .
2015-08-17 11:20:20 -04:00