93448a47c6
Migration: change trace view to alternate between edges and nodes.
...
Previously, we only included edges in the trace view, which resulted
in a lot of missing information. Generally the reasoning process
looks like "type at A is nullable because of an expression at B, which
propagates nullability from a type at C, which is nullable because of
an expression at D, etc." This change makes the trace reflect that
reasoning process better.
Change-Id: I27d1b7aac736529b6f1fa2f7be8dea0d3eca9a6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139064
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-03-11 21:30:40 +00:00
4e55949fa6
Refactor RemoveUnusedLocalVariable and fix for locals outside of function bodies.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Idfb85bbe97a48055fc96dc5441618b7889a7cc00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 18:19:40 +00:00
60dd17d053
Add the void keyword into additional missing portions of the AST in the keyword_contributor.dart - type arguments and method invocation type arguments
...
Related PR: https://dart-review.googlesource.com/c/sdk/+/138743
Change-Id: I085cb0718ae00867e245fc13ef219e738306f14e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138914
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-03-11 15:29:59 +00:00
37530145ff
Extract RemoveUnusedLocalVariable producer.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I0d0d7cccd0adb064f87bb1b9e656cad49f03a2e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139033
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 06:01:29 +00:00
ace1d9b921
Do not repeatedly analyze a full library per part when dartfixing.
...
Migration performance improves 10x on web_ui with this CL.
Also fixes a heisenbug in the linter code where identical uniqueNames
for LintCodes could wind up in objects that compare differently.
Bug: https://github.com/dart-lang/sdk/issues/40915
Change-Id: Iddddfd7659f4bc724ddf21ebae41750a0ee51e74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2020-03-10 21:16:11 +00:00
cc85d28e60
Migrator: Add preliminary styles to stack trace
...
Change-Id: Iac8fdccb18b5ba04b058236ac1ee9b60643f67cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138924
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-03-10 21:06:10 +00:00
d673c176ae
Start implementing new relevance scores for members of a type
...
Change-Id: I5594da6c9f1b71d239593131c02b5b10a57a4725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138907
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-10 17:28:51 +00:00
b311a0052e
Fixes REMOVE_UNUSED_FIELD and optional field formal parameters.
...
R=brianwilkerson@google.com
Change-Id: I15587001262ed70fb6e4b740fee12542acb6b1a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-10 15:50:00 +00:00
83378633e1
Add the attachment with the content of the file being analyzed.
...
Change-Id: I75b1c61e2d04cd5e03ef4375e97ef3c9f4add874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-10 04:57:20 +00:00
043af430c1
Migraiton: Add function names to trace output.
...
This makes them look a lot more like real stacktraces.
Change-Id: I0c060f72f8676ab6d5c0272532b90931b815fddf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138607
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-03-09 22:00:59 +00:00
f8792406d8
Extract RemoveUnusedElement and RemoveUnusedField producers.
...
There is an exception that we see internally, and I'd like to try to
refactor the code a bit.
R=brianwilkerson@google.com
Change-Id: I276e009437fd3cac82391126bde95c73225bca0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138784
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-09 20:06:10 +00:00
54e96f6ccf
Add the dynamic keyword into additional missing portions of the AST (in method and constructor parameters) in the keyword_contributor.dart
...
Change-Id: Idd394dc19992fa6406783a53ad50ebf58cf8f60f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138785
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-03-09 19:36:34 +00:00
8329bd7ca8
Do not check for '.analysis_options' for default options file in builder.
...
Change-Id: I9decba4d0db318caedcfd3695f41c127b66f416f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2020-03-09 19:31:24 +00:00
fa2df01895
Null Safety preview: Fix description for uninitialized field
...
Fixes #40773
Change-Id: I7639364820785f5a877917afbbb62ab9c09eff00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138781
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-03-09 18:34:17 +00:00
4e79175ee8
Fix per-line highlighting in Null Safety preview tool
...
Screenshot: https://screenshot.googleplex.com/Wi59xaxaEpx
Change-Id: Ib0fc98dafe77f49443b024af1b2fa2f505e470ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138780
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-03-09 16:23:37 +00:00
a629dbf073
Add a fix to inline a typedef
...
I needed to fix AST nodes for parameters to know about the required
token when computing the beginning token and child entities.
Change-Id: Icb0fc27bc1e9f6650376f5870944fb8f592a5e8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138744
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-09 14:17:07 +00:00
7e815546ac
Add the dynamic keyword into additional missing portions of the AST in the keyword_contributor.dart
...
Change-Id: I64ff9721c151e3e51841ea638e8b2fd2b472ac27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-03-09 05:34:00 +00:00
de493465c8
Include 'dynamic' in the list of suggested keywords for type names, i.e. the 'dynamic' in "dynamic contents = ..."
...
Change-Id: I8e388a2b8077140cb7e0047e1f16c36ea12aded5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138612
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-03-06 23:09:54 +00:00
48c6180b46
[nnbd_migration] Hide hint insertion links after the migration is applied.
...
Change-Id: If89b16ec1c4e26e4aa1fb03fc262075c75eac526
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138389
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-05 19:26:44 +00:00
123a1ea517
[nnbd_migration] Fix 'apply edit' links.
...
Previously we would do a POST, but not prevent the default action of
clicking on the link, which is to navigate the browser.
Also, the URLs we generate begin with 'http' and therefore the
absolutePath call is not needed, and in fact, breaks the URL.
Change-Id: Iff0c2820ee0cdc951f82807f9535900a1e0e7ae1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138383
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-05 19:26:44 +00:00
3629658722
[nnbd_migration] Handle POST requests
...
Change-Id: I4e609c249e99366177f5e35861986eef4b683eee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138332
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-05 19:26:44 +00:00
a74253987b
Migration: add trace functionality to the preview tool.
...
This establishes the base functionality. A lot of follow-up work is
needed from here:
- Each trace should have an entry at the top of it pointing to the
thing that was made nullable.
- The source code links in traces don't include lengths, so we can't
highlight whole identifiers when the user clicks on a link.
- Description strings are currently generated by running toString() on
the individual nullability nodes and edges, resulting in long-winded
and useless descriptions.
Change-Id: Ibb370bae6bedc7a8c86092462785023002a48ac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138481
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-03-05 17:21:54 +00:00
c2fc5f9756
[dart migrate] tweak the verbiage for dart migrate
...
Bug: https://github.com/dart-lang/sdk/issues/40881
Change-Id: Ie5b63410a926462352858f8d4341e79a8c332be5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138480
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-03-05 16:51:04 +00:00
d3fd44182d
Fix crash in declaredParameterElement().
...
R=brianwilkerson@google.com
Bug: b/150742402
Change-Id: Ia72179f934579f1eb6861bf8b6cc955168e10136
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-04 19:42:16 +00:00
d83efc38f9
[nnbd_migration] Apply the changes to disk on apply-migration request
...
This integrates fairly well with the new dartdev ux. We may be able to
improve the wording, etc., but given the fact that it has to be rerun
with --apply-edits, there is no need to notify anyone that the edits
occurred (currently). I'll take another look at potential wording
improvements in a follow-up CL.
In the dartfix ux, the dartfix driver doesn't get notified of the
changes and will ask if you want to apply, and this is not as good :) If
you say yes, you will apply the edits twice. Given that there is already
a CL to delete that code, I didn't change this in dartfix and don't plan
to.
Change-Id: Ie822a5761d05b3dd08b5a793f812a331d4657598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138203
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-04 18:42:56 +00:00
9eb655ee66
[nnbd_migration] Preserve "migration applied" state across reload.
...
Change-Id: I30e0dd282b4d50ad416cd1ac9aa3d1c0bc58037f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138202
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-04 18:42:56 +00:00
28a607c598
[nnbd_migration] Send request to server from apply migration button.
...
There are existing TODOs about how we should only handle POST and not
GET. In my tests, it looks like POST is not currently wired up at all.
This will make the apply migration button work, and from what I can tell
will also make the "add hint" buttons work (they likely aren't working
right now).
I'll revisit this and switch it to POST in a later CL. It requires a bit
of rewiring in the preview server.
Change-Id: Ie8541d29b3b9cbcc151c4b57b26b36e8a7a92246
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138201
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-04 18:42:56 +00:00
99d02a1ef8
[nnbd_migration] "Apply migration" button ux/styles
...
Change-Id: I28d474bf07f66cb5f582e8a190046fea78e7d7b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138107
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-04 18:42:56 +00:00
bb40d68956
quote fix
...
In accordance w/ `prefer_single_quotes`.
Change-Id: I2df4522c437a305ae5e43814295e507388de3027
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138320
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-04 18:20:36 +00:00
ed1091af3e
Add two fixes for avoid_returning_null_for_future
...
Change-Id: I6ece892025233fe3dd51ececb7b92368be9669ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-04 17:26:45 +00:00
027f9588e1
Fix replace_null_with_closure when the parameter type has no parameter names (issue 40578)
...
Change-Id: Ie85294e1925a1d3880416ef4ceed86052e1534e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138140
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-03 18:51:23 +00:00
48ae192635
Prevent a crash when we have a -1 offset.
...
Bug: https://github.com/dart-lang/sdk/issues/40827
Change-Id: I1d76655410945bb0e8f7a58f71cc00aaf97d375e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138047
Commit-Queue: Janice Collins <jcollins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-03 17:46:01 +00:00
8fa6e9d20e
Migration: separate EditLink and TargetLink models for preview tool.
...
The preview tool's "edit details" box handles two kinds of links:
links allowing the user to request a change to the source file
(i.e. adding/removing hints), and links allowing the user to navigate
to a target. Use separate data structures for these two kinds of
links, because they store different data.
Change-Id: I41bdf7fc9c94fc28e703da34d67d8c20f6f86108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138012
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-03 16:42:51 +00:00
179f2caf14
Migration: update region_renderer_test to use new EditDetails data structure.
...
Change-Id: I4103eb63f752b91fb679d024b27ed63b5fca4551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138048
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-03 16:42:51 +00:00
aaa63b511c
Make migration codegen traverse directories in a stable order.
...
Fixes #40505 .
Bug: https://github.com/dart-lang/sdk/issues/40505
Change-Id: I846c4262845a30417ae2cac91997a65692473e42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138060
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-03-03 16:42:51 +00:00
33b2df4600
Migration: create object model for edit details.
...
We still exchange information between the client and server in JSON
format, but on the server side, we build the object and then serialize
it (rather than build the JSON directly); conversely, on the client
side we deserialize the JSON back into objects and then use them.
This makes the data interchange format easier to understand because it
is captured in class declarations.
Change-Id: Ia20293ce2713aa1793baf6e7ca8141da5615ab4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138011
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-03-03 16:42:51 +00:00
ca3ad264a6
[nnbd_migration] Report info building exceptions to server adapter
...
Change-Id: I4e3eef0d3e404bd090f36f8b2516abb97cc6c311
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137520
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-03-02 23:33:06 +00:00
1cb188e2a1
[nnbd_migration] Add assertions that we produced good explanations.
...
Change-Id: Id09c64304eb1ffce51ccfde33403dec5f8498072
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137122
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-02 23:33:06 +00:00
581bfee7a9
Convert AssistProcessor to use new contributor methods
...
Also use `List<Object>` rather than `List<dynamic>`.
Change-Id: Iba95b09cc7c468b67194f53d30cffbcdeaf10671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138016
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-02 23:22:47 +00:00
dda9290461
Add a fix for use_full_hex_values_for_flutter_colors
...
I also extended the framework to allow arguments to be returned so that
the fix messages can be parameterized. I'm not super thrilled with the
extra return statements everywhere, so if you have suggestions for an
alternate approach I'm happy to hear them.
Change-Id: Ie7c7133d83df4aa54b198125477fcbbc0ab8f5ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-02 22:04:26 +00:00
1c590fd8cd
Migration: Sort declarations in migration.dart
...
Change-Id: Iff9fbf1fcd7b94aa4b71099274aec4d6356d9149
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138005
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-03-02 20:24:42 +00:00
1c34d8ce57
Add a new command-line flag for server to enable the new relevance computations
...
Change-Id: If4c9e95a6e5e804fe480cf8a061ff95ec37651e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138002
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-02 18:55:32 +00:00
3ae91fc8c5
[nnbd_migration] Add an edge origin for return;
...
Change-Id: I94e56933c4fb8d8c8b80ca0c427fc34c56674d04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137841
Reviewed-by: Paul Berry <paulberry@google.com >
2020-02-28 23:26:22 +00:00
e9df1ee07a
[nnbd_migration] Add an edge origin for inferred parameter substitution
...
Change-Id: I37ce933e05a6b7ad7b8fdcc26f44968ae92516be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137658
Reviewed-by: Paul Berry <paulberry@google.com >
2020-02-28 23:26:22 +00:00
c0bcfb7d0c
[nnbd_migration] Add a description for type parameter instantiation
...
Change-Id: Id8e3c4c98f3569b794e90d8a7a74d245f6f89504
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137648
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-02-28 23:26:22 +00:00
34fcc56458
Fix for renaming named formal parameters from invocations, when synthetic.
...
R=brianwilkerson@google.com
Change-Id: I4dc57cfc2a941229f2ba8b8b262ed49ecdd6b170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-28 23:11:00 +00:00
f1e60ccf03
Fix REMOVE_UNUSED_ELEMENT crash when not the only variable.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I5201d957f59aa9f81478ab51db5870ec57ad6868
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137845
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-28 21:54:40 +00:00
3cf8c3d4b6
Issue 40243. Flush Flutter widget descriptions on a file change.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/40243
Change-Id: Iecd2a0bd4053588dfb93445918656df65bf4b60e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137738
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-28 21:08:30 +00:00
3852fe2d79
Fix for cast exception in LintNames.empty_catches fix.
...
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I965ec72d98f3bc3edb9d04c7d1d254603e2e3f13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-28 20:24:00 +00:00
289c5db588
[dartfix] update the readme for trying out the migration tooling
...
Change-Id: I30b12213deb4f85a25f5a0fd91c3756b0c69cbb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137644
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-02-28 18:54:05 +00:00
Paul Berry