dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4618 Commits

Author SHA1 Message Date
Brian Wilkerson 7e0190a6d7 Add new relevance values for field formal parameter suggestions 
Also updated a comment that I missed from the last CL.

Change-Id: Ibfcce19998532c672b9990308cd7b03fd42d14cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140772
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-24 20:46:27 +00:00
Jaime Wren 81894b958f Fix another case of the form described in https://github.com/dart-lang/sdk/issues/41039, this fixes the FunctionDeclaration case. 
Bug: https://github.com/dart-lang/sdk/issues/41039
Change-Id: I03df7f8d92b1e7754410dc88e1c09ad83476960e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140769
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-24 19:11:15 +00:00
Brian Wilkerson 2d0fed35bb Update the ArgListContributor to have new relevance scores 
This also includes a new metric computation showing how often function
typed parameters have closures as arguments.

Change-Id: I8999cc3935bcc7514ebba90a8a4d246b2f236c42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140702
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-03-24 17:00:55 +00:00
Mike Fairhurst 799560bff7 [nnbd_migration] Remove language version comments during migrate 
Bug: 41095
Change-Id: I3262d6da485d78fee1e2dfe4ac22692c5e4b6daf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140369
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-24 16:44:05 +00:00
Sam Rawlins 5a1a83275c Migrator: Scroll the Edit Details panel into view when refreshing the contents 
Change-Id: I577d165189c0a790774f2ac7c44fe9c70367bfbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140370
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-24 14:12:49 +00:00
Devon Carew 1e45051341 [analyzer] initial implementation of SDK, file based configuration of the analysis server 
Change-Id: Iff3808fb073b062fa566993e7f05e2669a5fde7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140003
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-24 14:07:59 +00:00
Jaime Wren 6219daa274 Preventatively check for null from the return of AstNode.findPrevious(..). This was the only instance of a missing null check in analyzer, analyzer_plugin, analysis_server and analyzer_cli. 
Context: https://dart-review.googlesource.com/c/sdk/+/140245 (cases in code completion)
Bug: https://github.com/dart-lang/sdk/issues/38681
Change-Id: I951811034976041c425e74a52f33d27f13781015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140253
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
 2020-03-23 18:08:16 +00:00
Jaime Wren 6f76f194b1 Fix the common case of https://github.com/dart-lang/sdk/issues/41039, around MethodDeclarations 
Code completion will now include void, dynamic and other class declaration keywords in the return type location, in the following snippet: '@override void someMethod(...) {}'

This is relatively common, this happens 103 times in the collection package.

Bug: https://github.com/dart-lang/sdk/issues/41039
Change-Id: I28129f2d735d2ff7d0a0e65194b7963c74b01c51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-23 18:03:44 +00:00
Sam Rawlins 0fdc2816c0 Migrator: Improve scrolling behavior for elements near top or bottom 
Change-Id: I24f951d6e16b8175e15af1bff32ed0d7d58a39b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140367
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-20 23:17:15 +00:00
Jaime Wren 6238c6c0f9 Add missing null checks for return values from AstNode.findPrevious(..) 
The documentation on [findPrevious] reads: "Return the token before [target] or `null` if it cannot be found."

Bug: https://github.com/dart-lang/sdk/issues/38681
Change-Id: I3f9d0418e7ea4efa5190da895a3932bf91f160d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140245
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-03-20 17:52:12 +00:00
pq a3499f0849 quickfix for prefer_const_constructors_in_immutables 
Fixes: https://github.com/dart-lang/sdk/issues/41097

Change-Id: I2ff001437ff4a4174bc7ba10b9f6ea5fab89317e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-03-20 17:04:29 +00:00
Jens Johansen 71e05a8d37 [analyzer] Make setters work in 'Add explicit 'show' combinator' 
Fixes #41069

Change-Id: I12586b761b92b25be592bb61b4df11a0f1ebbfe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-20 08:19:40 +00:00
Devon Carew 3f8366363b [nnbd migration] move the docs for the NNBD migration tool 
Change-Id: I932da23be10839b5bde6034f120763c54f63889f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140102
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-03-19 23:12:24 +00:00
Brian Wilkerson a5c2d2aa71 Add new relevance support to the OverrideContributor 
I couldn't think of any useful features to use when ranking overrides. I
briefly considered `deprecated`, but even deprecated members might need
to be overridden until all implementation of the member can be deleted.

Change-Id: I994d4177b1111ebdf44a223f975422779c5a8ae8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140005
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 22:48:39 +00:00
Brian Wilkerson 63738baa4b Add relevance support to InheritedReferenceContributor 
Change-Id: Ib5d518034a766de369da3b5bad1bc0ce1cb8cda4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140145
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 20:56:58 +00:00
Sam Rawlins a225178919 Trim not useful bottoms off of the non/nullability stack traces 
Change-Id: I2f7bfab13fd3d70c5cbdbb10ce14a8a91f8c7a60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140000
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-19 18:13:33 +00:00
Brian Wilkerson dcdde433b6 Use the deprecated feature for static members 
Change-Id: I718a30d9c392ebae2fe611b402c13cdb60a90825
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140080
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 16:09:59 +00:00
Brian Wilkerson 2a2855c781 Perform new relevance computations for extension members 
Sorry for the size of the change.

This started out looking like a fairly simple task of repeating the work
done for type mambers, but it was too similar so I ended up doing some
refactoring in order to share the code.

Along the way I realized that we didn't yet have a feature for demoting
deprecated members, so I added it.

Then I discovered some more places where the old and new logic were
getting intertwined, so I straightened that out as well.

Change-Id: Ic24babd30bbbeeae9709a8019642e497a2ebb65d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139949
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 13:34:19 +00:00
Paul Berry 75a720f2fb Migration: in preview tool, links in edit details should not clear edit details 
Change-Id: I30336e93b9d3d579d1ef8c91d3a21d68b0e4aeb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139946
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-18 21:40:02 +00:00
Paul Berry 3b0b0eb6dd Migration: reorder data in "Edit Details" box 
This CL moves the "edit rationale" section down to the bottom, and
marks it as "experimental", since it doesn't seem to give as useful
information as the traces.

Change-Id: I5c45c31d9cfcee89bf03b1ef8803f4a59ac180e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139945
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-18 21:24:32 +00:00
Paul Berry 40976c6000 Migration: remove "Nullability trace for" text from preview tool. 
It was redundant with the text in the trace description.

Change-Id: I7970cede15fe620440e3a05adb987ea451ac9f16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139943
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-18 21:18:22 +00:00
Paul Berry 096bf5769d Migration: add "why not nullable" traces to preview tool. 
Change-Id: If945d32f33124e5e85429bd76c1db14167c0024e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139960
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-18 21:18:22 +00:00
Paul Berry 41b67a9b52 Migration: add grayed-out spaces to indicate types not being made nullable. 
Change-Id: I4fa076693c25cf9466d33332030df3983043ffd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139940
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-18 21:18:22 +00:00
Brian Wilkerson 23abbd30b8 Set a default relevance for cases where none of the features apply 
Change-Id: I7fd837349965ce7710fd99daacd691b30bf25100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139841
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:27:30 +00:00
Brian Wilkerson 8c07071afb Use context type in the static member contributor 
I couldn't think of any other features related to static members. Please
let me know if you can think of any.

I need to modify the metrics utility to be able to differentiate between
static and instance member references in order to measure the impact of
this approach. I'll look into doing that today. I suspect that we'll
eventually need it to split out results in many more ways as well.

Also updated some comments in an attempt to make it easier in the future
to determine which contributor to look at for bug fixes or enhancements.

Change-Id: Ieef62c6189bbfbd35283abdf35b8cbdd17746ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139820
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 17:27:46 +00:00
Paul Berry d9ce4d57aa Migration: create data structures for the navigation tree view. 
Change-Id: I482b07d3ae2025cf3a9375a02ddaa509beabc2de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139780
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-17 17:19:41 +00:00
Paul Berry 87cc6c76ca Sort declarations in navigation_tree_renderer.dart 
Change-Id: I3689bc8e6079252cead246bfd0a8402b8f60da1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 17:19:41 +00:00
Paul Berry 2ce64e4a7e Migration: create data structures for file details. 
Change-Id: Ibb909795431b33f826e52c39cd7108cc3ec7f204
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139684
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-17 00:07:41 +00:00
pq 0e0d4fb76b linter 0.1.113 
Change-Id: I75cc9478171de15df24bc5addfa0aca4dcf7e97a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139660
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 19:48:00 +00:00
Brian Wilkerson 90e32fe161 Disable other sorting when using the new relevance computation 
This actually makes the scores slightly worse, but I think it's important
that we understand the quality of the scores without other sorting. The
scores are still better than with the old computation.

Change-Id: I514aa35029b600b9ab87bf531064f1e89b02774a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139682
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 18:36:03 +00:00
Mike Fairhurst 1ec961a7f9 [nnbd_migration] Reload changed paths on rerun to remove hack. 
Fixes https://github.com/dart-lang/sdk/issues/41025

Change-Id: I40fc3aa3438bdcecd595768d8b34dbe864b2a5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139407
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 18:14:48 +00:00
Konstantin Shcheglov 3237380259 Fix for creating a field when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I90b8031a805ba0cb51e7ccb8c2477d4f0d0ac8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 15:52:08 +00:00
Brian Wilkerson 8929bbfbe1 Add a fix for the prefer_interpolation_to_compose_strings lint 
Change-Id: I24cf735233dcf4c0e0c269ba14fbc59873a89751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 14:31:58 +00:00
pq a6a879577d remove non_const_const fix 
Change-Id: Ib2c96b06416b4f392f726de9af22bbf6700dd9dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139487
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 22:08:16 +00:00
Brian Wilkerson 1d959fad1b Refactor the way context type is computed to improve performance 
Change-Id: Icab69d66d30c616c4800d18ae7543059a21e5e7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139484
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 20:34:06 +00:00
Brian Wilkerson cf4b7d312a Add a flutter-specific fix for ARGUMENT_TYPE_NOT_ASSIGNABLE. 
Change-Id: I1687f88a274c69dd2fb6af5bcca7425378b9fd61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 17:33:01 +00:00
Paul Berry c3a0bb086a Migration: Add "why not nullable" traces where "!"s are inserted. 
Change-Id: I0367f869d59da0397589df7df43170f1ecbcb69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139401
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-13 16:31:11 +00:00
Mike Fairhurst 4cdd7ec7be [nnbd_migration] Enable apply edit links by default. 
Change-Id: I06731286a049a58c8ba968423b0629a0800825f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139310
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst 624b135cf0 [nnbd_migration] Add a rerunning pane to enforce consistency on hinting 
Change-Id: Ie1f08f5a7bb73e9e73783326c4efcfc6b5f75dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139309
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst f1452fc2d9 [nnbd_migration] Apply hint block until rerun; refresh preview after. 
Change-Id: I49df050ec05099742510aa78584bfd15d9e9f840
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139321
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst 563aebd5c7 [nnbd_migration] Rerun migration after performing edits. 
The way the server is managed is not 100% ideal, filed here: #41018

Change-Id: Idca6dd56e8375b2e8ea7cbb2f2bf329f2643a442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139308
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst 2ee07c3193 [nnbd_migration] Fix issue creating two PreviewSite's for GET/POST 
This caused an issue where the POST request to add a hint would trigger
a rerun and update the state of the POST handler, but the GET handler
still had the old state.

Make just one PreviewSite so that state can be updated and stay
consistent.

Change-Id: I9f984708fd95954b1d8d2c0b8fc2e3bce8350053
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139307
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-13 16:16:21 +00:00
Mike Fairhurst 546acb1e8e [nnbd_migration] Split apart running tasks from sending dartfix response 
This enables us to get code that we can execute to rerun dartfix in
later CLs.

One note is that this won't pick up on certain file changes, etc. I
think a better long-term solution is to rerun the entire DartFix code on
rerun, and that dartfix response can be returned directly to the js
front end. Its possible that the types of file changes this will miss
are extremely rare, such as changed .packages files only etc.

This would require a bit more untangling, things like managing the way that
dartfix will start a server each time, and ensuring that we get a
DartFix respnse *and* a migration state, so this CL seems worth landing
in the meantime. Filed as #41017

Change-Id: If629cac41149728b34f6eb9785a7cea543a23a6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139306
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-13 16:16:21 +00:00
Paul Berry 8361357e6e Fix assertion failure in stack trace builder. 
Fixes #41020.

Change-Id: I6cf52c3a5aac545c352f653def53508356676d71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139317
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-13 12:27:40 +00:00
Brian Wilkerson b31445c0f8 Improve the relevance scores for instance type members 
The "super matches" feature should have been disabled (-1.0) when the
target wasn't `super`, but it wasn't. That artificially lowered the
score for methods. But it wasn't being used (even when it should have
been) for getters and setters, so their scores weren't being lowered.
That accounted for the poor mrr I was seeing. This fixes both problems
so that the feature is now used everywhere when it should be and not
when it shouldn't be.

Change-Id: I541a9b1ed524e8b2ed2c0c7f39e7bca786e12ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139380
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 01:12:41 +00:00
Konstantin Shcheglov a42efec049 Don't suggest ADD_RETURN_TYPE for setters. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ia584be1de6d6e4237f316bdd8cef77ae841a15ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139315
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 22:54:36 +00:00
Konstantin Shcheglov 68b0b83bfe Issue 40842. Fix for getter return type location. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: Ifc8343a6df62d64d05b3870255b4602ab898d4cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139260
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 17:44:26 +00:00
Konstantin Shcheglov d5eb515a88 Extract AddReturnType producer. 
As a preparation to fix the bug.

R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: I9b448ebb79520e1f0f79cb008feeecd657e5b596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139148
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-03-12 16:20:58 +00:00
Konstantin Shcheglov 009d27b081 Extract AddFieldFormalParameters. 
Here I also add forCode(ErrorCode) method with the same goal - keep
all the knowledge about one issue in one place. Producers already
have to know which error they handle, because the have expectations
about the target node.

R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I584521b3a6e79cc126b5ff152dab26a397535463
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 15:34:42 +00:00
Konstantin Shcheglov 51f5636daf Report FLUTTER_GET_WIDGET_DESCRIPTION_CONTENT_MODIFIED when a file is changed during the request. 
R=brianwilkerson@google.com

Change-Id: I9d77df28dd16fdaf30ba4dd04fe8cfff221c236d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 01:09:00 +00:00