05c867873a
[nnbd_migration] Reset dartfix change listener on rerun.
...
Without this, rerunning causes the change list to grow, including all
prior changes. When users hit the apply migration button, the result is
corrupt.
Change-Id: I3b57b24be25e897ac6c976254d04a78dbb3a5a7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143324
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 22:42:46 +00:00
da2f4a6363
[nnbd_migration] Add CSS class tracking when the user needs to rerun
...
Currently not hooked up to any special styling, but will hide the "apply
migration" button.
Also currently not set to true by any workeflows, but that will of
course change in follow-up CLs.
Change-Id: Ie0ef64361dac40b19bf08497c1c4f92a80b0891d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143323
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 22:42:46 +00:00
3ae6f3231e
[nnbd_migration] Rename originalContent to diskContent, it can change.
...
Remove assertion as well that disk content is only set once. In the new
workflow it can be set many times.
Change-Id: I86039fee1d144a8a03cd82dc5c9e0f45bb130141
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143304
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 21:05:25 +00:00
23b636ae29
[nnbd_migration] Add three new offset mappers: insert, sequence, rebase
...
Change-Id: I5c11a98acf54735c21e7bf399ef099f371ebdb39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143281
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-14 21:05:25 +00:00
fad05e89dc
Require exact type matches for equality in LSP classes
...
Change-Id: Ia3f502a315e2c6fbc62eb6fbe3785dad86c782cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142992
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-14 15:47:01 +00:00
2fbe4d9194
Resolve type aliases when generating LSP equals methods
...
Change-Id: Iccecfa8dc8d77cb0d4358db1f7fa54607ffaa428
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142991
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-14 15:47:01 +00:00
7fe16ba812
sort_directives quick fix
...
Fixes: https://github.com/dart-lang/sdk/issues/41464
Change-Id: I9c5804ef8ec872b8420feba3d9a0f0da5fb757d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143303
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-14 00:45:18 +00:00
b68334052a
Support macro expansion of Dartdoc in code completion
...
Change-Id: Idbde9584da82606949cce79849088c6432d0602a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-13 21:37:09 +00:00
e1822e9626
Migrator: Add new fix kinds: replaceVar, addType
...
Fixes #41410
Change-Id: I127d309e84423c24eb2563063af433187b9bf057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143222
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-13 20:11:32 +00:00
3a8cfa3547
Migration: don't generate traces for casts that don't involve nullability.
...
Change-Id: I9dca37cb5542d27485b28a012d32eb0e05f45044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143016
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-10 23:32:03 +00:00
65f9127e14
Add word breaks in details panel; fixes #41404
...
Change-Id: Ic79ac26318b51fa73d5f7f7a645e474d5310daaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143103
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-10 19:21:34 +00:00
eb4b9b5241
[nnbd_migration] Fix windows file paths in edit links, pt 2
...
Change-Id: Ie9bc22d2a5d48b7e7d9355ac77b1cbe4397bf532
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143121
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-04-10 19:03:59 +00:00
254d115a80
Fix analyzer windows bot
...
Change-Id: Ic95b3121461765622fd577409faa8163d7740c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142660
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
2020-04-09 17:33:09 +00:00
0923668147
Migration: remove preview section "edit rationale"
...
Also remove the code to generate it, and associated tests. This
feature is no longer useful now that we have the "stacktrace" view,
and there's a considerable amount of complex logic backing it that's
interfering with other work I'm trying to do.
Fixes #41387
Change-Id: I552ffbfea8573e5d640ec98a3a196bd0eb36cdb9
Bug: https://github.com/dart-lang/sdk/issues/41387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142886
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-09 17:30:09 +00:00
b11da4d65e
Get go-to-definition working with plugins for LSP
...
Change-Id: I49c469a15a651718ed21850e6c1a8fac798392c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142378
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-09 17:01:19 +00:00
03c15848d6
Migration: distinguish inserted casts based on whether they are downcasts.
...
Inserted casts that aren't downcasts are much less likely to be safe
than inserted downcasts.
Change-Id: I21e0ef54b1c4d58c54724a510b25828fc3018142
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142552
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2020-04-07 18:35:56 +00:00
8c982a1373
Migration: categorize changes shown in the preview tool.
...
We now sort changes into the following categories (in order):
- Dead code removals
- Casts added
- Null checks added
- Required keywords added
- Types made nullable
- Casts now unnecessary
- Language version comments removed
The reasoning is that this corresponds roughly to how important it is
for a human to inspect each kind of change to make sure it is safe
(dead code removals, for example, are highly likely to indicate an
incorrect migration, where as dropping of unnecessary casts is benign
and almost certainly correct).
Change-Id: I49e3adac3ac98de1a9298f9caadb76c73a9c67d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142542
Reviewed-by: Janice Collins <jcollins@google.com >
2020-04-07 18:35:56 +00:00
f0f3199daa
Improve the completion of return types on FunctionTypedFormalParameters in FormalParameterLists
...
Change-Id: I7c7446f5077844daadf935f5ec0af5b12da739fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142600
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-07 17:51:16 +00:00
7e68842b8e
[nnbd_migration] Add sanity checks before writing to disk.
...
Change-Id: I09e8f1bebd12747c06538f7cc5976a8601e8cbee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142210
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-04-06 18:26:14 +00:00
5d9eb40f20
[nnbd_migration] Change edit links to buttons.
...
Change-Id: I7ac1b19021849c93a23aa6ffc739c318b7770664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142214
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-04-06 18:12:34 +00:00
1e4a56ee72
remove type params for list param args
...
Fixes: https://github.com/dart-lang/sdk/issues/41303
Change-Id: I733cef8d7ed94cab931a5e13c1a0a0f7d9f36c66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142420
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-04 02:35:37 +00:00
3edfab164f
Migration: remove redundancy from NullabilityFixKind enum.
...
The values discardCondition, discardElse, discardIf, discardThen, and
removeNullAwareness are all variants of dead code removal and there's
no reason to distinguish them.
Change-Id: Id55035486e07f52e6ef7b5a2485dcb0cadb153e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142060
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-04-03 16:18:51 +00:00
8eab8bfc0c
Bug fix in inherited_reference_contributor.dart, completions inside of ConstructorDeclarations should include inherited members.
...
Change-Id: I9f91087e98c8925b5b733b4b4a0a852f53073b82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142208
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-04-02 22:16:59 +00:00
191be51124
Extract GenericInferrer and type schema.
...
Change-Id: Ic306342609911e3e232dbf95f30b60cff94c34be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-01 20:54:48 +00:00
278a2db4df
Add a --preview-port flag to dart migrate.
...
Change-Id: I526a2e40198960e0e3fb3509ed8a84979f520b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141765
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-04-01 12:10:04 +00:00
b7130b0bf7
Migration: improve preview tool display when ! is added due to an explicit hint.
...
Change-Id: Ie9b2a6cabaf02c46da2e8b8ac1bffa0e699acc64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141741
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-03-31 22:04:46 +00:00
ca6b0fd0df
Fix for crash in WrapInText when the parameter is not InterfaceType.
...
There was a crash in the logs.
_TypeError: type 'GenericFunctionTypeElementImpl' is not a subtype of type 'ClassElement'
at WrapInText.compute (wrap_in_text.dart:26 )
at FixProcessor._addFromProducers.compute (fix_internal.dart:4506 )
at FixProcessor._addFromProducers (fix_internal.dart:4520 )
at FixProcessor.compute (fix_internal.dart:762 )
at DartFixContributor.computeFixes (fix_internal.dart:82 )
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I187b3348a212391cc6c64ab2c412653bd2319334
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141820
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-31 15:56:40 +00:00
fb4b59e043
Deprecate isProxy / isOrInheritsProxy in ClassElement.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ied4011961d4dece33d527888d274893985d85f93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141767
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-30 23:27:39 +00:00
0943e6136d
[nnbd_migration] Save line number of details to preserve on reload.
...
When clicking on a region, store its offset & line in the URL via
`pushState`, so that on reload (after rerun migration or after apply
edit, or just in general) the context isn't lost.
Note that offset is not enough. Basically, every navigable element gets
a class `o$offset`, and if the page is loaded with some offset such
that no element with class `o$offset` exists, it falls back to line
number. And if there were edits mode before the region since reload,
there will only be an element `o$offset` if you are lucky.
Change-Id: Ic5fd83aceb4e8731348e70c039fec2ca2a6ab9e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141465
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-30 21:41:59 +00:00
8969b1839c
Enable omit_local_variable_types in analysis_server
...
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-30 03:58:44 +00:00
3a0bf3ad36
Fix for creating a setter when the target is in a part without a library.
...
R=brianwilkerson@google.com
Change-Id: I3c364f01c9cb31166e24f2b28d6a4640fa7d8c93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-28 21:00:23 +00:00
7e724e70b0
Sort non-generated files in analyis_server and add a test to ensure they stay that way
...
Change-Id: I6c7a38cefa69f46737bd50eefe2fbb88c127017b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-28 17:12:03 +00:00
232052da06
New relevance values for UriContributor
...
Change-Id: I32a3151cb78a333ef7e23e89f2688acb4c74edb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141480
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-27 22:51:34 +00:00
c3fc96ad62
New relevance values for KeywordContributor
...
Change-Id: I851e9fa12bc674b6714089fa2b23443c2e2140d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141463
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
2020-03-27 22:37:59 +00:00
8a126788fc
New relevance values for VariableNameContributor
...
Change-Id: Id2670c4ec0860ce246a44dfe2abd8b6dbf987a35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141462
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-27 22:37:51 +00:00
104bdcd4cc
[nnbd_migration] Add confirm dialog to "apply migration" button
...
Change-Id: I377caf627725c6f38eeca34001e61ab23323a700
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141029
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
2020-03-27 19:50:57 +00:00
127d84aa56
Update relevance computations in LocalReferenceContributor
...
Change-Id: I19baafc28488304d781757c2a2648ec3d3781d15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141361
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-27 18:33:29 +00:00
db91583b38
Update relevance values for LocalLibraryContributor and ImportedReferenceContributor
...
Change-Id: I204bd8a95d9697f166e8e0a97d36098fc35c1dc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141206
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-27 18:30:08 +00:00
62c4b1fb2e
[nnbd_migration] Add a "rerun from sources" button.
...
Change-Id: I09f1c76cb41549b81218783ec69d190271508ba0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141028
Commit-Queue: Janice Collins <jcollins@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2020-03-27 16:50:12 +00:00
7d66feb5ff
Compute new relevance in LocalConstructorContributor
...
Change-Id: Ife24a24829fae36b1caef5ab0a55e4c210a063a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141201
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-26 21:50:29 +00:00
da1d9eb1bd
Add a way for analysis_server to open communication via a IsolateChannel.
...
The idea is to pass a SendPort as an optional parameter to
ServerStarter.start(), and if present, key server behavior around
behaving well as an isolate.
Bug: https://github.com/dart-lang/sdk/issues/41056
Change-Id: Ifc6ac2fefcf6aae8bce712e470524d1c06fa2ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140373
Commit-Queue: Janice Collins <jcollins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-26 21:37:59 +00:00
fe6f3eaf9f
Migrator: Add an auth token for the preview site
...
Fixes #41134
Change-Id: I6d436805d3dfb64cc4d7ddde2b307132fbd1365d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140621
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-03-26 20:01:56 +00:00
d194838578
Add new relevance scores to LibraryElementSuggestionBuilder, which covers both LibraryMemberContributor and CombinatorContributor
...
This should have tests, but I (or someone else) need to do some data
mining to figure out the correct relevance values and hence the correct
ordering to test for.
Change-Id: I7782d7b7e13ff38a785c445cd0d6fc82a388a6aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141000
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-25 22:49:26 +00:00
df5e6c8e5f
Compute new relevances in LibraryPrefixConstributor
...
Once again, test suggestions are welcome.
Change-Id: I470825a0ef51f555977bdc86192cc38bd718519a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140943
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-25 21:01:16 +00:00
5f20fe7d83
Revert "Trim not useful bottoms off of the non/nullability stack traces"
...
This reverts commit a225178919https://dart-review.googlesource.com/c/sdk/+/140000
> Commit-Queue: Samuel Rawlins <srawlins@google.com >
> Reviewed-by: Paul Berry <paulberry@google.com >
TBR=paulberry@google.com ,mfairhurst@google.com ,srawlins@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I9a2fb07e387d57394242b694e27456333f2cf2b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140908
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-03-25 20:57:36 +00:00
244b4247e9
Migration: better description text for edges.
...
Change-Id: I58651c927a741721283c3c4c951673a86aa7a1b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140883
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-03-25 19:38:34 +00:00
9e4eb054a4
Add new relevance scores for NamedConstructorContributor
...
Change-Id: I6e5fd10edf74b44afb766acd675dffd5ef0cb25f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140906
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-25 17:47:42 +00:00
2323087237
Fix the comment for the LabelContributor
...
Change-Id: I8ac9f343608b04b7fe1ec59a9d151dd6dd81e926
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140902
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-25 16:39:12 +00:00
8760283247
New implementation of runZoned.
...
A combination of `runZoned` and `runZonedGuarded` where only the latter allows an `onError` parameter,
and only that has a nullable return type.
Retains the `onError` parameter on `runZoned` for now because it's too breaking to remove it until packages have been migrated off of it.
It will be removed in a follow-up CL.
Change-Id: If0e86c8d14e13fa089c66f4af975aeacb2616cf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137302
Reviewed-by: Jake Macdonald <jakemac@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2020-03-25 00:24:33 +00:00
ef56e3a3fc
Update relevance of labels
...
Change-Id: Id862fa2da7969a9dcdb1854f6ffe38a4c122a024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140778
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-24 22:46:07 +00:00
Mike Fairhurst