Commit Graph

2393 Commits

Author SHA1 Message Date
Brian Wilkerson dc972240d4 Remove unused IdeOptions
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2924633002 .
2017-06-05 14:12:17 -07:00
Brian Wilkerson e8a5e404c3 Move LocalDeclarationVisitor for use by contributors that will be moved to analyzer_plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2918343002 .
2017-06-05 10:24:54 -07:00
Brian Wilkerson db7d3d0fe7 Move relevance constants for use in plugins
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2923573002 .
2017-06-05 10:10:56 -07:00
Devon Carew 0b79e4d20d update the analyzer and analysis server perf tags
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2917183003 .
2017-06-03 19:51:27 -07:00
Devon Carew 4f2867d86c Add clientID and clientVersion to the diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2925463002 .
2017-06-03 17:53:52 -07:00
Devon Carew 511963d715 Add an analytics domain to the analysis server.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2922603002 .
2017-06-02 14:38:53 -07:00
Devon Carew 428c0ff59d Expose the exceptions info in the diagnostics page.
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2914383002 .
2017-06-02 09:57:09 -07:00
Brian Wilkerson b5c630426c Update a few more methods in FixProcessor, and fix some bugs in ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2916923002 .
2017-06-02 07:36:51 -07:00
Devon Carew 7e32f3bd7c Remove dead code related to the diagnostics server.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2918553002 .
2017-06-01 10:31:27 -07:00
Devon Carew 6c1625743c Relax a null check in context_manager.dart.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2915673002 .
2017-06-01 09:50:00 -07:00
Brian Wilkerson d7d3ee40dd Report plugin errors to the instrumentation service
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2913913002 .
2017-05-31 08:01:07 -07:00
Devon Carew 02f7f5fee7 Updates to the diagnostics page.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2918533002 .
2017-05-31 07:15:20 -07:00
Devon Carew c817241ad6 Update the analysis server diagnostic page - re-enable code completion and overlay pages,
and refactor the css and navigation.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2911313002 .
2017-05-30 18:46:33 -07:00
Devon Carew 24b0d1489f Fix an npe in context_manager.dart.
BUG=

Review-Url: https://codereview.chromium.org/2917453002 .
2017-05-30 14:29:53 -07:00
Max Kim 82490f0d2f Allow replacementOffset and replacementLength overriding from plugin autocompletion. In cases where a plugin overrides the original Dart autocompletion offset/length or another plugin's offset/length - the suggestion for the plugin is dropped and an error notification is logged.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2913833002 .
2017-05-30 13:54:11 -07:00
Devon Carew 1e7ff6bccf Add the analysis options path to the diagnostics page.
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2913493002 .
2017-05-30 13:29:25 -07:00
Konstantin Shcheglov 9737664106 [Extract Method] When no selection, check for implicitly selected closure.
R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review-Url: https://codereview.chromium.org/2907213002 .
2017-05-30 11:11:46 -07:00
Brian Wilkerson f6c6c01211 Update some of the fixes to use ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2910683002 .
2017-05-30 08:01:52 -07:00
Devon Carew 03e0a93092 show the enableAssertInitializer setting in the diagnostics page
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2911563002 .
2017-05-26 08:36:26 -07:00
Brian Wilkerson a7cc00e01a Make server forward getNavigation requests to plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2908633002 .
2017-05-25 14:49:35 -07:00
Brian Wilkerson f65c7ecbdf Fix a recent regression with nested contexts
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2903303002 .
2017-05-25 13:17:08 -07:00
Brian Wilkerson 1c8b59dc31 Update status pages to show package map and plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2904983003 .
2017-05-25 12:51:19 -07:00
Brian Wilkerson 013411c10b Allow plugins to provide completions for non-dart files
R=maxkim@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2910463002 .
2017-05-25 10:53:07 -07:00
Brian Wilkerson 61e3486ed1 Find drivers even when the file is not a dart file
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2898213004 .
2017-05-23 17:23:30 -07:00
Konstantin Shcheglov ab9ee72a34 Switch server tests to strong mode.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2903523003 .
2017-05-23 14:58:53 -07:00
Brian Wilkerson 0929b7736e Convert quick assist support to use AnalysisDriver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2899843002 .
2017-05-22 13:45:55 -07:00
Ian McKellar 5b6a9392e5 Fix inifinite loop in analysis server. (#29685)
It was walking up a directory heirarchy looking for a directory named
"lib" but didn't terminate when it reached the root.
2017-05-22 11:46:44 -07:00
Brian Wilkerson 7e47a24c8a Convert quick fix support to use AnalysisDriver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2894403003 .
2017-05-22 10:41:57 -07:00
Steve Messick 5455f21565 Fix reparent on windows
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2892963002 .
2017-05-19 10:28:44 -07:00
Brian Wilkerson a8dc041543 Capture the request time for performance data and support forced shutdown
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2893803004 .
2017-05-19 08:49:47 -07:00
Brian Wilkerson c1a7070770 Add the ability to whitelist plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2897653002 .
2017-05-19 08:48:32 -07:00
Brian Wilkerson a6214b3129 Remove more libraries directives from server
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2894883002 .
2017-05-19 08:42:30 -07:00
Brian Wilkerson daffcecc11 Pass the sdk path to plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2885993004 .
2017-05-17 08:19:49 -07:00
pq aa491e7133 Support tear-off completions for named params (in constructors) (flutter-intellij#836)
R=danrubel@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/836
Review-Url: https://codereview.chromium.org/2883363002 .
2017-05-16 13:40:33 -07:00
Brian Wilkerson a03958bfc9 More clean-up after getting common protocol classes
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2880393002 .
2017-05-15 13:01:57 -07:00
Brian Wilkerson 6643349a8f Minor clean-up
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2885473002 .
2017-05-15 10:09:47 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
Brian Wilkerson 3085734ef6 Generate common types into a separate library
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2880443006 .
2017-05-13 08:12:14 -07:00
Konstantin Shcheglov a4fd5d814f Extract PerformanceLogger from AnalysisDriver.
I also added the runAsync().

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2883633002 .
2017-05-12 14:27:50 -07:00
danrubel 98825b4918 improve code completion abort request tests
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2876793006 .
2017-05-12 13:28:39 -07:00
Brian Wilkerson bef53e72e4 Remove unintentional dependency on analysis_server
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2875323002 .
2017-05-12 10:07:37 -07:00
pq dc64c43480 Unused import cleanup.
BUG=
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2876913002 .
2017-05-11 14:08:47 -07:00
danrubel 66bb2d618e Remove unused analysisContext from completion request and contributors
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.

R=brianwilkerson@google.com, pquitslund@google.com

Review-Url: https://codereview.chromium.org/2877653002 .
2017-05-11 09:38:50 -07:00
danrubel 6798cdfcd1 cleanup dart code completion contributors
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.

DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2873943003 .
2017-05-11 09:12:36 -07:00
Brian Wilkerson 3b2c3ae5b2 Add support for built-in plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
Steve Messick 55097a44b3 Recover from merge problem
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2868383002 .
2017-05-10 13:12:14 -07:00
Brian Wilkerson a3ac4253b1 Remove an obsolete error from the spec and an obsolete command-line flag
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2865403005 .
2017-05-10 09:33:43 -07:00
Brian Wilkerson fbc3f3708d Remove unused reference to SearchEngine
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2872803003 .
2017-05-09 14:32:12 -07:00
Brian Wilkerson 98e8f17b96 Convert server to use RangeFactory
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2869083002 .
2017-05-09 10:08:14 -07:00
Konstantin Shcheglov bd1ee32543 Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/.
We are going to reuse ByteStore in front_end, also for incremental
compilation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2869803004 .
2017-05-09 09:12:15 -07:00