84a36f1b77
flag to limit file and package URI completion suggestions
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3003233002 .
2017-08-23 13:39:32 -04:00
e4d44b2dcd
Remove more references to the old plugin system
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3004523003 .
2017-08-23 09:25:07 -07:00
b999edf5ee
Remove more references to AnalysisContext
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3003173002 .
2017-08-23 07:53:14 -07:00
b941f148a7
Remove uses of the old plugin model from the analysis server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3001413002 .
2017-08-23 07:42:13 -07:00
4aeedec64e
Remove the auto-discovery of plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3003663002 .
2017-08-22 09:04:23 -07:00
4076ef910f
Guard the fix code against file system exceptions
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2997153002 .
2017-08-17 10:41:22 -07:00
8b96449718
Handle watch events that arrive before plugin start-up
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001133002 .
2017-08-17 09:57:22 -07:00
6f96d88e1e
Avoid closing an already closed channel
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2999153002 .
2017-08-17 09:47:33 -07:00
bd8f5ad79f
Guard against getting a watch event before the driver is created
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001023002 .
2017-08-16 14:08:44 -07:00
35f6d5da1b
Correctly handle adding imports when pasting into part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001733002 .
2017-08-16 07:43:36 -07:00
44b5341de8
Update edit.importElements response data to support part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001723002 .
2017-08-15 08:51:51 -07:00
eaf779ba1e
Fix insertion of imports when there are no existing directives (issue 30430)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002643002 .
2017-08-14 13:32:57 -07:00
e42abf621e
Update the version of the server API spec for analysis.closingLabels
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3002513002 .
2017-08-12 14:44:41 -07:00
8c8969db4c
Forward Kythe requests to plugins and merge in the results
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3000823002 .
2017-08-12 08:16:34 -07:00
0647d9a228
Improvements to analysis server closing labels ( #30411 )
...
* Tweak comment that was based on integration test verison.
See #30285
* Include additional 1/2-line spans that end on same lines as >2 line spans.
See #30285
* Add tests to ensure no unwanted closing labels from multiline expressions.
See #30285
* Don't show closing labels for code inside interpolated strings.
See #30285
* Remove unwanted @soloTest.
See #30285
* Make casing of test names consistent.
See #30285
* Add a constructor and make fields final.
See #30285
* Use putIfAbsent for adding to map.
See #30285
* Shorten closing labels constructor.
See #30285
* Run "Sort members" on closing labels files.
See #30285
* Remove unnecessary type annotations.
See #30285
2017-08-11 11:04:34 -07:00
ecc72d6be5
Initial implementation of the kythe domain
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2999783002 .
2017-08-10 11:49:22 -07:00
c8f8f8e7cc
Ignore two unused element warnings in pkg/analysis_server.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2994113002 .
2017-08-10 11:36:12 -07:00
579a032564
Add kythe support to plugins and format the spec files
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2994103002 .
2017-08-10 11:24:40 -07:00
619f2995ab
Implement analysis server closing labels (work-in-progress) ( #30372 )
...
* Add empty closing labels computer/visitor and tests.
See #30285
* Add initial implementation and test for closing labels.
See #30285
* Add various tests for analyzer closing labels.
See #30285
* Fail tests if errors occur.
Without this the notifications will never come through and the test will time out. This causes them to fail right away on errors.
See #30285
* Add test and fix for crash that occurred during testing.
See #30285
* Remove unnecessary abs().
See #30285
* Remove question that has been answered (yes).
See #30285
* Remove unnecessary .argumentList on spansManyLines check.
See #30285
* Add test for prefixed import and constructor names.
The behaviour seems like what we want, though need to confirm if this is the best way to do it.
See #30285
* Add additional prefixed tests and another TODO.
See #30285
* Fix method invocations to show full target/name.
See #30285
* Fix constructor invocations to not use toString().
See #30285
* Convert most closing label tests to unit tests.
See #30285
2017-08-09 14:13:47 -07:00
8a426f3d67
Initial experimental Kythe Dart Analysis Server protocol
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2995683002 .
2017-08-09 12:44:59 -07:00
beae4b29f1
Handle creation of class members in files other than the file containing the error
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2998703002 .
2017-08-09 08:57:29 -07:00
c4420a8943
Add "closing labels" to API spec. ( #30332 )
...
* Add "closing labels" to API spec.
See #30285
* Re-generate spec after adding "closing labels".
See 30285
2017-08-08 11:54:37 -07:00
89c910b9c1
Move byte_store.dart and file_byte_store.dart to their own subdirectory.
...
This allows us to use the subpackage relationships test to verify that
they don't import any other parts of front_end, which paves the way
for the possibility of moving them to their own package in the future.
R=scheglov@google.com , sigmund@google.com
Review-Url: https://codereview.chromium.org/2990323002 .
2017-08-07 11:04:48 -07:00
4c635b7b85
Initial support for an explicit plugin list
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988343002 .
2017-08-02 11:30:57 -07:00
ae69313731
Initial implementation of the import-aware copy support
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988183002 .
2017-08-01 08:32:12 -07:00
17d640d6ff
Some initial work for the Dart Kythe indexer support in the analysis server
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2987193002 .
2017-07-31 14:38:32 -07:00
5b88eef0af
Suggest covariant in parameter lists
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2986133002 .
2017-07-28 10:33:07 -07:00
de0b7a2f40
Add sourceFactory getter to AnalysisSession
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2989883002 .
2017-07-28 06:18:53 -07:00
9591a9449f
Partial support for intelligent paste operation
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2986073002 .
2017-07-27 13:55:59 -07:00
c618032a69
Remove the uri from the ImportedElements object in the experimental spec API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2991893002 .
2017-07-27 12:52:38 -07:00
9a6b134d33
Improve name generation for indexed expressions
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2990793002 .
2017-07-27 07:58:34 -07:00
950b4108f7
Add assist to convert part-of directives
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2986903002 .
2017-07-26 09:08:37 -07:00
a040de8c08
Update the version of the server API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2985003002 .
2017-07-25 12:45:16 -07:00
8bbf373a5e
Remove the analysus.reanalyze request from the plugin API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988743002 .
2017-07-25 12:10:52 -07:00
939d8aaf6d
Issue 30238. Fix for subscribing for a notifications with already cached analysis result.
...
With the new 'sendCachedToStream' option we can control that whether
cached analysis result is also reported into the 'results' stream when
it is desirable (when we do this to send analysis notifications from
the stream listener). Or not, when it is not desirable, e.g. when we
ask becaue we need the results unit for Quick Assists.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/30238
Review-Url: https://codereview.chromium.org/2989633002 .
2017-07-25 10:28:25 -07:00
0f9707073d
Add support for creating a .packages file when the plugin is in a Bazel workspace
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988673002 .
2017-07-24 10:00:05 -07:00
bdd69ccd6c
Remove UriReferencedElement with its uri/uriOffset/uriEnd properties.
...
The 'Move File' refactoring does not work, so I comment out most
of its code.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2982993003 .
2017-07-19 09:31:03 -07:00
90121b528a
Remove the 'Move File' refactoring.
...
It has been broken since we switched to Analysis Driver.
Given that IDEA does not use it, there is little incentive to fix it.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2983783003 .
2017-07-18 17:59:20 -07:00
8b7e3ef7e4
add env var info to the diagnostics page
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2981123002 .
2017-07-17 09:22:23 -07:00
2eb0017013
Add angular to analyzer plugin whitelist
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2982773002 .
2017-07-13 14:36:14 -07:00
78f78feaf8
Don't include *.yaml files in 'analysis.analyzedFiles' notification.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review-Url: https://codereview.chromium.org/2980653002 .
2017-07-11 14:19:15 -07:00
b47bfa88be
remove unused analysis server flag
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2974013002 .
2017-07-11 08:10:42 -04:00
def1ee6604
add analysis server --flutter-repo startup flag
...
This adds a new flag used by `flutter analyze --watch` when analyzing
the flutter repository. When specified, this flag causes analysis server
to enable the public_member_api_docs lint even though it is not enabled
in the analysis_options file. `flutter analyze --watch` needs the results
of this lint to summarize the number of public members missing dartdoc,
but enabling it in the analysis_options causes too much noise in the IDE.
See https://github.com/flutter/flutter/issues/10721 for more background
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2976473003 .
2017-07-10 16:50:04 -04:00
a2e9519279
Make exception reporting best effort.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2965263002 .
2017-07-06 13:36:28 -07:00
ba625804b7
Tweaks to the profiling diagnostics page.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2966383002 .
2017-07-06 11:47:26 -07:00
d4abd49df7
Add analytics to analyzer-cli and analysis server.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com , zra@google.com
Review-Url: https://codereview.chromium.org/2963323002 .
2017-07-05 23:29:46 -07:00
d9754a58e9
Initial implementation of copy/paste support
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2972833002 .
2017-07-05 14:02:07 -07:00
ce43a15e51
Stop depending of visiting LocalVariableElement(s) in Executableelement.visitChildren().
...
We still visit them, but analyzer and analysis_server don't need it.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2969343002 .
2017-07-05 12:28:20 -07:00
d2569cc3ee
Add lint timing information to the status pages
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2970153002 .
2017-07-05 12:00:42 -07:00
3c1c22a3a1
Add a quick fix for missing new (issue 30077)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2965063002 .
2017-07-05 10:59:34 -07:00
danrubel