45acfc4524
fix code completion invocation on getter
...
BUG=dartbug.com/22376
R=scheglov@google.com
Review URL: https://codereview.chromium.org//929323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43896 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:14:52 +00:00
3750ba067f
Return version with connected notification
...
R=jwren@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//943723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:45:01 +00:00
7256562fcd
Return RequestErrorCode.NO_INDEX_GENERATED if no index.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//939823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43866 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 05:07:06 +00:00
1e120443b5
Issue 21879. Don't include 'this' and 'super' keywords if not in a method/constructor body.
...
R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21879
Review URL: https://codereview.chromium.org//935123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43857 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 23:17:10 +00:00
6a78250c64
Issue 22476. Outline for enums.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476
Review URL: https://codereview.chromium.org//934353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 21:37:27 +00:00
4e34c0d247
Generate artificial hashCode for often used classes.
...
By avoiding calling Object.hashCode we analyze about 1% faster.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//934113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43832 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 01:12:43 +00:00
0e73ada9c2
Use package: URIs for files in lib
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//914373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43827 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 22:47:34 +00:00
55a3255070
Return RequestErrorCode.NO_INDEX_GENERATED for search/refactoring requests.
...
Also remove passing a SearchEngine instance into Quick assists/fixes - they don't use it.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//923103004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43819 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 20:01:45 +00:00
a46fc6016d
Addition of the --no-index flag to the analysis server spec.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//932883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43816 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:55:00 +00:00
298747c23e
Add properties to the element tree
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//934603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43801 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-16 21:41:50 +00:00
a56ac2f521
update code completion suggestion relevance based on common usage
...
BUG=
R=lukechurch@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//925723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43792 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-15 21:17:48 +00:00
9e883eb661
Use a slightly faster way to write index data.
...
It makes initial analysis about 3% faster.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//924943003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43786 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-14 04:30:27 +00:00
ef1e368409
Improve code generation for 'bottom' and 'dynamic' arguments.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//924783005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43780 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 21:02:34 +00:00
056909e4a7
Rework analysis server performance measurement code.
...
This change has the following advantages:
- We now keep track of the amount of time spent doing unknown
activities using its own timer.
- Several pieces of analysis server functionality are now tracked
(previously we only tracked time spent inside the "analyzer"
package).
- The set of all performance timers is tracked in PerformanceTag.all
so that new timers can be added without having to update the code
that prints out timing measurements.
- Performance measurement code has been integrated with Observatory
"user tags", so that the same categories measured by the analysis
server also show up in the VM profiler view.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//918383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43745 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 23:54:49 +00:00
865b217511
Issue 22381. Fix for navigating to constructor from redirecting factory constructor.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22381
Review URL: https://codereview.chromium.org//921833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43731 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 17:58:29 +00:00
06b1a16819
Include source info in status AST dump
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//922453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43708 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 00:41:38 +00:00
3f5da18831
Add packageUriResolver before ResourceUriResolver.
...
Otherwise execution.mapUri always restores file:// URI.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//922433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43705 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 23:06:48 +00:00
0efb52aa0f
More complete state transition data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//916973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43700 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 22:04:51 +00:00
c762e94a1c
check for null completion node
...
BUG=dartbug.com/22371
R=scheglov@google.com
Review URL: https://codereview.chromium.org//915023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43690 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 15:44:21 +00:00
0b922f3d22
Quick Fix for an undefined class in is/as expressions.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//913923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43675 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 01:31:53 +00:00
7b59c01e8a
Use async/await in refactorings.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//913903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43674 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 01:21:43 +00:00
52af26ea3d
Minimal initial performance reporting
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//913853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43672 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 23:09:40 +00:00
937c4be45d
Add index search support to AST and element model pages
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//910293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43665 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 20:11:27 +00:00
ff4e2bfce1
Issue 22188. Verify that none or all execution flows return.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188
Review URL: https://codereview.chromium.org//871013012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43663 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:14:01 +00:00
92e3e1b94a
Fix notifications for nested packages
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//907183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43620 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 22:57:44 +00:00
94dd9d28f8
Fix a null pointer exception
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//908873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43617 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:55:48 +00:00
07d2c82919
Issue 22316. Don't propose to create invalid local variable.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22316
Review URL: https://codereview.chromium.org//895773004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43600 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 16:45:43 +00:00
5194a2b1b4
filter static methods when showing instance completions
...
BUG=dartbug.com/22171
R=scheglov@google.com
Review URL: https://codereview.chromium.org//908493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43580 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-07 00:56:15 +00:00
8cee600323
Don't propose fixes to update SDK sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//902273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43574 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 22:21:48 +00:00
2593c00b36
Quick Fix for adding 'async' to fix invalid 'await'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//894373005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43571 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 21:10:11 +00:00
f43912dfce
fix code completion in string literals
...
BUG=dartbug.com/22297
R=scheglov@google.com
Review URL: https://codereview.chromium.org//907453005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43567 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:07:29 +00:00
bd8778a87b
Quick Assist to add explicit types to formal parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//908503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43566 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:03:39 +00:00
f473ae15a3
Spec changes for issue 22254
...
Review URL: https://codereview.chromium.org//882643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43565 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:35:40 +00:00
eac4b2e0a3
Discard pending notifications on the same source change.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//904093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43564 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:31:13 +00:00
c2d3ff3b95
Handle exception and clean-up code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//907483004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43563 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:19:55 +00:00
4468038300
Rework requests in execution domain
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//904733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43556 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 15:49:44 +00:00
20b64a97a4
fix completion in for statement
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//862803008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43541 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:58:11 +00:00
84350e186c
fix named param default value code completion
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897483003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43540 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:50:57 +00:00
dc95fd3689
use propogated type for completions
...
BUG=dartbug.com/21457
R=scheglov@google.com
Review URL: https://codereview.chromium.org//902983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43539 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:43:15 +00:00
fa0dc53f6f
fix code completion in conditional expressions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//904653004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43538 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:33:07 +00:00
81ebd5fd77
Fix for extracting local variable in if-else-if statements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//879463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43528 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:36:56 +00:00
e5a34c3c12
fix completions in indexed expression
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//902913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43523 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 21:42:43 +00:00
ae2e608ff9
Send notificatinos after no-op changes.
...
This should solve the problem when client remove some part of the code,
so removes also error markers for it, and then quickly restores it,
so for the server it looks as an empty/no-op change. But information is
lost, and the server should resend it to the client.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//899753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43521 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 20:42:17 +00:00
2425d0c57c
const rename and cleanup
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//904603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43520 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:50:42 +00:00
8233434126
move relevance computation from client to server
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//901253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43519 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:36:19 +00:00
a65a5b599b
Have analysis.getLibraryDependencies wait for the server.onAnalysisComplete completer
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//891693003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43489 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 22:06:50 +00:00
6ddc37a5cc
Disable analysis in hidden directories (fix for issue 22170)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//880313006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43485 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:27:43 +00:00
dbd0fa9d68
fix exception and improve keyword completion
...
BUG=dartbug.com/22231
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43466 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 13:18:42 +00:00
51842b06f2
Fix type hierarchy when there is no element.
...
This one was caught by an integration test.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//892913004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43445 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 23:01:51 +00:00
1a94fa3a6a
Wait for analysis in search domain. Rewrite with async/await.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//894323003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43435 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 21:59:31 +00:00
danrubel@google.com