d04ad125fc
Add link to performance data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//892843005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43410 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 17:28:11 +00:00
658d3e949e
Check PackageMapUriResolver constructor arguments.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//887943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43405 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 16:06:25 +00:00
98e926db9a
Support for inspecting index.
...
Page http://127.0.0.1:2040/index/element-by-name?name=sendAnalysisNotificationHighlights
shows all relations with elements named 'sendAnalysisNotificationHighlights'.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//894853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43377 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 03:11:09 +00:00
cd996f37bf
Improve error reporting on status page
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//899513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43374 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:34:29 +00:00
ba6742f9fe
Formatter service API tweaks.
...
Some way to indicate no selection is required in the case where there is none. I opted for the -1 convention not becuase I particularly like it but because, well, it's convention! :)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//894863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43369 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:14:22 +00:00
b40a5702b3
Fix async/await type checking in analyzer.
...
This required making the "async" library into TypeProvider so that we
can create Future<...> types when doing resolution and error/hint
checking.
BUG=21888,22053,22091,22092,22160,22164
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//898513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43361 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 20:58:37 +00:00
03874e1c60
record and display request latency
...
and update unknown page handler
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//894823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43359 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 19:44:51 +00:00
dd09212ee5
fix internal option typo
...
BUG=
Review URL: https://codereview.chromium.org//887053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43339 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 15:53:36 +00:00
01ea08c589
Fix incremental resolution of files referenced by multiple contexts.
...
There were two problems:
1. When a file was set as a priority, we weren't propagating that
information to all contexts; as a result, the resolved AST wasn't
cached in all contexts, so incremental resolution wasn't able to take
place in all contexts.
2. In setPriorityFiles we weren't scheduling analysis operations, so
even after the file was made a priority, its resolved AST wouldn't be
available until some other event triggered analysis in that context.
BUG=dartbug.com/22209
R=scheglov@google.com
Review URL: https://codereview.chromium.org//892493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43323 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 00:27:58 +00:00
f9f324ca9b
Avoid redundant notifications when a file is analyzed in multiple contexts.
...
BUG=dartbug.com/22210
R=danrubel@google.com
Review URL: https://codereview.chromium.org//887793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43315 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 21:42:48 +00:00
675b99110c
fix race condition when recording computeCache performance
...
and improve completion performance status page
BUG=dartbug.com/22205
R=paulberry@google.com
Review URL: https://codereview.chromium.org//889583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43299 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 17:00:57 +00:00
4229cb1c6f
use CompletionTarget for replacement offset/length
...
add code completion replacementLength and replacementOffset assertions
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//886463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43255 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:11:10 +00:00
a016a7b56e
Fix for 'Convert Method to Getter' when multiple files are changed.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43221 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 23:12:23 +00:00
3c66f9be64
Change server API version to 1.0.0 for clients
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//881873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43212 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 22:06:16 +00:00
b280b861f9
Issue 22143. Navigation from super initializers.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22143
Review URL: https://codereview.chromium.org//882823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43209 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 21:50:00 +00:00
c93b24904d
Issue 22157. Cancel a pending refactoring request on receiving a new one.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22157
Review URL: https://codereview.chromium.org//884453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43201 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 19:24:19 +00:00
af8a953cb8
Tweaks for refactoring manager.
...
My forgotten changes for your review comments.
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//880613004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43194 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:39:15 +00:00
b9f355d2a4
Library dependencies server API updates (to pass package maps).
...
R=brianwilkerson@google.com , jwren@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//874373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
4f5494c2ac
Clean up and add analyzing contexts
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//875663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43170 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 03:40:39 +00:00
7bf029506d
Fix "reanalyze sources" when there are unsaved files.
...
The analysis server now maintains a single content cache which is
shared by all contexts; this allows it to persist the content cache
across reanalysis (which destroys all contexts and recreates them from
scratch).
Two other bugs are fixed in the process:
- If a file is analyzed in multiple contexts, then editing it will
cause all affected contexts to be notified of the change. (Note
that this could potentially account for some other strange behaviors
we've seen recently, such as incorrect semantic highlighting and
lingering errors/warnings.)
- If the client supplies a ChangeContentOverlay for a file which
currently has no overlay, the proper error is generated.
I plan to submit tests for these two bugs in a follow-up CL.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//880643005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43163 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:26:45 +00:00
23b8a90d91
Use async/await in edit_domain.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//876633005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43162 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 23:13:47 +00:00
7db81a77c0
Make AnalysisServer.onAnalysisComplete a Future and wait for it before refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//875163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43158 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 22:31:51 +00:00
a9bc5e512d
Issue 22150. Quick fix to add a getter, in addition to create a field.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22150
Review URL: https://codereview.chromium.org//875193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43155 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 22:29:37 +00:00
2b8c66ea79
Rename ChangeNotice resolved Dart/Html unit fields.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//881463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43147 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:58:19 +00:00
dc144bb870
Issue 22155. Send outline for both parsed and resolved Dart units.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22155
Review URL: https://codereview.chromium.org//876703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43145 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:39:36 +00:00
f32f6699bf
Fix for file:// package: references to the same element.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//877693004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43143 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 19:30:45 +00:00
ef257710e1
add periodic delay in analysis to reduce request processing latency
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//874083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43127 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-26 02:10:38 +00:00
768aeeac4b
Use 'print' to send responses/notifications to the client.
...
Ensure that Java client reads lines in a separate thread,
so that server's stdout never overflows.
R=brianwilkerson@google.com , danrubel@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//872633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43123 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 21:33:40 +00:00
3226596c3c
Prioritize analysis operations for contexts with priority files.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//869153003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43118 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 19:29:05 +00:00
f94326c241
add optional request field to record time at which client made request
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//865383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43113 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 17:41:29 +00:00
beff0fa32d
Move indexing into operations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//869793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43090 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 00:32:30 +00:00
4f59e94ce1
update analysis server spec and regen files
...
this is needed to support new UpdateContentConsumer
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//868893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43088 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 23:14:09 +00:00
d284fef9db
cleanup unused imports
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//868803006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43086 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 22:41:51 +00:00
55d1df2cf2
cache completion performance by default
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//867023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43084 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 22:25:38 +00:00
e2bf6de0f9
(TBR) fix the build
...
BUG=
Review URL: https://codereview.chromium.org//872443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43079 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 21:33:00 +00:00
03aa9c33e5
Library Dependencies Analysis service API.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//861893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43077 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 21:26:28 +00:00
a26c95865a
Use a raw string to correctly print \n in option description in the analysis server.
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//867433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43054 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 22:28:57 +00:00
f99f4f3212
improve measurement of completion performance
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//861153003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43051 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 19:33:43 +00:00
14d008359d
Use UTF-8 when serving web pages for analysis server debug.
...
This avoids the need to encode unicode characters using hexadecimal
escape sequences.
(Note that setting the charset using response.headers.contentType
affects the encoding used by both client and server.)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//855643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43045 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 17:57:57 +00:00
30f1b97888
Handle generic parameters correctly in invocation completions.
...
When doing invocation completions, we need to walk the interface
types, not the classes, because the interface types record the actual
types of the generic parameters. This required some rework because
the old technique used an element visitor, and interface types can't
be visited using an element visitor.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//829173003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43040 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 15:16:50 +00:00
252c19c920
Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with IntelliJs integration.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//857283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43028 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:48:00 +00:00
f7915c7a84
Return outline after parse
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//842533004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43027 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 21:36:14 +00:00
0b975704b5
Alternate status page
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//840953008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43020 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 18:46:44 +00:00
f5f408e412
send priority instrumentation message on startup with version info
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//859513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43017 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 17:30:47 +00:00
96462aab53
Send notifications using separate server operations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//847663005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42970 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 20:11:47 +00:00
bcad595a17
Revert "Addition of the optional FileReadMode into the server spec."
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//838243004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42965 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 17:39:32 +00:00
288694de4e
Console was removed from dart:io.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//854183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42964 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 17:37:13 +00:00
30ae29f4f2
Reapply revert of "Make stdout/stderr async"
...
This re-applies r42909 which was reverted in r42910 with a few fixes.
TBR=ajohnsen@google.com
BUG=
Review URL: https://codereview.chromium.org//851253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42953 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 13:35:37 +00:00
3eb4d4f9a2
Include overlays contents.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//854703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42943 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 04:50:36 +00:00
a737481621
improve completion performance status page
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//813563007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42941 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 00:33:20 +00:00
brianwilkerson@google.com