18758d3d22
fix exception when completing between arglist and body
...
BUG=dartbug.com/22885
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1038673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44687 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:27:44 +00:00
ac87c46ebd
exclude identifier being completed from list of suggestions
...
BUG=dartbug.com/22747
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1027693007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44683 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 12:46:08 +00:00
8811f05a1d
Fix hints in the analysis_server package.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1027273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44638 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 17:28:57 +00:00
a640643eeb
Quick Fixes for unused catch clause/stack.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1020853006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44636 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 17:10:14 +00:00
03cac10578
improve parser recovery of type argument list
...
BUG=
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//1025903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44626 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-22 18:33:23 +00:00
6150881e01
Add plugin info to the status page
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1020813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44620 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 23:23:13 +00:00
cd1b09f5c3
Simplify rules for extracting getters.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1026503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44607 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 18:54:56 +00:00
9f92f24c59
Issue 22851. Append comment tokens after sorted directives.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22851
Review URL: https://codereview.chromium.org//1019993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44591 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 20:54:40 +00:00
56ff9d92e7
Add engine plugin
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1026483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44589 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 20:08:05 +00:00
b36c00f15f
Temporarily move plugin support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1027433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44586 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 19:06:22 +00:00
39c3a6c255
Issue 22886. Quick fixes create getter' and 'create field' for hints.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22886
Review URL: https://codereview.chromium.org//1024573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44585 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 18:16:04 +00:00
a115d9dd7c
remove pub list caching
...
BUG=
R=jwren@google.com
Review URL: https://codereview.chromium.org//998993005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44544 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 22:05:21 +00:00
7eae9c4902
Fix for NPE in the field creation Quick Fix.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1013303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44542 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 20:29:47 +00:00
4cdce46316
Issue 22757. Update self references on package rename.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22757
Review URL: https://codereview.chromium.org//1010803003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44524 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 21:28:57 +00:00
ca64df1d44
Casted variable declarations for 'if (v is! Type)' should be declared after IfStatement.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1012913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44517 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 19:26:33 +00:00
a28e99b719
Issue 22757. Create pubspec.yaml file change on project rename.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22757
Review URL: https://codereview.chromium.org//1015513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44515 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 18:59:16 +00:00
b44673fef0
Quick Fix for adding field formal parameters of not initialized final fields.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1018433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44514 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 18:18:19 +00:00
e2ee41cd3f
Use faster way to get AnalysisContext in execution domain notifications.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1015463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44513 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 18:16:37 +00:00
b34d061d1f
Issue 22834. Disable 'Add type annotation' Quick Assist if the type is not accessible.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22834
Review URL: https://codereview.chromium.org//1014503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44509 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 15:26:58 +00:00
a9975332ac
Issue 22833. Quick Assist to convert for-each into for-index.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22833
Review URL: https://codereview.chromium.org//1012623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44507 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 15:06:18 +00:00
dbf1e4cbe0
Quick Assist for creating a constructor for selected final fields.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1009833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44504 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 15:00:28 +00:00
28764d3a93
Quick Fix for creating a missing part file.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1013543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44497 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-15 23:39:50 +00:00
da0cecb331
Issue 22845. Rename should prevent the use of invalid identifiers.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22845
Review URL: https://codereview.chromium.org//1011613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44495 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-15 19:55:57 +00:00
2eafc9fc9c
Display synthetic nodes on status page
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1008153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44493 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-15 16:03:25 +00:00
0a63518267
include library prefix completions given trailing local method invocation
...
BUG=dartbug.com/22790
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1008973003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44491 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-14 03:09:29 +00:00
31339e3a62
Completion should not show overridden inherited methods
...
and centralize checking for duplicate suggestions
BUG=dartbug.com/22396
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1004343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44490 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-14 03:07:12 +00:00
0c21dc284c
Add 'containingClassDescription' to HoverInformation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1003193005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44483 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 22:05:05 +00:00
5903f0c31c
include unimported sdk lib types as low priority suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1000223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44473 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 19:15:46 +00:00
4dac0013c0
Fix hints
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1008583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44447 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:58:22 +00:00
b03f3cd6a3
If the file belongs to any analysis root, check whether we're in it now.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1000203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44445 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:46:43 +00:00
676e027663
remove duplicate completion suggestions
...
BUG=dartbug.com/22684
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1001143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44444 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:40:55 +00:00
aa442339ae
Fix completion before core is analyzed
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1008533002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44441 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 19:31:50 +00:00
e867811d28
include constructor arguments in completion suggestions
...
BUG=dartbug.com/22364
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1006593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44438 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 18:46:06 +00:00
47128e2603
completions in map literals
...
BUG=dartbug.com/22784
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1002713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44432 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 15:24:57 +00:00
8a04710a47
add completion in type argument list
...
BUG=dartbug.com/22584
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1005483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44431 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 15:20:08 +00:00
fcc0559acd
completions for function return type
...
BUG=dartbug.com/22686
R=scheglov@google.com
Review URL: https://codereview.chromium.org//999923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44415 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 21:19:57 +00:00
fc4de72889
completion for method return type after comment
...
BUG=dartbug.com/22686
R=scheglov@google.com
Review URL: https://codereview.chromium.org//996263003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44409 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 17:44:25 +00:00
6c1a40377c
fix completion target handling of comments
...
The intent is to normalize the completion target returned given different comment arrangements.
This is a precursor to the fix for code completions given preceeding comments.
BUG=dartbug.com/22686
R=paulberry@google.com
Review URL: https://codereview.chromium.org//985183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44408 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 17:38:53 +00:00
29c0fb7cd6
Add an analyzer option to properly check ".call" methods.
...
Enabling this option fixes issue 21938. For now the option is
disabled by default, since there is a lot of code in the dart SDK (and
in third_party) that isn't warning clean with this option enabled.
Once the SDK and third_party code have been cleaned up, we should be
able to turn this option on permanently.
BUG=dartbug.com/21938
R=scheglov@google.com
Review URL: https://codereview.chromium.org//994253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44390 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 00:35:31 +00:00
50dfd3c1ff
Handle IO exception in ContextManager
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//995873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44377 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 16:15:05 +00:00
3f2c48008f
Fix NPE in ContextManager
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//996773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44376 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 16:13:43 +00:00
dbcce3568e
Fix for dartbug.com/22656- analysis.flushedResults implementation.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//987143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44373 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 14:54:00 +00:00
51870ff901
Quick Fix for using similarly named field/getter/setter instead of undefined.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//991133003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44357 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 03:09:00 +00:00
2e77fcdd11
Add an optional 'typeParameters' to Element.
...
Also use it in Editor, e.g. in Outline.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//990343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44349 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 22:02:44 +00:00
7a8603736d
Quick Fix for returning Future from 'async' functions.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//987173002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44348 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 21:35:31 +00:00
faab2d3863
Don't schedule indexing operations if index is null.
...
R=jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//993723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44347 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 21:27:36 +00:00
ea3790c960
Fix for issue 22733
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//994723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44336 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 19:12:55 +00:00
d954183441
Change all sources associated with changed files (issue 22680)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//981283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44335 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 18:28:21 +00:00
9df7bc68b5
Allow sending duplicate notifications.
...
This will "unfix" dartbug.com/22210 , but at the same time it will
remove most of of expensive AnalysisContext calculations introduced
in https://code.google.com/p/dart/source/detail?r=44305
It reduces "notices" tag percentage from 15 to a little above 3.
Also, we don't produce errors for external sources, which was the
main problem in dartbug.com/22210.
There is also the same expensive computation in execution domain.
I will address it in a separate CL.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//986663004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44330 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 16:57:28 +00:00
60d4a29500
Fix for subscribing for notifications for files in packages.
...
Unfortunately this fix makes the server about 20% slower.
This is mostly because of the check in scheduleNotificationOperations(),
as required to fix dartbug.com/22210. I think it is much cheaper to send
duplicate notifications, like outline or navigation, than to check if
they should not be sent.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//987663002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44305 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-06 22:55:20 +00:00
danrubel@google.com