Commit Graph

2739 Commits

Author SHA1 Message Date
asiva@google.com d3eb344f08 Do not generate code to create a CallStack in the ConsoleBase calls as that
variable is not used at all.

R=jacobr@google.com

Review URL: https://codereview.chromium.org//153183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32265 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 22:47:46 +00:00
rmacnak@google.com 3364d3f78a Adapt tools/full-coverage.dart to changes in the isolate API and coverage output format.
BUG=http://dartbug.com/16352
R=iposva@google.com

Review URL: https://codereview.chromium.org//137143018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32256 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 18:33:02 +00:00
johnniwinther@google.com 7b52480b56 Align source mirrors with runtime mirrors.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//119913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32195 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 14:15:26 +00:00
jmesserly@google.com 0f277224e8 update custom elements and shadow dom
R=blois@google.com

Review URL: https://codereview.chromium.org//140853005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32171 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 20:56:22 +00:00
sigmund@google.com fdc6d43083 Improve how we handle packages/ HTML imports. This improves resolution of URLs containing
"package/" under the web/ directory. Resolution under 'lib' is the same, but it and gives better suggestions if the path looks wrong. This summarizes what changed:

- source file: lib/b.html

  import to "packages/c/d.html" was error, now is error + suggestion
  import to "../packages/c/d.html" was error, now is error + suggestion
  import to "../../packages/c/d.html" was resolved, now is resolved too

- source file: lib/a/b.html

  import to "packages/c/d.html" was error, now is error + suggestion
  import to "../packages/c/d.html" was error, now is error + suggestion
  import to "../../packages/c/d.html" was error, now is error + suggestion
  import to "../../../packages/c/d.html" was resolved, now is resolved too

- source file: web/b.html

  import to "packages/c/d.html" was and continues to be resolved
  import to "../packages/c/d.html" was error, now is resolved

- source file: web/a/b.html

  import to "packages/c/d.html" was error, now is resolved
  import to "../packages/c/d.html" was and continues to be resolved
  import to "../../packages/c/d.html" was and continues to be resolved

Note: polymer-build and development mode are slightly different: polymer-build
detects and issues an error for bad paths inside lib/. These are not detected by
our package-resolution in loader.dart, but as long as users are not creating
symlinks by hand, Dartium should detect if the paths are wrong.

When we switch to start using pub-serve by default, we should be able to go back
to the web-ui style of using "package:" urls directly in HTML.

R=jmesserly@google.com, kustermann@google.com

Review URL: https://codereview.chromium.org//148913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32170 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 20:51:28 +00:00
ricow@google.com 0306e06b5f Allow copy_coredumps flag on all platforms.
This will have not effect on winodws/mac yet, since the core file will not be there.

Don't try to archive on non linux platforms

I will apply this flag on all vm bots - setting this up on system basis is harder, and this is a no-op on mac/windows

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//148283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32117 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 11:45:36 +00:00
ricow@google.com b89331831e Fix static warnings introduced by not having pid in base CommandOutput class.
Review URL: https://codereview.chromium.org//137823008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32116 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 10:51:53 +00:00
ricow@google.com c2f12c4da6 Add support for copying coredumps to /tmp
This will be used on the bots to be able to archive dumps from unexpectec crashes.

The tools/archive_crash.py tool will be used to actually archive the dumps to gcs and delete the local copies. The reason for the split is to enable developers to actually utilize this locally as well (run tools/test.py in a loop but don't archive the expected crashes). Additionally, this puts the bot specific code in the small python script.

R=whesse@google.com

Review URL: https://codereview.chromium.org//145273024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32111 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 09:41:47 +00:00
whesse@google.com c7fdd3b521 Add testing script to test Dartium on Android devices.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//137623008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32103 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 06:14:34 +00:00
ricow@google.com 1252f88cff Give default value for builder_tag in test options
Remove now passing test pkgbuild/samples/third_party/angular_todo suppression

Review URL: https://codereview.chromium.org//148893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32068 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 14:47:25 +00:00
ricow@google.com 8b959be6fe Add builder_tag option to tools/test.dart
This will allow us to pass in machine specific tags that describes the setup of a given machine.

Use this to pass in the locale on the pub russian bot and to suppress the two failures we have due to issue 16356

R=kasperl@google.com

Review URL: https://codereview.chromium.org//148463007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32061 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 09:55:49 +00:00
alanknight@google.com 3730236bdf Add a snapshot for docgen and use it in the build
R=efortuna@google.com, ricow@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//116043013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32025 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-27 18:40:34 +00:00
sra@google.com 9f09fcbaac Redo "Make dart2js typed_data implementation classes private"
This time with analyzer suppression for new library/

BUG=

Review URL: https://codereview.chromium.org//141653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31935 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 23:01:26 +00:00
sra@google.com 9ceaef9d73 Revert "Redo "Make dart2js typed_data implementation classes private""
Revert while I figure out the correct analyzer suppression.

BUG=

Review URL: https://codereview.chromium.org//141523008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31933 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 21:54:18 +00:00
sra@google.com 42b1721927 Redo "Make dart2js typed_data implementation classes private"
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//138543005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31930 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 21:08:40 +00:00
blois@google.com 192df7e88b Fixing TouchEvent.supported
It was reporting as not being supported because there's no Window.ontouch, but the constructor is now working.

TBR
BUG=

Review URL: https://codereview.chromium.org//141113006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31907 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 02:49:43 +00:00
kustermann@google.com d4bfaaafd6 Change bleeding_edge version to 1.2.0-edge.REV
R=ricow@google.com

Review URL: https://codereview.chromium.org//134643016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31903 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 23:13:40 +00:00
blois@google.com 93b7001172 Making readonly fields on interfaces be readonly
This will be causing compilation warnings once https://codereview.chromium.org/140803002 is landed.

BUG=16105
R=vsm@google.com

Review URL: https://codereview.chromium.org//140903003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31892 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 18:13:48 +00:00
lrn@google.com 3b3e87cabc Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Committed: https://code.google.com/p/dart/source/detail?r=31827

R=floitsch@google.com

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31877 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 12:06:38 +00:00
iposva@google.com adcb051df3 - Undo inadvertent change to test_runner.dart
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31869 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 05:13:41 +00:00
iposva@google.com 39eec505e1 - Update svn:ignore.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31868 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 05:09:35 +00:00
iposva@google.com 781f737c6a First round of http://dartbug.com/15922:
- Address warnings about 64-bit to 32-bit conversions.
- Remove heap profiler.

R=asiva@google.com

Review URL: https://codereview.chromium.org//139043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31867 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 05:05:35 +00:00
sra@google.com 8ffab76c82 Revert "Redo "Make dart2js typed_data implementation classes private""
Review URL: https://codereview.chromium.org//140543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31866 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 05:03:02 +00:00
sra@google.com 83ae5cfabf Redo "Make dart2js typed_data implementation classes private"
The main library is now private, with the user visible library as small re-export library.

R=blois@google.com, floitsch@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//130563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31865 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 04:27:50 +00:00
ahe@google.com bd2ad26d7a Don't eat non-empty chunks.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//138943005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31838 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 17:05:05 +00:00
ahe@google.com 974911e404 Update build.py to handle tweaked Xcode output in newer versions of Xcode.
R=ricow@google.com

Review URL: https://codereview.chromium.org//139443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31832 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 14:57:58 +00:00
lrn@google.com ead87f47e9 Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31827 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 12:27:44 +00:00
lrn@google.com 0098710559 Rename internal library dart:_collection-dev to dart:_internal.
BUG= http://dartbug.com/14140
R=floitsch@google.com

Review URL: https://codereview.chromium.org//133893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31823 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 09:24:46 +00:00
kustermann@google.com db052838a1 Run out.precompiled.js for commandline JS runtimes instead of out.js
R=whesse@google.com

Review URL: https://codereview.chromium.org//136333005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31735 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 12:26:32 +00:00
vsm@google.com e86b75260b Add special case templates to handle Global/WindowEventHandlers
TBR=blois@google.com

BUG=15954

Review URL: https://codereview.chromium.org//133693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31714 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 21:59:38 +00:00
vsm@google.com eebdf4ccf9 Revert "Revert "Revert "Fix dart2js type warnings"""
Hitting layout test failures in Dartium now....

TBR=blois@google.com
BUG=

Review URL: https://codereview.chromium.org//134623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31702 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:27:09 +00:00
vsm@google.com f236af9969 Revert "Revert "Fix dart2js type warnings""
Retrying with a fix.  Patch 1 is initial change.

BUG=15954
R=blois@google.com

Review URL: https://codereview.chromium.org//126873003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31699 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:00:03 +00:00
kustermann@google.com 54b71bdbe2 Reaply "Use a real package-root for all of our samples (and tests inside a package) instead of buildDir/packages/"
R=whesse@google.com

Review URL: https://codereview.chromium.org//133653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31694 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 15:15:37 +00:00
kustermann@google.com 8afb1d4844 Revert "Use a real package-root for all of our samples (and tests inside a package) instead of buildDir/packages/"
Review URL: https://codereview.chromium.org//130743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31693 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 12:58:33 +00:00
kustermann@google.com 76e4bdeb0c Use a real package-root for all of our samples (and tests inside a package) instead of buildDir/packages/
For all tests that depend on other packages (e.g. samples) we can
 - use packages from pub.dartlang.org
 - use packages from pub.dartlang.org with overrides for the packages we have
   in the dart repository.

This CL does NOT include test-specific package-roots for dartium. Dartium will request a URL containing
"packages" when it encounters a package import. Our HTTP server will then serve from buildDir/packages.
This needs to change when we have test specific VMOptions for dartium.

For normal tests (without a pubspec.yaml on the path to dart/, we still use buildDir/packages).

R=ricow@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//126173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31691 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 12:29:55 +00:00
kustermann@google.com 6b219869ec Add content_shell to the list of processes that get killed in the task_kill.py step
R=ricow@google.com

Review URL: https://codereview.chromium.org//131743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31656 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 14:07:20 +00:00
kustermann@google.com 338fabdb6c Cancel stdout/stderr subscriptions once subprocesses are dead, add more debugging information in case the debug timer expires
R=whesse@google.com

Review URL: https://codereview.chromium.org//128703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31649 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 09:04:46 +00:00
blois@google.com 1820da3a53 Fixing Window.animationFrame timing issue
Was using async completer which changes the timing.

Additional Dartium changes are from https://codereview.chromium.org//111613002 which did not re-gen the Dartium file.

BUG=15848
R=efortuna@google.com

Review URL: https://codereview.chromium.org//98183006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31590 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 23:33:46 +00:00
vsm@google.com 0a7a4e8646 Revert "Fix dart2js type warnings"
This is breaking the Dartium build.  Will investigate and hopefully resubmit.

TBR=blois@google.com

Review URL: https://codereview.chromium.org//126883003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31588 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 23:13:20 +00:00
vsm@google.com 5755d7d28a Fix dart2js type warnings
This should fix the errors reported here:

http://chromegw.corp.google.com/i/client.dart/builders/dart2js-linux-release-checked-5-5-be/builds/2126/steps/dart2js_unit%20tests%20--checked/logs/stdio

Should we make these types private?

R=blois@google.com

Review URL: https://codereview.chromium.org//126793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31587 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 22:49:38 +00:00
vsm@google.com f119db9dfb Fix unknown type error in html_*.dart
The type Matrix is used unqualified in html_*.dart (CanvasRenderingContext2D.currentTransform).  This imports that type only unqualified.

Is there a better way to do this?

R=blois@google.com

Review URL: https://codereview.chromium.org//126693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31585 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 22:10:52 +00:00
asiva@google.com 7ea7adfe16 Add more functions to the list of leaf functions which do not need an
auto generated dart scope. Resulting improvements in the Dromaeo benchmarks

getAttribute 1072.0 1529.0
element_property_access 1304.0 1987.0
setAttribute 305.38922155688624 422.1556886227545
element_property_assignment 509.4905094905095 668.0
getElementById 1012.0 1523.0
getElementById (not in document) 2440.0 3279.0
getElementsByTagName(div) 119232.0 155037.0
getElementsByTagName(p) 109280.0 148015.0
getElementsByTagName(a) 119869.0 156460.0
getElementsByTagName(*) 114050.0 146375.0
getElementsByTagName (not in document) 172848.0 238313.0
getElementsByName 1356.0 1724.0
getElementsByName (not in document) 2657.0 2891.0

R=rmacnak@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//113743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31582 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 21:48:17 +00:00
blois@google.com dd84eacad7 Suppressing media events from list of global events.
Fixes analyzer issue

TBR
BUG=

Review URL: https://codereview.chromium.org//108943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31563 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 18:40:30 +00:00
blois@google.com 0e62a20627 Removing media events from Document and Element.
We were already doing this for Window, but they just got added to Element & Document in Chrome 32. Suppressing them as they aren't needed and can be used from MediaElement already.

TBR
BUG=

Review URL: https://codereview.chromium.org//109473009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31562 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 18:34:37 +00:00
vsm@google.com 1436645a1b Rerun go.sh
Regenerating with Chrome 32 IDL.

TBR=blois@google.com,efortuna@google.com

Review URL: https://codereview.chromium.org//94043006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31558 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 17:58:22 +00:00
kustermann@google.com 2dca82b247 Make TestUtils.copyDirectory() more robust by ensureing arguments are a native path
Review URL: https://codereview.chromium.org//126053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31550 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 15:38:15 +00:00
kustermann@google.com 704fa7b241 Convert statusfile path to native path
R=ricow@google.com

Review URL: https://codereview.chromium.org//125973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31544 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 14:05:30 +00:00
kustermann@google.com ba8e16e806 Write testoutcomelog on pub builders + append to logfiles on later test.py runs
R=ricow@google.com

Review URL: https://codereview.chromium.org//125933002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31542 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 13:21:28 +00:00
kustermann@google.com 82d9dca9dd Run pkbuild with public packages from pub.dartlang.org as well
R=ricow@google.com

Review URL: https://codereview.chromium.org//125853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31538 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 10:23:27 +00:00
kustermann@google.com e363ffb931 Enable pkgbuild testsuite on pub builders
R=ricow@google.com

Review URL: https://codereview.chromium.org//125833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31537 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 10:12:10 +00:00