Commit Graph

21645 Commits

Author SHA1 Message Date
nweiz@google.com 23c2fcd648 Add a bunch of toString methods to internal Barback classes.
These will make it easier to debug barback by making it easier to
inspect the current state.

R=alanknight@google.com
BUG=

Review URL: https://codereview.chromium.org//155213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32304 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 00:47:00 +00:00
sra@google.com 8b14fbced0 Redo "Fix for issue 16497 - fix load elimination aliasing for typed arrays"
Re-add assignment 'cast' to avoid analyzer warning.

Review URL: https://codereview.chromium.org//155123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32302 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 23:33:29 +00:00
sra@google.com 020c305407 Revert "Fix for issue 16497 - fix load elimination aliasing for typed arrays"
BUG=

Review URL: https://codereview.chromium.org//155113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32301 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 23:26:30 +00:00
sra@google.com 589123472f Fix for issue 16497 - fix load elimination aliasing for typed arrays
R=floitsch@google.com

Review URL: https://codereview.chromium.org//154353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32300 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 23:06:19 +00:00
kevmoo@google.com 8184cfc847 pkg/unittest: remove rerunTests
R=nweiz@google.com

Review URL: https://codereview.chromium.org//154323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32298 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 22:38:01 +00:00
nweiz@google.com 8b77eae11c Do not warn about packages without lib dir while pub get. (http://dartbug.com/16515)
BUG=http://dartbug.com/16515
R=nweiz@google.com

Review URL: https://codereview.chromium.org//141443006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32294 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 21:51:49 +00:00
alanknight@google.com da43d16ec5 Let users specify the start page of the resulting docs
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//154373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32293 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 21:35:32 +00:00
alanknight@google.com 56ea63472c Fix missing package qualifier for typedefs
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//138073013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32291 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 21:25:15 +00:00
alanknight@google.com 5fe10e575b Print options when given no arguments instead of crashing
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//143403006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32290 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 21:22:52 +00:00
kevmoo@google.com 9b5165c2f8 Reverting 32284 - unittest using zones - investigating breaks in html
R=blois@google.com

Review URL: https://codereview.chromium.org//135013006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32288 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 20:51:44 +00:00
pquitslund@google.com 5c26be4b49 Indent fix for trailing comments (dartbug.com/16383).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//153203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32287 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 20:50:12 +00:00
kevmoo@google.com 245640e3d9 pkg/unittest: Run each test in a Zone
added a change log
Deprecate methods with behavior subsumed by runZoned
removed rerunTests
updated async/future_timeout_test to not assume Zone.ROOT during test run

BUG= https://code.google.com/p/dart/issues/detail?id=13277
R=nweiz@google.com

Review URL: https://codereview.chromium.org//130173010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32284 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 17:52:44 +00:00
johnniwinther@google.com 9b55806eb4 Test source mirrors with lib/mirrors test.
BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org//108753003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32280 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 13:37:10 +00:00
floitsch@google.com ee2258d2e2 Infer types for compile-time constant closures.
BUG= http://dartbug.com/16448
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32276
Reverted: https://code.google.com/p/dart/source/detail?r=32278

Review URL: https://codereview.chromium.org//147353010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32279 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 12:40:13 +00:00
floitsch@google.com dd85f3885f Revert "Infer types for compile-time constant closures."
This reverts commit r32276.

Review URL: https://codereview.chromium.org//141713007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32278 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 10:29:42 +00:00
ajohnsen@google.com fd18e472e6 Optmize detached socket to not contain a extra stream controller/subscription, but simly forward callbacks (and inject potential extra data).
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//141553014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32277 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 10:27:43 +00:00
floitsch@google.com 75ff4c8315 Infer types for compile-time constant closures.
BUG= http://dartbug.com/16448
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//147353010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32276 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 10:02:55 +00:00
lrn@google.com 6f4ac08a2b Add Capability implementation to dart2js libraries.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//152633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32275 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 09:30:46 +00:00
lrn@google.com 29dd07f51a Add Capability class.
Currently throws UnimplementedError in constructor patches. All implementation is still missing.

R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//148883009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32274 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 09:23:38 +00:00
ricow@google.com 18c7d04d90 Remove non existent paths from the analyze_library suite and add bugs for all other entries
R=kasperl@google.com

Review URL: https://codereview.chromium.org//138303005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32273 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 09:00:44 +00:00
sra@google.com 56b09ad90b Test for Issue 16497
Review URL: https://codereview.chromium.org//132883020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32272 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 03:33:02 +00:00
asiva@google.com 732d1a44de Add a UpdatedGuardedCidBit to Class object so that we don't have
to iterate over all the classes and it's fields to update the
GuardedCid value on each call to Dart_Allocate.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//153103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32271 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 01:12:55 +00:00
sigmund@google.com f924fac14a Use a transformer to initialize custom elements and call initMethod. This is the
first step to removes the dependence on mirrors in the deployable application.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//151893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32270 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 01:08:50 +00:00
nweiz@google.com 061ed62abc Avoid "cannot create a Trace from null" errors in pub.
These errors cover up other errors. They were caused because dart:io
produces asynchronous errors without associated stack traces, and when
running without --trace or --verbose pub doesn't add its own trace
information to these errors.

R=alanknight@google.com
BUG=16470

Review URL: https://codereview.chromium.org//133213011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32267 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 23:02:58 +00:00
asiva@google.com d3eb344f08 Do not generate code to create a CallStack in the ConsoleBase calls as that
variable is not used at all.

R=jacobr@google.com

Review URL: https://codereview.chromium.org//153183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32265 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 22:47:46 +00:00
nweiz@google.com 95e495af6e Ensure that a locked git dependency is downloaded correctly.
Previously, if a git dependency's version was locked but its repo
wasn't available locally, attempting to download it would crash pub.

This also enhances some logging infrastructure around git and other
processes.

R=alanknight@google.com
BUG=16470

Review URL: https://codereview.chromium.org//145633008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32264 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 22:27:11 +00:00
jmesserly@google.com fdc29a9ed5 regenerate fixed custom_elements polyfill
fixes an issue in the previous package, it was missing MutationObservers which it expects included in the binary generated by Grunt.
This did not happen because the sources are pulled in from a relative path, rather than being included in the repository, and there was unfortunately no error issued.

R=blois@google.com

Review URL: https://codereview.chromium.org//153063003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32263 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 21:52:24 +00:00
brianwilkerson@google.com 7ca113a5ac Fix the build. Not sure why this test passes on my local machine but not on the bot.
Review URL: https://codereview.chromium.org//144953004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32262 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 20:55:31 +00:00
brianwilkerson@google.com b4d20f6c94 Rename getNextAnalysisTask and clean-up one method
R=scheglov@google.com

Review URL: https://codereview.chromium.org//153043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32261 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 20:14:25 +00:00
kevmoo@google.com d808a3ce93 pkg/unittest: renamed new test, marked as failing on dartium due to issue 13921
R=sigmund@google.com

Review URL: https://codereview.chromium.org//148213012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32260 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 20:11:33 +00:00
floitsch@google.com 1a64cb2a18 Mark custom/document_register_type_extensions_test/functional as flaky.
Review URL: https://codereview.chromium.org//153013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32257 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 18:58:05 +00:00
rmacnak@google.com 3364d3f78a Adapt tools/full-coverage.dart to changes in the isolate API and coverage output format.
BUG=http://dartbug.com/16352
R=iposva@google.com

Review URL: https://codereview.chromium.org//137143018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32256 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 18:33:02 +00:00
kevmoo@google.com 6847e55c67 pkg/unittest: more lock-down, cleanup
TestCase: cannot set 'enabled' directly. Use enable/disableTest top-level method
TestCase: pass, fail, error are now private

Tests for protectAsyncN
Moved private helper classes into their own files
html_enhanced_config: fixed usage of deprecated query apis

R=sigmund@google.com

Review URL: https://codereview.chromium.org//149573006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32255 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 18:24:17 +00:00
rmacnak@google.com 509556a094 Fix handling of CRLF line endings in Script::GetSnippet.
BUG=http://dartbug.com/16098
R=hausner@google.com

Review URL: https://codereview.chromium.org//132773006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32254 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 18:11:57 +00:00
floitsch@google.com f336830ceb classes with call-methods were not recognized as Functions.
Also fixes similar issue (classes with 'call' getter were recognized as Function).

BUG= http://dartbug.com/16401
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//147743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32252 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 17:45:01 +00:00
johnmccutchan@google.com 2bfa3e40ae Doc fixes
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//144863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32247 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 16:32:05 +00:00
sigurdm@google.com 797e38b133 Mark test as slow.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//132883018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32246 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 14:23:30 +00:00
vegorov@google.com 0470bef7e8 Fix html/js test on Dartium.
Don't use identity check on strings, use equality instead.

R=kasperl@google.com
BUG=

Review URL: https://codereview.chromium.org//136953005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32245 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 13:51:59 +00:00
vegorov@google.com 0b33ed017c Ensure that dart:js does not attempt to load cached proxies from prototypes.
dart:js caches proxies on the object itself thus it must guard loading cached proxy from the object with a hasOwnProperty check.

R=justinfagnani@google.com
BUG=dart:16199

Review URL: https://codereview.chromium.org//138723006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32244 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 13:01:27 +00:00
kasperl@google.com c1e482f27a Revert "Deal with intercepted fields in the InstanceMirror.getField optimizations."
This reverts r32236 in an attempt to figure out if this is the cause of the
redness on the dart2js build bots that I cannot reproduce locally.

R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//131003015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32243 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 12:54:22 +00:00
sigurdm@google.com f8d3b2d466 Emit the type test support code to the right output unit.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//141023007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32239 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 09:55:09 +00:00
johnniwinther@google.com 99d4b3343d Another analyzer nondeterminism.
BUG=

Review URL: https://codereview.chromium.org//152583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32238 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 09:50:24 +00:00
fschneider@google.com baa148b853 Fix wrongly recorded uses after polymorphic inlining.
When inlining function bodies at a polymorphic site, uses at the
callee graph entry need to be removed since this block
is removed in the process of inlining.

BUG=dartbug.com/16404
TEST=pkgbuild/samples/searchable_list
R=srdjan@google.com

Review URL: https://codereview.chromium.org//151653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32237 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 09:46:18 +00:00
kasperl@google.com be24067f8d Deal with intercepted fields in the InstanceMirror.getField optimizations.
R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//150973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32236 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 08:26:58 +00:00
johnniwinther@google.com 3f54abdff5 Fix analyzer redness.
BUG=

Review URL: https://codereview.chromium.org//152543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32235 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 08:22:21 +00:00
floitsch@google.com 9f1ebd7f55 Mark issue14236 test as RuntimeError in addition to crash.
Review URL: https://codereview.chromium.org//151903004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32233 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-01 02:22:25 +00:00
floitsch@google.com 630ec3f4ed Mark Timer_A01_t01 as flaky on Dartium.
Review URL: https://codereview.chromium.org//151943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32232 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-01 01:54:36 +00:00
floitsch@google.com d94eacec20 Mark custom/js_custom_test as flaky
Review URL: https://codereview.chromium.org//147223004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32231 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-01 01:47:06 +00:00
floitsch@google.com 0976357b34 Mark custom_elements_test/mixins as flaky
Review URL: https://codereview.chromium.org//130913015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32230 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-01 01:42:13 +00:00
floitsch@google.com 8d666f47b9 Mark noscript_test as flaky.
Review URL: https://codereview.chromium.org//130913014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32229 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-01 01:38:26 +00:00