Add builder_tag option to tools/test.dart

This will allow us to pass in machine specific tags that describes the setup of a given machine.

Use this to pass in the locale on the pub russian bot and to suppress the two failures we have due to issue 16356

R=kasperl@google.com

Review URL: https://codereview.chromium.org//148463007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32061 260f80e4-7a28-3924-810f-c04153c831b5

pkg/pkgbuild.status

@@ -17,3 +17,7 @@ pkg/stack_trace: PubGetError
 
 [ $use_public_packages ]
 pkg/watcher: PubGetError # Issue 16026
+
+[ $builder_tag == russian ]
+samples/third_party/angular_todo: Fail # Issue 16356 
+samples/third_party/pop-pop-win: Fail # Issue 16356

tools/bots/bot.py

@@ -40,11 +40,12 @@ class BuildInfo(object):
   - arch: The architecture to build on.
   - dart2js_full: Boolean indicating whether this builder will run dart2js
     on several different runtimes.
+  - builder_tag: A tag indicating a special builder setup.
   """
   def __init__(self, compiler, runtime, mode, system, checked=False,
                host_checked=False, minified=False, shard_index=None,
                total_shards=None, is_buildbot=False, test_set=None,
-               csp=None, arch=None, dart2js_full=False):
+               csp=None, arch=None, dart2js_full=False, builder_tag=None):
     self.compiler = compiler
     self.runtime = runtime
     self.mode = mode
@@ -58,6 +59,7 @@ class BuildInfo(object):
     self.test_set = test_set
     self.csp = csp
     self.dart2js_full = dart2js_full
+    self.builder_tag = builder_tag
     if (arch == None):
       self.arch = 'ia32'
     else:

tools/bots/pub.py

@@ -15,7 +15,7 @@ import sys
 
 import bot
 
-PUB_BUILDER = r'pub-(linux|mac|win)(-russian)?'
+PUB_BUILDER = r'pub-(linux|mac|win)(-(russian))?'
 
 def PubConfig(name, is_buildbot):
   """Returns info for the current buildbot based on the name of the builder.
@@ -29,9 +29,11 @@ def PubConfig(name, is_buildbot):
     return None
 
   system = pub_pattern.group(1)
+  locale = pub_pattern.group(3)
   if system == 'win': system = 'windows'
 
-  return bot.BuildInfo('none', 'vm', 'release', system, checked=True)
+  return bot.BuildInfo('none', 'vm', 'release', system, checked=True,
+                       builder_tag=locale)
 
 
 def PubSteps(build_info):
@@ -41,17 +43,19 @@ def PubSteps(build_info):
     print 'Building package-root: %s' % (' '.join(args))
     bot.RunProcess(args)
 
-  bot.RunTest('pub', build_info, ['--write-test-outcome-log',
-      'pub', 'pkg', 'dartdoc', 'docs'])
+  common_args = ['--write-test-outcome-log']
+  if build_info.builder_tag:
+    common_args.append('--builder-tag=%s' % build_info.builder_tag)
+                 
+  bot.RunTest('pub', build_info,
+              common_args + ['pub', 'pkg', 'dartdoc', 'docs'])
 
   pkgbuild_build_info = bot.BuildInfo('none', 'vm', 'release',
       build_info.system, checked=False)
   bot.RunTest('pkgbuild_repo_pkgs', pkgbuild_build_info,
-      ['--append_logs', '--write-test-outcome-log',
-       '--use-repository-packages', 'pkgbuild'])
+      common_args + ['--append_logs', '--use-repository-packages', 'pkgbuild'])
   bot.RunTest('pkgbuild_public_pkgs', pkgbuild_build_info,
-      ['--append_logs', '--write-test-outcome-log',
-       '--use-public-packages', 'pkgbuild'])
+      common_args + ['--append_logs', '--use-public-packages', 'pkgbuild'])
 
 if __name__ == '__main__':
   bot.RunBot(PubConfig, PubSteps)

tools/testing/dart/test_options.dart

@@ -383,6 +383,14 @@ Note: currently only implemented for dart2js.''',
               ['--replay_from_file'],
               [],
               null),
+          new _TestOptionSpecification(
+              'builder_tag',
+              'Machine specific options that is not captured by the regular '
+              'test options. Used to be able to make sane updates to the '
+              'status files.',
+              ['--builder-tag'],
+              [],
+              null),
           new _TestOptionSpecification(
               'vm_options',
               'Extra options to send to the vm when running',