23c2fcd648
Add a bunch of toString methods to internal Barback classes.
...
These will make it easier to debug barback by making it easier to
inspect the current state.
R=alanknight@google.com
BUG=
Review URL: https://codereview.chromium.org//155213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32304 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 00:47:00 +00:00
8184cfc847
pkg/unittest: remove rerunTests
...
R=nweiz@google.com
Review URL: https://codereview.chromium.org//154323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32298 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 22:38:01 +00:00
da43d16ec5
Let users specify the start page of the resulting docs
...
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//154373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32293 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 21:35:32 +00:00
56ea63472c
Fix missing package qualifier for typedefs
...
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//138073013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32291 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 21:25:15 +00:00
5fe10e575b
Print options when given no arguments instead of crashing
...
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//143403006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32290 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 21:22:52 +00:00
9b5165c2f8
Reverting 32284 - unittest using zones - investigating breaks in html
...
R=blois@google.com
Review URL: https://codereview.chromium.org//135013006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32288 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 20:51:44 +00:00
5c26be4b49
Indent fix for trailing comments (dartbug.com/16383).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//153203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32287 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 20:50:12 +00:00
245640e3d9
pkg/unittest: Run each test in a Zone
...
added a change log
Deprecate methods with behavior subsumed by runZoned
removed rerunTests
updated async/future_timeout_test to not assume Zone.ROOT during test run
BUG= https://code.google.com/p/dart/issues/detail?id=13277
R=nweiz@google.com
Review URL: https://codereview.chromium.org//130173010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32284 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 17:52:44 +00:00
f924fac14a
Use a transformer to initialize custom elements and call initMethod. This is the
...
first step to removes the dependence on mirrors in the deployable application.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//151893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32270 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 01:08:50 +00:00
fdc29a9ed5
regenerate fixed custom_elements polyfill
...
fixes an issue in the previous package, it was missing MutationObservers which it expects included in the binary generated by Grunt.
This did not happen because the sources are pulled in from a relative path, rather than being included in the repository, and there was unfortunately no error issued.
R=blois@google.com
Review URL: https://codereview.chromium.org//153063003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32263 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 21:52:24 +00:00
d808a3ce93
pkg/unittest: renamed new test, marked as failing on dartium due to issue 13921
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//148213012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32260 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 20:11:33 +00:00
6847e55c67
pkg/unittest: more lock-down, cleanup
...
TestCase: cannot set 'enabled' directly. Use enable/disableTest top-level method
TestCase: pass, fail, error are now private
Tests for protectAsyncN
Moved private helper classes into their own files
html_enhanced_config: fixed usage of deprecated query apis
R=sigmund@google.com
Review URL: https://codereview.chromium.org//149573006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32255 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 18:24:17 +00:00
797e38b133
Mark test as slow.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//132883018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32246 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 14:23:30 +00:00
baa148b853
Fix wrongly recorded uses after polymorphic inlining.
...
When inlining function bodies at a polymorphic site, uses at the
callee graph entry need to be removed since this block
is removed in the process of inlining.
BUG=dartbug.com/16404
TEST=pkgbuild/samples/searchable_list
R=srdjan@google.com
Review URL: https://codereview.chromium.org//151653002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32237 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 09:46:18 +00:00
3f54abdff5
Fix analyzer redness.
...
BUG=
Review URL: https://codereview.chromium.org//152543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32235 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 08:22:21 +00:00
8d666f47b9
Mark noscript_test as flaky.
...
Review URL: https://codereview.chromium.org//130913014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32229 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-01 01:38:26 +00:00
2bafb56a97
pkg/unittest: remove interactive html configuration
...
hide and make final a bunch of internal state in TestCase
R=sigmund@google.com
Review URL: https://codereview.chromium.org//142543005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32226 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-01 00:36:05 +00:00
7dcaea0527
pkg/intl: dartfmt
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org//143453011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32223 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 23:01:45 +00:00
48778e9420
Get ready to publish
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//132483012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32218 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 21:43:02 +00:00
6f690c0970
[Intl] Cleanup some code
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org//140843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32217 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 21:36:12 +00:00
ebbc454d2d
Fix missing .mirror.
...
Review URL: https://codereview.chromium.org//151693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32209 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 19:02:22 +00:00
2c3153d6cb
pkg/unittest fix status file post r32188
...
also fixed a test name
R=dgrove@google.com
Review URL: https://codereview.chromium.org//132743009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32198 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 16:19:13 +00:00
7b52480b56
Align source mirrors with runtime mirrors.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//119913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32195 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 14:15:26 +00:00
eb71ef37bb
throw when group or test is called while unittest system is running
...
This is not un-common and makes any future refactoring of unittest more difficult
Let's kill it before we rev a v1
R=efortuna@google.com
Review URL: https://codereview.chromium.org//142023005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32188 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 04:54:32 +00:00
77f39712b7
mark flaky ie9 tests
...
Review URL: https://codereview.chromium.org//151103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32187 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 02:09:10 +00:00
07888b2f25
Indent fix for switch statement defaults (dartbug.com/16406).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//150533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32174 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 21:39:28 +00:00
d5e713a9f1
pkg/collection: mark fields in wrappers as final
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//143243005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32173 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 21:19:16 +00:00
0f277224e8
update custom elements and shadow dom
...
R=blois@google.com
Review URL: https://codereview.chromium.org//140853005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32171 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 20:56:22 +00:00
fdc6d43083
Improve how we handle packages/ HTML imports. This improves resolution of URLs containing
...
"package/" under the web/ directory. Resolution under 'lib' is the same, but it and gives better suggestions if the path looks wrong. This summarizes what changed:
- source file: lib/b.html
import to "packages/c/d.html" was error, now is error + suggestion
import to "../packages/c/d.html" was error, now is error + suggestion
import to "../../packages/c/d.html" was resolved, now is resolved too
- source file: lib/a/b.html
import to "packages/c/d.html" was error, now is error + suggestion
import to "../packages/c/d.html" was error, now is error + suggestion
import to "../../packages/c/d.html" was error, now is error + suggestion
import to "../../../packages/c/d.html" was resolved, now is resolved too
- source file: web/b.html
import to "packages/c/d.html" was and continues to be resolved
import to "../packages/c/d.html" was error, now is resolved
- source file: web/a/b.html
import to "packages/c/d.html" was error, now is resolved
import to "../packages/c/d.html" was and continues to be resolved
import to "../../packages/c/d.html" was and continues to be resolved
Note: polymer-build and development mode are slightly different: polymer-build
detects and issues an error for bad paths inside lib/. These are not detected by
our package-resolution in loader.dart, but as long as users are not creating
symlinks by hand, Dartium should detect if the paths are wrong.
When we switch to start using pub-serve by default, we should be able to go back
to the web-ui style of using "package:" urls directly in HTML.
R=jmesserly@google.com , kustermann@google.com
Review URL: https://codereview.chromium.org//148913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32170 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 20:51:28 +00:00
9e6ec633f9
Mark collection/test/priority_queue_test as slow.
...
Review URL: https://codereview.chromium.org//149023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32167 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 18:35:16 +00:00
18ad816d5f
Max line length test fix (dartbug.com/16405).
...
The rub: two off by ones! --- Proof that two wrongs don't make a right! :)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//149913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32166 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 18:35:17 +00:00
69e6357506
polymer_expressions: Add % as an operator. Test all operators..
...
BUG=https://code.google.com/p/dart/issues/detail?id=15601
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//148883006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32153 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 05:50:16 +00:00
28ec54ceb0
pkg/unittest: formatter spin
...
R=efortuna@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//145403005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32152 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 05:20:08 +00:00
23d6c2e4a9
Disable crashing pkgbuild test.
...
BUG=https://code.google.com/p/dart/issues/detail?id=16404
R=nweiz@google.com
Review URL: https://codereview.chromium.org//146683004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32146 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 22:42:43 +00:00
9d5f39180c
Empty map formatting fix (dartbug.com/16382).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//149793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32143 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 22:02:26 +00:00
0cd85f6736
Wait for all log entries to be printed before exiting "pub build".
...
Previously, we could drop messages on the floor if too many were
emitted and the actual building was quick enough.
R=rnystrom@google.com
BUG=16242
Review URL: https://codereview.chromium.org//148213009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32141 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 21:28:08 +00:00
c5d1ec4384
Add some additional debugging prints to the mac os watcher.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//146693014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32139 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 21:06:50 +00:00
4260d5a585
Fix to allow single method cascades to fit on one line (dartbug.com/16384).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//149743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32138 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 20:57:44 +00:00
becf22691a
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//147903005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32135 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 20:03:33 +00:00
d6d365cdcc
Format fix for assert statements.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//149363007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32133 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 19:46:52 +00:00
fc68077557
Fix package docnames for select return types, and some more docgen refactoring.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org//135653009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32129 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 18:43:36 +00:00
cc7ec019aa
Mark pgkbuild/samples/third_party/angular_todo as failing on russian windows
...
Due to long file name issues, see issue 16356
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//147983008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32119 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 12:26:39 +00:00
b66342b854
Remove workaround for missing setter function returns (dartbug.com/15914).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//145953006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32091 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 22:51:27 +00:00
01c3a30ac0
Add test for complex in expressions in polymer_expressions
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//148523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32090 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 22:48:23 +00:00
99595ef86b
Remove workaround for missing abstract keyword for ClassTypeAliases (dartbug.com/15912).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//144743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32086 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 22:25:38 +00:00
13961dc1f6
Improved linebreaking for imports (darbug.com/16366) and non-breaking line support.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//147983005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32084 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 21:37:05 +00:00
8aec1f8b51
pkg/mime: formatting, finals, consts, etc
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//141433024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32072 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 17:24:08 +00:00
1252f88cff
Give default value for builder_tag in test options
...
Remove now passing test pkgbuild/samples/third_party/angular_todo suppression
Review URL: https://codereview.chromium.org//148893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32068 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 14:47:25 +00:00
57eb514346
Revert 32053 - this was already covered by revision 32041
...
The dartium failures is another test
Review URL: https://codereview.chromium.org//143633005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32066 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 12:22:30 +00:00
8b959be6fe
Add builder_tag option to tools/test.dart
...
This will allow us to pass in machine specific tags that describes the setup of a given machine.
Use this to pass in the locale on the pub russian bot and to suppress the two failures we have due to issue 16356
R=kasperl@google.com
Review URL: https://codereview.chromium.org//148463007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32061 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 09:55:49 +00:00
nweiz@google.com