dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[dart:html] Remove deprecated gridRowGap and gridColumnGap

Browse Source 
After chatting offline, we decided we don't actually need
gridRowGap and gridColumnGap since the rowGap and columnGap
properties are the preferred names. Removing the deprecated
grid versions before it becomes a breaking change to do so,
and to keep dart:html bloat minimal.

Change-Id: I75a7de40a4bb1a5479723600987d19e7e42bf69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224700
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Riley Porter <rileyporter@google.com>
This commit is contained in:
Riley Porter
2021-12-20 18:21:03 +00:00
committed by Commit Bot
parent 23ed95a4cb
commit 8e0d5f98a3
3 changed files with 0 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sdk/lib/html/dart2js/html_dart2js.dart
-16
View File
@@ -7125,14 +7125,6 @@ abstract class CssStyleDeclarationBase {
setProperty('grid-column-end', value, '');
}
/** Gets the value of "grid-column-gap" */
String get gridColumnGap => getPropertyValue('grid-column-gap');
/** Sets the value of "grid-column-gap" */
set gridColumnGap(String value) {
setProperty('grid-column-gap', value, '');
}
/** Gets the value of "grid-column-start" */
String get gridColumnStart => getPropertyValue('grid-column-start');
@@ -7157,14 +7149,6 @@ abstract class CssStyleDeclarationBase {
setProperty('grid-row-end', value, '');
}
/** Gets the value of "grid-row-gap" */
String get gridRowGap => getPropertyValue('grid-row-gap');
/** Sets the value of "grid-row-gap" */
set gridRowGap(String value) {
setProperty('grid-row-gap', value, '');
}
/** Gets the value of "grid-row-start" */
String get gridRowStart => getPropertyValue('grid-row-start');
tools/dom/scripts/CSSPropertyNames.in
-2
View File
@@ -329,7 +329,6 @@ grid-auto-rows
grid-area
grid-column
grid-column-end
grid-column-gap
grid-column-start
grid
grid-template
@@ -337,7 +336,6 @@ grid-template-columns
grid-template-rows
grid-row
grid-row-end
grid-row-gap
grid-row-start
grid-template-areas
-webkit-highlight
tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
-18
View File
@@ -3211,15 +3211,6 @@ abstract class CssStyleDeclarationBase {
setProperty('grid-column-end', value, '');
}
/** Gets the value of "grid-column-gap" */
String get gridColumnGap =>
getPropertyValue('grid-column-gap');
/** Sets the value of "grid-column-gap" */
set gridColumnGap(String value) {
setProperty('grid-column-gap', value, '');
}
/** Gets the value of "grid-column-start" */
String get gridColumnStart =>
getPropertyValue('grid-column-start');
@@ -3247,15 +3238,6 @@ abstract class CssStyleDeclarationBase {
setProperty('grid-row-end', value, '');
}
/** Gets the value of "grid-row-gap" */
String get gridRowGap =>
getPropertyValue('grid-row-gap');
/** Sets the value of "grid-row-gap" */
set gridRowGap(String value) {
setProperty('grid-row-gap', value, '');
}
/** Gets the value of "grid-row-start" */
String get gridRowStart =>
getPropertyValue('grid-row-start');