From 8e0d5f98a36e606fcd05520c52f65d1d02b9db7d Mon Sep 17 00:00:00 2001
From: Riley Porter <rileyporter@google.com>
Date: Mon, 20 Dec 2021 18:21:03 +0000
Subject: [PATCH] [dart:html] Remove deprecated gridRowGap and gridColumnGap

After chatting offline, we decided we don't actually need
gridRowGap and gridColumnGap since the rowGap and columnGap
properties are the preferred names. Removing the deprecated
grid versions before it becomes a breaking change to do so,
and to keep dart:html bloat minimal.

Change-Id: I75a7de40a4bb1a5479723600987d19e7e42bf69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224700
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Riley Porter <rileyporter@google.com>
---
 sdk/lib/html/dart2js/html_dart2js.dart         | 16 ----------------
 tools/dom/scripts/CSSPropertyNames.in          |  2 --
 .../impl/impl_CSSStyleDeclaration.darttemplate | 18 ------------------
 3 files changed, 36 deletions(-)

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 3298b08e754..c6280c1cef4 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -7125,14 +7125,6 @@ abstract class CssStyleDeclarationBase {
     setProperty('grid-column-end', value, '');
   }
 
-  /** Gets the value of "grid-column-gap" */
-  String get gridColumnGap => getPropertyValue('grid-column-gap');
-
-  /** Sets the value of "grid-column-gap" */
-  set gridColumnGap(String value) {
-    setProperty('grid-column-gap', value, '');
-  }
-
   /** Gets the value of "grid-column-start" */
   String get gridColumnStart => getPropertyValue('grid-column-start');
 
@@ -7157,14 +7149,6 @@ abstract class CssStyleDeclarationBase {
     setProperty('grid-row-end', value, '');
   }
 
-  /** Gets the value of "grid-row-gap" */
-  String get gridRowGap => getPropertyValue('grid-row-gap');
-
-  /** Sets the value of "grid-row-gap" */
-  set gridRowGap(String value) {
-    setProperty('grid-row-gap', value, '');
-  }
-
   /** Gets the value of "grid-row-start" */
   String get gridRowStart => getPropertyValue('grid-row-start');
 
diff --git a/tools/dom/scripts/CSSPropertyNames.in b/tools/dom/scripts/CSSPropertyNames.in
index cf59dcabe35..8947335612f 100644
--- a/tools/dom/scripts/CSSPropertyNames.in
+++ b/tools/dom/scripts/CSSPropertyNames.in
@@ -329,7 +329,6 @@ grid-auto-rows
 grid-area
 grid-column
 grid-column-end
-grid-column-gap
 grid-column-start
 grid
 grid-template
@@ -337,7 +336,6 @@ grid-template-columns
 grid-template-rows
 grid-row
 grid-row-end
-grid-row-gap
 grid-row-start
 grid-template-areas
 -webkit-highlight
diff --git a/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate b/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
index a81ff5aafdf..7aade9840a6 100644
--- a/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
+++ b/tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
@@ -3211,15 +3211,6 @@ abstract class CssStyleDeclarationBase {
     setProperty('grid-column-end', value, '');
   }
 
-  /** Gets the value of "grid-column-gap" */
-  String get gridColumnGap =>
-    getPropertyValue('grid-column-gap');
-
-  /** Sets the value of "grid-column-gap" */
-  set gridColumnGap(String value) {
-    setProperty('grid-column-gap', value, '');
-  }
-
   /** Gets the value of "grid-column-start" */
   String get gridColumnStart =>
     getPropertyValue('grid-column-start');
@@ -3247,15 +3238,6 @@ abstract class CssStyleDeclarationBase {
     setProperty('grid-row-end', value, '');
   }
 
-  /** Gets the value of "grid-row-gap" */
-  String get gridRowGap =>
-    getPropertyValue('grid-row-gap');
-
-  /** Sets the value of "grid-row-gap" */
-  set gridRowGap(String value) {
-    setProperty('grid-row-gap', value, '');
-  }
-
   /** Gets the value of "grid-row-start" */
   String get gridRowStart =>
     getPropertyValue('grid-row-start');