dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Enable computing hints when using front-end

Browse Source 
Change-Id: I8a8344c98dc8fdb65c8711b2adbdfbaaafb023ed
Reviewed-on: https://dart-review.googlesource.com/26780
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Brian Wilkerson
2017-12-06 22:04:31 +00:00
committed by commit-bot@chromium.org
parent fe178582ef
commit 7937e6e84a
2 changed files with 21 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
+21 -23
View File
@@ -206,8 +206,7 @@ class LibraryAnalyzer {
var resolutions = new _ResolutionProvider(analyzerTarget.resolutions);
units.forEach((file, unit) {
_resolveFile2(file, unit, resolutions);
// TODO(scheglov) Restore.
// _computePendingMissingRequiredParameters(file, unit);
_computePendingMissingRequiredParameters(file, unit);
});
_computeConstants();
@@ -219,27 +218,26 @@ class LibraryAnalyzer {
// });
// });
// TODO(scheglov) Restore.
// if (_analysisOptions.hint) {
// PerformanceStatistics.hints.makeCurrentWhile(() {
// units.forEach((file, unit) {
// {
// var visitor = new GatherUsedLocalElementsVisitor(_libraryElement);
// unit.accept(visitor);
// _usedLocalElementsList.add(visitor.usedElements);
// }
// {
// var visitor =
// new GatherUsedImportedElementsVisitor(_libraryElement);
// unit.accept(visitor);
// _usedImportedElementsList.add(visitor.usedElements);
// }
// });
// units.forEach((file, unit) {
// _computeHints(file, unit);
// });
// });
// }
if (_analysisOptions.hint) {
PerformanceStatistics.hints.makeCurrentWhile(() {
units.forEach((file, unit) {
{
var visitor = new GatherUsedLocalElementsVisitor(_libraryElement);
unit.accept(visitor);
_usedLocalElementsList.add(visitor.usedElements);
}
{
var visitor =
new GatherUsedImportedElementsVisitor(_libraryElement);
unit.accept(visitor);
_usedImportedElementsList.add(visitor.usedElements);
}
});
units.forEach((file, unit) {
_computeHints(file, unit);
});
});
}
if (_analysisOptions.lint) {
PerformanceStatistics.lints.makeCurrentWhile(() {
pkg/analyzer/test/src/dart/analysis/driver_kernel_test.dart
-7
View File
@@ -134,13 +134,6 @@ class AnalysisDriverTest_Kernel extends AnalysisDriverTest {
await super.test_getErrors();
}
@failingTest
@potentialAnalyzerProblem
@override
test_getResult_errors() async {
await super.test_getResult_errors();
}
@failingTest
@potentialAnalyzerProblem
@override