diff --git a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart index 1e10a16942b..57e2afeadec 100644 --- a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart +++ b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart @@ -206,8 +206,7 @@ class LibraryAnalyzer { var resolutions = new _ResolutionProvider(analyzerTarget.resolutions); units.forEach((file, unit) { _resolveFile2(file, unit, resolutions); - // TODO(scheglov) Restore. -// _computePendingMissingRequiredParameters(file, unit); + _computePendingMissingRequiredParameters(file, unit); }); _computeConstants(); @@ -219,27 +218,26 @@ class LibraryAnalyzer { // }); // }); - // TODO(scheglov) Restore. -// if (_analysisOptions.hint) { -// PerformanceStatistics.hints.makeCurrentWhile(() { -// units.forEach((file, unit) { -// { -// var visitor = new GatherUsedLocalElementsVisitor(_libraryElement); -// unit.accept(visitor); -// _usedLocalElementsList.add(visitor.usedElements); -// } -// { -// var visitor = -// new GatherUsedImportedElementsVisitor(_libraryElement); -// unit.accept(visitor); -// _usedImportedElementsList.add(visitor.usedElements); -// } -// }); -// units.forEach((file, unit) { -// _computeHints(file, unit); -// }); -// }); -// } + if (_analysisOptions.hint) { + PerformanceStatistics.hints.makeCurrentWhile(() { + units.forEach((file, unit) { + { + var visitor = new GatherUsedLocalElementsVisitor(_libraryElement); + unit.accept(visitor); + _usedLocalElementsList.add(visitor.usedElements); + } + { + var visitor = + new GatherUsedImportedElementsVisitor(_libraryElement); + unit.accept(visitor); + _usedImportedElementsList.add(visitor.usedElements); + } + }); + units.forEach((file, unit) { + _computeHints(file, unit); + }); + }); + } if (_analysisOptions.lint) { PerformanceStatistics.lints.makeCurrentWhile(() { diff --git a/pkg/analyzer/test/src/dart/analysis/driver_kernel_test.dart b/pkg/analyzer/test/src/dart/analysis/driver_kernel_test.dart index 5ab3f18b73a..a6dc5cb64f3 100644 --- a/pkg/analyzer/test/src/dart/analysis/driver_kernel_test.dart +++ b/pkg/analyzer/test/src/dart/analysis/driver_kernel_test.dart @@ -134,13 +134,6 @@ class AnalysisDriverTest_Kernel extends AnalysisDriverTest { await super.test_getErrors(); } - @failingTest - @potentialAnalyzerProblem - @override - test_getResult_errors() async { - await super.test_getResult_errors(); - } - @failingTest @potentialAnalyzerProblem @override