dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Remove TODO block from analyze_snapshot_api_impl.cc

Browse Source 
Closes https://github.com/dart-lang/sdk/pull/60310

GitOrigin-RevId: eec15734b982fe3b1e9ed023a7b0d651c75ff611
Change-Id: Ibd17b61088a7d940ac2052a2e3ef1f21f282a068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414923
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
This commit is contained in:
Eric Seidel
2025-03-12 10:33:42 -07:00
committed by Commit Queue
parent e4d9ea3843
commit 7531f294db
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/analyze_snapshot_api_impl.cc
-12
View File
@@ -344,18 +344,6 @@ void SnapshotAnalyzer::DumpMetadata() {
js_.CloseObject();
}
// TODO(#47924): Add processing of the entires in the dispatch table.
// Below is an example skeleton
// void DumpDispatchTable(dart::Thread* thread) {
// auto dispatch = thread->isolate_group()->dispatch_table();
// auto length = dispatch->length();
// We must unbias the array entries so we don't crash on null access.
// auto entries = dispatch->ArrayOrigin() - DispatchTable::kOriginElement;
// for (intptr_t i = 0; i < length; i++) {
// OS::Print("0x%lx at %ld\n", entries[i], i);
// }
// }
void SnapshotAnalyzer::DumpSnapshotInformation(char** buffer,
intptr_t* buffer_length) {
thread_ = Thread::Current();