From 7531f294db44226f6a75a6590d2fa4637c68d35b Mon Sep 17 00:00:00 2001 From: Eric Seidel Date: Wed, 12 Mar 2025 10:33:42 -0700 Subject: [PATCH] Remove TODO block from analyze_snapshot_api_impl.cc Closes https://github.com/dart-lang/sdk/pull/60310 GitOrigin-RevId: eec15734b982fe3b1e9ed023a7b0d651c75ff611 Change-Id: Ibd17b61088a7d940ac2052a2e3ef1f21f282a068 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414923 Commit-Queue: Slava Egorov Reviewed-by: Slava Egorov --- runtime/vm/analyze_snapshot_api_impl.cc | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/runtime/vm/analyze_snapshot_api_impl.cc b/runtime/vm/analyze_snapshot_api_impl.cc index a9c87a43a9d..7fccd34ef3a 100644 --- a/runtime/vm/analyze_snapshot_api_impl.cc +++ b/runtime/vm/analyze_snapshot_api_impl.cc @@ -344,18 +344,6 @@ void SnapshotAnalyzer::DumpMetadata() { js_.CloseObject(); } -// TODO(#47924): Add processing of the entires in the dispatch table. -// Below is an example skeleton -// void DumpDispatchTable(dart::Thread* thread) { -// auto dispatch = thread->isolate_group()->dispatch_table(); -// auto length = dispatch->length(); -// We must unbias the array entries so we don't crash on null access. -// auto entries = dispatch->ArrayOrigin() - DispatchTable::kOriginElement; -// for (intptr_t i = 0; i < length; i++) { -// OS::Print("0x%lx at %ld\n", entries[i], i); -// } -// } - void SnapshotAnalyzer::DumpSnapshotInformation(char** buffer, intptr_t* buffer_length) { thread_ = Thread::Current();