dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[gardening] Fix httpIG samples - ensure only shareable vars are captured.

Browse Source 
Fixes https://ci.chromium.org/p/dart/builders/ci.sandbox/vm-linux-release-x64/6047

Follow-up to 650ed9cde1.
TEST=samples/ffi/httpIG/test/http_test

Change-Id: I435f1be6dbcf17fb16fbd589a52ad1fcd38971c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444102
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Alexander Aprelev
2025-08-06 11:06:30 -07:00
committed by Commit Queue
parent 13edb28f23
commit 333460ead4
1 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
samples/ffi/httpIG/lib/http.dart
+23 -20
View File
@@ -12,6 +12,15 @@ import 'package:ffi/ffi.dart';
import 'dylib_utils.dart';
Function (Pointer<Utf8>) createGetSender(SendPort sendPort) {
return (Pointer<Utf8> responsePointer) {
final typedList = responsePointer.cast<Uint8>().asTypedList(
responsePointer.length,
);
sendPort.send(utf8.decode(typedList));
};
}
// Runs a simple HTTP GET request using a native HTTP library that runs
// the request on a background thread.
Future<String> httpGet(String uri) async {
@@ -26,16 +35,8 @@ Future<String> httpGet(String uri) async {
print('httpGet receiver get error $e $st');
},
);
final sendPort = rp.sendPort;
final callback = NativeCallable<HttpCallback>.isolateGroupBound((
Pointer<Utf8> responsePointer,
) {
final typedList = responsePointer.cast<Uint8>().asTypedList(
responsePointer.length,
);
final s = utf8.decode(typedList);
sendPort.send(s);
});
final callback = NativeCallable<HttpCallback>.isolateGroupBound(
createGetSender(rp.sendPort));
// Invoke the native HTTP API. Our example HTTP library runs our GET
// request on a background thread, and calls the callback on that same
@@ -56,20 +57,22 @@ Future<String> httpGet(String uri) async {
@pragma('vm:shared')
late int counter;
// Start a HTTP server on a background thread.
ReceivePort httpServe(void Function(String) onRequest) {
counter = 0;
final rp = ReceivePort();
final callback = NativeCallable<HttpCallback>.isolateGroupBound((
Pointer<Utf8> requestPointer,
) {
Function (Pointer<Utf8>) createServeSender(SendPort sendPort) {
return (Pointer<Utf8> requestPointer) {
counter++;
final typedList = requestPointer.cast<Uint8>().asTypedList(
requestPointer.length,
);
final s = utf8.decode(typedList);
rp.sendPort.send(s);
});
sendPort.send(utf8.decode(typedList));
};
}
// Start a HTTP server on a background thread.
ReceivePort httpServe(void Function(String) onRequest) {
counter = 0;
final rp = ReceivePort();
final callback = NativeCallable<HttpCallback>.isolateGroupBound(
createServeSender(rp.sendPort));
rp.listen(
(s) {
print('httpServe counter: $counter');