From 333460ead410f2b57d3d59639bfa7585bf554c57 Mon Sep 17 00:00:00 2001
From: Alexander Aprelev <aam@google.com>
Date: Wed, 6 Aug 2025 11:06:30 -0700
Subject: [PATCH] [gardening] Fix httpIG samples - ensure only shareable vars
 are captured.

Fixes https://ci.chromium.org/p/dart/builders/ci.sandbox/vm-linux-release-x64/6047

Follow-up to 650ed9cde16c5055eb1946bb262f044fae6304ec.
TEST=samples/ffi/httpIG/test/http_test

Change-Id: I435f1be6dbcf17fb16fbd589a52ad1fcd38971c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444102
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
---
 samples/ffi/httpIG/lib/http.dart | 43 +++++++++++++++++---------------
 1 file changed, 23 insertions(+), 20 deletions(-)

diff --git a/samples/ffi/httpIG/lib/http.dart b/samples/ffi/httpIG/lib/http.dart
index b150d47ea34..0a1024de352 100644
--- a/samples/ffi/httpIG/lib/http.dart
+++ b/samples/ffi/httpIG/lib/http.dart
@@ -12,6 +12,15 @@ import 'package:ffi/ffi.dart';
 
 import 'dylib_utils.dart';
 
+Function (Pointer<Utf8>) createGetSender(SendPort sendPort) {
+  return (Pointer<Utf8> responsePointer) {
+    final typedList = responsePointer.cast<Uint8>().asTypedList(
+          responsePointer.length,
+        );
+    sendPort.send(utf8.decode(typedList));
+  };
+}
+
 // Runs a simple HTTP GET request using a native HTTP library that runs
 // the request on a background thread.
 Future<String> httpGet(String uri) async {
@@ -26,16 +35,8 @@ Future<String> httpGet(String uri) async {
         print('httpGet receiver get error $e $st');
       },
     );
-  final sendPort = rp.sendPort;
-  final callback = NativeCallable<HttpCallback>.isolateGroupBound((
-    Pointer<Utf8> responsePointer,
-  ) {
-    final typedList = responsePointer.cast<Uint8>().asTypedList(
-          responsePointer.length,
-        );
-    final s = utf8.decode(typedList);
-    sendPort.send(s);
-  });
+  final callback = NativeCallable<HttpCallback>.isolateGroupBound(
+      createGetSender(rp.sendPort));
 
   // Invoke the native HTTP API. Our example HTTP library runs our GET
   // request on a background thread, and calls the callback on that same
@@ -56,20 +57,22 @@ Future<String> httpGet(String uri) async {
 @pragma('vm:shared')
 late int counter;
 
-// Start a HTTP server on a background thread.
-ReceivePort httpServe(void Function(String) onRequest) {
-  counter = 0;
-  final rp = ReceivePort();
-  final callback = NativeCallable<HttpCallback>.isolateGroupBound((
-    Pointer<Utf8> requestPointer,
-  ) {
+Function (Pointer<Utf8>) createServeSender(SendPort sendPort) {
+  return (Pointer<Utf8> requestPointer) {
     counter++;
     final typedList = requestPointer.cast<Uint8>().asTypedList(
           requestPointer.length,
         );
-    final s = utf8.decode(typedList);
-    rp.sendPort.send(s);
-  });
+    sendPort.send(utf8.decode(typedList));
+  };
+}
+
+// Start a HTTP server on a background thread.
+ReceivePort httpServe(void Function(String) onRequest) {
+  counter = 0;
+  final rp = ReceivePort();
+  final callback = NativeCallable<HttpCallback>.isolateGroupBound(
+      createServeSender(rp.sendPort));
   rp.listen(
     (s) {
       print('httpServe counter: $counter');