[tests] Avoid small --optimization-counter-threshold in tests

Small --optimization-counter-threshold makes tests very slow,
especially on architectures where kernel service runs from
kernel and not from app-jit snapshot.

TEST=change in tests, *-ia32 bots
Fixes https://github.com/dart-lang/sdk/issues/48627

Change-Id: I63e7e201ef9a0e4f645016c39a5be1819b61822d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263421
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>

runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 //
 // VMOptions=--async_debugger
-// VMOptions=--async_debugger --optimization-counter-threshold=5
+// VMOptions=--async_debugger --optimization-counter-threshold=90
 
 import 'package:observatory/service_io.dart';
 import 'package:observatory/models.dart' as M;

runtime/observatory_2/tests/service_2/pause_on_unhandled_async_exceptions2_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 //
 // VMOptions=--async_debugger
-// VMOptions=--async_debugger --optimization-counter-threshold=5
+// VMOptions=--async_debugger --optimization-counter-threshold=90
 
 import 'package:observatory_2/service_io.dart';
 import 'package:observatory_2/models.dart' as M;

runtime/tests/vm/dart/entrypoints/jit/polymorphic_optional_this_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 -Denable_inlining=true --compilation-counter-threshold=1
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 --compilation-counter-threshold=1
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=1
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1
 
 // Test that 'PolymorphicInstanceCall's against "this" go through the unchecked
 // entrypoint. The use of optional arguments here encourages prologue sharing

runtime/tests/vm/dart/entrypoints/jit/polymorphic_this_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 -Denable_inlining=true --compilation-counter-threshold=1
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 --compilation-counter-threshold=1
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=1
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1
 
 // Test that 'PolymorphicInstanceCall's against "this" go through the unchecked
 // entrypoint.

runtime/tests/vm/dart/entrypoints/jit/static_this_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 --compilation-counter-threshold=5
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 -Denable_inlining=true --compilation-counter-threshold=5
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=5
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1
 
 import '../static_this.dart';
 

runtime/tests/vm/dart/entrypoints/jit/super_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 -Denable_inlining=true --compilation-counter-threshold=5
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 --compilation-counter-threshold=5
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=5
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1
 
 import "../super.dart";
 

runtime/tests/vm/dart/regress32619_test.dart

@@ -4,7 +4,7 @@
 
 // Regression test for dartbug.com/32619: incorrect widening of smis to int32.
 
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=90 --no-background-compilation
 
 import "package:expect/expect.dart";
 import 'dart:typed_data';
@@ -31,7 +31,7 @@ int _mulAdd(Uint32List multiplicandDigits, int i, Uint32List accumulatorDigits,
   return carry;
 }
 
-main() {
+test() {
   var multiplicandDigits = new Uint32List.fromList([0, 294967296, 0, 0]);
   var accumulatorDigits = new Uint32List.fromList([0, 4, 4, 0, 0, 0]);
 
@@ -39,3 +39,9 @@ main() {
 
   Expect.equals(0, d1);
 }
+
+main() {
+  for (int i = 0; i < 100; ++i) {
+    test();
+  }
+}

runtime/tests/vm/dart/regress_b_230945329_test.dart

@@ -7,13 +7,13 @@
 // Check that AssertAssignables for the same uninstantiated type, where the
 // instantiated types at runtime may differ, are not optimized away.
 //
-// VMOptions=--no-use-field-guards --no-use-osr --deterministic --optimization-counter-threshold=5
+// VMOptions=--no-use-field-guards --no-use-osr --deterministic --optimization-counter-threshold=90
 
 void main() {
   final bar = Box<dynamic>('a'); // T=dynamic
   final barInt = Box<int>(1); // T=int
 
-  for (int i = 0; i < 5; ++i) {
+  for (int i = 0; i < 100; ++i) {
     bar.bar(bar);
   }
   try {

runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_optional_this_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 -Denable_inlining=true --compilation-counter-threshold=1
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 --compilation-counter-threshold=1
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=1
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1
 
 // @dart = 2.9
 

runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_this_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 -Denable_inlining=true --compilation-counter-threshold=1
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 --compilation-counter-threshold=1
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=1
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1
 
 // @dart = 2.9
 

runtime/tests/vm/dart_2/entrypoints/jit/static_this_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 --compilation-counter-threshold=5
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 -Denable_inlining=true --compilation-counter-threshold=5
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=5
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1
 
 // @dart = 2.9
 

runtime/tests/vm/dart_2/entrypoints/jit/super_test.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 -Denable_inlining=true --compilation-counter-threshold=5
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 --compilation-counter-threshold=5
-// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=5
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90
+// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1
 
 // @dart = 2.9
 

runtime/tests/vm/dart_2/regress32619_test.dart

@@ -6,7 +6,7 @@
 
 // Regression test for dartbug.com/32619: incorrect widening of smis to int32.
 
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=90 --no-background-compilation
 
 import "package:expect/expect.dart";
 import 'dart:typed_data';
@@ -33,7 +33,7 @@ int _mulAdd(Uint32List multiplicandDigits, int i, Uint32List accumulatorDigits,
   return carry;
 }
 
-main() {
+test() {
   var multiplicandDigits = new Uint32List.fromList([0, 294967296, 0, 0]);
   var accumulatorDigits = new Uint32List.fromList([0, 4, 4, 0, 0, 0]);
 
@@ -41,3 +41,9 @@ main() {
 
   Expect.equals(0, d1);
 }
+
+main() {
+  for (int i = 0; i < 100; ++i) {
+    test();
+  }
+}

runtime/tests/vm/dart_2/regress_b_230945329_test.dart

@@ -7,7 +7,7 @@
 // Check that AssertAssignables for the same uninstantiated type, where the
 // instantiated types at runtime may differ, are not optimized away.
 //
-// VMOptions=--no-use-field-guards --no-use-osr --deterministic --optimization-counter-threshold=5
+// VMOptions=--no-use-field-guards --no-use-osr --deterministic --optimization-counter-threshold=90
 //
 // @dart=2.9
 
@@ -15,7 +15,7 @@ void main() {
   final bar = Box<dynamic>('a'); // T=dynamic
   final barInt = Box<int>(1); // T=int
 
-  for (int i = 0; i < 5; ++i) {
+  for (int i = 0; i < 100; ++i) {
     bar.bar(bar);
   }
   try {

samples/ffi/sqlite/test/sqlite_test.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// VMOptions=--optimization-counter-threshold=5
-
 import "dart:ffi";
 import "dart:io";
 

tests/corelib/bigint_from_test.dart

@@ -6,7 +6,7 @@
 // VMOptions=--intrinsify --no-enable-asserts
 // VMOptions=--intrinsify --enable-asserts
 // VMOptions=--no-intrinsify --enable-asserts
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 // VMOptions=--dwarf_stack_traces --no-retain_function_objects --no-retain_code_objects
 
 import "package:expect/expect.dart";

tests/corelib/bigint_js_test.dart

@@ -6,7 +6,7 @@
 // VMOptions=--intrinsify --no-enable-asserts
 // VMOptions=--intrinsify --enable-asserts
 // VMOptions=--no-intrinsify --enable-asserts
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 // Test for JavaScript specific BigInt behaviour. Any JavaScript number (double)
 // that is an integral value is a Dart 'int' value, so any BigInt that has a

tests/corelib/bigint_parse_radix_test.dart

@@ -6,7 +6,7 @@
 // VMOptions=--intrinsify --no-enable-asserts
 // VMOptions=--intrinsify --enable-asserts
 // VMOptions=--no-intrinsify --enable-asserts
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 import "package:expect/expect.dart";
 

tests/corelib/bigint_test.dart

@@ -6,7 +6,7 @@
 // VMOptions=--intrinsify --no-enable-asserts
 // VMOptions=--intrinsify --enable-asserts
 // VMOptions=--no-intrinsify --enable-asserts
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 import "package:expect/expect.dart";
 

tests/corelib_2/bigint_from_test.dart

@@ -8,7 +8,7 @@
 // VMOptions=--intrinsify --no-enable-asserts
 // VMOptions=--intrinsify --enable-asserts
 // VMOptions=--no-intrinsify --enable-asserts
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 // VMOptions=--dwarf_stack_traces --no-retain_function_objects --no-retain_code_objects
 
 import "package:expect/expect.dart";

tests/corelib_2/bigint_js_test.dart

@@ -8,7 +8,7 @@
 // VMOptions=--intrinsify --no-enable-asserts
 // VMOptions=--intrinsify --enable-asserts
 // VMOptions=--no-intrinsify --enable-asserts
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 // Test for JavaScript specific BigInt behaviour. Any JavaScript number (double)
 // that is an integral value is a Dart 'int' value, so any BigInt that has a

tests/corelib_2/bigint_parse_radix_test.dart

@@ -8,7 +8,7 @@
 // VMOptions=--intrinsify --no-enable-asserts
 // VMOptions=--intrinsify --enable-asserts
 // VMOptions=--no-intrinsify --enable-asserts
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 import "package:expect/expect.dart";
 

tests/corelib_2/bigint_test.dart

@@ -8,7 +8,7 @@
 // VMOptions=--intrinsify --no-enable-asserts
 // VMOptions=--intrinsify --enable-asserts
 // VMOptions=--no-intrinsify --enable-asserts
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 import "package:expect/expect.dart";
 

tests/ffi/function_callbacks_structs_by_value_generated_test.dart

@@ -7,7 +7,7 @@
 //
 // SharedObjects=ffi_test_functions
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=10
+// VMOptions=--deterministic --optimization-counter-threshold=20
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 

tests/ffi/function_callbacks_structs_by_value_test.dart

@@ -4,7 +4,7 @@
 //
 // SharedObjects=ffi_test_functions
 //
-// VMOptions=--deterministic --optimization-counter-threshold=5 --use-slow-path --stacktrace-every=100
+// VMOptions=--deterministic --optimization-counter-threshold=90 --use-slow-path --stacktrace-every=100
 
 import 'dart:ffi';
 
@@ -19,7 +19,7 @@ import 'function_structs_by_value_generated_compounds.dart';
 final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions");
 
 void main() {
-  for (int i = 0; i < 10; i++) {
+  for (int i = 0; i < 100; i++) {
     recursiveTest(10);
     recursiveTest(11);
     testCopyLogic();

tests/ffi/function_callbacks_very_many_test.dart

@@ -4,7 +4,7 @@
 
 // Dart test program for testing dart:ffi function pointers with callbacks.
 //
-// VMOptions=--deterministic --optimization-counter-threshold=10
+// VMOptions=--deterministic --optimization-counter-threshold=90
 // VMOptions=--stacktrace-every=100
 // VMOptions=--write-protect-code --no-dual-map-code
 // VMOptions=--write-protect-code --no-dual-map-code --stacktrace-every=100

tests/ffi/function_structs_by_value_generated_leaf_test.dart

@@ -7,7 +7,7 @@
 //
 // SharedObjects=ffi_test_functions
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=5
+// VMOptions=--deterministic --optimization-counter-threshold=20
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 
@@ -23,7 +23,7 @@ import 'function_structs_by_value_generated_compounds.dart';
 
 final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions");
 void main() {
-  for (int i = 0; i < 10; ++i) {
+  for (int i = 0; i < 25; ++i) {
     testPassStruct1ByteIntx10Leaf();
     testPassStruct3BytesHomogeneousUint8x10Leaf();
     testPassStruct3BytesInt2ByteAlignedx10Leaf();

tests/ffi/function_structs_by_value_generated_test.dart

@@ -7,7 +7,7 @@
 //
 // SharedObjects=ffi_test_functions
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=5
+// VMOptions=--deterministic --optimization-counter-threshold=20
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 
@@ -23,7 +23,7 @@ import 'function_structs_by_value_generated_compounds.dart';
 
 final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions");
 void main() {
-  for (int i = 0; i < 10; ++i) {
+  for (int i = 0; i < 25; ++i) {
     testPassStruct1ByteIntx10();
     testPassStruct3BytesHomogeneousUint8x10();
     testPassStruct3BytesInt2ByteAlignedx10();

tests/ffi/generator/structs_by_value_tests_generator.dart

@@ -954,7 +954,7 @@ ${headerCommon(copyrightYear: copyrightYear)}
 //
 // SharedObjects=ffi_test_functions
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=5
+// VMOptions=--deterministic --optimization-counter-threshold=20
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 
@@ -984,7 +984,7 @@ Future<void> writeDartCallTest({required bool isLeaf}) async {
     final suffix = isLeaf ? 'Leaf' : '';
     buffer.write("""
     void main() {
-      for (int i = 0; i < 10; ++i) {
+      for (int i = 0; i < 25; ++i) {
         ${functions.map((e) => "${e.dartTestName}$suffix();").join("\n")}
       }
     }
@@ -1014,7 +1014,7 @@ ${headerCommon(copyrightYear: copyrightYear)}
 //
 // SharedObjects=ffi_test_functions
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=10
+// VMOptions=--deterministic --optimization-counter-threshold=20
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 

tests/ffi/regress_43016_test.dart

@@ -4,7 +4,7 @@
 //
 // SharedObjects=ffi_test_functions
 //
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=200
 
 import 'dart:ffi';
 

tests/ffi/variance_function_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 //
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=10
+// VMOptions=--deterministic --optimization-counter-threshold=90
 // VMOptions=--use-slow-path
 // SharedObjects=ffi_test_functions
 //

tests/ffi_2/function_callbacks_structs_by_value_generated_test.dart

@@ -7,7 +7,7 @@
 //
 // SharedObjects=ffi_test_functions
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=10
+// VMOptions=--deterministic --optimization-counter-threshold=20
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 

tests/ffi_2/function_callbacks_structs_by_value_test.dart

@@ -4,7 +4,7 @@
 //
 // SharedObjects=ffi_test_functions
 //
-// VMOptions=--deterministic --optimization-counter-threshold=5 --use-slow-path --stacktrace-every=100
+// VMOptions=--deterministic --optimization-counter-threshold=90 --use-slow-path --stacktrace-every=100
 
 // @dart = 2.9
 
@@ -21,7 +21,7 @@ import 'function_structs_by_value_generated_compounds.dart';
 final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions");
 
 void main() {
-  for (int i = 0; i < 10; i++) {
+  for (int i = 0; i < 100; i++) {
     recursiveTest(10);
     recursiveTest(11);
     testCopyLogic();

tests/ffi_2/function_callbacks_very_many_test.dart

@@ -6,7 +6,7 @@
 
 // Dart test program for testing dart:ffi function pointers with callbacks.
 //
-// VMOptions=--deterministic --optimization-counter-threshold=10
+// VMOptions=--deterministic --optimization-counter-threshold=90
 // VMOptions=--stacktrace-every=100
 // VMOptions=--write-protect-code --no-dual-map-code
 // VMOptions=--write-protect-code --no-dual-map-code --stacktrace-every=100

tests/ffi_2/function_structs_by_value_generated_leaf_test.dart

@@ -7,7 +7,7 @@
 //
 // SharedObjects=ffi_test_functions
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=5
+// VMOptions=--deterministic --optimization-counter-threshold=20
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 
@@ -25,7 +25,7 @@ import 'function_structs_by_value_generated_compounds.dart';
 
 final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions");
 void main() {
-  for (int i = 0; i < 10; ++i) {
+  for (int i = 0; i < 25; ++i) {
     testPassStruct1ByteIntx10Leaf();
     testPassStruct3BytesHomogeneousUint8x10Leaf();
     testPassStruct3BytesInt2ByteAlignedx10Leaf();

tests/ffi_2/function_structs_by_value_generated_test.dart

@@ -7,7 +7,7 @@
 //
 // SharedObjects=ffi_test_functions
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=5
+// VMOptions=--deterministic --optimization-counter-threshold=20
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 
@@ -25,7 +25,7 @@ import 'function_structs_by_value_generated_compounds.dart';
 
 final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions");
 void main() {
-  for (int i = 0; i < 10; ++i) {
+  for (int i = 0; i < 25; ++i) {
     testPassStruct1ByteIntx10();
     testPassStruct3BytesHomogeneousUint8x10();
     testPassStruct3BytesInt2ByteAlignedx10();

tests/ffi_2/null_test.dart

@@ -7,7 +7,7 @@
 // Separated into a separate file to make NNBD testing easier.
 //
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=10
+// VMOptions=--deterministic --optimization-counter-threshold=90
 // VMOptions=--use-slow-path
 // VMOptions=--use-slow-path --stacktrace-every=100
 // VMOptions=--write-protect-code --no-dual-map-code

tests/ffi_2/regress_43016_test.dart

@@ -4,7 +4,7 @@
 //
 // SharedObjects=ffi_test_functions
 //
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=200
 
 // @dart = 2.9
 

tests/ffi_2/variance_function_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 //
 // VMOptions=
-// VMOptions=--deterministic --optimization-counter-threshold=10
+// VMOptions=--deterministic --optimization-counter-threshold=90
 // VMOptions=--use-slow-path
 // SharedObjects=ffi_test_functions
 //

tests/language/async/await_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 // VMOptions=
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=20
 
 import "package:expect/expect.dart";
 import "package:async_helper/async_helper.dart";

tests/language/await/exceptions_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=20
 
 import 'package:expect/expect.dart';
 import "package:async_helper/async_helper.dart";

tests/language/await/future_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 // VMOptions=
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=20
 
 import 'package:expect/expect.dart';
 import "package:async_helper/async_helper.dart";

tests/language/await/nonfuture_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=20
 
 import 'package:expect/expect.dart';
 import 'package:async_helper/async_helper.dart';

tests/language/is/optimized_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Testing optimized 'is' tests.
-// VMOptions=--optimization-counter-threshold=5 --no-use-osr --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-use-osr --no-background-compilation
 
 import "package:expect/expect.dart";
 

tests/language/null/null_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 // Second dart test program.
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=90
 
 import "package:expect/expect.dart";
 
@@ -40,7 +40,7 @@ confuse(x) {
 }
 
 void main() {
-  for (int i = 0; i < 10; i++) {
+  for (int i = 0; i < 100; i++) {
     test();
   }
 }

tests/language/optimize/osr_test.dart

@@ -1,7 +1,7 @@
 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 // Test correct OSR (issue 16151).
 
 import "dart:collection";

tests/language/regress/regress31591_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=90
 
 import 'package:expect/expect.dart';
 
@@ -11,7 +11,7 @@ typedef FunObjObj = Object? Function<T>(Object?, {Object? y});
 Object? funTypObj<T>(T x, {Object? y}) => y;
 
 main() {
-  for (int i = 0; i < 10; i++) {
+  for (int i = 0; i < 100; i++) {
     Expect.throwsTypeError(() {
       dynamic y = funTypObj;
       final FunObjObj x2 = y;

tests/language/vm/debug_break_enabled_vm_test.dart

@@ -1,7 +1,7 @@
 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-// VMOptions=--optimization-counter-threshold=5 --enable-debug-break --no-background-compilation
+// VMOptions=--optimization-counter-threshold=50 --enable-debug-break --no-background-compilation
 
 // Verify that the optimizer does not trip over the debug break (StopInstr).
 
@@ -11,13 +11,13 @@ test(i) {
   }
   // "crash" is not an allowed outcome specifier.
   // Use "ok" instead and mark the status file with "Crash, OK".
-  if (i == 18) {
+  if (i == 180) {
     break "hit"; //  //# 01: ok
   }
 }
 
 void main() {
-  for (var i = 0; i < 20; i += 2) {
+  for (var i = 0; i < 200; i += 2) {
     test(i);
   }
 }

tests/language/vm/regress_23117_vm_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Test location summary for Uint32 multiplication.
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 import 'package:expect/expect.dart';
 
@@ -10,7 +10,7 @@ mintLeftShift(x, y) => x << y;
 mintRightShift(x, y) => x >> y;
 
 main() {
-  for (var i = 0; i < 20; i++) {
+  for (var i = 0; i < 25; i++) {
     var x = 1 + (1 << (i + 32));
     Expect.equals(x, mintLeftShift(x, 0));
     Expect.equals(x, mintRightShift(x, 0));

tests/language/vm/regress_29137_vm_test.dart

@@ -11,7 +11,7 @@
 // optimizer must *not* replace v2 with v0 because the first conversion is
 // truncating and is erasing the high part of the mint value.
 //
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=90 --no-background-compilation
 
 import "package:expect/expect.dart";
 
@@ -30,7 +30,7 @@ main() {
   const value = 0xF0F00000;
   const rotated = 0xF00000F0;
   Expect.equals(rotated, rot8(value));
-  for (var i = 0; i < 10; i++) {
+  for (var i = 0; i < 100; i++) {
     Expect.equals(rotated, rot8(value));
   }
 }

tests/language/vm/regress_45260_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
-// VMOptions=--optimization-counter-threshold=5 --deterministic
+// VMOptions=--optimization-counter-threshold=20 --deterministic
 
 import 'package:expect/expect.dart';
 

tests/language_2/async/await_test.dart

@@ -5,7 +5,7 @@
 // @dart = 2.9
 
 // VMOptions=
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=20
 
 import "package:expect/expect.dart";
 import "package:async_helper/async_helper.dart";

tests/language_2/await/exceptions_test.dart

@@ -4,7 +4,7 @@
 
 // @dart = 2.9
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=20
 
 import 'package:expect/expect.dart';
 import "package:async_helper/async_helper.dart";

tests/language_2/await/future_test.dart

@@ -5,7 +5,7 @@
 // @dart = 2.9
 
 // VMOptions=
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=20
 
 import 'package:expect/expect.dart';
 import "package:async_helper/async_helper.dart";

tests/language_2/await/nonfuture_test.dart

@@ -4,7 +4,7 @@
 
 // @dart = 2.9
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=20
 
 import 'package:expect/expect.dart';
 import 'package:async_helper/async_helper.dart';

tests/language_2/is/optimized_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Testing optimized 'is' tests.
-// VMOptions=--optimization-counter-threshold=5 --no-use-osr --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-use-osr --no-background-compilation
 
 // @dart = 2.9
 

tests/language_2/null/null_test.dart

@@ -5,7 +5,7 @@
 
 // @dart = 2.9
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=90
 
 import "package:expect/expect.dart";
 
@@ -42,7 +42,7 @@ confuse(x) {
 }
 
 void main() {
-  for (int i = 0; i < 10; i++) {
+  for (int i = 0; i < 100; i++) {
     test();
   }
 }

tests/language_2/optimize/osr_test.dart

@@ -1,7 +1,7 @@
 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 // Test correct OSR (issue 16151).
 
 // @dart = 2.9

tests/language_2/regress/regress31591_test.dart

@@ -4,7 +4,7 @@
 
 // @dart = 2.9
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=90
 
 import 'package:expect/expect.dart';
 
@@ -13,7 +13,7 @@ typedef FunObjObj = Object Function<T>(Object, {Object y});
 Object funTypObj<T>(T x, {Object y}) => y;
 
 main() {
-  for (int i = 0; i < 10; i++) {
+  for (int i = 0; i < 100; i++) {
     Expect.throwsTypeError(() {
       dynamic y = funTypObj;
       final FunObjObj x2 = y;

tests/language_2/vm/debug_break_enabled_vm_test.dart

@@ -1,7 +1,7 @@
 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-// VMOptions=--optimization-counter-threshold=5 --enable-debug-break --no-background-compilation
+// VMOptions=--optimization-counter-threshold=50 --enable-debug-break --no-background-compilation
 
 // @dart = 2.9
 
@@ -13,13 +13,13 @@ test(i) {
   }
   // "crash" is not an allowed outcome specifier.
   // Use "ok" instead and mark the status file with "Crash, OK".
-  if (i == 18) {
+  if (i == 180) {
     break "hit"; //  //# 01: ok
   }
 }
 
 void main() {
-  for (var i = 0; i < 20; i += 2) {
+  for (var i = 0; i < 200; i += 2) {
     test(i);
   }
 }

tests/language_2/vm/regress_23117_vm_test.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Test location summary for Uint32 multiplication.
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 // @dart = 2.9
 
@@ -12,7 +12,7 @@ mintLeftShift(x, y) => x << y;
 mintRightShift(x, y) => x >> y;
 
 main() {
-  for (var i = 0; i < 20; i++) {
+  for (var i = 0; i < 25; i++) {
     var x = 1 + (1 << (i + 32));
     Expect.equals(x, mintLeftShift(x, 0));
     Expect.equals(x, mintRightShift(x, 0));

tests/language_2/vm/regress_29137_vm_test.dart

@@ -11,7 +11,7 @@
 // optimizer must *not* replace v2 with v0 because the first conversion is
 // truncating and is erasing the high part of the mint value.
 //
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=90 --no-background-compilation
 
 // @dart = 2.9
 
@@ -32,7 +32,7 @@ main() {
   const value = 0xF0F00000;
   const rotated = 0xF00000F0;
   Expect.equals(rotated, rot8(value));
-  for (var i = 0; i < 10; i++) {
+  for (var i = 0; i < 100; i++) {
     Expect.equals(rotated, rot8(value));
   }
 }

tests/language_2/vm/regress_45260_test.dart

@@ -4,7 +4,7 @@
 
 // @dart = 2.9
 
-// VMOptions=--optimization-counter-threshold=5 --deterministic
+// VMOptions=--optimization-counter-threshold=20 --deterministic
 
 import 'package:expect/expect.dart';
 

tests/lib/math/double_pow_test.dart

@@ -1,7 +1,7 @@
 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 library math_test;
 

tests/lib/mirrors/null_test.dart

@@ -2,13 +2,13 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=90
 
 import "dart:mirrors";
 import "package:expect/expect.dart";
 
 void main() {
-  for (int i = 0; i < 10; i++) {
+  for (int i = 0; i < 100; i++) {
     test();
   }
 }

tests/lib_2/math/double_pow_test.dart

@@ -1,7 +1,7 @@
 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-// VMOptions=--optimization-counter-threshold=5 --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-background-compilation
 
 // @dart = 2.9
 

tests/lib_2/mirrors/null_test.dart

@@ -4,13 +4,13 @@
 
 // @dart = 2.9
 
-// VMOptions=--optimization-counter-threshold=5
+// VMOptions=--optimization-counter-threshold=90
 
 import "dart:mirrors";
 import "package:expect/expect.dart";
 
 void main() {
-  for (int i = 0; i < 10; i++) {
+  for (int i = 0; i < 100; i++) {
     test();
   }
 }

tests/standalone/int_list_test.dart

@@ -5,7 +5,7 @@
 // Dart Mint representations and type propagation issue.
 // Testing Int32List and Uint32List loads.
 //
-// VMOptions=--optimization-counter-threshold=5 --no-use-osr --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-use-osr --no-background-compilation
 
 import 'dart:typed_data';
 import "package:expect/expect.dart";

tests/standalone/slowpath_safepoints_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 // Test that safepoints associated with slowpaths don't mark non-existing values
 // alive.
-// VMOptions=--optimization-counter-threshold=5 --no-inline_alloc --no-background-compilation
+// VMOptions=--optimization-counter-threshold=90 --no-inline_alloc --no-background-compilation
 
 class C {
   final next;
@@ -41,7 +41,7 @@ crash(f, i) {
 }
 
 main() {
-  for (var i = 0; i < 10; i++) {
+  for (var i = 0; i < 100; i++) {
     print(i);
     crash(noop, 10);
   }

tests/standalone_2/int_list_test.dart

@@ -5,7 +5,7 @@
 // Dart Mint representations and type propagation issue.
 // Testing Int32List and Uint32List loads.
 //
-// VMOptions=--optimization-counter-threshold=5 --no-use-osr --no-background-compilation
+// VMOptions=--optimization-counter-threshold=20 --no-use-osr --no-background-compilation
 
 // @dart = 2.9
 

tests/standalone_2/slowpath_safepoints_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 // Test that safepoints associated with slowpaths don't mark non-existing values
 // alive.
-// VMOptions=--optimization-counter-threshold=5 --no-inline_alloc --no-background-compilation
+// VMOptions=--optimization-counter-threshold=90 --no-inline_alloc --no-background-compilation
 
 // @dart = 2.9
 
@@ -43,7 +43,7 @@ crash(f, i) {
 }
 
 main() {
-  for (var i = 0; i < 10; i++) {
+  for (var i = 0; i < 100; i++) {
     print(i);
     crash(noop, 10);
   }