From 24b8399086239f0deca7faf36e6df65d1d364ac6 Mon Sep 17 00:00:00 2001 From: Alexander Markov Date: Mon, 10 Oct 2022 21:04:18 +0000 Subject: [PATCH] [tests] Avoid small --optimization-counter-threshold in tests Small --optimization-counter-threshold makes tests very slow, especially on architectures where kernel service runs from kernel and not from app-jit snapshot. TEST=change in tests, *-ia32 bots Fixes https://github.com/dart-lang/sdk/issues/48627 Change-Id: I63e7e201ef9a0e4f645016c39a5be1819b61822d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263421 Commit-Queue: Alexander Markov Reviewed-by: Ryan Macnak --- .../pause_on_unhandled_async_exceptions2_test.dart | 2 +- .../pause_on_unhandled_async_exceptions2_test.dart | 2 +- .../jit/polymorphic_optional_this_test.dart | 6 +++--- .../vm/dart/entrypoints/jit/polymorphic_this_test.dart | 6 +++--- .../vm/dart/entrypoints/jit/static_this_test.dart | 6 +++--- runtime/tests/vm/dart/entrypoints/jit/super_test.dart | 6 +++--- runtime/tests/vm/dart/regress32619_test.dart | 10 ++++++++-- runtime/tests/vm/dart/regress_b_230945329_test.dart | 4 ++-- .../jit/polymorphic_optional_this_test.dart | 6 +++--- .../dart_2/entrypoints/jit/polymorphic_this_test.dart | 6 +++--- .../vm/dart_2/entrypoints/jit/static_this_test.dart | 6 +++--- .../tests/vm/dart_2/entrypoints/jit/super_test.dart | 6 +++--- runtime/tests/vm/dart_2/regress32619_test.dart | 10 ++++++++-- runtime/tests/vm/dart_2/regress_b_230945329_test.dart | 4 ++-- samples/ffi/sqlite/test/sqlite_test.dart | 2 -- tests/corelib/bigint_from_test.dart | 2 +- tests/corelib/bigint_js_test.dart | 2 +- tests/corelib/bigint_parse_radix_test.dart | 2 +- tests/corelib/bigint_test.dart | 2 +- tests/corelib_2/bigint_from_test.dart | 2 +- tests/corelib_2/bigint_js_test.dart | 2 +- tests/corelib_2/bigint_parse_radix_test.dart | 2 +- tests/corelib_2/bigint_test.dart | 2 +- ...tion_callbacks_structs_by_value_generated_test.dart | 2 +- .../ffi/function_callbacks_structs_by_value_test.dart | 4 ++-- tests/ffi/function_callbacks_very_many_test.dart | 2 +- .../function_structs_by_value_generated_leaf_test.dart | 4 ++-- .../ffi/function_structs_by_value_generated_test.dart | 4 ++-- .../generator/structs_by_value_tests_generator.dart | 6 +++--- tests/ffi/regress_43016_test.dart | 2 +- tests/ffi/variance_function_test.dart | 2 +- ...tion_callbacks_structs_by_value_generated_test.dart | 2 +- .../function_callbacks_structs_by_value_test.dart | 4 ++-- tests/ffi_2/function_callbacks_very_many_test.dart | 2 +- .../function_structs_by_value_generated_leaf_test.dart | 4 ++-- .../function_structs_by_value_generated_test.dart | 4 ++-- tests/ffi_2/null_test.dart | 2 +- tests/ffi_2/regress_43016_test.dart | 2 +- tests/ffi_2/variance_function_test.dart | 2 +- tests/language/async/await_test.dart | 2 +- tests/language/await/exceptions_test.dart | 2 +- tests/language/await/future_test.dart | 2 +- tests/language/await/nonfuture_test.dart | 2 +- tests/language/is/optimized_test.dart | 2 +- tests/language/null/null_test.dart | 4 ++-- tests/language/optimize/osr_test.dart | 2 +- tests/language/regress/regress31591_test.dart | 4 ++-- tests/language/vm/debug_break_enabled_vm_test.dart | 6 +++--- tests/language/vm/regress_23117_vm_test.dart | 4 ++-- tests/language/vm/regress_29137_vm_test.dart | 4 ++-- tests/language/vm/regress_45260_test.dart | 2 +- tests/language_2/async/await_test.dart | 2 +- tests/language_2/await/exceptions_test.dart | 2 +- tests/language_2/await/future_test.dart | 2 +- tests/language_2/await/nonfuture_test.dart | 2 +- tests/language_2/is/optimized_test.dart | 2 +- tests/language_2/null/null_test.dart | 4 ++-- tests/language_2/optimize/osr_test.dart | 2 +- tests/language_2/regress/regress31591_test.dart | 4 ++-- tests/language_2/vm/debug_break_enabled_vm_test.dart | 6 +++--- tests/language_2/vm/regress_23117_vm_test.dart | 4 ++-- tests/language_2/vm/regress_29137_vm_test.dart | 4 ++-- tests/language_2/vm/regress_45260_test.dart | 2 +- tests/lib/math/double_pow_test.dart | 2 +- tests/lib/mirrors/null_test.dart | 4 ++-- tests/lib_2/math/double_pow_test.dart | 2 +- tests/lib_2/mirrors/null_test.dart | 4 ++-- tests/standalone/int_list_test.dart | 2 +- tests/standalone/slowpath_safepoints_test.dart | 4 ++-- tests/standalone_2/int_list_test.dart | 2 +- tests/standalone_2/slowpath_safepoints_test.dart | 4 ++-- 71 files changed, 126 insertions(+), 116 deletions(-) diff --git a/runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart b/runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart index 4d06f0bb933..f53dd3a2218 100644 --- a/runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart +++ b/runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // // VMOptions=--async_debugger -// VMOptions=--async_debugger --optimization-counter-threshold=5 +// VMOptions=--async_debugger --optimization-counter-threshold=90 import 'package:observatory/service_io.dart'; import 'package:observatory/models.dart' as M; diff --git a/runtime/observatory_2/tests/service_2/pause_on_unhandled_async_exceptions2_test.dart b/runtime/observatory_2/tests/service_2/pause_on_unhandled_async_exceptions2_test.dart index 05f2e2225ec..901ac8752dd 100644 --- a/runtime/observatory_2/tests/service_2/pause_on_unhandled_async_exceptions2_test.dart +++ b/runtime/observatory_2/tests/service_2/pause_on_unhandled_async_exceptions2_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // // VMOptions=--async_debugger -// VMOptions=--async_debugger --optimization-counter-threshold=5 +// VMOptions=--async_debugger --optimization-counter-threshold=90 import 'package:observatory_2/service_io.dart'; import 'package:observatory_2/models.dart' as M; diff --git a/runtime/tests/vm/dart/entrypoints/jit/polymorphic_optional_this_test.dart b/runtime/tests/vm/dart/entrypoints/jit/polymorphic_optional_this_test.dart index cd53c432783..120f884b282 100644 --- a/runtime/tests/vm/dart/entrypoints/jit/polymorphic_optional_this_test.dart +++ b/runtime/tests/vm/dart/entrypoints/jit/polymorphic_optional_this_test.dart @@ -2,9 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 -Denable_inlining=true --compilation-counter-threshold=1 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 --compilation-counter-threshold=1 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=1 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 // Test that 'PolymorphicInstanceCall's against "this" go through the unchecked // entrypoint. The use of optional arguments here encourages prologue sharing diff --git a/runtime/tests/vm/dart/entrypoints/jit/polymorphic_this_test.dart b/runtime/tests/vm/dart/entrypoints/jit/polymorphic_this_test.dart index 579341926fa..af02b4c28e4 100644 --- a/runtime/tests/vm/dart/entrypoints/jit/polymorphic_this_test.dart +++ b/runtime/tests/vm/dart/entrypoints/jit/polymorphic_this_test.dart @@ -2,9 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 -Denable_inlining=true --compilation-counter-threshold=1 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 --compilation-counter-threshold=1 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=1 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 // Test that 'PolymorphicInstanceCall's against "this" go through the unchecked // entrypoint. diff --git a/runtime/tests/vm/dart/entrypoints/jit/static_this_test.dart b/runtime/tests/vm/dart/entrypoints/jit/static_this_test.dart index 29094e46559..e73f55587e3 100644 --- a/runtime/tests/vm/dart/entrypoints/jit/static_this_test.dart +++ b/runtime/tests/vm/dart/entrypoints/jit/static_this_test.dart @@ -2,9 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 --compilation-counter-threshold=5 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 -Denable_inlining=true --compilation-counter-threshold=5 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=5 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 import '../static_this.dart'; diff --git a/runtime/tests/vm/dart/entrypoints/jit/super_test.dart b/runtime/tests/vm/dart/entrypoints/jit/super_test.dart index be8d2d9a217..93f18485550 100644 --- a/runtime/tests/vm/dart/entrypoints/jit/super_test.dart +++ b/runtime/tests/vm/dart/entrypoints/jit/super_test.dart @@ -2,9 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 -Denable_inlining=true --compilation-counter-threshold=5 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 --compilation-counter-threshold=5 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=5 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 import "../super.dart"; diff --git a/runtime/tests/vm/dart/regress32619_test.dart b/runtime/tests/vm/dart/regress32619_test.dart index 3659926bb29..92cefd3956f 100644 --- a/runtime/tests/vm/dart/regress32619_test.dart +++ b/runtime/tests/vm/dart/regress32619_test.dart @@ -4,7 +4,7 @@ // Regression test for dartbug.com/32619: incorrect widening of smis to int32. -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=90 --no-background-compilation import "package:expect/expect.dart"; import 'dart:typed_data'; @@ -31,7 +31,7 @@ int _mulAdd(Uint32List multiplicandDigits, int i, Uint32List accumulatorDigits, return carry; } -main() { +test() { var multiplicandDigits = new Uint32List.fromList([0, 294967296, 0, 0]); var accumulatorDigits = new Uint32List.fromList([0, 4, 4, 0, 0, 0]); @@ -39,3 +39,9 @@ main() { Expect.equals(0, d1); } + +main() { + for (int i = 0; i < 100; ++i) { + test(); + } +} diff --git a/runtime/tests/vm/dart/regress_b_230945329_test.dart b/runtime/tests/vm/dart/regress_b_230945329_test.dart index 46c9b8428ad..6705dddd6a6 100644 --- a/runtime/tests/vm/dart/regress_b_230945329_test.dart +++ b/runtime/tests/vm/dart/regress_b_230945329_test.dart @@ -7,13 +7,13 @@ // Check that AssertAssignables for the same uninstantiated type, where the // instantiated types at runtime may differ, are not optimized away. // -// VMOptions=--no-use-field-guards --no-use-osr --deterministic --optimization-counter-threshold=5 +// VMOptions=--no-use-field-guards --no-use-osr --deterministic --optimization-counter-threshold=90 void main() { final bar = Box('a'); // T=dynamic final barInt = Box(1); // T=int - for (int i = 0; i < 5; ++i) { + for (int i = 0; i < 100; ++i) { bar.bar(bar); } try { diff --git a/runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_optional_this_test.dart b/runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_optional_this_test.dart index eb7c8d6d2d1..c182d15b162 100644 --- a/runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_optional_this_test.dart +++ b/runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_optional_this_test.dart @@ -2,9 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 -Denable_inlining=true --compilation-counter-threshold=1 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 --compilation-counter-threshold=1 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=1 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 // @dart = 2.9 diff --git a/runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_this_test.dart b/runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_this_test.dart index 37f5a66229f..52a1f769743 100644 --- a/runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_this_test.dart +++ b/runtime/tests/vm/dart_2/entrypoints/jit/polymorphic_this_test.dart @@ -2,9 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 -Denable_inlining=true --compilation-counter-threshold=1 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=10 --compilation-counter-threshold=1 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=1 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 // @dart = 2.9 diff --git a/runtime/tests/vm/dart_2/entrypoints/jit/static_this_test.dart b/runtime/tests/vm/dart_2/entrypoints/jit/static_this_test.dart index bfdc0f874c9..0fddb8cb062 100644 --- a/runtime/tests/vm/dart_2/entrypoints/jit/static_this_test.dart +++ b/runtime/tests/vm/dart_2/entrypoints/jit/static_this_test.dart @@ -2,9 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 --compilation-counter-threshold=5 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 -Denable_inlining=true --compilation-counter-threshold=5 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=5 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 // @dart = 2.9 diff --git a/runtime/tests/vm/dart_2/entrypoints/jit/super_test.dart b/runtime/tests/vm/dart_2/entrypoints/jit/super_test.dart index bccaa311792..45b8289515b 100644 --- a/runtime/tests/vm/dart_2/entrypoints/jit/super_test.dart +++ b/runtime/tests/vm/dart_2/entrypoints/jit/super_test.dart @@ -2,9 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 -Denable_inlining=true --compilation-counter-threshold=5 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=5 --compilation-counter-threshold=5 -// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 --compilation-counter-threshold=5 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 -Denable_inlining=true +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=90 +// VMOptions=--enable-testing-pragmas --no-background-compilation --optimization-counter-threshold=-1 // @dart = 2.9 diff --git a/runtime/tests/vm/dart_2/regress32619_test.dart b/runtime/tests/vm/dart_2/regress32619_test.dart index fe1897a6b38..3762aebfba3 100644 --- a/runtime/tests/vm/dart_2/regress32619_test.dart +++ b/runtime/tests/vm/dart_2/regress32619_test.dart @@ -6,7 +6,7 @@ // Regression test for dartbug.com/32619: incorrect widening of smis to int32. -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=90 --no-background-compilation import "package:expect/expect.dart"; import 'dart:typed_data'; @@ -33,7 +33,7 @@ int _mulAdd(Uint32List multiplicandDigits, int i, Uint32List accumulatorDigits, return carry; } -main() { +test() { var multiplicandDigits = new Uint32List.fromList([0, 294967296, 0, 0]); var accumulatorDigits = new Uint32List.fromList([0, 4, 4, 0, 0, 0]); @@ -41,3 +41,9 @@ main() { Expect.equals(0, d1); } + +main() { + for (int i = 0; i < 100; ++i) { + test(); + } +} diff --git a/runtime/tests/vm/dart_2/regress_b_230945329_test.dart b/runtime/tests/vm/dart_2/regress_b_230945329_test.dart index 86c422dbc5f..fad640ff653 100644 --- a/runtime/tests/vm/dart_2/regress_b_230945329_test.dart +++ b/runtime/tests/vm/dart_2/regress_b_230945329_test.dart @@ -7,7 +7,7 @@ // Check that AssertAssignables for the same uninstantiated type, where the // instantiated types at runtime may differ, are not optimized away. // -// VMOptions=--no-use-field-guards --no-use-osr --deterministic --optimization-counter-threshold=5 +// VMOptions=--no-use-field-guards --no-use-osr --deterministic --optimization-counter-threshold=90 // // @dart=2.9 @@ -15,7 +15,7 @@ void main() { final bar = Box('a'); // T=dynamic final barInt = Box(1); // T=int - for (int i = 0; i < 5; ++i) { + for (int i = 0; i < 100; ++i) { bar.bar(bar); } try { diff --git a/samples/ffi/sqlite/test/sqlite_test.dart b/samples/ffi/sqlite/test/sqlite_test.dart index c0c9151b40f..9e989b7bd67 100644 --- a/samples/ffi/sqlite/test/sqlite_test.dart +++ b/samples/ffi/sqlite/test/sqlite_test.dart @@ -2,8 +2,6 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 - import "dart:ffi"; import "dart:io"; diff --git a/tests/corelib/bigint_from_test.dart b/tests/corelib/bigint_from_test.dart index a12abd9f52d..33ea4e02034 100644 --- a/tests/corelib/bigint_from_test.dart +++ b/tests/corelib/bigint_from_test.dart @@ -6,7 +6,7 @@ // VMOptions=--intrinsify --no-enable-asserts // VMOptions=--intrinsify --enable-asserts // VMOptions=--no-intrinsify --enable-asserts -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation // VMOptions=--dwarf_stack_traces --no-retain_function_objects --no-retain_code_objects import "package:expect/expect.dart"; diff --git a/tests/corelib/bigint_js_test.dart b/tests/corelib/bigint_js_test.dart index ebebc25d680..f6798410f05 100644 --- a/tests/corelib/bigint_js_test.dart +++ b/tests/corelib/bigint_js_test.dart @@ -6,7 +6,7 @@ // VMOptions=--intrinsify --no-enable-asserts // VMOptions=--intrinsify --enable-asserts // VMOptions=--no-intrinsify --enable-asserts -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation // Test for JavaScript specific BigInt behaviour. Any JavaScript number (double) // that is an integral value is a Dart 'int' value, so any BigInt that has a diff --git a/tests/corelib/bigint_parse_radix_test.dart b/tests/corelib/bigint_parse_radix_test.dart index 57057e22b7f..68639798b5f 100644 --- a/tests/corelib/bigint_parse_radix_test.dart +++ b/tests/corelib/bigint_parse_radix_test.dart @@ -6,7 +6,7 @@ // VMOptions=--intrinsify --no-enable-asserts // VMOptions=--intrinsify --enable-asserts // VMOptions=--no-intrinsify --enable-asserts -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation import "package:expect/expect.dart"; diff --git a/tests/corelib/bigint_test.dart b/tests/corelib/bigint_test.dart index 39b8cddea92..2f9342996b4 100644 --- a/tests/corelib/bigint_test.dart +++ b/tests/corelib/bigint_test.dart @@ -6,7 +6,7 @@ // VMOptions=--intrinsify --no-enable-asserts // VMOptions=--intrinsify --enable-asserts // VMOptions=--no-intrinsify --enable-asserts -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation import "package:expect/expect.dart"; diff --git a/tests/corelib_2/bigint_from_test.dart b/tests/corelib_2/bigint_from_test.dart index 015934cfbb3..ddda982089c 100644 --- a/tests/corelib_2/bigint_from_test.dart +++ b/tests/corelib_2/bigint_from_test.dart @@ -8,7 +8,7 @@ // VMOptions=--intrinsify --no-enable-asserts // VMOptions=--intrinsify --enable-asserts // VMOptions=--no-intrinsify --enable-asserts -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation // VMOptions=--dwarf_stack_traces --no-retain_function_objects --no-retain_code_objects import "package:expect/expect.dart"; diff --git a/tests/corelib_2/bigint_js_test.dart b/tests/corelib_2/bigint_js_test.dart index 45c2f0265a5..6a85df5b6c0 100644 --- a/tests/corelib_2/bigint_js_test.dart +++ b/tests/corelib_2/bigint_js_test.dart @@ -8,7 +8,7 @@ // VMOptions=--intrinsify --no-enable-asserts // VMOptions=--intrinsify --enable-asserts // VMOptions=--no-intrinsify --enable-asserts -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation // Test for JavaScript specific BigInt behaviour. Any JavaScript number (double) // that is an integral value is a Dart 'int' value, so any BigInt that has a diff --git a/tests/corelib_2/bigint_parse_radix_test.dart b/tests/corelib_2/bigint_parse_radix_test.dart index 9a073d08f6d..ed2a8b33539 100644 --- a/tests/corelib_2/bigint_parse_radix_test.dart +++ b/tests/corelib_2/bigint_parse_radix_test.dart @@ -8,7 +8,7 @@ // VMOptions=--intrinsify --no-enable-asserts // VMOptions=--intrinsify --enable-asserts // VMOptions=--no-intrinsify --enable-asserts -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation import "package:expect/expect.dart"; diff --git a/tests/corelib_2/bigint_test.dart b/tests/corelib_2/bigint_test.dart index 24b7ebda8fb..b2d10d64f30 100644 --- a/tests/corelib_2/bigint_test.dart +++ b/tests/corelib_2/bigint_test.dart @@ -8,7 +8,7 @@ // VMOptions=--intrinsify --no-enable-asserts // VMOptions=--intrinsify --enable-asserts // VMOptions=--no-intrinsify --enable-asserts -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation import "package:expect/expect.dart"; diff --git a/tests/ffi/function_callbacks_structs_by_value_generated_test.dart b/tests/ffi/function_callbacks_structs_by_value_generated_test.dart index 2fbccd18f63..75df9caead3 100644 --- a/tests/ffi/function_callbacks_structs_by_value_generated_test.dart +++ b/tests/ffi/function_callbacks_structs_by_value_generated_test.dart @@ -7,7 +7,7 @@ // // SharedObjects=ffi_test_functions // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=10 +// VMOptions=--deterministic --optimization-counter-threshold=20 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 diff --git a/tests/ffi/function_callbacks_structs_by_value_test.dart b/tests/ffi/function_callbacks_structs_by_value_test.dart index f14ce1f868f..a33cadcccba 100644 --- a/tests/ffi/function_callbacks_structs_by_value_test.dart +++ b/tests/ffi/function_callbacks_structs_by_value_test.dart @@ -4,7 +4,7 @@ // // SharedObjects=ffi_test_functions // -// VMOptions=--deterministic --optimization-counter-threshold=5 --use-slow-path --stacktrace-every=100 +// VMOptions=--deterministic --optimization-counter-threshold=90 --use-slow-path --stacktrace-every=100 import 'dart:ffi'; @@ -19,7 +19,7 @@ import 'function_structs_by_value_generated_compounds.dart'; final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions"); void main() { - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 100; i++) { recursiveTest(10); recursiveTest(11); testCopyLogic(); diff --git a/tests/ffi/function_callbacks_very_many_test.dart b/tests/ffi/function_callbacks_very_many_test.dart index 3180e89e1e9..211d19ad5d8 100644 --- a/tests/ffi/function_callbacks_very_many_test.dart +++ b/tests/ffi/function_callbacks_very_many_test.dart @@ -4,7 +4,7 @@ // Dart test program for testing dart:ffi function pointers with callbacks. // -// VMOptions=--deterministic --optimization-counter-threshold=10 +// VMOptions=--deterministic --optimization-counter-threshold=90 // VMOptions=--stacktrace-every=100 // VMOptions=--write-protect-code --no-dual-map-code // VMOptions=--write-protect-code --no-dual-map-code --stacktrace-every=100 diff --git a/tests/ffi/function_structs_by_value_generated_leaf_test.dart b/tests/ffi/function_structs_by_value_generated_leaf_test.dart index 770441739da..a0334a0b7a5 100644 --- a/tests/ffi/function_structs_by_value_generated_leaf_test.dart +++ b/tests/ffi/function_structs_by_value_generated_leaf_test.dart @@ -7,7 +7,7 @@ // // SharedObjects=ffi_test_functions // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=5 +// VMOptions=--deterministic --optimization-counter-threshold=20 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 @@ -23,7 +23,7 @@ import 'function_structs_by_value_generated_compounds.dart'; final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions"); void main() { - for (int i = 0; i < 10; ++i) { + for (int i = 0; i < 25; ++i) { testPassStruct1ByteIntx10Leaf(); testPassStruct3BytesHomogeneousUint8x10Leaf(); testPassStruct3BytesInt2ByteAlignedx10Leaf(); diff --git a/tests/ffi/function_structs_by_value_generated_test.dart b/tests/ffi/function_structs_by_value_generated_test.dart index 897472cd2d7..8eb47dcadb9 100644 --- a/tests/ffi/function_structs_by_value_generated_test.dart +++ b/tests/ffi/function_structs_by_value_generated_test.dart @@ -7,7 +7,7 @@ // // SharedObjects=ffi_test_functions // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=5 +// VMOptions=--deterministic --optimization-counter-threshold=20 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 @@ -23,7 +23,7 @@ import 'function_structs_by_value_generated_compounds.dart'; final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions"); void main() { - for (int i = 0; i < 10; ++i) { + for (int i = 0; i < 25; ++i) { testPassStruct1ByteIntx10(); testPassStruct3BytesHomogeneousUint8x10(); testPassStruct3BytesInt2ByteAlignedx10(); diff --git a/tests/ffi/generator/structs_by_value_tests_generator.dart b/tests/ffi/generator/structs_by_value_tests_generator.dart index 671f65ec76c..7518dd8318c 100644 --- a/tests/ffi/generator/structs_by_value_tests_generator.dart +++ b/tests/ffi/generator/structs_by_value_tests_generator.dart @@ -954,7 +954,7 @@ ${headerCommon(copyrightYear: copyrightYear)} // // SharedObjects=ffi_test_functions // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=5 +// VMOptions=--deterministic --optimization-counter-threshold=20 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 @@ -984,7 +984,7 @@ Future writeDartCallTest({required bool isLeaf}) async { final suffix = isLeaf ? 'Leaf' : ''; buffer.write(""" void main() { - for (int i = 0; i < 10; ++i) { + for (int i = 0; i < 25; ++i) { ${functions.map((e) => "${e.dartTestName}$suffix();").join("\n")} } } @@ -1014,7 +1014,7 @@ ${headerCommon(copyrightYear: copyrightYear)} // // SharedObjects=ffi_test_functions // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=10 +// VMOptions=--deterministic --optimization-counter-threshold=20 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 diff --git a/tests/ffi/regress_43016_test.dart b/tests/ffi/regress_43016_test.dart index db3d816cf83..cbd68cca1b6 100644 --- a/tests/ffi/regress_43016_test.dart +++ b/tests/ffi/regress_43016_test.dart @@ -4,7 +4,7 @@ // // SharedObjects=ffi_test_functions // -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=200 import 'dart:ffi'; diff --git a/tests/ffi/variance_function_test.dart b/tests/ffi/variance_function_test.dart index bea1dd06856..5293cdd00f9 100644 --- a/tests/ffi/variance_function_test.dart +++ b/tests/ffi/variance_function_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=10 +// VMOptions=--deterministic --optimization-counter-threshold=90 // VMOptions=--use-slow-path // SharedObjects=ffi_test_functions // diff --git a/tests/ffi_2/function_callbacks_structs_by_value_generated_test.dart b/tests/ffi_2/function_callbacks_structs_by_value_generated_test.dart index b890cbc1c5b..b4d58817955 100644 --- a/tests/ffi_2/function_callbacks_structs_by_value_generated_test.dart +++ b/tests/ffi_2/function_callbacks_structs_by_value_generated_test.dart @@ -7,7 +7,7 @@ // // SharedObjects=ffi_test_functions // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=10 +// VMOptions=--deterministic --optimization-counter-threshold=20 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 diff --git a/tests/ffi_2/function_callbacks_structs_by_value_test.dart b/tests/ffi_2/function_callbacks_structs_by_value_test.dart index e3cee6280b3..fad090e9922 100644 --- a/tests/ffi_2/function_callbacks_structs_by_value_test.dart +++ b/tests/ffi_2/function_callbacks_structs_by_value_test.dart @@ -4,7 +4,7 @@ // // SharedObjects=ffi_test_functions // -// VMOptions=--deterministic --optimization-counter-threshold=5 --use-slow-path --stacktrace-every=100 +// VMOptions=--deterministic --optimization-counter-threshold=90 --use-slow-path --stacktrace-every=100 // @dart = 2.9 @@ -21,7 +21,7 @@ import 'function_structs_by_value_generated_compounds.dart'; final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions"); void main() { - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 100; i++) { recursiveTest(10); recursiveTest(11); testCopyLogic(); diff --git a/tests/ffi_2/function_callbacks_very_many_test.dart b/tests/ffi_2/function_callbacks_very_many_test.dart index 957e13be4b5..d9d25bf5657 100644 --- a/tests/ffi_2/function_callbacks_very_many_test.dart +++ b/tests/ffi_2/function_callbacks_very_many_test.dart @@ -6,7 +6,7 @@ // Dart test program for testing dart:ffi function pointers with callbacks. // -// VMOptions=--deterministic --optimization-counter-threshold=10 +// VMOptions=--deterministic --optimization-counter-threshold=90 // VMOptions=--stacktrace-every=100 // VMOptions=--write-protect-code --no-dual-map-code // VMOptions=--write-protect-code --no-dual-map-code --stacktrace-every=100 diff --git a/tests/ffi_2/function_structs_by_value_generated_leaf_test.dart b/tests/ffi_2/function_structs_by_value_generated_leaf_test.dart index 8c010567d92..a759e1e2e41 100644 --- a/tests/ffi_2/function_structs_by_value_generated_leaf_test.dart +++ b/tests/ffi_2/function_structs_by_value_generated_leaf_test.dart @@ -7,7 +7,7 @@ // // SharedObjects=ffi_test_functions // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=5 +// VMOptions=--deterministic --optimization-counter-threshold=20 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 @@ -25,7 +25,7 @@ import 'function_structs_by_value_generated_compounds.dart'; final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions"); void main() { - for (int i = 0; i < 10; ++i) { + for (int i = 0; i < 25; ++i) { testPassStruct1ByteIntx10Leaf(); testPassStruct3BytesHomogeneousUint8x10Leaf(); testPassStruct3BytesInt2ByteAlignedx10Leaf(); diff --git a/tests/ffi_2/function_structs_by_value_generated_test.dart b/tests/ffi_2/function_structs_by_value_generated_test.dart index 6329287ff76..a25487f33cc 100644 --- a/tests/ffi_2/function_structs_by_value_generated_test.dart +++ b/tests/ffi_2/function_structs_by_value_generated_test.dart @@ -7,7 +7,7 @@ // // SharedObjects=ffi_test_functions // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=5 +// VMOptions=--deterministic --optimization-counter-threshold=20 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 @@ -25,7 +25,7 @@ import 'function_structs_by_value_generated_compounds.dart'; final ffiTestFunctions = dlopenPlatformSpecific("ffi_test_functions"); void main() { - for (int i = 0; i < 10; ++i) { + for (int i = 0; i < 25; ++i) { testPassStruct1ByteIntx10(); testPassStruct3BytesHomogeneousUint8x10(); testPassStruct3BytesInt2ByteAlignedx10(); diff --git a/tests/ffi_2/null_test.dart b/tests/ffi_2/null_test.dart index d852cd8bede..75185e96014 100644 --- a/tests/ffi_2/null_test.dart +++ b/tests/ffi_2/null_test.dart @@ -7,7 +7,7 @@ // Separated into a separate file to make NNBD testing easier. // // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=10 +// VMOptions=--deterministic --optimization-counter-threshold=90 // VMOptions=--use-slow-path // VMOptions=--use-slow-path --stacktrace-every=100 // VMOptions=--write-protect-code --no-dual-map-code diff --git a/tests/ffi_2/regress_43016_test.dart b/tests/ffi_2/regress_43016_test.dart index dda4f3a019d..c1927c99be9 100644 --- a/tests/ffi_2/regress_43016_test.dart +++ b/tests/ffi_2/regress_43016_test.dart @@ -4,7 +4,7 @@ // // SharedObjects=ffi_test_functions // -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=200 // @dart = 2.9 diff --git a/tests/ffi_2/variance_function_test.dart b/tests/ffi_2/variance_function_test.dart index 295f52d0e7f..36b63ee55a1 100644 --- a/tests/ffi_2/variance_function_test.dart +++ b/tests/ffi_2/variance_function_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // // VMOptions= -// VMOptions=--deterministic --optimization-counter-threshold=10 +// VMOptions=--deterministic --optimization-counter-threshold=90 // VMOptions=--use-slow-path // SharedObjects=ffi_test_functions // diff --git a/tests/language/async/await_test.dart b/tests/language/async/await_test.dart index e7920d60121..a7e4a5d9e4e 100644 --- a/tests/language/async/await_test.dart +++ b/tests/language/async/await_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // VMOptions= -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=20 import "package:expect/expect.dart"; import "package:async_helper/async_helper.dart"; diff --git a/tests/language/await/exceptions_test.dart b/tests/language/await/exceptions_test.dart index 15419d4574b..b43704962e3 100644 --- a/tests/language/await/exceptions_test.dart +++ b/tests/language/await/exceptions_test.dart @@ -2,7 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=20 import 'package:expect/expect.dart'; import "package:async_helper/async_helper.dart"; diff --git a/tests/language/await/future_test.dart b/tests/language/await/future_test.dart index 76546984cba..65fb8295c42 100644 --- a/tests/language/await/future_test.dart +++ b/tests/language/await/future_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // VMOptions= -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=20 import 'package:expect/expect.dart'; import "package:async_helper/async_helper.dart"; diff --git a/tests/language/await/nonfuture_test.dart b/tests/language/await/nonfuture_test.dart index 1aa6855ff6d..cd214f04b15 100644 --- a/tests/language/await/nonfuture_test.dart +++ b/tests/language/await/nonfuture_test.dart @@ -2,7 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=20 import 'package:expect/expect.dart'; import 'package:async_helper/async_helper.dart'; diff --git a/tests/language/is/optimized_test.dart b/tests/language/is/optimized_test.dart index 3c3f875b6a9..2625a2e178f 100644 --- a/tests/language/is/optimized_test.dart +++ b/tests/language/is/optimized_test.dart @@ -2,7 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // Testing optimized 'is' tests. -// VMOptions=--optimization-counter-threshold=5 --no-use-osr --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-use-osr --no-background-compilation import "package:expect/expect.dart"; diff --git a/tests/language/null/null_test.dart b/tests/language/null/null_test.dart index f42d618e4b5..86851821194 100644 --- a/tests/language/null/null_test.dart +++ b/tests/language/null/null_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // Second dart test program. -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=90 import "package:expect/expect.dart"; @@ -40,7 +40,7 @@ confuse(x) { } void main() { - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 100; i++) { test(); } } diff --git a/tests/language/optimize/osr_test.dart b/tests/language/optimize/osr_test.dart index 3bc8db382f7..65f82d6e0a6 100644 --- a/tests/language/optimize/osr_test.dart +++ b/tests/language/optimize/osr_test.dart @@ -1,7 +1,7 @@ // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation // Test correct OSR (issue 16151). import "dart:collection"; diff --git a/tests/language/regress/regress31591_test.dart b/tests/language/regress/regress31591_test.dart index 1ad5754ac2b..4f204ac7267 100644 --- a/tests/language/regress/regress31591_test.dart +++ b/tests/language/regress/regress31591_test.dart @@ -2,7 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=90 import 'package:expect/expect.dart'; @@ -11,7 +11,7 @@ typedef FunObjObj = Object? Function(Object?, {Object? y}); Object? funTypObj(T x, {Object? y}) => y; main() { - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 100; i++) { Expect.throwsTypeError(() { dynamic y = funTypObj; final FunObjObj x2 = y; diff --git a/tests/language/vm/debug_break_enabled_vm_test.dart b/tests/language/vm/debug_break_enabled_vm_test.dart index a0e0c59a0c8..86139fde743 100644 --- a/tests/language/vm/debug_break_enabled_vm_test.dart +++ b/tests/language/vm/debug_break_enabled_vm_test.dart @@ -1,7 +1,7 @@ // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 --enable-debug-break --no-background-compilation +// VMOptions=--optimization-counter-threshold=50 --enable-debug-break --no-background-compilation // Verify that the optimizer does not trip over the debug break (StopInstr). @@ -11,13 +11,13 @@ test(i) { } // "crash" is not an allowed outcome specifier. // Use "ok" instead and mark the status file with "Crash, OK". - if (i == 18) { + if (i == 180) { break "hit"; // //# 01: ok } } void main() { - for (var i = 0; i < 20; i += 2) { + for (var i = 0; i < 200; i += 2) { test(i); } } diff --git a/tests/language/vm/regress_23117_vm_test.dart b/tests/language/vm/regress_23117_vm_test.dart index d6fcf6932d8..82912dd1f74 100644 --- a/tests/language/vm/regress_23117_vm_test.dart +++ b/tests/language/vm/regress_23117_vm_test.dart @@ -2,7 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // Test location summary for Uint32 multiplication. -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation import 'package:expect/expect.dart'; @@ -10,7 +10,7 @@ mintLeftShift(x, y) => x << y; mintRightShift(x, y) => x >> y; main() { - for (var i = 0; i < 20; i++) { + for (var i = 0; i < 25; i++) { var x = 1 + (1 << (i + 32)); Expect.equals(x, mintLeftShift(x, 0)); Expect.equals(x, mintRightShift(x, 0)); diff --git a/tests/language/vm/regress_29137_vm_test.dart b/tests/language/vm/regress_29137_vm_test.dart index 978483f5b60..1bba2b98b65 100644 --- a/tests/language/vm/regress_29137_vm_test.dart +++ b/tests/language/vm/regress_29137_vm_test.dart @@ -11,7 +11,7 @@ // optimizer must *not* replace v2 with v0 because the first conversion is // truncating and is erasing the high part of the mint value. // -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=90 --no-background-compilation import "package:expect/expect.dart"; @@ -30,7 +30,7 @@ main() { const value = 0xF0F00000; const rotated = 0xF00000F0; Expect.equals(rotated, rot8(value)); - for (var i = 0; i < 10; i++) { + for (var i = 0; i < 100; i++) { Expect.equals(rotated, rot8(value)); } } diff --git a/tests/language/vm/regress_45260_test.dart b/tests/language/vm/regress_45260_test.dart index 17991e36f8d..d4fb0c53770 100644 --- a/tests/language/vm/regress_45260_test.dart +++ b/tests/language/vm/regress_45260_test.dart @@ -2,7 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// VMOptions=--optimization-counter-threshold=5 --deterministic +// VMOptions=--optimization-counter-threshold=20 --deterministic import 'package:expect/expect.dart'; diff --git a/tests/language_2/async/await_test.dart b/tests/language_2/async/await_test.dart index fd3f3f9646a..c0e86417f00 100644 --- a/tests/language_2/async/await_test.dart +++ b/tests/language_2/async/await_test.dart @@ -5,7 +5,7 @@ // @dart = 2.9 // VMOptions= -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=20 import "package:expect/expect.dart"; import "package:async_helper/async_helper.dart"; diff --git a/tests/language_2/await/exceptions_test.dart b/tests/language_2/await/exceptions_test.dart index 6a9f2f5e17b..5057f7d6870 100644 --- a/tests/language_2/await/exceptions_test.dart +++ b/tests/language_2/await/exceptions_test.dart @@ -4,7 +4,7 @@ // @dart = 2.9 -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=20 import 'package:expect/expect.dart'; import "package:async_helper/async_helper.dart"; diff --git a/tests/language_2/await/future_test.dart b/tests/language_2/await/future_test.dart index 4b9c8d36236..67af0b259fa 100644 --- a/tests/language_2/await/future_test.dart +++ b/tests/language_2/await/future_test.dart @@ -5,7 +5,7 @@ // @dart = 2.9 // VMOptions= -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=20 import 'package:expect/expect.dart'; import "package:async_helper/async_helper.dart"; diff --git a/tests/language_2/await/nonfuture_test.dart b/tests/language_2/await/nonfuture_test.dart index 6d5eb4a8362..26c64d5284d 100644 --- a/tests/language_2/await/nonfuture_test.dart +++ b/tests/language_2/await/nonfuture_test.dart @@ -4,7 +4,7 @@ // @dart = 2.9 -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=20 import 'package:expect/expect.dart'; import 'package:async_helper/async_helper.dart'; diff --git a/tests/language_2/is/optimized_test.dart b/tests/language_2/is/optimized_test.dart index 0c630ac6854..cb1563232de 100644 --- a/tests/language_2/is/optimized_test.dart +++ b/tests/language_2/is/optimized_test.dart @@ -2,7 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // Testing optimized 'is' tests. -// VMOptions=--optimization-counter-threshold=5 --no-use-osr --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-use-osr --no-background-compilation // @dart = 2.9 diff --git a/tests/language_2/null/null_test.dart b/tests/language_2/null/null_test.dart index ffa40ec479e..c7d39dd0168 100644 --- a/tests/language_2/null/null_test.dart +++ b/tests/language_2/null/null_test.dart @@ -5,7 +5,7 @@ // @dart = 2.9 -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=90 import "package:expect/expect.dart"; @@ -42,7 +42,7 @@ confuse(x) { } void main() { - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 100; i++) { test(); } } diff --git a/tests/language_2/optimize/osr_test.dart b/tests/language_2/optimize/osr_test.dart index 34a55bf6ad4..c9528f3fc55 100644 --- a/tests/language_2/optimize/osr_test.dart +++ b/tests/language_2/optimize/osr_test.dart @@ -1,7 +1,7 @@ // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation // Test correct OSR (issue 16151). // @dart = 2.9 diff --git a/tests/language_2/regress/regress31591_test.dart b/tests/language_2/regress/regress31591_test.dart index 95564f4adc7..04ad7f6a800 100644 --- a/tests/language_2/regress/regress31591_test.dart +++ b/tests/language_2/regress/regress31591_test.dart @@ -4,7 +4,7 @@ // @dart = 2.9 -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=90 import 'package:expect/expect.dart'; @@ -13,7 +13,7 @@ typedef FunObjObj = Object Function(Object, {Object y}); Object funTypObj(T x, {Object y}) => y; main() { - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 100; i++) { Expect.throwsTypeError(() { dynamic y = funTypObj; final FunObjObj x2 = y; diff --git a/tests/language_2/vm/debug_break_enabled_vm_test.dart b/tests/language_2/vm/debug_break_enabled_vm_test.dart index 42c8790ed18..bcd68937eac 100644 --- a/tests/language_2/vm/debug_break_enabled_vm_test.dart +++ b/tests/language_2/vm/debug_break_enabled_vm_test.dart @@ -1,7 +1,7 @@ // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 --enable-debug-break --no-background-compilation +// VMOptions=--optimization-counter-threshold=50 --enable-debug-break --no-background-compilation // @dart = 2.9 @@ -13,13 +13,13 @@ test(i) { } // "crash" is not an allowed outcome specifier. // Use "ok" instead and mark the status file with "Crash, OK". - if (i == 18) { + if (i == 180) { break "hit"; // //# 01: ok } } void main() { - for (var i = 0; i < 20; i += 2) { + for (var i = 0; i < 200; i += 2) { test(i); } } diff --git a/tests/language_2/vm/regress_23117_vm_test.dart b/tests/language_2/vm/regress_23117_vm_test.dart index 4dcb411cc9e..255c12cdd1b 100644 --- a/tests/language_2/vm/regress_23117_vm_test.dart +++ b/tests/language_2/vm/regress_23117_vm_test.dart @@ -2,7 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // Test location summary for Uint32 multiplication. -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation // @dart = 2.9 @@ -12,7 +12,7 @@ mintLeftShift(x, y) => x << y; mintRightShift(x, y) => x >> y; main() { - for (var i = 0; i < 20; i++) { + for (var i = 0; i < 25; i++) { var x = 1 + (1 << (i + 32)); Expect.equals(x, mintLeftShift(x, 0)); Expect.equals(x, mintRightShift(x, 0)); diff --git a/tests/language_2/vm/regress_29137_vm_test.dart b/tests/language_2/vm/regress_29137_vm_test.dart index 1088ceeb0f9..55293d4da19 100644 --- a/tests/language_2/vm/regress_29137_vm_test.dart +++ b/tests/language_2/vm/regress_29137_vm_test.dart @@ -11,7 +11,7 @@ // optimizer must *not* replace v2 with v0 because the first conversion is // truncating and is erasing the high part of the mint value. // -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=90 --no-background-compilation // @dart = 2.9 @@ -32,7 +32,7 @@ main() { const value = 0xF0F00000; const rotated = 0xF00000F0; Expect.equals(rotated, rot8(value)); - for (var i = 0; i < 10; i++) { + for (var i = 0; i < 100; i++) { Expect.equals(rotated, rot8(value)); } } diff --git a/tests/language_2/vm/regress_45260_test.dart b/tests/language_2/vm/regress_45260_test.dart index a75143feb45..5f82672a9ac 100644 --- a/tests/language_2/vm/regress_45260_test.dart +++ b/tests/language_2/vm/regress_45260_test.dart @@ -4,7 +4,7 @@ // @dart = 2.9 -// VMOptions=--optimization-counter-threshold=5 --deterministic +// VMOptions=--optimization-counter-threshold=20 --deterministic import 'package:expect/expect.dart'; diff --git a/tests/lib/math/double_pow_test.dart b/tests/lib/math/double_pow_test.dart index c3e7969bfd1..5daba88a3f4 100644 --- a/tests/lib/math/double_pow_test.dart +++ b/tests/lib/math/double_pow_test.dart @@ -1,7 +1,7 @@ // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation library math_test; diff --git a/tests/lib/mirrors/null_test.dart b/tests/lib/mirrors/null_test.dart index ab4c9156a3b..a7105c430b9 100644 --- a/tests/lib/mirrors/null_test.dart +++ b/tests/lib/mirrors/null_test.dart @@ -2,13 +2,13 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=90 import "dart:mirrors"; import "package:expect/expect.dart"; void main() { - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 100; i++) { test(); } } diff --git a/tests/lib_2/math/double_pow_test.dart b/tests/lib_2/math/double_pow_test.dart index e68380bb6ad..0a28f20ff30 100644 --- a/tests/lib_2/math/double_pow_test.dart +++ b/tests/lib_2/math/double_pow_test.dart @@ -1,7 +1,7 @@ // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// VMOptions=--optimization-counter-threshold=5 --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-background-compilation // @dart = 2.9 diff --git a/tests/lib_2/mirrors/null_test.dart b/tests/lib_2/mirrors/null_test.dart index 68d4e0b135f..9db0b896d04 100644 --- a/tests/lib_2/mirrors/null_test.dart +++ b/tests/lib_2/mirrors/null_test.dart @@ -4,13 +4,13 @@ // @dart = 2.9 -// VMOptions=--optimization-counter-threshold=5 +// VMOptions=--optimization-counter-threshold=90 import "dart:mirrors"; import "package:expect/expect.dart"; void main() { - for (int i = 0; i < 10; i++) { + for (int i = 0; i < 100; i++) { test(); } } diff --git a/tests/standalone/int_list_test.dart b/tests/standalone/int_list_test.dart index c719f4d14b0..e0c751b8a82 100644 --- a/tests/standalone/int_list_test.dart +++ b/tests/standalone/int_list_test.dart @@ -5,7 +5,7 @@ // Dart Mint representations and type propagation issue. // Testing Int32List and Uint32List loads. // -// VMOptions=--optimization-counter-threshold=5 --no-use-osr --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-use-osr --no-background-compilation import 'dart:typed_data'; import "package:expect/expect.dart"; diff --git a/tests/standalone/slowpath_safepoints_test.dart b/tests/standalone/slowpath_safepoints_test.dart index c983e623131..203d47b4d60 100644 --- a/tests/standalone/slowpath_safepoints_test.dart +++ b/tests/standalone/slowpath_safepoints_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // Test that safepoints associated with slowpaths don't mark non-existing values // alive. -// VMOptions=--optimization-counter-threshold=5 --no-inline_alloc --no-background-compilation +// VMOptions=--optimization-counter-threshold=90 --no-inline_alloc --no-background-compilation class C { final next; @@ -41,7 +41,7 @@ crash(f, i) { } main() { - for (var i = 0; i < 10; i++) { + for (var i = 0; i < 100; i++) { print(i); crash(noop, 10); } diff --git a/tests/standalone_2/int_list_test.dart b/tests/standalone_2/int_list_test.dart index 8fc0a5e2d9e..2b9ca9f0196 100644 --- a/tests/standalone_2/int_list_test.dart +++ b/tests/standalone_2/int_list_test.dart @@ -5,7 +5,7 @@ // Dart Mint representations and type propagation issue. // Testing Int32List and Uint32List loads. // -// VMOptions=--optimization-counter-threshold=5 --no-use-osr --no-background-compilation +// VMOptions=--optimization-counter-threshold=20 --no-use-osr --no-background-compilation // @dart = 2.9 diff --git a/tests/standalone_2/slowpath_safepoints_test.dart b/tests/standalone_2/slowpath_safepoints_test.dart index b8f0f2a1b97..5396ae0ceb9 100644 --- a/tests/standalone_2/slowpath_safepoints_test.dart +++ b/tests/standalone_2/slowpath_safepoints_test.dart @@ -3,7 +3,7 @@ // BSD-style license that can be found in the LICENSE file. // Test that safepoints associated with slowpaths don't mark non-existing values // alive. -// VMOptions=--optimization-counter-threshold=5 --no-inline_alloc --no-background-compilation +// VMOptions=--optimization-counter-threshold=90 --no-inline_alloc --no-background-compilation // @dart = 2.9 @@ -43,7 +43,7 @@ crash(f, i) { } main() { - for (var i = 0; i < 10; i++) { + for (var i = 0; i < 100; i++) { print(i); crash(noop, 10); }