dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert "[build] Use ad-hoc code signing by default."

Browse Source 
This reverts commit 1d5057e94d.

Reason for revert: breaks sanitizer builds

Original change's description:
> [build] Use ad-hoc code signing by default.
>
> Change-Id: I00b483581a04bfb4a4ed0d6212c767d67c003f83
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508164
> Reviewed-by: Slava Egorov <vegorov@google.com>
> Commit-Queue: Slava Egorov <vegorov@google.com>

Change-Id: Iaa21b281ac56c7e6f1cd94c42602c6a17eb6a38b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509080
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
This commit is contained in:
Ryan Macnak
2026-06-03 10:27:18 -07:00
committed by dart-scoped@luci-project-accounts.iam.gserviceaccount.com
parent f8ef9fdb61
commit 165dd4d04e
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/bots/test_matrix.json
+9
View File
@@ -1059,6 +1059,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"--codesigning-identity=-",
"--include-experimental-vm-service",
"runtime"
]
@@ -1089,6 +1090,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"--codesigning-identity=-",
"--include-experimental-vm-service",
"runtime"
]
@@ -1097,6 +1099,7 @@
"name": "build iOS shared library",
"script": "tools/build.py",
"arguments": [
"--codesigning-identity=-",
"--os=ios",
"runtime:dart_jit_library"
]
@@ -1137,6 +1140,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"--codesigning-identity=-",
"runtime"
]
},
@@ -1167,6 +1171,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"--codesigning-identity=-",
"--include-experimental-vm-service",
"runtime",
"dartaotruntime"
@@ -1208,6 +1213,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"--codesigning-identity=-",
"runtime",
"dartaotruntime"
]
@@ -1322,6 +1328,7 @@
"script": "tools/build.py",
"arguments": [
"--dart-dynamic-modules",
"--codesigning-identity=-",
"runtime",
"utils/dart2bytecode",
"utils/modular_aot_compiler"
@@ -1478,6 +1485,7 @@
"script": "tools/build.py",
"arguments": [
"--dart-dynamic-modules",
"--codesigning-identity=-",
"runtime",
"runtime_precompiled",
"utils/gen_kernel"
@@ -3132,6 +3140,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"--codesigning-identity=-",
"create_sdk",
"dartanalyzer",
"ddc_stable_test",
tools/gn.py
+1 -1
View File
@@ -552,7 +552,7 @@ def AddCommonGnOptionArgs(parser):
action='store_true')
parser.add_argument('--codesigning-identity',
help='Sign executables using the given identity.',
default='-',
default='',
type=str)
parser.add_argument(
'--include-experimental-vm-service',