From 165dd4d04eb97e162a81b84c3d6075b50f1660c5 Mon Sep 17 00:00:00 2001 From: Ryan Macnak Date: Wed, 3 Jun 2026 10:27:18 -0700 Subject: [PATCH] Revert "[build] Use ad-hoc code signing by default." This reverts commit 1d5057e94dd75af63061ea378b51106c092b62ce. Reason for revert: breaks sanitizer builds Original change's description: > [build] Use ad-hoc code signing by default. > > Change-Id: I00b483581a04bfb4a4ed0d6212c767d67c003f83 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508164 > Reviewed-by: Slava Egorov > Commit-Queue: Slava Egorov Change-Id: Iaa21b281ac56c7e6f1cd94c42602c6a17eb6a38b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509080 Reviewed-by: Alexander Aprelev Commit-Queue: Ryan Macnak Bot-Commit: rubber-stamper@appspot.gserviceaccount.com --- tools/bots/test_matrix.json | 9 +++++++++ tools/gn.py | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json index ed2a75f1860..b511ce01f45 100644 --- a/tools/bots/test_matrix.json +++ b/tools/bots/test_matrix.json @@ -1059,6 +1059,7 @@ "name": "build dart", "script": "tools/build.py", "arguments": [ + "--codesigning-identity=-", "--include-experimental-vm-service", "runtime" ] @@ -1089,6 +1090,7 @@ "name": "build dart", "script": "tools/build.py", "arguments": [ + "--codesigning-identity=-", "--include-experimental-vm-service", "runtime" ] @@ -1097,6 +1099,7 @@ "name": "build iOS shared library", "script": "tools/build.py", "arguments": [ + "--codesigning-identity=-", "--os=ios", "runtime:dart_jit_library" ] @@ -1137,6 +1140,7 @@ "name": "build dart", "script": "tools/build.py", "arguments": [ + "--codesigning-identity=-", "runtime" ] }, @@ -1167,6 +1171,7 @@ "name": "build dart", "script": "tools/build.py", "arguments": [ + "--codesigning-identity=-", "--include-experimental-vm-service", "runtime", "dartaotruntime" @@ -1208,6 +1213,7 @@ "name": "build dart", "script": "tools/build.py", "arguments": [ + "--codesigning-identity=-", "runtime", "dartaotruntime" ] @@ -1322,6 +1328,7 @@ "script": "tools/build.py", "arguments": [ "--dart-dynamic-modules", + "--codesigning-identity=-", "runtime", "utils/dart2bytecode", "utils/modular_aot_compiler" @@ -1478,6 +1485,7 @@ "script": "tools/build.py", "arguments": [ "--dart-dynamic-modules", + "--codesigning-identity=-", "runtime", "runtime_precompiled", "utils/gen_kernel" @@ -3132,6 +3140,7 @@ "name": "build dart", "script": "tools/build.py", "arguments": [ + "--codesigning-identity=-", "create_sdk", "dartanalyzer", "ddc_stable_test", diff --git a/tools/gn.py b/tools/gn.py index 17dd1525780..b2d1bec4538 100755 --- a/tools/gn.py +++ b/tools/gn.py @@ -552,7 +552,7 @@ def AddCommonGnOptionArgs(parser): action='store_true') parser.add_argument('--codesigning-identity', help='Sign executables using the given identity.', - default='-', + default='', type=str) parser.add_argument( '--include-experimental-vm-service',