dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert accidental change in ObjectHash benchmark

Browse Source 
The change in [0] made ObjectHash.hash.5 benchmark accidentally hash one
more value (i.e. 6 instead of 5). This CL reverts that change.

[0] https://dart-review.googlesource.com/c/sdk/+/276161

TEST=ci

Change-Id: Idee8cd445683b89d1a4013beae3ea544a5e3a8e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277988
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
This commit is contained in:
Martin Kustermann
2023-01-03 09:50:38 +00:00
committed by Commit Queue
parent 5d0325d3f1
commit 150635653e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
benchmarks/ObjectHash/dart/ObjectHash.dart
+3 -2
View File
@@ -28,12 +28,13 @@ abstract class Node5 {
class Node5Hash extends Node5 {
// This is the main subject of the benchmark - a typical use of `Object.hash`.
@override
int get hashCode => Object.hash(item1, item2, item3, item4, item5, 0);
int get hashCode => Object.hash(item1, item2, item3, item4, item5);
}
class Node5Manual extends Node5 {
// This is a similar quality hashCode but with statically resolvable
// `hashCode` calls.
// `hashCode` calls and a 0 seed (instead of loading a unique random seed from
// global late-final variable).
@override
int get hashCode => _SystemHash.hash5(item1.hashCode, item2.hashCode,
item3.hashCode, item4.hashCode, item5.hashCode, 0);