From 150635653e6dde44b16f8f781b4a7fa384048dca Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Tue, 3 Jan 2023 09:50:38 +0000 Subject: [PATCH] Revert accidental change in ObjectHash benchmark The change in [0] made ObjectHash.hash.5 benchmark accidentally hash one more value (i.e. 6 instead of 5). This CL reverts that change. [0] https://dart-review.googlesource.com/c/sdk/+/276161 TEST=ci Change-Id: Idee8cd445683b89d1a4013beae3ea544a5e3a8e5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277988 Commit-Queue: Lasse Nielsen Reviewed-by: Lasse Nielsen --- benchmarks/ObjectHash/dart/ObjectHash.dart | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/benchmarks/ObjectHash/dart/ObjectHash.dart b/benchmarks/ObjectHash/dart/ObjectHash.dart index 5f70d447128..aac2af4875d 100644 --- a/benchmarks/ObjectHash/dart/ObjectHash.dart +++ b/benchmarks/ObjectHash/dart/ObjectHash.dart @@ -28,12 +28,13 @@ abstract class Node5 { class Node5Hash extends Node5 { // This is the main subject of the benchmark - a typical use of `Object.hash`. @override - int get hashCode => Object.hash(item1, item2, item3, item4, item5, 0); + int get hashCode => Object.hash(item1, item2, item3, item4, item5); } class Node5Manual extends Node5 { // This is a similar quality hashCode but with statically resolvable - // `hashCode` calls. + // `hashCode` calls and a 0 seed (instead of loading a unique random seed from + // global late-final variable). @override int get hashCode => _SystemHash.hash5(item1.hashCode, item2.hashCode, item3.hashCode, item4.hashCode, item5.hashCode, 0);