dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[gardening] Fix httpIG sample test, update new isolate_group_bound test status on fuchsia.

Browse Source 
Fix failures https://dart-ci.appspot.com/log/vm-linux-release-x64/vm-linux-release-x64/6082/samples/ffi/httpIG/test/http_test

Lift .status-file constraints on where http and httpIG samples can run.

Follow-up to b759d096cb
TEST=ci

Change-Id: Icc71d6407e910d30f6ff028830550a05b179f1da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444927
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Alexander Aprelev
2025-08-13 12:27:40 -07:00
committed by Commit Queue
parent 5e2dc27fce
commit 1499a30cd5
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
samples/ffi/httpIG/lib/http.dart
+2 -2
View File
@@ -12,7 +12,7 @@ import 'package:ffi/ffi.dart';
import 'dylib_utils.dart';
Function (Pointer<Utf8>) createGetSender(SendPort sendPort) {
Function (Pointer<Utf8>) createGetSender(final SendPort sendPort) {
return (Pointer<Utf8> responsePointer) {
final typedList = responsePointer.cast<Uint8>().asTypedList(
responsePointer.length,
@@ -57,7 +57,7 @@ Future<String> httpGet(String uri) async {
@pragma('vm:shared')
late int counter;
Function (Pointer<Utf8>) createServeSender(SendPort sendPort) {
Function (Pointer<Utf8>) createServeSender(final SendPort sendPort) {
return (Pointer<Utf8> requestPointer) {
counter++;
final typedList = requestPointer.cast<Uint8>().asTypedList(
samples/samples.status
-2
View File
@@ -15,8 +15,6 @@ ffi/*: SkipByDesign # FFI skips, see ffi.status
*: Skip # Not yet triaged.
[ $arch != x64 || $compiler != dartk || $system != linux || $hot_reload || $hot_reload_rollback ]
ffi/http/test/http_test: SkipByDesign
ffi/httpIG/test/http_test: SkipByDesign
ffi/sqlite/test/sqlite_test: SkipByDesign # FFI not supported or libsqlite3.so not available.
[ $runtime == d8 || $browser ]
tests/ffi/ffi.status
+1
View File
@@ -58,6 +58,7 @@ function_callbacks_structs_by_value_generated_test/*: Skip # Test harness doesn'
function_callbacks_structs_by_value_native_callable_generated_test/*: Skip # Test harness doesn't support multitest with Fuchsia
function_callbacks_subtype_test/*: Skip # Test harness doesn't support multitest with Fuchsia
isolate_group_bound_callback_test: Skip # gen_snapshot requires experimental-shared-data flag
isolate_group_bound_captured_local_test: Skip # gen_snapshot requires experimental-shared-data flag
isolate_group_bound_init_test: Skip # gen_snapshot requires experimental-shared-data flag
isolate_group_bound_send_test: Skip # gen_snapshot requires experimental-shared-data flag
native_assets/*: Skip # Source not available in the emulator