From 1499a30cd560b93ea692b5dfa78dbd01275dd720 Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Wed, 13 Aug 2025 12:27:40 -0700 Subject: [PATCH] [gardening] Fix httpIG sample test, update new isolate_group_bound test status on fuchsia. Fix failures https://dart-ci.appspot.com/log/vm-linux-release-x64/vm-linux-release-x64/6082/samples/ffi/httpIG/test/http_test Lift .status-file constraints on where http and httpIG samples can run. Follow-up to b759d096cb0f428534bfee21eb2a242e8f9ce358 TEST=ci Change-Id: Icc71d6407e910d30f6ff028830550a05b179f1da Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444927 Commit-Queue: Alexander Aprelev Reviewed-by: Ryan Macnak --- samples/ffi/httpIG/lib/http.dart | 4 ++-- samples/samples.status | 2 -- tests/ffi/ffi.status | 1 + 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/samples/ffi/httpIG/lib/http.dart b/samples/ffi/httpIG/lib/http.dart index 0a1024de352..4b3798db8e4 100644 --- a/samples/ffi/httpIG/lib/http.dart +++ b/samples/ffi/httpIG/lib/http.dart @@ -12,7 +12,7 @@ import 'package:ffi/ffi.dart'; import 'dylib_utils.dart'; -Function (Pointer) createGetSender(SendPort sendPort) { +Function (Pointer) createGetSender(final SendPort sendPort) { return (Pointer responsePointer) { final typedList = responsePointer.cast().asTypedList( responsePointer.length, @@ -57,7 +57,7 @@ Future httpGet(String uri) async { @pragma('vm:shared') late int counter; -Function (Pointer) createServeSender(SendPort sendPort) { +Function (Pointer) createServeSender(final SendPort sendPort) { return (Pointer requestPointer) { counter++; final typedList = requestPointer.cast().asTypedList( diff --git a/samples/samples.status b/samples/samples.status index 26d9087668d..0cea15b080b 100644 --- a/samples/samples.status +++ b/samples/samples.status @@ -15,8 +15,6 @@ ffi/*: SkipByDesign # FFI skips, see ffi.status *: Skip # Not yet triaged. [ $arch != x64 || $compiler != dartk || $system != linux || $hot_reload || $hot_reload_rollback ] -ffi/http/test/http_test: SkipByDesign -ffi/httpIG/test/http_test: SkipByDesign ffi/sqlite/test/sqlite_test: SkipByDesign # FFI not supported or libsqlite3.so not available. [ $runtime == d8 || $browser ] diff --git a/tests/ffi/ffi.status b/tests/ffi/ffi.status index 4fc7624fe8f..937c929dba2 100644 --- a/tests/ffi/ffi.status +++ b/tests/ffi/ffi.status @@ -58,6 +58,7 @@ function_callbacks_structs_by_value_generated_test/*: Skip # Test harness doesn' function_callbacks_structs_by_value_native_callable_generated_test/*: Skip # Test harness doesn't support multitest with Fuchsia function_callbacks_subtype_test/*: Skip # Test harness doesn't support multitest with Fuchsia isolate_group_bound_callback_test: Skip # gen_snapshot requires experimental-shared-data flag +isolate_group_bound_captured_local_test: Skip # gen_snapshot requires experimental-shared-data flag isolate_group_bound_init_test: Skip # gen_snapshot requires experimental-shared-data flag isolate_group_bound_send_test: Skip # gen_snapshot requires experimental-shared-data flag native_assets/*: Skip # Source not available in the emulator