flutter/shorebird
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(shorebird_cli): shorebird release linux not forwarding args (#3020)

Browse Source
This commit is contained in:
Felix Angelov
2025-03-27 15:38:14 -05:00
committed by GitHub
parent 9ccede765e
commit ff3c0c6e09
2 changed files with 56 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/shorebird_cli/lib/src/commands/release/linux_releaser.dart
+2
View File
@@ -76,6 +76,8 @@ For more information see: ${supportedFlutterVersionsUrl.toLink()}''');
@override
Future<FileSystemEntity> buildReleaseArtifacts() async {
await artifactBuilder.buildLinuxApp(
target: target,
args: argResults.forwardedArgs,
base64PublicKey: argResults.encodedPublicKey,
);
packages/shorebird_cli/test/src/commands/release/linux_releaser_test.dart
+54 -28
View File
@@ -259,6 +259,7 @@ For more information see: ${supportedFlutterVersionsUrl.toLink()}'''),
() => artifactBuilder.buildLinuxApp(
target: any(named: 'target'),
args: any(named: 'args'),
base64PublicKey: any(named: 'base64PublicKey'),
),
).thenAnswer((_) async => projectRoot);
});
@@ -269,37 +270,62 @@ For more information see: ${supportedFlutterVersionsUrl.toLink()}'''),
);
expect(releaseDir, releaseDirectory);
});
});
group('when public key is passed as an arg', () {
setUp(() {
when(
() => artifactBuilder.buildLinuxApp(
target: any(named: 'target'),
args: any(named: 'args'),
base64PublicKey: any(named: 'base64PublicKey'),
),
).thenAnswer((_) async => projectRoot);
when(
() => argResults.wasParsed(CommonArguments.publicKeyArg.name),
).thenReturn(true);
when(
() => argResults[CommonArguments.publicKeyArg.name],
).thenReturn('public_key');
when(
() => codeSigner.base64PublicKey(any()),
).thenReturn('encoded_public_key');
group('when target and flavor are specified', () {
const flavor = 'my-flavor';
const target = 'my-target';
setUp(() {
releaser = LinuxReleaser(
argResults: argResults,
flavor: flavor,
target: target,
);
});
test('builds artifacts with flavor and target', () async {
await runWithOverrides(releaser.buildReleaseArtifacts);
verify(
() => artifactBuilder.buildLinuxApp(target: target, args: []),
).called(1);
});
});
test('passes public key to buildLinuxApp', () async {
await runWithOverrides(releaser.buildReleaseArtifacts);
verify(
() => artifactBuilder.buildLinuxApp(
base64PublicKey: 'encoded_public_key',
target: any(named: 'target'),
args: any(named: 'args'),
),
).called(1);
group('when additional args are specified', () {
final args = ['--build-number=0 --build-name=1.0.0+1'];
setUp(() {
when(() => argResults.rest).thenReturn(args);
});
test('forwards args to artifact builder', () async {
await runWithOverrides(releaser.buildReleaseArtifacts);
verify(() => artifactBuilder.buildLinuxApp(args: args)).called(1);
});
});
group('when public key is passed as an arg', () {
setUp(() {
when(
() => argResults.wasParsed(CommonArguments.publicKeyArg.name),
).thenReturn(true);
when(
() => argResults[CommonArguments.publicKeyArg.name],
).thenReturn('public_key');
when(
() => codeSigner.base64PublicKey(any()),
).thenReturn('encoded_public_key');
});
test('passes public key to buildLinuxApp', () async {
await runWithOverrides(releaser.buildReleaseArtifacts);
verify(
() => artifactBuilder.buildLinuxApp(
base64PublicKey: 'encoded_public_key',
target: any(named: 'target'),
args: any(named: 'args'),
),
).called(1);
});
});
});