chore(shorebird_cli)!: remove alpha suffix from ios commands (#1680)

This commit is contained in:
Felix Angelov
2024-02-01 10:56:56 -06:00
committed by GitHub
parent 0a6e2ac198
commit f4bb9133c5
11 changed files with 44 additions and 16 deletions
@@ -76,7 +76,7 @@ const preLinkerFlutterRevisions = <String>{
};
/// {@template patch_ios_command}
/// `shorebird patch ios-alpha` command.
/// `shorebird patch ios` command.
/// {@endtemplate}
class PatchIosCommand extends ShorebirdCommand
with ShorebirdBuildMixin, ShorebirdArtifactMixin {
@@ -128,7 +128,10 @@ If this option is not provided, the version number will be determined from the p
}
@override
String get name => 'ios-alpha';
String get name => 'ios';
@override
List<String> get aliases => ['ios-alpha'];
@override
String get description =>
@@ -59,7 +59,10 @@ of the iOS app that is using this module.''',
final IosArchiveDiffer _archiveDiffer;
@override
String get name => 'ios-framework-alpha';
String get name => 'ios-framework';
@override
List<String> get aliases => ['ios-framework-alpha'];
@override
String get description =>
@@ -51,7 +51,7 @@ Test on designated devices that do not need to be registered with the Apple deve
}
/// {@template release_ios_command}
/// `shorebird release ios-alpha`
/// `shorebird release ios`
/// Create new app releases for iOS.
/// {@endtemplate}
class ReleaseIosCommand extends ShorebirdCommand
@@ -96,6 +96,12 @@ class ReleaseIosCommand extends ShorebirdCommand
);
}
@override
String get name => 'ios';
@override
List<String> get aliases => ['ios-alpha'];
@override
String get description => '''
Builds and submits your iOS app to Shorebird.
@@ -103,9 +109,6 @@ Shorebird saves the compiled Dart code from your application in order to
make smaller updates to your app.
''';
@override
String get name => 'ios-alpha';
@override
Future<int> run() async {
try {
@@ -33,11 +33,14 @@ of the iOS app that is using this module.''',
}
@override
String get description =>
'Builds and submits your iOS framework to Shorebird.';
String get name => 'ios-framework';
@override
String get name => 'ios-framework-alpha';
List<String> get aliases => ['ios-framework-alpha'];
@override
String get description =>
'Builds and submits your iOS framework to Shorebird.';
@override
Future<int> run() async {
@@ -151,15 +151,15 @@ mixin ShorebirdArtifactMixin on ShorebirdCommand {
static const String appXcframeworkName = 'App.xcframework';
/// Returns the path to the App.xcframework generated by
/// `shorebird release ios-framework-alpha` or
/// `shorebird patch ios-framework-alpha`.
/// `shorebird release ios-framework` or
/// `shorebird patch ios-framework`.
String getAppXcframeworkPath() {
return p.join(getAppXcframeworkDirectory().path, appXcframeworkName);
}
/// Returns the [Directory] containing the App.xcframework generated by
/// `shorebird release ios-framework-alpha` or
/// `shorebird patch ios-framework-alpha`.
/// `shorebird release ios-framework` or
/// `shorebird patch ios-framework`.
Directory getAppXcframeworkDirectory() {
final projectRoot = shorebirdEnv.getShorebirdProjectRoot()!;
return Directory(
+1 -1
View File
@@ -1,4 +1,4 @@
The xcarchives in this folder were generated by building the stock Flutter counter app with `shorebird release ios-alpha --no-codesign`. .dylib files have been removed to reduce size.
The xcarchives in this folder were generated by building the stock Flutter counter app with `shorebird release ios --no-codesign`. .dylib files have been removed to reduce size.
Files:
@@ -1,4 +1,4 @@
The xcframework files in this folder were generated by building the stock Flutter counter app with `shorebird release ios-framework-alpha` and zipped with the `ditto` command.
The xcframework files in this folder were generated by building the stock Flutter counter app with `shorebird release ios-framework` and zipped with the `ditto` command.
Files:
@@ -483,6 +483,10 @@ flutter:
)..testArgResults = argResults;
});
test('supports alpha alias', () {
expect(command.aliases, contains('ios-alpha'));
});
test('has a description', () {
expect(command.description, isNotEmpty);
});
@@ -363,6 +363,10 @@ flutter:
)..testArgResults = argResults;
});
test('supports alpha alias', () {
expect(command.aliases, contains('ios-framework-alpha'));
});
test('has a description', () {
expect(command.description, isNotEmpty);
});
@@ -310,6 +310,10 @@ flutter:
..testArgResults = argResults;
});
test('supports alpha alias', () {
expect(command.aliases, contains('ios-alpha'));
});
test('has a description', () {
expect(command.description, isNotEmpty);
});
@@ -225,6 +225,10 @@ flutter:
..testArgResults = argResults;
});
test('supports alpha alias', () {
expect(command.aliases, contains('ios-framework-alpha'));
});
test('has a description', () {
expect(command.description, isNotEmpty);
});