fix(shorebird_cli): --split-per-abi incorrectly always enabled (#1042)

This commit is contained in:
Felix Angelov
2023-08-05 18:12:48 -05:00
committed by GitHub
parent fa494f802c
commit ef6d36f6f8
2 changed files with 11 additions and 3 deletions
@@ -138,7 +138,7 @@ mixin ShorebirdBuildMixin on ShorebirdCommand {
Future<void> buildApk({
String? flavor,
String? target,
bool? splitPerAbi,
bool splitPerAbi = false,
}) async {
const executable = 'flutter';
final arguments = [
@@ -147,7 +147,7 @@ mixin ShorebirdBuildMixin on ShorebirdCommand {
'--release',
if (flavor != null) '--flavor=$flavor',
if (target != null) '--target=$target',
if (splitPerAbi != null) '--split-per-abi',
if (splitPerAbi) '--split-per-abi',
...results.rest,
];
@@ -375,6 +375,14 @@ void main() {
status: ReleaseStatus.active,
),
).called(1);
const buildApkArguments = ['build', 'apk', '--release'];
verify(
() => shorebirdProcess.run(
'flutter',
buildApkArguments,
runInShell: true,
),
).called(1);
expect(exitCode, ExitCode.success.code);
});
@@ -401,7 +409,7 @@ void main() {
status: ReleaseStatus.active,
),
).called(1);
final buildApkArguments = [
const buildApkArguments = [
'build',
'apk',
'--release',