flutter/shorebird
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat(shorebird_cli): add useVersion to ShorebirdFlutter (#1069)

Browse Source
This commit is contained in:
Felix Angelov
2023-08-08 16:16:13 -05:00
committed by GitHub
parent b5002aa5f2
commit e21c104f2c
3 changed files with 92 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/shorebird_cli/lib/src/shorebird_flutter.dart
+14
View File
@@ -72,4 +72,18 @@ class ShorebirdFlutter {
.map((e) => e.replaceFirst('origin/flutter_release/', ''))
.toList();
}
Future<void> useVersion({required String version}) async {
final revision = await git.revParse(
revision: 'origin/flutter_release/$version',
directory: _workingDirectory(),
);
final targetDirectory = Directory(_workingDirectory(revision: revision));
if (!targetDirectory.existsSync()) {
await installRevision(revision: revision);
}
shorebirdEnv.flutterRevision = revision;
}
}
packages/shorebird_cli/test/src/shorebird_env_test.dart
+4 -4
View File
@@ -399,8 +399,8 @@ test-revision
..createSync(recursive: true)
..writeAsStringSync(revision, flush: true);
final snapshot = File(
p.join(shorebirdRoot.path, 'bin', 'cache', 'shorebird.snapshot'))
..createSync(recursive: true);
p.join(shorebirdRoot.path, 'bin', 'cache', 'shorebird.snapshot'),
)..createSync(recursive: true);
expect(
runWithOverrides(() => shorebirdEnv.flutterRevision),
@@ -429,8 +429,8 @@ test-revision
..createSync(recursive: true)
..writeAsStringSync(revision, flush: true);
final snapshot = File(
p.join(shorebirdRoot.path, 'bin', 'cache', 'shorebird.snapshot'))
..createSync(recursive: true);
p.join(shorebirdRoot.path, 'bin', 'cache', 'shorebird.snapshot'),
)..createSync(recursive: true);
expect(
runWithOverrides(() => shorebirdEnv.flutterRevision),
packages/shorebird_cli/test/src/shorebird_flutter_test.dart
+74
View File
@@ -64,6 +64,12 @@ void main() {
args: ['--untracked-files=no', '--porcelain'],
),
).thenAnswer((_) async => '');
when(
() => git.revParse(
revision: any(named: 'revision'),
directory: any(named: 'directory'),
),
).thenAnswer((_) async => flutterRevision);
when(() => shorebirdEnv.flutterDirectory).thenReturn(flutterDirectory);
when(() => shorebirdEnv.flutterRevision).thenReturn(flutterRevision);
});
@@ -352,5 +358,73 @@ origin/flutter_release/3.10.6''';
);
});
});
group('useVersion', () {
const version = '3.10.0';
const newRevision = 'new-revision';
setUp(() {
when(
() => git.revParse(
revision: any(named: 'revision'),
directory: any(named: 'directory'),
),
).thenAnswer((_) async => newRevision);
});
test('installs revision if it does not exist', () async {
await expectLater(
runWithOverrides(
() => shorebirdFlutterManager.useVersion(version: version),
),
completes,
);
verify(
() => git.revParse(
revision: 'origin/flutter_release/$version',
directory: p.join(flutterDirectory.parent.path, flutterRevision),
),
).called(1);
verify(
() => git.clone(
url: ShorebirdFlutter.flutterGitUrl,
outputDirectory: p.join(
flutterDirectory.parent.path,
newRevision,
),
args: ['--filter=tree:0', '--no-checkout'],
),
).called(1);
verify(() => shorebirdEnv.flutterRevision = newRevision).called(1);
});
test('skips installation if revision already exists', () async {
Directory(p.join(flutterDirectory.parent.path, newRevision))
.createSync(recursive: true);
await expectLater(
runWithOverrides(
() => shorebirdFlutterManager.useVersion(version: version),
),
completes,
);
verify(
() => git.revParse(
revision: 'origin/flutter_release/$version',
directory: p.join(flutterDirectory.parent.path, flutterRevision),
),
).called(1);
verifyNever(
() => git.clone(
url: ShorebirdFlutter.flutterGitUrl,
outputDirectory: p.join(
flutterDirectory.parent.path,
newRevision,
),
args: ['--filter=tree:0', '--no-checkout'],
),
);
verify(() => shorebirdEnv.flutterRevision = newRevision).called(1);
});
});
});
}