fix(shorebird_cli): remove outdated note from release output (#3007)

packages/shorebird_cli/lib/src/commands/release/aar_releaser.dart

@@ -48,9 +48,6 @@ class AarReleaser extends Releaser {
   @override
   String get artifactDisplayName => 'Android archive';
 
-  @override
-  bool get requiresReleaseVersionArg => true;
-
   @override
   Future<void> assertPreconditions() async {
     try {

packages/shorebird_cli/lib/src/commands/release/ios_framework_releaser.dart

@@ -38,9 +38,6 @@ class IosFrameworkReleaser extends Releaser {
     p.join(shorebirdEnv.getShorebirdProjectRoot()!.path, 'release'),
   );
 
-  @override
-  bool get requiresReleaseVersionArg => true;
-
   @override
   String get artifactDisplayName => 'iOS framework';
 

packages/shorebird_cli/lib/src/commands/release/release_command.dart

@@ -553,12 +553,5 @@ ${summary.join('\n')}
     logger.info(
       '''To create a patch for this release, run ${lightCyan.wrap('$baseCommand --release-version=$releaseVersion')}''',
     );
-
-    if (!releaser.requiresReleaseVersionArg) {
-      logger.info('''
-
-Note: ${lightCyan.wrap(baseCommand)} without the --release-version option will patch the current version of the app.
-''');
-    }
   }
 }

packages/shorebird_cli/lib/src/commands/release/releaser.dart

@@ -29,10 +29,6 @@ abstract class Releaser {
   /// the release command.
   final String? target;
 
-  /// Whether --release-version must be specified to release. Currently only
-  /// required for add-to-app/hybrid releases (aar and ios-framework).
-  bool get requiresReleaseVersionArg => false;
-
   /// The type of artifact we are creating a release for.
   ReleaseType get releaseType;
 

packages/shorebird_cli/test/src/commands/release/aar_releaser_test.dart

@@ -118,12 +118,6 @@ void main() {
       });
     });
 
-    group('requiresReleaseVersionArg', () {
-      test('is true', () {
-        expect(aarReleaser.requiresReleaseVersionArg, isTrue);
-      });
-    });
-
     group('assertPreconditions', () {
       group('when validation succeeds', () {
         setUp(() {

packages/shorebird_cli/test/src/commands/release/ios_framework_releaser_test.dart

@@ -115,12 +115,6 @@ void main() {
       );
     });
 
-    group('requiresReleaseVersionArg', () {
-      test('is true', () {
-        expect(iosFrameworkReleaser.requiresReleaseVersionArg, isTrue);
-      });
-    });
-
     group('releaseType', () {
       test('is xcframework', () {
         expect(iosFrameworkReleaser.releaseType, ReleaseType.iosFramework);

packages/shorebird_cli/test/src/commands/release/release_command_test.dart

@@ -161,7 +161,6 @@ void main() {
       when(
         () => releaser.updatedReleaseMetadata(any()),
       ).thenAnswer((_) async => UpdateReleaseMetadata.forTest());
-      when(() => releaser.requiresReleaseVersionArg).thenReturn(false);
 
       when(() => shorebirdEnv.getShorebirdYaml()).thenReturn(shorebirdYaml);
       when(
@@ -268,10 +267,6 @@ void main() {
         () => logger.info(
           '''To create a patch for this release, run ${lightCyan.wrap('shorebird patch --platforms=android --release-version=${release.version}')}''',
         ),
-        () => logger.info('''
-
-Note: ${lightCyan.wrap('shorebird patch --platforms=android')} without the --release-version option will patch the current version of the app.
-'''),
       ]);
     });
 
@@ -354,27 +349,6 @@ Note: ${lightCyan.wrap('shorebird patch --platforms=android')} without the --rel
       });
     });
 
-    group('when release version arg is required', () {
-      setUp(() {
-        when(() => releaser.requiresReleaseVersionArg).thenReturn(true);
-      });
-
-      test(
-        'does not print patch instructions for no release version',
-        () async {
-          final exitCode = await runWithOverrides(command.run);
-          expect(exitCode, equals(ExitCode.success.code));
-
-          verifyNever(
-            () => logger.info('''
-
-Note: ${lightCyan.wrap('shorebird patch --platforms=android')} without the --release-version option will patch the current version of the app.
-'''),
-          );
-        },
-      );
-    });
-
     group('when flavor and target are provided', () {
       const flavor = 'test-flavor';
       const target = 'test-target';
@@ -409,10 +383,6 @@ Note: ${lightCyan.wrap('shorebird patch --platforms=android')} without the --rel
           () => logger.info(
             '''To create a patch for this release, run ${lightCyan.wrap('shorebird patch --platforms=android --flavor=$flavor --target=$target --release-version=${release.version}')}''',
           ),
-          () => logger.info('''
-
-Note: ${lightCyan.wrap('shorebird patch --platforms=android --flavor=$flavor --target=$target')} without the --release-version option will patch the current version of the app.
-'''),
         ]);
       });
     });

packages/shorebird_cli/test/src/commands/release/releaser_test.dart

@@ -1,76 +0,0 @@
-import 'dart:io';
-
-import 'package:shorebird_cli/src/commands/release/releaser.dart';
-import 'package:shorebird_cli/src/metadata/metadata.dart';
-import 'package:shorebird_cli/src/release_type.dart';
-import 'package:shorebird_code_push_protocol/src/models/release.dart';
-import 'package:test/test.dart';
-
-import '../../mocks.dart';
-
-void main() {
-  group(Releaser, () {
-    group('requiresReleaseVersionArg', () {
-      test('defaults to false', () {
-        final releaser = FakeReleaser(
-          argResults: MockArgResults(),
-          flavor: 'flavor',
-          target: 'target',
-        );
-        expect(releaser.requiresReleaseVersionArg, false);
-      });
-    });
-  });
-}
-
-class FakeReleaser extends Releaser {
-  FakeReleaser({
-    required super.argResults,
-    required super.flavor,
-    required super.target,
-  });
-
-  @override
-  String get artifactDisplayName => 'Fake artifact';
-
-  @override
-  Future<FileSystemEntity> buildReleaseArtifacts() {
-    throw UnimplementedError();
-  }
-
-  @override
-  Future<String> getReleaseVersion({
-    required FileSystemEntity releaseArtifactRoot,
-  }) {
-    throw UnimplementedError();
-  }
-
-  @override
-  String get postReleaseInstructions => throw UnimplementedError();
-
-  @override
-  Future<UpdateReleaseMetadata> updatedReleaseMetadata(
-    UpdateReleaseMetadata metadata,
-  ) => throw UnimplementedError();
-
-  @override
-  ReleaseType get releaseType => throw UnimplementedError();
-
-  @override
-  Future<void> uploadReleaseArtifacts({
-    required Release release,
-    required String appId,
-  }) {
-    throw UnimplementedError();
-  }
-
-  @override
-  Future<void> assertArgsAreValid() {
-    throw UnimplementedError();
-  }
-
-  @override
-  Future<void> assertPreconditions() {
-    throw UnimplementedError();
-  }
-}