chore(shorebird_cli): exit early if ios commands are run on non-mac OS (#914)

packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart

@@ -11,6 +11,7 @@ import 'package:shorebird_cli/src/config/config.dart';
 import 'package:shorebird_cli/src/doctor.dart';
 import 'package:shorebird_cli/src/formatters/file_size_formatter.dart';
 import 'package:shorebird_cli/src/logger.dart';
+import 'package:shorebird_cli/src/platform.dart';
 import 'package:shorebird_cli/src/shorebird_artifact_mixin.dart';
 import 'package:shorebird_cli/src/shorebird_build_mixin.dart';
 import 'package:shorebird_cli/src/shorebird_config_mixin.dart';
@@ -72,6 +73,11 @@ class PatchIosCommand extends ShorebirdCommand
 
   @override
   Future<int> run() async {
+    if (!platform.isMacOS) {
+      logger.err('This command is only supported on macOS.');
+      return ExitCode.unavailable.code;
+    }
+
     try {
       await validatePreconditions(
         checkShorebirdInitialized: true,
@@ -88,7 +94,7 @@ class PatchIosCommand extends ShorebirdCommand
 
     const arch = 'aarch64';
     const channelName = 'stable';
-    const platform = ReleasePlatform.ios;
+    const releasePlatform = ReleasePlatform.ios;
     final force = results['force'] == true;
     final dryRun = results['dry-run'] == true;
     final flavor = results['flavor'] as String?;
@@ -213,7 +219,7 @@ https://github.com/shorebirdtech/shorebird/issues/472
       if (flavor != null) '🍧 Flavor: ${lightCyan.wrap(flavor)}',
       '📦 Release Version: ${lightCyan.wrap(releaseVersion)}',
       '📺 Channel: ${lightCyan.wrap(channelName)}',
-      '''🕹️  Platform: ${lightCyan.wrap(platform.name)} ${lightCyan.wrap('[$arch (${formatBytes(aotFileSize)})]')}''',
+      '''🕹️  Platform: ${lightCyan.wrap(releasePlatform.name)} ${lightCyan.wrap('[$arch (${formatBytes(aotFileSize)})]')}''',
     ];
 
     logger.info(
@@ -240,7 +246,7 @@ ${summary.join('\n')}
     await codePushClientWrapper.publishPatch(
       appId: appId,
       releaseId: release.id,
-      platform: platform,
+      platform: releasePlatform,
       channelName: channelName,
       patchArtifactBundles: {
         Arch.arm64: PatchArtifactBundle(

packages/shorebird_cli/lib/src/commands/release/release_ios_command.dart

@@ -8,6 +8,7 @@ import 'package:shorebird_cli/src/command.dart';
 import 'package:shorebird_cli/src/config/config.dart';
 import 'package:shorebird_cli/src/doctor.dart';
 import 'package:shorebird_cli/src/logger.dart';
+import 'package:shorebird_cli/src/platform.dart';
 import 'package:shorebird_cli/src/shorebird_artifact_mixin.dart';
 import 'package:shorebird_cli/src/shorebird_build_mixin.dart';
 import 'package:shorebird_cli/src/shorebird_config_mixin.dart';
@@ -59,6 +60,11 @@ make smaller updates to your app.
 
   @override
   Future<int> run() async {
+    if (!platform.isMacOS) {
+      logger.err('This command is only supported on macOS.');
+      return ExitCode.unavailable.code;
+    }
+
     try {
       await validatePreconditions(
         checkUserIsAuthenticated: true,
@@ -73,7 +79,7 @@ make smaller updates to your app.
       '''iOS support is in an alpha state. See https://docs.shorebird.dev/faq#ios-alpha for more information.''',
     );
 
-    const platform = ReleasePlatform.ios;
+    const releasePlatform = ReleasePlatform.ios;
     final flavor = results['flavor'] as String?;
     final shorebirdYaml = ShorebirdEnvironment.getShorebirdYaml()!;
     final appId = shorebirdYaml.getAppId(flavor: flavor);
@@ -128,7 +134,7 @@ make smaller updates to your app.
     if (existingRelease != null) {
       codePushClientWrapper.ensureReleaseIsNotActive(
         release: existingRelease,
-        platform: platform,
+        platform: releasePlatform,
       );
     }
 
@@ -136,7 +142,7 @@ make smaller updates to your app.
       '''📱 App: ${lightCyan.wrap(app.displayName)} ${lightCyan.wrap('($appId)')}''',
       if (flavor != null) '🍧 Flavor: ${lightCyan.wrap(flavor)}',
       '📦 Release Version: ${lightCyan.wrap(releaseVersion)}',
-      '''🕹️  Platform: ${lightCyan.wrap(platform.name)}''',
+      '''🕹️  Platform: ${lightCyan.wrap(releasePlatform.name)}''',
     ];
 
     logger.info('''
@@ -173,7 +179,7 @@ ${summary.join('\n')}
       await codePushClientWrapper.updateReleaseStatus(
         appId: appId,
         releaseId: release.id,
-        platform: platform,
+        platform: releasePlatform,
         status: ReleaseStatus.draft,
       );
     } else {
@@ -181,7 +187,7 @@ ${summary.join('\n')}
         appId: appId,
         version: releaseVersion,
         flutterRevision: shorebirdFlutterRevision,
-        platform: platform,
+        platform: releasePlatform,
       );
     }
 
@@ -197,7 +203,7 @@ ${summary.join('\n')}
     await codePushClientWrapper.updateReleaseStatus(
       appId: app.appId,
       releaseId: release.id,
-      platform: platform,
+      platform: releasePlatform,
       status: ReleaseStatus.active,
     );
 

packages/shorebird_cli/test/src/commands/patch/patch_ios_command_test.dart

@@ -213,6 +213,7 @@ flutter:
       when(flutterValidator.validate).thenAnswer((_) async => []);
       when(() => logger.confirm(any())).thenReturn(true);
       when(() => logger.progress(any())).thenReturn(progress);
+      when(() => platform.isMacOS).thenReturn(true);
       when(() => platform.environment).thenReturn({});
       when(() => platform.script).thenReturn(
         Uri.file(
@@ -268,6 +269,16 @@ flutter:
       expect(command.hidden, isTrue);
     });
 
+    test('exits with unavailable code if run on non-macOS platform', () async {
+      when(() => platform.isMacOS).thenReturn(false);
+
+      final result = await runWithOverrides(command.run);
+
+      expect(result, equals(ExitCode.unavailable.code));
+      verify(() => logger.err('This command is only supported on macOS.'))
+          .called(1);
+    });
+
     test('throws no user error when user is not logged in', () async {
       when(() => auth.isAuthenticated).thenReturn(false);
       final tempDir = setUpTempDir();

packages/shorebird_cli/test/src/commands/release/release_ios_command_test.dart

@@ -91,7 +91,7 @@ flutter:
     late CodePushClientWrapper codePushClientWrapper;
     late Directory shorebirdRoot;
     late Doctor doctor;
-    late Platform environmentPlatform;
+    late Platform platform;
     late Auth auth;
     late IpaReader ipaReader;
     late Ipa ipa;
@@ -111,7 +111,7 @@ flutter:
           codePushClientWrapperRef.overrideWith(() => codePushClientWrapper),
           doctorRef.overrideWith(() => doctor),
           loggerRef.overrideWith(() => logger),
-          platformRef.overrideWith(() => environmentPlatform),
+          platformRef.overrideWith(() => platform),
           processRef.overrideWith(() => shorebirdProcess),
         },
       );
@@ -143,7 +143,7 @@ flutter:
       codePushClientWrapper = _MockCodePushClientWrapper();
       doctor = _MockDoctor();
       httpClient = _MockHttpClient();
-      environmentPlatform = _MockPlatform();
+      platform = _MockPlatform();
       shorebirdRoot = Directory.systemTemp.createTempSync();
       auth = _MockAuth();
       ipa = _MockIpa();
@@ -158,7 +158,7 @@ flutter:
       registerFallbackValue(release);
       registerFallbackValue(shorebirdProcess);
 
-      when(() => environmentPlatform.script).thenReturn(
+      when(() => platform.script).thenReturn(
         Uri.file(
           p.join(
             shorebirdRoot.path,
@@ -195,6 +195,7 @@ flutter:
       when(
         () => logger.prompt(any(), defaultValue: any(named: 'defaultValue')),
       ).thenReturn(version);
+      when(() => platform.isMacOS).thenReturn(true);
       when(
         () => flutterBuildProcessResult.exitCode,
       ).thenReturn(ExitCode.success.code);
@@ -259,6 +260,16 @@ flutter:
       expect(command.hidden, isTrue);
     });
 
+    test('exits with unavailable code if run on non-macOS platform', () async {
+      when(() => platform.isMacOS).thenReturn(false);
+
+      final result = await runWithOverrides(command.run);
+
+      expect(result, equals(ExitCode.unavailable.code));
+      verify(() => logger.err('This command is only supported on macOS.'))
+          .called(1);
+    });
+
     test('throws config error when shorebird is not initialized', () async {
       final tempDir = Directory.systemTemp.createTempSync();
       final exitCode = await IOOverrides.runZoned(